Repository navigation
Conversation
|
Intent: Let a user defer an exact composer message while preserving its original session and the session automation exclusivity shared with goals and monitors. |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify the Slack egress rework: every live turn now routes through Not justified as shipped
The rewritten pins in What this change shipsInventory (10 items) — 9 justifiedIntent: let a user defer an exact composer message to a chosen time inside the same conversation — ADDITION (fixes #9836). The change has more than 10 observable differences; these are the 10 most noticeable.
[FIRST-PRINCIPLES-REVIEWED] 3b89a5e |
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Stale superseded-design claims remain: the spec promises at-least-once replay across a crash the memory-only backend cannot deliver; the description cites absent bundle-ceiling hunks. Watch
Suggestions
[DESIGN-REVIEWED] 3b89a5e |
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed 2 of 2 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- website/src/components/ChatInput.tsx:1866 -- stale scheduled callbacks mutate the active chat BLOCKING -- src/kiro_crew/dashboard/chat_runner.py:17331 -- multipart Slack reply continues after mirror revocation [BLOCK-MERGE] 3b89a5e Adjudication (Opus 5) — is blocking on each finding proportionate?F1 — HIGH: cross-slot write with no recovery for the draft half. F2 — Cross-audience publication with no recall. [ADJUDICATION] 3b89a5e total=0 uphold=0 downgrade=0 [ADJUDICATION-FENCED] 3b89a5e fenced=2 flagged=0 |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed |
3eb1781 to
7b90d95
Compare
|
|
|
|
|
|
|
|
7b90d95 to
3d4f537
Compare
|
|
|
|
self-added: yes
|
|
self-added: yes
|
|
self-added: yes
|
|
self-added: yes
|
|
|
|
|
|
|
|
|
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been idle since 2026-09-25 with two blocking findings and a conflicting base. I reviewed the blockers — several of them need your decision rather than a mechanical fix:
Two findings ARE concrete and would be ours once the above is settled — both security-class and both upheld on adjudication: stale scheduled callbacks in Also worth knowing: at 11,833 added lines across 80 files introducing a new subsystem, this is past the surface our automation will reason about unattended, so we would not drive it even with every answer above. And Two smaller accuracy items: the spec still carries an "at-least-once … may replay the exact user input" sentence in When you've settled the ownership, the guard-test question and the placement calls, the pipeline will re-assess on its next cycle. |
|
PR triage (2026-10-05): rebase needed, plus one overlap to discuss Rebase. Head CI on this head is red, and the failures come from this diff, not from flakes:
Overlap to discuss: #9815 (draft, same author), "feat(cron): let a created job target a chat session". Both PRs serve issue #9836, but they use different mechanisms, so this is not a duplicate:
I found no breaking change to an existing surface. The |
iamwhatever
left a comment
There was a problem hiding this comment.
Thanks @kvzz42 for the scheduled-messages work. One rebase issue before this can land.
#17642 and #17662 (remote-crew-sidebar RFC, wave 4) deleted the relay path on main. The peer now owns its session and the dashboard opens a crew window onto it (#16757). These hunks touch code that no longer exists, so they are no longer needed:
src/kiro_crew/dashboard/remote_relay.py(deleted on main): all hunks, R54-1047 (RemoteTurnError,ensure_version_parity,_drop_unsent_user_row,relay_remote_turn,_peer_turn_chunks).src/kiro_crew/slack/gateway.py: therelay_remote_turnimport fromremote_relayat R183-186 and its call at R7832.test/test_local_command_done_landing.py(new file): importsrelay_remote_turnat R16 and calls it at R56.test/test_remote_crew_execution.py(deleted on main): all hunks, including therelay_remote_turncalls (R567-R4054) and the_relay_in_flightasserts at R3930 and R4017.
Could you drop those hunks and rebase on main? Please keep the rest of the PR as it is. Thank you.
dodgeblaster
left a comment
There was a problem hiding this comment.
Stewarding review for #9836 (Schedule a one-shot cron from the UI). Re-grounded against current main (5821f39214).
Where main stands now (the gap this PR targets is still real):
website/src/components/JobForm.tsxstill derivesschedModefromisInterval(line 77) elseisWeekly(line 112) elsecron(line 114) — there is nooncemode. A one-shot job (at, noevery_secs/cron_expr) still falls intocronmode with an empty expression andbuildBodyrefuses to save it, so an MCP-created one-shot still cannot be round-tripped from the Schedule page.- The backend one-shot halves ARE merged:
src/kiro_crew/dashboard/handlers/cron_jobs.pyresolvesat/delay/at_time. So the Schedule-tabonceread-path fix has everything it needs on main.
Blocking: this PR no longer applies to main. As @iamwhatever already flagged (CHANGES_REQUESTED, 2026-10-08), RFC waves #17642 / #17662 / #16757 deleted the relay path (src/kiro_crew/dashboard/remote_relay.py) that several hunks here depend on (relay_remote_turn and its import in slack/gateway.py). Those hunks touch code that no longer exists, so the PR is CONFLICTING and cannot be applied as-is.
Scope concern. Beyond the scheduled-messages feature, this PR also carries a large autonudge* refactor (rename/move across autonudge.py, autonudge_authz.py, autonudge_selfarm.py, autonudge_service/*, plus their tests). Folding an unrelated subsystem rename into a feature PR widens the blast radius and makes the rebase harder than it needs to be. A smaller PR scoped to the Schedule once read-path (a fourth schedMode recognising at/no-every_secs/no-cron_expr, buildBody emitting at, i18n keys, Screenshot Evidence) would land far more easily, as @CrysisDeu's triage on #9836 suggested.
Validation note (unattended-execution safety). A UI create path for a one-shot must go through the SAME validation/approval as the existing cron create route — a scheduled job runs an agent turn unattended. Please confirm the composer-caret / form path posts through POST /api/crons (the cron_jobs.py validation) and does not introduce a side door.
Recommendation. This needs the author to: (1) rebase onto current main and drop the deleted-relay hunks; (2) split the unrelated autonudge refactor out; (3) re-request review. As a fork PR it also needs the author's rebase and a maintainer to run/merge — not something a reviewer can push here. Leaving the issue open; not approving a PR that cannot currently apply.
Review posted as part of the #9836 T1/T2 sweep.
Problem / Motivation
Goal: Let users schedule exact composer text once for a chosen future time in the same chat from a visible Send later control, without persisting plaintext or weakening audience containment.
Kiro Crew has no safe composer path for deferring ordinary chat text. A cron creates another conversation and changes the prompt contract instead of submitting the user’s message in the chat they chose.
Why it matters
Deferred text should keep the same conversation, workspace, app, audience, prompt, skill, and slash-command behavior as a normal composer submission. The feature must not let agent-writable automation metadata impersonate fresh user input or let stale browser and mirror state redirect a message.
Not a goal
What changed (motivation → approach → change)
Send later submits the composer’s exact text once, in its original chat, at the selected time. It uses the split AutoNudge service as the timer and keeps authoritative text in gateway-owned memory, rather than creating a cron conversation or trusting the agent-writable loop store.
website/src/components,website/src/pages,website/src/monitoring,website/src/lib,website/src/types,website/src/utilssrc/kiro_crew/autonudge.py,src/kiro_crew/autonudge_service,autonudge_authz.py,autonudge_selfarm.pysrc/kiro_crew/dashboard,src/kiro_crew/slack,src/kiro_crew/goal_command.py/goaltext from mutating automation.src/kiro_crew/cron.py,cron_service/fields.py,website/src/components/JobForm.tsxwebsite/src/i18n,docs,test,website/src/test,.github/black-baseline.txtA pending message is dropped after restart because its exact text is intentionally not persisted. The picker discloses that before scheduling. Busy pre-dispatch sessions retry without spending an attempt. Successful completion removes the one-shot record. A read-only relay-archive chat refuses the turn like any other send. Failed, truncated, cancelled, or unclaimed dispatched turns retry; after three such failures, the message is retired only after its reason-neutral dropped notice is durable. The dropped-message card gives recovery guidance without claiming which safety check stopped delivery. Manual early fire is refused.
Backwards compatibility
Breaking: PATCH of an existing scheduled-message AutoNudge row now requires a 64-hex
expected_revision; a stale or revision-less scheduled edit is rejected instead of using last-write-wins. Cron updates that setat_ts=0are now rejected before mutation instead of replacing a working schedule with an inert one-shot. Writer sweep onorigin/main@d50deedd56a92e00687336aec19447c0dc5f2796: main has no scheduled-row writer; itsAutoNudgePopoverPATCHes only ordinary goal loops and remains accepted. Main’s CLI, dashboard, MCP, and onboarding one-shot writers require a future or strictly positive timestamp and never use zero as a scheduled value. This PR’sSessionAutomationPopoveris the sole scheduled-row writer and sends a revision derived from loop ID, slot, exact protected message, and deadline on both text and time edits.Tests
website/distregistering extra window-entry routes; the same file passes on a clean checkout of the base.Manual verification
Scripted Playwright loaded the real production build through the repository’s standard gateway-free
/api/**fixture harness at desktop and 390 px touch widths. It typed a draft and asserted that the visible Clock is enabled immediately beside Send, no inline Optimize remains, desktop + and touch More each retain Send later and Optimize, and both pickers stay within the viewport. The notice fixture also asserted the exact reason-neutral dropped-message copy before capture.Screenshots / video
Visible Clock beside Send — desktop
Desktop + menu retains Send later and Optimize
Touch picker opened from the visible Clock
More exact-head UI evidence
Related Issues
Fixes #9836
Supersedes #9960
Pattern harvest
Rule candidate: review-prompt
Pattern: Deferred user speech must keep exact text outside agent-writable state, capture its audience at admission, compare protected edit state under the mutation lock, and revalidate every egress after asynchronous work.
Checklist