Repository navigation
Conversation
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS
Not justified as shipped
What this change shipsInventory (10 items) — 5 justifiedIntent: let a user render, edit, and create a one-shot scheduled message from the dashboard — a FIX of the read/edit gap (#9836, linked) carrying declared UI ADDITIONS on top.
Committed PNGs under Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] 7a5348a |
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The shortcut's write and the banner's read use different Watch
Suggestions
[DESIGN-REVIEWED] 7a5348a |
UX Review (Fable 5, fork) — 🟡 CONCERNSUX-level review of I have everything I need. Reconciling: the diff adds four user-visible surfaces (plus-menu "Send later…" row, time-picker popover with "Schedule" confirm, scheduled-message banner with "View schedule" link, and the Schedule form's "Run once" arm) — all four appear only in screenshots the fork PR adds, which are not materialized in this lane, and no blind read ran. I verified the base-tree patterns: every sibling path to the Schedule page uses client-side UX-Verdict: CONCERNS Sound flow and copy, but every new control is unseen in this lane, and the banner link full-reloads an SPA every sibling navigates client-side. Watch
Evidence gaps
Suggestions
[UX-REVIEWED] 7a5348a |
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed 1 of 3 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- src/kiro_crew/cron.py:2880 -- Recurring one-run jobs lose their deletion flag BLOCKING -- website/src/pages/ChatPage.tsx:1068 -- Cron-list failures are silent in both chat hosts BLOCKING -- src/kiro_crew/dashboard/handlers/cron.py:802 -- Feature map omits the new one-shot dashboard flow (origin: validation) [BLOCK-MERGE] 7a5348a Adjudication (Opus 4.8) — is blocking on each finding proportionate?Verified: F2's anchor F2 — harm rung LOW on its own (silent read-failure hides the reminder banner; the scheduled cron still fires and refetch self-corrects), but the anchor is a blocking:true AUTOSDE rule requiring read/list/load failures to render through ErrorNotice; the rule's flag outranks weighing. F3 — the feature map (docs/feature-map/README.md) was not touched by this PR despite structural dashboard changes; anchored to blocking:true F1 (fenced) — unbounded residual (silent loss of deletion intent → job recurs indefinitely); conditions are reachable via the create paths and an ordinary recurring-schedule edit, so no rarity argument completes. |
Opus 4.8 Review (fork) — ✅ no blocking findingsReviewed Review detailsThe composer "Send later" shortcut is inert: the scheduled-message banner never shows and the run is never mirrored back to the chat. FINDING — website/src/components/ChatInput.tsx:670 — the composer creates the job with bare [OPUS-REVIEWED] 7a5348a |
8fddbcd to
3ffbd4c
Compare
|
Why it surfaced on this PR rather than earlier: the job is path-filtered to The established remedy looks like a maintainer action rather than a contributor Happy to raise the budget here with a comment attributing the growth to The other failure in that round, |
3ffbd4c to
796b934
Compare
Legitimate, and I initially wanted to argue it — a split button is one visual Taken a different route than the one suggested, for a smaller blast radius: Send The honest cost is discoverability — a caret advertises itself, a menu row has to be |
Both correct, and both now follow this file's own precedents rather than inventing a Failures render through The draft clear is now conditional on the live draft still being the text that |
Both real, both data loss, and both mine. The Opus lane independently found the first The deletion flag. Every dashboard and composer one-shot is created with The truncated instant. Tests pin all of it: interval and cron conversions disarm the flag, a same-kind retime |
This is the same defect the GPT lane reached from the form, and your framing put it in Your parenthetical is the part that made the severity obvious: because every Two related notes from the same sweep, both now pinned by tests: a same-kind retime |
Close the read and edit halves of one-shot scheduling, then build the two UI
surfaces on top.
`at`/`delay`/`at_time` were create-only, so a one-shot was the one schedule kind
a client could create and then neither render nor edit: GET /api/crons carried no
machine-readable fire time, PATCH accepted no one-shot spelling, and the store
had no at_ts branch to apply if it had. The Schedule form consequently opened
such a job in cron mode with an empty expression and refused to save it.
- GET /api/crons reports at_ts and delete_after_run
- PATCH /api/crons/{id} accepts at/delay/at_time via the create route's parser
- _update_job_locked applies at_ts, mutually exclusive with the recurring
spellings and bounded so an unrenderable value cannot break the job list
- JobForm gains a fourth `once` arm, decided by at_ts and showing no timezone
select (an instant has no zone to choose)
- the composer's send button gains a caret that schedules the draft into THIS
chat, as a shortcut over the same create route
796b934 to
7a5348a
Compare
|
Closing this implementation in favor of the replacement one-shot AutoNudge design. The replacement keeps scheduled messages mutually exclusive with goals and monitors, delivers into the original session as an exact user turn, and removes the automation automatically after completion. I will link the replacement PR here once it is open. |
|
Replacement opened: #11397 |
Problem / Motivation
Scheduling a one-shot from the dashboard, end to end: the read/edit halves of the
one-shot contract, then the two UI surfaces on top of them.
Why it matters
at/delay/at_timelanded on the create routes only, which left aone-shot as the single schedule kind a client could create and then neither render
nor edit. Three gaps, one per layer:
GET /api/cronsserializedcron_expronly forkind == "cron"andevery_secsonly forkind == "every", with noat_tsat all — a one-shot'sfire time existed on that payload only inside the human-readable
schedulestring;
PATCH /api/crons/{id}accepted onlycronandevery;_update_job_lockedhad noat_tsbranch, so a handler passing one throughwould have been silently dropped.
The user-visible consequence was the bug #9836 describes: the Schedule form
matched neither the interval nor the weekly shape, fell through to cron mode
with an empty expression, and its own
buildBodythen refused to save it — so anMCP-created one-shot could not be edited from the dashboard at all.
What changed (motivation → approach → change)
Backend
at_tsanddelete_after_runon the list payload, each set only for thekind that owns it.
delete_after_runis reported rather than inferred, since itis an independent field.
PATCHacceptsat/delay/at_timethrough the same_resolve_one_shot_atparser and precedence the create route uses, so a firetime means one thing on both surfaces.
at_tsis mutually exclusive withcron_expr/every_secs(a schedule has exactly one kind; accepting both would drop onedepending on assignment order) and bounded by
_MAX_AT_TS, for the reason thecreate path bounds it: a value past what
datetime.fromtimestampcan render isstored fine by a caller that skips the schema and then raises while the job list
is serialized, failing
GET /api/cronsfor every job until that record isdeleted by id. Re-timing never touches
delete_after_run.UI
Schedule form — a fourth
schedModearm,once, decided byat_tsbeing afinite number rather than by having matched nothing else. It shows a
datetime-localcontrol and no timezone select, because anatfire time isan absolute instant and there is no zone to choose. An empty or past time is
refused in the form, naming the field the user is looking at.
Composer shortcut — a Send later… row in the composer's plus menu opens a
time picker that schedules the current draft, creating an ordinary one-shot with
session_keynaming this chat. A shortcut, not a second scheduling surface: theSchedule page stays where the job is listed, edited and cancelled.
It is a menu row rather than a caret on Send (Slack's shape) because the idle action
row already carries mic + Optimize + Send, and
max-two-buttons-per-row(
website/AUTOSDE.yaml,blocking: true) caps a row at two peers and nameswidening and wrapping as non-fixes. The plus menu is a separate visual group, so the
row costs that row nothing and relocates nothing already in it.
Scheduled-message banner — a
role="status"strip above the composer naming thesoonest pending one-shot for this chat, linking to the Schedule page, in the spirit
of Slack's "1 scheduled message". Without it a pending message is invisible between
scheduling and firing, since the menu row is not a persistent affordance. It is what
pays for the discoverability the menu row costs.
scheduledMessagesis supplied bythe HOST page rather than fetched by
ChatInput: that component is rendered byseveral surfaces and by many tests, and a per-mount
GET /api/cronswould add arequest to all of them.
Ordering note: create-time
session_keyis #9815. Unknown body keys areignored on
POST /api/crons, so before that merges the caret still schedulescorrectly and the job delivers to its own tab — it degrades rather than failing.
This PR does not depend on #9815 to be correct, only to be complete.
Screenshots / video
onceCaptured by
website/scripts/capture-schedule-once.mjsagainst the real built SPAwith fixture-stubbed
/api/**. The Schedule frame is driven from a fixture jobcarrying
at_tsrather than by filling the create form, because the defect thiscloses is on the read path — photographing the seeded job is what shows the arm
doing its job.
Tests
test/test_cron_oneshot_read_and_retime.py(14) — the payload reports the firetime,
PATCHre-times by absolute and relative spellings, an unparseable time isrefused rather than stored, and the store refuses a recurring spelling alongside
at_ts, a non-numeric value, and an unrenderable one (inf,nan, negative,past the cap).
website/src/test/JobForm.once.test.ts(11) — a one-shot reads intoonceinstead of an empty cron, the fire time round-trips through the local-zone
rendering, a recurring job is untouched, and the body carries
atwith notimezoneand no recurring spelling.website/src/test/ScheduleSendButton.test.ts(8) — the picker is read as localwall clock, a past or current-minute time is refused, and the default opens on a
time that is already valid.
Backend: 2289 passed / 3 skipped across the cron and schedule suites. Frontend:
2009 passed (one pre-existing
WebPreviewPanelfailure that reproduces on cleanmain).npm run i18n:checkpasses all 19 checks withI18N_BASE_REF=origin/main;tsc -b, flake8, mypy,docs-lint.shand the comment-history gate are clean.Manual verification
Captured against the real built SPA (
npm run build+ the harness below), not acomponent mock: the Schedule frame opens a fixture job carrying
at_tsand showsRun oncewith06/01/2026, 09:30 AMpopulated, which is the read path the bugwas on. The composer frames drive the actual caret and picker.
Related Issues
Closes #9836. Completed (not required) by #9815, which adds create-time
session_key.