Repository navigation
Conversation
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS When wiring [DESIGN-REVIEWED] ac225d1 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Accepting What this change shipsInventory (6 items) — 6 justifiedIntent: unwedge main's red Backend Tests by making the Fargate engine conform to the already-widened LaunchEngine protocol — a FIX (red on base, issues #11417/#11416, base test asserts four attributes against a five-attribute protocol).
[FIRST-PRINCIPLES-REVIEWED] ac225d1 |
Give macOS Cmd+W to the native Window menu and use Option+Shift+W for session close. Preserve hide-to-tray for the main window and ask before discarding unsaved work in secondary windows. Keep browser pages and their control owners alive until the user confirms closing. Include the Fargate protocol compatibility repair from PR kirodotdev#11422 so inherited backend CI failures do not hide regressions in this change. Co-authored-by: Stan Tian <273962421+pepmach@users.noreply.github.com>
Give macOS Cmd+W to the native Window menu and use Option+Shift+W for session close. Preserve hide-to-tray for the main window. Confirm every secondary close before renderer teardown: unload probes can discard unsaved work when a renderer accepts or times out. Keep browser pages and their control owners alive until the user confirms closing. Include the Fargate protocol compatibility repair from PR kirodotdev#11422 so inherited backend CI failures do not hide regressions in this change. Co-authored-by: Stan Tian <273962421+pepmach@users.noreply.github.com>
Give macOS Cmd+W to the native Window menu and use Option+Shift+W for session close. Preserve hide-to-tray for the main window. Confirm every secondary close before renderer teardown: unload probes can discard unsaved work when a renderer accepts or times out. Keep browser pages and their control owners alive until the user confirms closing. Include the Fargate protocol repair from PR kirodotdev#11422 and the ledger test fixture repair from PR kirodotdev#11445 so inherited backend CI failures do not hide regressions in this change. Correct the remaining crew event fixture to use its valid type without changing production validation. Co-authored-by: Stan Tian <273962421+pepmach@users.noreply.github.com> Co-authored-by: Raymond Chen <45910466+chenmingwei23@users.noreply.github.com>
…rotocol #9840 added the login_target keyword and SigninHandle.error contract. #11230's Fargate engine predates that widening. Add both missing members. Default targets keep the existing immediate success path. Non-default targets return a verified refusal because the Fargate engine does not yet pin a Kiro identity. Fixes #11417 Duplicate report: #11416
ab31b00 to
ac225d1
Compare
Summary
Restore
FargateLaunchEngineconformance with the widenedLaunchEngineprotocol. Default identities keep the existing immediate sign-in result. A non-default identity returns a verified refusal because the Fargate engine does not pin a Kiro identity.Problem / Motivation
Current
mainfails two deterministic tests intest/test_fargate_launch_engine.py. The Fargate engine lacks thelogin_targetkeyword and its sign-in handle lacks the protocol'serrormember.9ab334b435)login_targettoLaunchEngine.begin_signinanderrortoSigninHandle.2e4cc9e16b)mainWhy it matters
Every pull request whose merge ref includes current
maininherits these Backend Tests failures. The fail-fast matrix then cancels sibling work and blocks PR Readiness for unrelated changes.What changed (motivation → approach → change)
Keep the widened protocol as the source of truth. In
src/kiro_crew/cloud/fargate_engine.py,FargateSigninHandlenow provides an emptyerror, andFargateLaunchEngine.begin_signinacceptslogin_target.A missing or default target preserves the existing immediate success path. A non-default target sets a one-sentence
erroron the handle, so the launch job records a verified refusal instead of claiming that Fargate pinned the requested Kiro identity.The cloud system specification records this behavior. The protocol-member test now includes
error, and one behavior test coversNone, the default target, and a non-default target.Tests
2 failed:begin_signin: ['instance_id', 'profile', 'region'] != ['instance_id', 'profile', 'region', 'login_target']; the protocol-member test also showed the pre-mergeerrormismatch.3 failed: signature mismatch,FargateSigninHandle is missing error, andunexpected keyword argument 'login_target'.3 passed.test/test_fargate_launch_engine.py46 passed.93 passed.src/kiro_crew/dashboard/handlers/sessions.py:7F401 onmain, tracked by #11415.Manual verification
N/A. Unit coverage exercises the protocol signatures, concrete handle members, and all three login-target cases without calling AWS.
Related Issues
Fixes #11417
Also resolves #11416 (same defect, filed in parallel)
Pattern harvest
Not generalizable: cross-PR merge race (#9840 widened a Protocol, #11230 added an implementer from an older base; each green alone). The signature-conformance test that caught it is the right guard; nothing to add.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)