Repository navigation
docs(rfc): Projects revision 2 -- the thin Project - #11564
Conversation
|
Intent: Record the maintainer's decision to narrow Projects to the parts only a runtime can provide -- a fenced registry, a synced Git workspace, a memory store keyed to the Project, and MCP servers referenced by name -- so the implementation can be split into small PRs against a design that is written down. |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Motivation cites needing a non-draft RFC on [DESIGN-REVIEWED] f95df9e |
a5a3fbb to
1d9c937
Compare
|
|
|
Inherited CI reds, not this PR's. The five backend shards that failed on
Reproduced on a clean detached |
1d9c937 to
37b4141
Compare
37b4141 to
65f2a0d
Compare
|
|
65f2a0d to
7cd9294
Compare
|
|
Narrow the Projects RFC to the parts only a runtime can provide: a fenced registry, a synced Git workspace, a memory store keyed to the Project (memory.mode), and MCP servers referenced by name. The capabilities layer (installing a bundle's agents, skills and MCP into global state at activation) is superseded by cwd discovery, which main already delivers, and by kiro-cli's own workspace-level mcp.json. Records the revised migration plan (PR A thin Project, PR B memory.mode, PR C MCP by name), the two-fence storage rule, and re-audits the index row.
7cd9294 to
f95df9e
Compare
|
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed the full production diff on f95df9e. 将Projects RFC收敛为薄项目模型及分阶段实施计划。
仅RFC正文和索引,完整文本已由只读审查者阅读;不改变运行时代码、权限或存储。未按文档或架构类别人为增加审批门槛;具体讨论未发现有效hold。 本轮已合并项仅为已审查且归档的授权变更;写前逐文件对照证明本项生产文件及文档自阶段A没有变化。
Fresh REST checks: current-head PR Readiness success; no effective change request or unresolved review hold; CODEOWNERS/UX eligibility and the distinct last pusher verified. Optional baseline failures, if present, remain recorded and are not claimed green. This approval does not bypass branch protection.
Narrow the Projects RFC to the parts only a runtime can provide: a fenced registry, a synced Git workspace, a memory store keyed to the Project (memory.mode), and MCP servers referenced by name. The capabilities layer (installing a bundle's agents, skills and MCP into global state at activation) is superseded by cwd discovery, which main already delivers, and by kiro-cli's own workspace-level mcp.json. Records the revised migration plan (PR A thin Project, PR B memory.mode, PR C MCP by name), the two-fence storage rule, and re-audits the index row.
Problem / Motivation
The Projects RFC on
maindescribes a bundle that installs its own agents, skills and MCP servers into the install's global state at activation. Building that (PR #7181) took twelve review rounds, and almost every blocker was the same class: a privileged reader trusting state an agent shell can write. Meanwhilemaingrew the same capability by a different route: a session's project directory already discovers its own.kiro/skills, project-local agents and.kiro/steering, and kiro-cli reads a workspace-level.kiro/settings/mcp.jsonon its own. The RFC no longer says what the design should be.Why it matters
Without a recorded decision, the implementation keeps paying for a layer the runtime already provides, every new head re-opens the same security class, and the two things only a runtime can give a Project (a memory store keyed to it, and MCP servers it can name) have no design at all. A First Principles lane also needs a non-draft RFC on
mainbefore a product-shape PR can land.What changed (motivation → approach → change)
A Project gets smaller and keeps only what needs a runtime. The RFC in
docs/request-for-change/rfc-crew-projects.mdgains a Revision 2 section, placed after the TL;DR, that supersedes the capabilities half of the original design and leaves the sources, sessions and sharing design standing.trust/(sandbox-visible)_SENSITIVE_HOME_DIRSand_CREW_HIDDEN_LEAVES)mainalready doesmcp.json.kiro/directory.kiro/steering/is in the activation digest; asyncthat changes it marks the Project review stale and sessions refuse until the owner re-activates against the digest of the content shownidpresent, unexplainedidkept as the structural identity the store keys on (nameis for people), adopted before manifests circulatememory.mode: project— declared in the manifest, ratified at activation, a Memory V2 store owned by aproject--<id>member🟩 added · 🟨 changed · 🟥 removed · 🟦 unchanged
The manifest declares whether a Project has memory, never which store, so a bundle can never point a session at someone's private memory. A pull can never create or select a store either: activation is the owner's one trust step, and a manifest edit makes the activation stale until the owner re-activates. The same rule governs MCP: a repo names servers, the owner's install supplies the definitions, and an unknown name shows as unavailable. The checkout is treated as a second channel and decided rather than assumed: everything under its
.kiro/directory except.kiro/steering/is inside the activation digest (default-stale, so a discovery surface kiro-cli adds later is covered without Crew knowing its name), a synced commit that changes it stops sessions until the owner re-activates, and text surfaces (.kiro/steering, documents) inherit kiro-cli's existing repository-trust posture. The storage rule is spelled out with the two fence tables it must sit on, and the revised migration plan names three PRs (thin Project,memory.mode, MCP by name) with exit criteria. The original agent-context section is marked superseded, the front matter is re-audited at0640c1e0d5, and the index row indocs/request-for-change/README.mdsays what exists onmaintoday.Tests
N/A — documentation only.
scripts/docs_lint.py,docs-lint.sh, the comment-history, brand, feature-map and changelog gates all pass on this diff.Manual verification
Two claims in the text were checked against sources rather than memory: the kiro.dev MCP configuration page for the workspace-level
.kiro/settings/mcp.jsonprecedence, andsrc/kiro_crew/sandbox.pyfortrustbeing in_CREW_SANDBOX_VISIBLE_LEAVESwhilememory_storesis in_CREW_HIDDEN_LEAVES.Related Issues
Related: #3551 (Projects tracking issue). Supersedes the design carried by PR #7181, which will be split per this revision.
no linked issue: a design revision, it closes nothing.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)