Repository navigation
feat: add portable project bundles - #7181
kyleseaman wants to merge 1 commit into
Conversation
GPT 5.6 Review — 🔴 changes requested (blocking)GPT 5.6 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- src/kiro_crew/project_registry.py:72 -- Agent can rewrite Project attachment authority Adjudication (Opus 4.8) — is blocking on each finding proportionate?I've examined the code. Here is my ruling.
For FLAG I must show the reaching conditions are so extreme a human would accept the residual. They are not: the required condition is an ordinary spawned-shell write to a VISIBLE leaf — precisely the primary bypass the doctrine treats as the baseline threat, not a mutually-contradicting or writer-impossible one. The suggested remedy (a dedicated hidden/secret top-level leaf) is bounded and standard. I cannot complete the rarity record, so the fenced verdict stands. [ADJUDICATION] 944310c total=0 uphold=0 downgrade=0 [ADJUDICATION-FENCED] 944310c fenced=1 flagged=0 False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of All evidence is reconciled: the blind read, all six screenshots, the diff, and the PR text. Both project-detail screenshots crop above the trust/sync/remove controls, which drives the verdict below. UX-Verdict: CONCERNS The flow reads well blind, but the feature's pivotal "Trust and activate" control and both confirm dialogs appear in no screenshot, and Add vs Create are indistinguishable. Watch
Evidence gaps
Suggestions
[UX-REVIEWED] 944310c |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of All evidence is in. Every substantive item traces to the pre-existing RFC (a recorded decision), specs were updated in the same commit, no pins were deleted or loosened, and the security items each sit on a named boundary. Two small pieces of dead surface survive the kill-filter, both verified by my own reads: First-Principles-Verdict: CONCERNS
Not justified as shipped
What this change shipsInventory (10 items) — 8 justifiedIntent: let a user name a body of work as a portable Project bundle — repos, agents, skills, MCP servers — and start sessions from it anywhere. ADDITION, derived from the pre-existing
Capped at 10: omitted are the ConfirmDialog destructive-styling opt-out (1 consumer — the knob its own prior comment deferred until a consumer existed), the e2e harness's ephemeral sandbox opt-in (scope-pinned by its own test), spec updates, and i18n strings. Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] 944310c |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of The RFC explicitly addresses my last candidate concern: "These activated entries are namespaced but install-global in v1... strict per-session capability scoping is a later capability-registry concern" — the install-global materialization is a documented, deliberate v1 decision, not a divergence. My review is complete. The design holds up across every gate I ran: the manifest is a versioned public contract ( Design-Verdict: PASS A real portability gap, solved with a versioned manifest contract, digest-bound explicit trust, provenance-scoped materialization, and a deliberately narrowed v1 — every deferral is named in the RFC. [DESIGN-REVIEWED] 944310c |
f7c851a to
f507017
Compare
f507017 to
d27d891
Compare
d27d891 to
58b940a
Compare
58b940a to
32c0682
Compare
|
|
|
|
|
|
|
|
|
|
|
|
self-added: yes
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
|
|
|
|
|
|
self-added: yes
|
Add local and Git-backed Projects that bundle repositories, agents, skills, and MCP configuration. Integrate Projects with session creation and expose the experience under Agent Capabilities.
|
self-added: yes
|
|
self-added: no
|
|
Closing this PR: the design it implements is being superseded, not merged. After twelve review rounds, all but two blocking findings were one class -- authority read back from state an agent shell can write -- and almost every instance lived in the capabilities layer (installing a bundle's agents, skills and MCP servers into the install's global state at activation). Main now provides that capability by another route (a session's project directory discovers its own The recorded decision is #11564, "Projects revision 2 -- the thin Project": a fenced registry, a synced Git workspace, a memory store keyed to the Project (
The branch |
Problem / Motivation
A Crew session today is pointed at one directory. There is no first-class way to say "this session is about the Payments Platform" and have the agent get the whole picture: which repositories belong together, which agents, skills and MCP servers that body of work carries, and how to pick it all up again on a second machine. The Projects RFC (
docs/request-for-change/rfc-crew-projects.md) describes that primitive; nothing onmainimplements it.Why it matters
Without a portable Project, every session starts from one folder and the user re-explains the shape of the work each time. Team members cannot share a Crew setup for a body of work, and an agent cannot reason about work that spans more than one repository. Projects turn that into a small, syncable manifest.
What changed (motivation → approach → change)
A Project is a
project.yamlbundle with a stable identity and no user identity, loaded from a local folder or a managed Git clone. It declares repositories, context selectors, agents, skills and MCP servers. Only the manifest is portable; clones, caches and materialized capabilities are derived state rebuilt per install.Projects live under Agent Capabilities → Projects (
website/src/pages/ProjectBundlesPage.tsx): list, detail, create, add-from-folder-or-Git, sync and remove. A Project can be picked when creating a session (ChatSidebarcreate menu) and the session shows the Project name while the agent resolves the full multi-repository workspace. Session-to-Project identity is a first-class slot field (project_id), persisted with the slot and restored on both restart paths.Bundle content is inert until the owner reviews and trusts it. Trust binds to a content digest over repo declarations, context selectors, agent JSON, skill trees and MCP JSON; the review shows agent names and the exact MCP commands, arguments and URLs before a separate confirmation. A sync that changes that digest withdraws the active materialization until the owner re-reviews. Materialization is namespaced and Project MCP entries carry provenance, so removing a Project reclaims exactly what it installed and a configuration-equal entry the owner keeps loses only its Project provenance. Every Project authorization decision is SEL-audited (
docs/system-specs/modules/sel.md).Every failed Project request, manifest load or list load renders through
ErrorNotice, so the structured error context and the agent hand-off survive; the hand-off is on everywhere except beside the create/add form's unsaved fields. In the sidebar's create menu a failed Project session create reports through the menu's shared new-chat notice, and a failed Project list read renders as the in-menu passive notice with its sibling hand-off row instead of silently dropping the Projects section.One layout change rides along:
SidePanelLayout.requestTabmakes re-clicking the already-active Capabilities tab a no-op.setTabdrops the pane's sub-selection when it rewrites the URL, and the Projects tab keeps the selected project in that sub-selection, so a re-click used to throw the user out of the project they were looking at. The guard applies to every tab of the layout.flowchart LR subgraph Before A1[New session]:::ctx --> B1[one directory]:::ctx --> C1[agent turn]:::ctx end subgraph After A2[New session]:::ctx --> P[Project picker]:::added --> M[project.yaml]:::added M --> R[multi-repo workspace]:::added --> C2[agent turn]:::ctx M -. owner trust .-> K[agents · skills · MCP]:::added end classDef added fill:#DCFCE7,stroke:#16A34A,color:#14532D,stroke-width:2px classDef changed fill:#FEF3C7,stroke:#D97706,color:#78350F,stroke-width:2px classDef removed fill:#FEE2E2,stroke:#DC2626,color:#7F1D1D,stroke-dasharray:4 3 classDef ctx fill:#E0F2FE,stroke:#0284C7,color:#0C4A6E🟩 added · 🟨 changed · 🟥 removed · 🟦 unchanged
A session can now start from a Project; the manifest resolves the repositories, and the owner's trust gate decides whether its agents, skills and MCP servers are installed.
Safety properties the diff pins:
file://authorities, path escapes, links, hardlink aliases, recursive YAML and alias-amplified documents; relative repo paths resolve against the declaring bundle before both the security decision and the Git clone; a remote manifest's blob size is preflighted before buffering.pinned_fsunder a byte ceiling that is fatal for Project activation.[PROJECT BRIEF —]and[END PROJECT BRIEF], join the set of structural markers the context builder rewrites to[marker-removed]in every scanned user-supplied string, so no message or file can forge the fence that marks the brief as background reference. Project MCP revocation is reconciled inside the final rendered-config lock./api/projectscontract is preserved; local credentials and install identity never enter the portable manifest.Tests
test/test_project_*.py,test/test_chat_slot_project.py,test/test_pinned_staging.py, handler coverage): manifest validation and rejection classes, Git transport trust, trust digest and withdrawal-on-sync, namespaced materialization and provenance-aware removal, session attach/refresh/detach including the persistedproject_idrestore paths, redaction of briefs and failures, SEL audit-or-deny ordering, and the byte-bounded pinned skill copy.ProjectBundlesPage.test.tsx,CapabilitiesPage.projects.test.tsx,ChatSidebar.createMenu.test.tsx,ChatInput.projectBranch.test.tsx): list/detail/create/add/sync/remove flows, error surfaces, create-session-from-Project carrying the Project identity in the request, and the sidebar create menu.website/playwright/project-bundles.spec.ts): external Git edit → Project sync → trust → multi-repo session, offline against the stub ACP backend. The harness enablesagent.sandbox_allow_unsandboxed_execin its throwaway CI home (_allow_ephemeral_unsandboxed_execintest/test_playwright_e2e.py) so the Git-backed flow can spawngiton a runner with no OS sandbox backend; the key pre-exists, and the opt-in is scope-pinned by its own test.origin/main(userns/ssh/jq-dependent); full frontend suite 2,024 files / 32,174 tests passed; mypy, black, isort, flake8, tsc, eslint, i18n check and render, jscpd, bundle-size, docs lint, feature-map, harness-parity and the policy gates passed.Manual verification
Real-gateway Chromium run of the Project flow (create → trust → new session → multi-repo workspace) passed; the screenshots below are from that run.
Screenshots / video
More
Related Issues
no linked issue: this feature implements the merged Projects RFC (#4941); #3551 (project-level
.kiro/config) is related context and is not closed by it.This lands as one vertical feature PR on purpose: splitting the manifest, the trust boundary, the session contract and the UI would leave partial states that are not independently useful or safe to ship.
CHANGELOG.mdis intentionally untouched; release notes stay release-PR owned. The two open repository-wide Dependabot alerts are transitive development dependencies inherited from the base lockfile, handled in #7766 and #7767; this PR does not modify dependency manifests.Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)