Repository navigation
Conversation
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the Windows named-pipe broker and launcher live before release — manual verification was POSIX-only, and that soft-fail path is designed but unobserved there. [DESIGN-REVIEWED] 59a5ddf Description read[DESCRIPTION-READ] e4f6f5e1ef20ee4e6be02fea1ff1065636c2f6567128476781ab074b8a735743 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed Review detailsOne advisory finding: the new spec text enumerates three brokered-call audit outcomes while the broker emits four. FINDING — docs/system-specs/modules/acp-client.md:191 — the added sentence pins the brokered-call audit contract as " [OPUS-REVIEWED] 59a5ddf |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify one shape call: Pi sessions now mount Crew tools by default; the registry's tracking RFC ( The base tree itself recorded the gap and the remedy this PR builds — the Pi registry entry's What this change shipsInventory (10 items) — 10 justifiedIntent: Let an operator's Pi sessions call Kiro Crew's MCP tools (subagents, schedules, memory) under per-call host approval — ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 59a5ddf Description read[DESCRIPTION-READ] 95ae0dd4509261d408c00789e1435c78605292a666c77afd7653dc9e65c0c558 That sha256 names the PR description this verdict read. Recompute it with |
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed 1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- src/kiro_crew/acp/client.py:6239 -- Warm-pool rekey loses the claiming channel for direct cron children (origin: validation) Adjudication (Opus 5) — is blocking on each finding proportionate?Verified the fenced finding against the base tree and the pre-fetched diff. F1 — Harm rung: MEDIUM-to-HIGH, silent at the moment it happens: the job persists with |
750eaa7 to
ae080d5
Compare
ae080d5 to
e049cab
Compare
fd31a32 to
0e37e0b
Compare
b15bfd5 to
bef4cd9
Compare
bef4cd9 to
296f90e
Compare
296f90e to
195b711
Compare
|
Windows: broker MCP children are spawned Re-verified against current head
Mechanism. On Windows Consequence. Every broker child stays frozen. Affected workflow. A Pi (pi-acp) session on native Windows that projects any MCP servers. The PR's headline capability — bridging Crew MCP tools into Pi — does not function there: the bridge soft-fails and the session falls back to Pi's pre-PR chat-only behaviour, after a ~30s stall per server charged against the 60s Suggested fix. After Suggested regression test. In Teardown ( Raised by an automated Windows-compatibility audit of the open PR queue. Non-blocking: the bridge degrades gracefully rather than crashing the session. |
|
I updated the frozen description sections because the PR template gained a required |
|
@bolichen97 Addressed in |
Builder handoff: Grok native-tool invocation investigationRead-only triage against PR head Observed behavior: In a standing Crew member conversation configured as Important limitations: This was not a controlled same-process A/B test. Changing the model may recreate the underlying session; the exact provider response model and tool roster sent on the failing turns were not captured. A separate Grok-configured triage worker subsequently emitted at least one native MCP call, so this does not establish that Grok categorically cannot use Crew tools. Runtime mismatch: The observed source gateway used detached base Relevance: #12380 owns the Pi MCP registration/bridge path and is the primary investigation point. Its documented deterministic-model full-chain test does not establish live xAI tool emission. #12442 addresses child startup/protected identity failures after invocation, but those failures were not demonstrated here. #12305 is model-catalog routing and is not currently implicated. Suggested next verification for the existing builder:
The operational workaround is to keep the affected conductor on GPT-6 Sol while this is investigated. Root cause and a Grok fix remain unconfirmed. |
|
Follow-up runtime evidence from the existing Murmr fleet (September 29):
Please keep provider-empty reproduction, template/runtime adoption, and expired AWS authentication as distinct test cases. The live checkout contains staged bridge changes and does not establish that this PR's current head has been validated. No competing fix was made to this PR's bridge files. |
|
|
|
|
|
Live Grok failure triage (2026-09-29): this incident is upstream of the Pi→Crew MCP bridge.
Next action is to restore the entitlement/usage of the xAI account used by Pi, or configure an authorized funded xAI API key, then rerun one read-only native tool probe under Grok. Separately, Crew should surface the provider's 403 category instead of labeling it as an unexplained empty response or retrying it. Keep #12380's bridge validation separate: its deterministic-model test remains useful but does not test live Grok entitlement. No bridge code change is supported by this incident evidence. |
|
PR triage (2026-10-05): rebase needed, plus one blocking finding still open Classification: DISTINCT. Nothing open or merged duplicates this. On Rebase: the merge base
Please rebase, and re-check Still open at head Recommendation: REBASE, then CONTINUE-DEVELOPMENT on the finding above. The approach itself looks fine. |
|
Thank you @pstarkgit for this bridge and the deep testing behind it. Closing this as superseded by another design. #19761 ( Your branch is kept. If the governed-broker parts cover something #19761 does not, please reopen this or open a follow-up. |
Problem / Motivation
Goal: Let Pi sessions use Kiro Crew MCP tools through per-call host approval.
pi-acpaccepts an ACPsession/newmcpServersarray but does not forward it to Pi. Kiro Crew therefore correctly keeps Pi out of the session MCP array capability, yet Pi member sessions cannot call Crew MCP tools for subagents, schedules, and memory.Why it matters
Operators using Pi can chat and select their signed-in models, but Crew tools are absent. The member experience is incomplete compared with other supported ACP backends.
Not a goal
session/newMCP array carry Crew servers; this PR uses a separate, permission-gated bridge.What changed (motivation → approach → change)
Pi needs a transport that its ACP adapter actually consumes, without moving MCP credentials or approval authority into the Pi process. This change seals a Pi extension that connects to a session-owned host broker. The broker keeps server commands and environment values on the host, admits the local principal, and forwards a call only after consuming a single-use host approval bound to the call ID, exact tool name, and complete arguments.
src/kiro_crew/acp/client.pybuilds one bounded, policy-filteredAdmittedServerRosterand passes it topi_mcp_broker.py; the broker cannot re-admit a raw server list. It starts eligible direct servers and pooled stubs through the existingsrc/kiro_crew/sandbox.py,src/kiro_crew/platform_compat.py,src/kiro_crew/security_posture.py, process-identity, resource, and audit controls. Failed children, oversized frames, stale approvals, replays, cancellation, and teardown failures remain fail-closed without discarding healthy siblings.src/kiro_crew/agent_sdkregisters bridged tools asmcp__{server}__{tool}, preserves supported text, image, structured output, and MCP error status, and reports only servers that initialized. The capability declarations insrc/kiro_crew/providersexpose the bridge only when the backend can serve it. Pi's unresolved@serverdiagnostics use that same bounded roster because its ACP MCP array remains inert.GITHUB_HOST=github.com,NODE_ENV=production, andAWS_REGION=eu-west-1no longer redact valid metadata or silently withhold a callable tool.src/kiro_crew/session_pool.pycompare the live Pi MCP policy with the prewarmed broker policy and discard stale or unreadable claims. Capability cards report bridged tools only after the extension and broker are verified.The session-owned broker is intentionally a Pi transport lifecycle, not a second policy plane.
AcpClientremains the sole production admission caller and the shared Crew policy, sandbox, redaction, identity, and audit boundaries remain authoritative.Backwards compatibility
Compatible: other backends keep their existing MCP launch path. Pi sessions without an available or verified bridge remain chat-capable and report the missing tool mount. No stored settings or MCP server specs are migrated.
Reader: src/kiro_crew/acp/client.py:AcpClient._spawn -- chat -- test_acp_pi_backend.py::test_the_read_back_child_is_sandbox_wrapped_with_the_adapter_mask; the Pi gate artifacts remain exposed for its read-back.
Reader: src/kiro_crew/mcp_core.py:_resolve_session_key_strict -- chat -- test_pi_mcp_broker.py::test_only_verified_host_children_omit_the_pi_credential_mask; the exact managed core child keeps access to its host-owned session binding.
Reader: src/kiro_crew/mcp_cron.py:_call_tool -- cron -- test_pi_mcp_broker.py::test_only_verified_host_children_omit_the_pi_credential_mask; the exact managed cron child keeps its host-owned session binding.
Tests
test/test_pi_mcp_broker.pyandtest/test_acp_pi_backend.py: 304 passed, one skipped on the rebased final implementation.scripts/local-gate.pycompleted its first related backend batch with 28,409 passed and 172 skipped. Its next batch reached only host-inherited failures: 40test_cloud_source.pyownership assertions and two ripgrep provenance assertions. Both exact sets reproduce on pristine current main because this container reports/and the ripgrep parent as owned by uid 65534. CI remains the cross-platform authority for those host-sensitive tests.Manual verification
On an isolated temporary home with no live credentials, actual Pi 0.87.1 and
pi-acpmade one ACP permission request for read-onlymcp__kirocrew-core__knowledge_list_sources. The candidate host approved it, the broker called a realpython -m kiro_crew mcp-corechild, and the result reached the deterministic local model beforeend_turn. Replay of the same call ID, name, and arguments was denied. The run discovered 83 Crew tools, called only the selected read-only tool, stopped test-owned processes, and removed its scratch directories.This isolated test does not validate subscription authentication, the desktop HTTP gateway, native Windows execution, or a signed app update. Those remain release checks.
Screenshots / video
no-visual-delta: Existing capability-card content now reflects bridged tool availability; no panel or layout changes. The isolated tool-call trace is stronger evidence for this backend behavior than a static screen.
Related Issues
No originating work item is linked. #12305 is related to the model catalog, but this Pi MCP bridge does not implement or close it.
Checklist