Skip to content

feat(chat): hide crewmates from the agent picker for now - #12755

Merged
chenmingwei23 merged 1 commit into
mainfrom
feat/hide-crewmates-in-agent-picker
Sep 22, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
feat/hide-crewmates-in-agent-picker

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

The chat agent pop-up lists the execution catalog grouped under Crewmates and Agent templates. The crewmate surface (per-member memory, DM threads, hiring) is still settling, and offering a crewmate from the chat picker puts a half-finished concept in front of every chat before its home on the Crew Members page is ready. We want the picker to offer agent templates only, for now, without touching how a crewmate is dispatched anywhere else.

Why it matters

Every chat composer shows this picker. A user who picks a crewmate there starts a member-store session from a surface that gives no hint of what that means, and the picker's two-group layout draws attention to the very distinction we are not ready to explain. Hiding the group buys time without removing the feature: a crewmate stays reachable from its DM thread, and every non-picker consumer keeps working.

What changed (motivation → approach → change)

Goal: templates-only picker, reversible in one place, zero effect on dispatch.

Approach: filter at the hook, not the component and not the backend. useAgents already returns two views of the catalog: choices (the typed list only the chat pop-up renders) and agents (the same list folded to one row per name for cron, channel and project bindings and the keyboard cycle). Filtering choices alone hides crewmates from exactly the surface in question. Filtering agents or the /api/agents/catalog route would change what a bare name dispatches, and a backend flag would need config plumbing for a temporary hide.

Change:

  • website/src/hooks/useAgents.ts: one exported constant, HIDE_CREWMATE_CHOICES = true. When on, choices drops every selection_kind === 'member' row, applied after the fold so agents is untouched and a shared name still resolves member-first. Flip to false to restore the two-group pop-up.
  • website/src/components/AgentDropdownList.tsx: the group header and the templates hint render only when the list holds more than one kind. With crewmates withheld the list is templates only; a header then separates nothing, and the hint ("runs the shared template on shared memory; nothing is enrolled as a crewmate") contrasts against a row the list never shows. The role="group" label stays for assistive technology, and the rows keep their grouped rendering (no origin badge), so the flag changes nothing but the chrome.
  • docs/system-specs/modules/crew-mode.md: records the header rule and the temporary flag in the execution-choice catalog section.
  • website/scripts/capture-agent-picker-hide-crewmates.mjs: the capture harness behind the screenshots below. It stubs /api/agents/catalog with a mixed catalog (three members, four templates, one shared name) and asserts before each frame that only template rows render, with no header, no hint and no crewmate avatar.

Not a product-shape change in the RFC sense: no default, loop or command behaviour changes; one picker group is withheld behind a flag while the crewmate work lands, and the folded roster and request contract are byte-identical.

Backwards compatibility

Compatible: the catalog route, the agent_kind request field, slot persistence and the folded agents list are unchanged. A slot already running a crewmate keeps running it; the picker simply does not offer a new one. Nothing is written.

Tests

  • website/src/test/useAgents.hideCrewmates.test.tsx (new): with a mixed catalog, choices holds every template and no member; agents still holds one row per name with the member winning a shared name; defaultAgent passes through.
  • website/src/test/AgentDropdownList.test.tsx: new case pins that a templates-only list renders no header text, no templates hint and no origin badge while keeping the accessible group label and every option. Existing two-kind cases still pass unchanged.

Manual verification

Built SPA behind the shared serveDist harness with a stubbed mixed catalog; the capture script's own assertions run before each frame (template names in order, zero members, zero header/hint, zero avatars). 353 tests across the useAgents*, AgentDropdownList* and ChatPane* suites pass; tsc, eslint --max-warnings 0, i18n check/render, phantom-classes and jscpd gates pass. The scoped frontend run reports 14 failures in ArtifactDetailPage, DiffBlock.streaming, SchedulePage.secrets, toolDiff and normalizePatchHunks; the same 14 fail with origin/main sources checked out, so they are inherited and unrelated to this diff.

Screenshots / video

Agent picker with a mixed catalog (3 crewmates + 4 templates stubbed), light and dark. Only the four templates render; no "Crewmates" or "Agent templates" header, no hint. The harness asserts the light and dark frames differ byte-for-byte before it writes them.

Agent picker, templates only, light theme

Agent picker, templates only, dark theme

Full chat page with the picker open

Chat page with the picker open, light theme

Chat page with the picker open, dark theme

Related Issues

Follows #12224 (the catalog-backed picker this hides one group of). No linked issue: temporary hide requested directly by the maintainer, reverted by flipping the flag once the crewmate surface is ready.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and cixuuz September 22, 2026 08:37
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Intent: Keep crewmates out of the chat agent pop-up for now, behind one frontend flag, so the picker offers agent templates only while the crewmate surface settles.
Not a goal: Changing how a crewmate is dispatched anywhere else (cron, channel, project bindings, DM threads), the catalog route, or the agent_kind request contract; removing the crewmate feature.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the keyboard cycle, which still resolves shared names member-first via agents, is an acceptable remaining chat path into a member-store session.

[DESIGN-REVIEWED] d78ad9f

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d78ad9f

Verdict parsed from the review's SHA-scoped output markers for commit d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ human override accepted

@CrysisDeu overrode this lane for d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Verify a crewmates-only catalog (zero templates) doesn't leave the picker as a bare italic "No matches" with no route to the hidden crewmates.

[UX-REVIEWED] d78ad9f

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d78ad9f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d: <one-sentence reason>

The chat agent pop-up lists the execution catalog grouped under
Crewmates and Agent templates. Until the crewmate surface settles, the
pop-up offers templates only: `useAgents` withholds member rows from
`choices` behind one flag, `HIDE_CREWMATE_CHOICES`, and a crewmate is
reached from its DM thread on the Crew Members page instead. The folded
`agents` list is not filtered, so cron, channel and project bindings and
the keyboard cycle still see every name and a bare name still resolves
member-first.

With one kind in the list a group header separates nothing and the
templates hint contrasts a template against a crewmate the list never
shows, so the pop-up draws both only when it lists more than one kind;
the accessible group label stays. Flipping the flag off restores the
two-group pop-up with no other change.
@CrysisDeu
CrysisDeu force-pushed the feat/hide-crewmates-in-agent-picker branch from 8b86683 to d78ad9f Compare September 22, 2026 09:06
@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author
  • fixed span=54c65f58d4fb in d78ad9f: the HIDE_CREWMATE_CHOICES docstring now names test/useAgents.hideCrewmates.test.tsx as the one other touch when the flag is flipped off, instead of claiming "no other change is needed".

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 22, 2026
@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author
  • fixed span=9a089999207b in d78ad9f: the capture harness seeded mc-theme itself, and the SPA overwrote it with the stub's /api/theme/boot default, so both runs rendered dark. The theme now goes through stubDashboardApi({ theme }), the script fails if the light and dark frames are byte-identical, and the four PR images were re-shot (light frames mean luminance ~245, dark ~35).

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 22, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles d78ad9f: Maintainer decision: withhold the Crewmates group from the chat agent picker while the crewmate surface (per-member memory, DM threads, hiring) is still settling. Temporary and reversible in one flag (HIDE_CREWMATE_CHOICES); the folded agents list, cron/channel/project bindings and the agent_kind request contract are unchanged, so no dispatch behaviour moves. No RFC: this is a hold on exposure, not a new product shape; the two-group picker returns when the flag flips off.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for d78ad9f1ae1bcf123733ea7b2ab390b0c479cb0d.

Maintainer decision: withhold the Crewmates group from the chat agent picker while the crewmate surface (per-member memory, DM threads, hiring) is still settling. Temporary and reversible in one flag (HIDE_CREWMATE_CHOICES); the folded agents list, cron/channel/project bindings and the agent_kind request contract are unchanged, so no dispatch behaviour moves. No RFC: this is a hold on exposure, not a new product shape; the two-group picker returns when the flag flips off.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 22, 2026
@chenmingwei23
chenmingwei23 merged commit b9f7167 into main Sep 22, 2026
93 of 94 checks passed
@chenmingwei23
chenmingwei23 deleted the feat/hide-crewmates-in-agent-picker branch September 22, 2026 12:13
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 22, 2026
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
…12755)

The chat agent pop-up lists the execution catalog grouped under
Crewmates and Agent templates. Until the crewmate surface settles, the
pop-up offers templates only: `useAgents` withholds member rows from
`choices` behind one flag, `HIDE_CREWMATE_CHOICES`, and a crewmate is
reached from its DM thread on the Crew Members page instead. The folded
`agents` list is not filtered, so cron, channel and project bindings and
the keyboard cycle still see every name and a bare name still resolves
member-first.

With one kind in the list a group header separates nothing and the
templates hint contrasts a template against a crewmate the list never
shows, so the pop-up draws both only when it lists more than one kind;
the accessible group label stays. Flipping the flag off restores the
two-group pop-up with no other change.
bolichen97 pushed a commit that referenced this pull request Sep 22, 2026
The chat agent pop-up lists the execution catalog grouped under
Crewmates and Agent templates. Until the crewmate surface settles, the
pop-up offers templates only: `useAgents` withholds member rows from
`choices` behind one flag, `HIDE_CREWMATE_CHOICES`, and a crewmate is
reached from its DM thread on the Crew Members page instead. The folded
`agents` list is not filtered, so cron, channel and project bindings and
the keyboard cycle still see every name and a bare name still resolves
member-first.

With one kind in the list a group header separates nothing and the
templates hint contrasts a template against a crewmate the list never
shows, so the pop-up draws both only when it lists more than one kind;
the accessible group label stays. Flipping the flag off restores the
two-group pop-up with no other change.

(cherry picked from commit b9f7167)
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
…12755)

The chat agent pop-up lists the execution catalog grouped under
Crewmates and Agent templates. Until the crewmate surface settles, the
pop-up offers templates only: `useAgents` withholds member rows from
`choices` behind one flag, `HIDE_CREWMATE_CHOICES`, and a crewmate is
reached from its DM thread on the Crew Members page instead. The folded
`agents` list is not filtered, so cron, channel and project bindings and
the keyboard cycle still see every name and a bare name still resolves
member-first.

With one kind in the list a group header separates nothing and the
templates hint contrasts a template against a crewmate the list never
shows, so the pop-up draws both only when it lists more than one kind;
the accessible group label stays. Flipping the flag off restores the
two-group pop-up with no other change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants