Repository navigation
feat(chat): hide crewmates from the agent picker for now - #12755
Conversation
|
Intent: Keep crewmates out of the chat agent pop-up for now, behind one frontend flag, so the picker offers agent templates only while the crewmate surface settles. |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the keyboard cycle, which still resolves shared names member-first via [DESIGN-REVIEWED] d78ad9f |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — ✅ human override accepted@CrysisDeu overrode this lane for |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Verify a crewmates-only catalog (zero templates) doesn't leave the picker as a bare italic "No matches" with no route to the hidden crewmates. [UX-REVIEWED] d78ad9f |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
The chat agent pop-up lists the execution catalog grouped under Crewmates and Agent templates. Until the crewmate surface settles, the pop-up offers templates only: `useAgents` withholds member rows from `choices` behind one flag, `HIDE_CREWMATE_CHOICES`, and a crewmate is reached from its DM thread on the Crew Members page instead. The folded `agents` list is not filtered, so cron, channel and project bindings and the keyboard cycle still see every name and a bare name still resolves member-first. With one kind in the list a group header separates nothing and the templates hint contrasts a template against a crewmate the list never shows, so the pop-up draws both only when it lists more than one kind; the accessible group label stays. Flipping the flag off restores the two-group pop-up with no other change.
8b86683 to
d78ad9f
Compare
|
|
|
/ai-review override first-principles d78ad9f: Maintainer decision: withhold the Crewmates group from the chat agent picker while the crewmate surface (per-member memory, DM threads, hiring) is still settling. Temporary and reversible in one flag (HIDE_CREWMATE_CHOICES); the folded agents list, cron/channel/project bindings and the agent_kind request contract are unchanged, so no dispatch behaviour moves. No RFC: this is a hold on exposure, not a new product shape; the two-group picker returns when the flag flips off. |
Human judgment recorded@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
…12755) The chat agent pop-up lists the execution catalog grouped under Crewmates and Agent templates. Until the crewmate surface settles, the pop-up offers templates only: `useAgents` withholds member rows from `choices` behind one flag, `HIDE_CREWMATE_CHOICES`, and a crewmate is reached from its DM thread on the Crew Members page instead. The folded `agents` list is not filtered, so cron, channel and project bindings and the keyboard cycle still see every name and a bare name still resolves member-first. With one kind in the list a group header separates nothing and the templates hint contrasts a template against a crewmate the list never shows, so the pop-up draws both only when it lists more than one kind; the accessible group label stays. Flipping the flag off restores the two-group pop-up with no other change.
The chat agent pop-up lists the execution catalog grouped under Crewmates and Agent templates. Until the crewmate surface settles, the pop-up offers templates only: `useAgents` withholds member rows from `choices` behind one flag, `HIDE_CREWMATE_CHOICES`, and a crewmate is reached from its DM thread on the Crew Members page instead. The folded `agents` list is not filtered, so cron, channel and project bindings and the keyboard cycle still see every name and a bare name still resolves member-first. With one kind in the list a group header separates nothing and the templates hint contrasts a template against a crewmate the list never shows, so the pop-up draws both only when it lists more than one kind; the accessible group label stays. Flipping the flag off restores the two-group pop-up with no other change. (cherry picked from commit b9f7167)
…12755) The chat agent pop-up lists the execution catalog grouped under Crewmates and Agent templates. Until the crewmate surface settles, the pop-up offers templates only: `useAgents` withholds member rows from `choices` behind one flag, `HIDE_CREWMATE_CHOICES`, and a crewmate is reached from its DM thread on the Crew Members page instead. The folded `agents` list is not filtered, so cron, channel and project bindings and the keyboard cycle still see every name and a bare name still resolves member-first. With one kind in the list a group header separates nothing and the templates hint contrasts a template against a crewmate the list never shows, so the pop-up draws both only when it lists more than one kind; the accessible group label stays. Flipping the flag off restores the two-group pop-up with no other change.
Problem / Motivation
The chat agent pop-up lists the execution catalog grouped under Crewmates and Agent templates. The crewmate surface (per-member memory, DM threads, hiring) is still settling, and offering a crewmate from the chat picker puts a half-finished concept in front of every chat before its home on the Crew Members page is ready. We want the picker to offer agent templates only, for now, without touching how a crewmate is dispatched anywhere else.
Why it matters
Every chat composer shows this picker. A user who picks a crewmate there starts a member-store session from a surface that gives no hint of what that means, and the picker's two-group layout draws attention to the very distinction we are not ready to explain. Hiding the group buys time without removing the feature: a crewmate stays reachable from its DM thread, and every non-picker consumer keeps working.
What changed (motivation → approach → change)
Goal: templates-only picker, reversible in one place, zero effect on dispatch.
Approach: filter at the hook, not the component and not the backend.
useAgentsalready returns two views of the catalog:choices(the typed list only the chat pop-up renders) andagents(the same list folded to one row per name for cron, channel and project bindings and the keyboard cycle). Filteringchoicesalone hides crewmates from exactly the surface in question. Filteringagentsor the/api/agents/catalogroute would change what a bare name dispatches, and a backend flag would need config plumbing for a temporary hide.Change:
website/src/hooks/useAgents.ts: one exported constant,HIDE_CREWMATE_CHOICES = true. When on,choicesdrops everyselection_kind === 'member'row, applied after the fold soagentsis untouched and a shared name still resolves member-first. Flip tofalseto restore the two-group pop-up.website/src/components/AgentDropdownList.tsx: the group header and the templates hint render only when the list holds more than one kind. With crewmates withheld the list is templates only; a header then separates nothing, and the hint ("runs the shared template on shared memory; nothing is enrolled as a crewmate") contrasts against a row the list never shows. Therole="group"label stays for assistive technology, and the rows keep their grouped rendering (no origin badge), so the flag changes nothing but the chrome.docs/system-specs/modules/crew-mode.md: records the header rule and the temporary flag in the execution-choice catalog section.website/scripts/capture-agent-picker-hide-crewmates.mjs: the capture harness behind the screenshots below. It stubs/api/agents/catalogwith a mixed catalog (three members, four templates, one shared name) and asserts before each frame that only template rows render, with no header, no hint and no crewmate avatar.Not a product-shape change in the RFC sense: no default, loop or command behaviour changes; one picker group is withheld behind a flag while the crewmate work lands, and the folded roster and request contract are byte-identical.
Backwards compatibility
Compatible: the catalog route, the
agent_kindrequest field, slot persistence and the foldedagentslist are unchanged. A slot already running a crewmate keeps running it; the picker simply does not offer a new one. Nothing is written.Tests
website/src/test/useAgents.hideCrewmates.test.tsx(new): with a mixed catalog,choicesholds every template and no member;agentsstill holds one row per name with the member winning a shared name;defaultAgentpasses through.website/src/test/AgentDropdownList.test.tsx: new case pins that a templates-only list renders no header text, no templates hint and no origin badge while keeping the accessible group label and every option. Existing two-kind cases still pass unchanged.Manual verification
Built SPA behind the shared
serveDistharness with a stubbed mixed catalog; the capture script's own assertions run before each frame (template names in order, zero members, zero header/hint, zero avatars). 353 tests across theuseAgents*,AgentDropdownList*andChatPane*suites pass;tsc,eslint --max-warnings 0, i18n check/render, phantom-classes and jscpd gates pass. The scoped frontend run reports 14 failures inArtifactDetailPage,DiffBlock.streaming,SchedulePage.secrets,toolDiffandnormalizePatchHunks; the same 14 fail withorigin/mainsources checked out, so they are inherited and unrelated to this diff.Screenshots / video
Agent picker with a mixed catalog (3 crewmates + 4 templates stubbed), light and dark. Only the four templates render; no "Crewmates" or "Agent templates" header, no hint. The harness asserts the light and dark frames differ byte-for-byte before it writes them.
Full chat page with the picker open
Related Issues
Follows #12224 (the catalog-backed picker this hides one group of). No linked issue: temporary hide requested directly by the maintainer, reverted by flipping the flag once the crewmate surface is ready.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)