Repository navigation
Conversation
|
Intent: Keep autonomous goals active through remediable permission, configuration, dependency, tool, build, and test blockers, with durable approval-stall recovery and verified least-privilege repair. |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Fable 5, fork) — 🔴 BLOCK (blocking)Design-level review of Design-Verdict: BLOCK Reverses the pinned "a loop proved unable to act must not burn another cycle" decision, unbounded, with no maintainer decision on record. BlockersPrompt-loop approval-stall terminal removed with no replacement bound, treating a named pin as a gap. WatchThe new instruction "a missing permission… is remediation work: inspect the owning code/config, make the least-privileged allowed fix" invites an unattended agent to edit permission/approval configuration it can reach (the OS fence covers only the governance keystone files); the "only the user can grant" carve-out relies on the model classifying correctly — the same model whose misclassification motivated this PR. Suggestions
[DESIGN-REVIEWED] 0768a4a |
First Principles Review (Fable 5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK Reverses the pinned stall-stop — "a loop proved unable to act must not burn another cycle" — and rewires every stop default, with no non-draft RFC covering that shape. Not justified as shipped
What this change shipsInventory (8 items) — 3 justifiedIntent: keep autonomous goal loops working through remediable blockers instead of retiring; framed as a FIX, but items 1–2 redesign pinned defaults.
Blockersproduct-shape change without accepted RFC — the default blocker/approval-stall lifecycle of first-class goal loops. [FIRST-PRINCIPLES-REVIEWED] 0768a4a |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed Review detailsTwo advisory gaps: the same skill's generated nudge still carries the retired "all blocked" stop, and the rewritten spec/field comment still name a FINDING — skills/self-nudge-loop/scaffold.sh:124 — the generator for this skill's own arming template still emits FINDING — src/kiro_crew/autonudge.py:725 — the rewritten field comment attributes [OPUS-REVIEWED] 0768a4a |
Treat missing permissions, credentials, configuration, dependencies, and failing tools as remediation work instead of terminal goal outcomes. Align the base prompt, stop-tool descriptor, slash goal nudge, self-nudge recipe, docs, and regression contracts.
0768a4a to
2a505fa
Compare
|
|
|
|
|
|
|
|
bolichen97
left a comment
There was a problem hiding this comment.
Requesting changes: unbounded prompt loops lose the approval-stall stop that RFC PR #13013 says they keep
The Design Review BLOCK above covers the reversal in general. This point is narrower and is not on the thread yet. The reply to that review says finite cycle/runtime budgets remain the terminal bound. A loop with max_cycles=0 and max_runtime_secs=0 has no such budget, and this head does not treat it differently.
What breaks. At src/kiro_crew/autonudge.py:5519:
if loop.approval_stalled:
...
consumed = await self._consume_prompt_approval_stall(loop)
...
if not consumed:
returnAfter this, the code falls through to the fire. Neither this branch nor _consume_prompt_approval_stall (:4257) checks whether the loop is bounded. The earlier checks do nothing at 0: if loop.max_cycles and ... (:5478) is skipped, and runtime_budget_exceeded (:933) returns False when max_runtime_secs is 0. On main, this spot deactivates the loop instead (autonudge.py:6113-6122: update(active=False, stopped_reason=APPROVAL_STALL_REASON), _emit("expired"), return).
Scenario. An unbounded prompt loop has an approval that nobody answers. Examples: an Issue Radar crew (src/kiro_crew/apps/builtins/issue_radar/backend/crew_runtime.py:785, max_cycles=0, no runtime budget), a ctx.nudge loop (src/kiro_crew/workflows/runner.py:566, default max_cycles=0), a popover goal set to 0 explicitly, or any goal stored with 0 before this change. On main, the next wake stops the loop with approval_stalled and emits expired. On this head, the loop consumes the marker and fires another model turn on every wake, and nothing on the service side ever ends it. Whether each cycle also waits out an approval window depends on the model calling the gated tool again, and the new "recheck it on later cycles" wording encourages it to.
Mismatch with the RFC. The current revision of docs/request-for-change/rfc-goal-blocker-lifecycle.md in RFC PR #13013 says:
- §3 step 2: "if neither bound is set, deactivates the loop with the terminal
approval_stalledoutcome exactly as today". - §5: "An unbounded loop keeps the terminal approval-stall stop unchanged".
- Phase 1 exit criteria: "a test pins both branches".
This head has neither the branch nor that test. test_prompt_stall_keeps_loop_active_for_remediation (test/test_autonudge_approval_stall.py:134) arms through _armed(svc) with the 0/0 defaults and asserts that the loop stays active and fires. That test pins the unbounded case to keep running.
Fix direction. In the _timer stall branch, keep main's deactivate-and-expired path when not loop.max_cycles and not loop.max_runtime_secs, and consume the marker only for bounded loops. Arm the existing test with a finite max_cycles, and add a test that pins the 0/0 stop.
From a full open-PR audit against origin/main c66f95b (2026-09-25); findings were checked by independent reviewers reading the code. Reply here if this is wrong.
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
One thing to know before the next push: main's #14994 cut When you've addressed these, the pipeline will re-assess on its next cycle. |
|
Status note. This PR's product path, keeping a goal loop firing through a permission blocker, was superseded by #16993 (merged 2026-10-07), which pauses the loop on an unanswered approval and keeps open ledgers running instead. The lifecycle RFC in #13013 was slimmed against that decision on 2026-10-10 and no longer depends on or references this PR (its stall path names #16993 as the implementation). The head |
|
Thank you @rubencu for this work, and for the status note. Closing this as superseded, as you suggested. #16993 ( Your branch is kept. If a gap remains, please reopen this or open a follow-up. |
Problem / Motivation
An autonomous
/goalcould identify a fixable missing permission, name the owning configuration change, and then stop its own AutoNudge loop as “blocked.” The same work succeeded when resumed manually, proving the blocker was remediation work rather than a terminal outcome.Why it matters
Autonomous goals lose continuity exactly when they should investigate and repair dependencies. A person must notice the stopped loop, repeat the instruction, and manually restart work even when the agent is allowed to make a least-privilege fix. Human-only approvals should be reported and rechecked, not silently retire the goal.
What changed (motivation → approach → change)
The root cause was inconsistent contracts across
src/kiro_crew/config/prompt.md,src/kiro_crew/dashboard/chat_runner.py,src/kiro_crew/mcp_tools/control.py, andskills/self-nudge-loop/SKILL.md: generic blockers were treated as stop conditions. Those surfaces now classify missing permissions, credentials, configuration, dependencies, and failing commands as remediation work, while preserving completion, explicit user stop, STOP sentinels, unrecoverable host failures, and finite budgets as legitimate endings. They also state that remediation never means granting the agent approvals/permissions, weakening approval policy, or editing governance controls.The runtime in
src/kiro_crew/autonudge.pynow makes that contract real. Prompt/goal loops durably consume unanswered-approval evidence before publishing another cycle, retain and retry evidence when persistence fails, and grant gated loops one follow-up tick so a QUIET probe cannot suppress remediation. Typed structured monitors still record an undeliverable accepted action asapproval_stallonMonitorState; pre-upgrade outer-loopapproval_stalledvalues remain readable. Approval-path comments insrc/kiro_crew/dashboard,src/kiro_crew/messaging,src/kiro_crew/slack, andsrc/kiro_crew/discorddocument the split.skills/self-nudge-loop/scaffold.shnow emits the same remediation-first step as its owning recipe.test/test_autonudge_approval_stall.py,test/test_goal_command.py,test/test_autonudge_stop_auth.py, andtest/test_prompt_compact_contract.pypin runtime, prompt, tool, generated-nudge, recipe, and scaffold behavior..github/black-baseline.txtdrops the now-formatted goal test.docs/system-specs/modules/learn-cron-dashboard.mdanddocs/system-specs/modules/messaging.mddescribe the lifecycle. This product-shape decision is proposed independently in RFC PR #13013; this implementation remains blocked until maintainers accept and merge that RFC ontomain.Backwards compatibility
Compatible: no accepted input, key, kind, or API is removed or narrowed. Existing stop conditions and structured-monitor approval-stall outcomes remain intact; only legacy prompt/goal loops stop treating a remediable approval timeout as terminal.
Tests
origin/main, while the one order-dependent case passed in isolation on this head.Manual verification
N/A — no external service or UI flow changed. Runtime transition ordering, persistence failure, gated QUIET behavior, and channel approval paths are covered by focused automated tests and mutation proof.
Screenshots / video
N/A — no user-visible frontend surface changed.
Related Issues
No linked issue: reported directly with a reproducible transcript.
Pattern harvest
Rule candidate: review-prompt
Pattern: a remediable permission, dependency, configuration, build, test, or tool failure is intermediate work to repair and verify, not a terminal goal outcome.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)