Repository navigation
fix(autonudge): pause on an unanswered approval; keep open ledgers running - #16993
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the 7-day ledger backstop is meant to measure active time only. Releasing a hold moves [DESIGN-REVIEWED] 76f61c7 Description read[DESCRIPTION-READ] 6f1dc03ef1a7fba88a815f4130d22a1bff78cfb3a531ef45235d99a4a0017c33 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The held-loop notice sends people looking for an approval that has already timed out, and it doesn't say whether resuming discards it. Watch
Suggestions
[UX-REVIEWED] 76f61c7 Description read[DESCRIPTION-READ] beda21e88913d3ab7a7689063529331ce0b5cf0336da163276eac1f17fbb3fab That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that a held loop bound to a Teams or iMessage session resumes: only the dashboard, Slack, Discord and the What this change shipsInventory (10 items) — 10 justifiedIntent: keep an unattended goal patrol running overnight after a missed approval or a spent bound, while its ledger still has open work. FIX.
[FIRST-PRINCIPLES-REVIEWED] 76f61c7 Description read[DESCRIPTION-READ] 761f04c786cb45777c863761038101fc88820386a1747021ba6205788e5fda13 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings that block the merge. FINDING — src/kiro_crew/dashboard/handlers/autonudge.py:351 — [OPUS-REVIEWED] 76f61c7 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
53a3255 to
b9ea065
Compare
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
…omous work Builds on rfc-goal-loop-approval-hold, whose hold (kirodotdev#16993) decides the runtime's response to an unanswered approval, and proposes what that document does not decide: - agent-facing contracts that treat a remediable blocker as work rather than a stop condition, across the base prompt, the /goal instruction, the autonudge_stop description and the bundled and repo skills; - an authority ceiling that covers the loop's own budget: a self-session bound write is capped at the pair the owner committed, a stop the agent can trigger retains the commitment, and a re-arm or proxy at a committed slot inherits it; - a per-slot commitment record in a leaf the sandbox seals, the file-edit gate refuses and only the gateway writes; - a commitment generation and sealed provenance for scheduled automation, so a run, cron or completion launched under an ended commitment arms nothing; and - a finite 50-cycle default for the dashboard goal surfaces and the refusal of a negative cap at every boundary. The bound-write cap collides with the conductor's agent-side renewal, which the approval-hold document keeps; that is open question 1 and the Phase 1 cap is blocked on it. Adds the document's row to the request-for-change index.
Problem / Motivation
Goal: A goal loop waits when a tool approval goes unanswered and picks up again by itself once someone is back. A conductor's work-ledger watch keeps running while its ledger still has open work.
A long patrol loop ended for good at cycle 47 of 200. One cycle asked for a tool approval while nobody was at the dashboard. The prompt timed out, and the next wake turned the loop off (
stopped_reason: approval_stalled). Only a person re-arming it could bring it back. A work-ledger watch has the same problem with its own limits: when its cycle cap or time budget runs out, it stops even though the ledger still has open items.Why it matters
Unattended patrols are meant to run overnight. Today one missed approval prompt, or one spent cap, ends the whole patrol. Nobody hears about it until someone opens the dashboard and starts it again by hand.
Not a goal
patrol_budget.py. A sibling PR owns those.gateway.loghistory. Another PR owns that.gate=Falsecontroller records). Their approval-stall handling is unchanged.What changed (motivation → approach → change)
Decision record.
rfc-goal-loop-approval-hold.mdrecords the hold, the held-time credit and the work-ledger extension, with the alternatives and risks. It landed on main as its own docs PR, #17033, and this PR is rebased onto it.Root cause. In the timer (
autonudge_service/firing.py), the approval stall was a stop, just like a spent cap. So nothing ever turned the loop back on.Approach. The timer now treats the stall as a hold. Setting the hold is written to the store first and announced only after the write lands (
_record_approval_hold). It then sends one notification on the monitor channel (_notify_nudge_heldinslack/gateway.py) naming what resumes it, in place of the old "loop stopped" one. (It replaces the old stop notice, which the hold removed; it is not a new kind.) It sits after the cycle cap and before the time budget, so the wall clock running during the wait cannot end the loop. When the hold ends, the waiting time is given back to the budget clock (created_ts). The reconciler skips a held loop. One release function (release_approval_hold, inautonudge_service/timers.py) writes the cleared hold to the store, waits for that write, and only then announces it and re-arms the loop. If the write fails, the hold stays as it was. It is bound on the service insrc/kiro_crew/autonudge.py, next to a best-effortrelease_approval_hold_forhelper. Its callers are: the dashboard runner's approval closer (only when no host route decided it), the Slack and Discord approval waits (slack/gateway.py,discord/renderer.py), the shared registry inmessaging/approval.py, a message a person typed in the dashboard (notify_user_input(human=True), set inchat_handlers.py), and the manual fire route, which refuses the press withapproval_hold_release_failedif the release cannot be written. A Slack or Discord message on its own does not release it; answering an approval there does. An agent's or app's turn does not release it.For the ledger watch, the timer reads open items through a new
has_open_itemsfunction inprobes/work_ledger.py, the module that is already the store's read seam for watches. The tick takes itself off the timer table before it raises the bound, so the update cannot cancel it before the WARNING runs. It only counts real evidence, so a ledger it cannot read leaves the limit in place. The runaway backstop is the existingmonitoring.max_runtime_secsceiling.Visible. The goal popover (
website/src/components/AutoNudgePopover.tsx, typed inautoNudgeLoop.ts) shows a held loop as paused, with a newpaused_approval_holdline in everywebsite/src/i18n/locales/catalog (en-XAregenerated): "Paused · an approval in this chat timed out. Press Play or send a message to resume." Play resumes it, and Pause still stops it. The stopped-goal Clear link stays with stopped loops.monitor_inspectreportspaused_for_approval, and the dashboard websocket frame carriesapproval_stalled, which the record normalizer (website/src/monitoring/automation.ts) and the popover bridge (SessionAutomationPopover.tsx) now pass through. The spec docs (monitor-architecture.md,learn-cron-dashboard.md,messaging.md) describe the hold and the extension.The cycle-cap check still runs first, so a cap reached before the hold began still ends the loop.
Backwards compatibility
Compatible: stored rows load as before. The new
approval_stalled_atfield defaults to 0, and a row already stopped withapproval_stalledkeeps that reason and can still be re-armed.Removes nothing: the stop on an unanswered approval becomes a hold, and no field, route or key is removed.
Tests
test/test_autonudge_approval_stall.py: an unanswered approval holds the loop (still active, no fire, noexpired, nothing armed). Waiting time is given back to the budget. A person typing releases the hold and an app send does not. A release re-arms, and the next cycle fires. The reconciler leaves a held loop alone. A hold or a release whose write fails is undone and announces nothing. The release helper is best-effort.monitor_inspectshows the hold.test/test_autonudge_ledger_extension.py: a tick running as the real armed timer survives its own update and logs. A spent cap or budget with open items is raised, with the right amounts and the clamp. A finished ledger, a non-ledger loop and a user stop all stop as before. The backstop refuses past the ceiling, an unreadable ledger counts as no open items, and there is a seven-day fallback.test/test_messaging_approval.py: an answer releases the hold and a timeout does not.test/test_dashboard_approval_window.py: the dashboard release is gated on the host attribution and is not in the timeout branch.test/test_autonudge_manual_fire.py: the fire route releases the hold before firing, and refuses with 503 when it cannot.website/src/test/automationNormalizer.test.tsandSessionAutomationPopover.test.tsx:approval_stalledsurvives the normalizer and the bridge, so the shipped popover shows the hold.website/src/test/AutoNudgePopover.test.tsx: a held loop reads paused (new line, warn box, Play resumes, Pause still stops it, no Clear).test/test_monitor_notice_channel.py: the hold notification lands on the monitor channel and names what resumes it.test_autonudge_refactor_contract.py,test_autonudge_handlers_cov80.py) are updated for the new members and field.Manual verification
I rendered the goal popover with a held loop and with a running loop, in an isolated capture page against the Vite dev server (screenshots below). The scoped local gates passed. Four backend tests and five frontend test files fail the same way on an unmodified base checkout on this host (sandbox and symlinked
node_modules), so they are environmental. CI is the authority on the full suites.Screenshots / video
Held for approval: the title reads Paused, the warn box says what resumes it, Play resumes it and Pause still stops it.
Running loop, unchanged
Related Issues
Closes #16976
Decision: #17033 (
docs/request-for-change/rfc-goal-loop-approval-hold.md), merged.Related: #13000 takes a different path (it keeps firing through permission blockers). This PR holds the loop instead.
Pattern harvest
Not generalizable: the fix changes one terminal decision into a hold with a release. That is a product choice in one timer, not a code pattern a rule could catch.
Checklist