Skip to content

docs(rfc): screen 02 records the returning-visit landing on the MRU crewmate - #13169

Merged
CrysisDeu merged 1 commit into
mainfrom
docs/rfc-crewmates-mru-landing
Sep 23, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
docs/rfc-crewmates-mru-landing

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

docs/request-for-change/rfc-crewmates-launch.md (accepted) decides screen 02 as the empty state, the New crewmate dialog and the post-create open, and says nothing about what the Crewmates tab shows to a returning person who already has crewmates. That default was the product owner's explicit call for the launch — with crewmates present, open the most-recently-used chat — and it was recorded in the original screen 03 text, which #13032 replaced with the startup prune. The First Principles lane reads product shape off the base branch, so the RFC on main must carry the decision the implementing PR (#12924) ships.

Why it matters

Until the RFC records the landing rule, #12924 is blocked as a product-shape change without an RFC, and the launch's decision record is silent on the screen every returning user sees first.

What changed (motivation → approach → change)

Docs only, one file. Screen 02 gains one decided bullet and one paragraph of reasoning:

Was Is
Screen 02 covers the empty hero, the dialog and the post-create open; the returning visit is undecided on main With crewmates present and none named in the URL, the tab lands on the most-recently-used crewmate's chat — the one this browser last opened when it remembers one, else the one with the latest activity. No "Pick a crewmate" sentence, no "joined your crew" banner; below the medium breakpoint the tab still lands on the roster

The reasoning paragraph says why: the tab is a place to talk to a teammate, not a menu of them; a returning person wants the conversation they left; the roster stays one column away; this replaces the earlier "the user picks" default (#11763), which predated crewmates having conversations worth returning to; a wrong guess costs one click and loses nothing.

Two references are updated so the RFC agrees with itself: implementation-prs in the front matter gains 12924, and the § 8 branch entry for feat/crewmates-page-empty-create becomes the #12924 link naming the landing. Every other line of the RFC is byte-identical.

Backwards compatibility

Compatible: a documentation change.

Tests

N/A — docs only; scripts/docs-lint.sh passes.

Manual verification

N/A — docs only.

Related Issues

no linked issue: amends the accepted launch RFC for #12924.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and dwu96 September 23, 2026 20:14
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 20c819e3d5bea7624ccfeb7968405251684e1947 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 20c819e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 20c819e3d5bea7624ccfeb7968405251684e1947: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 20c819e3d5bea7624ccfeb7968405251684e1947 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the added tiebreaker specifics (browser-remembered first, activity fallback, sub-medium roster landing) match the product owner's call, not #12924's implementation.

[DESIGN-REVIEWED] 20c819e

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 20c819e3d5bea7624ccfeb7968405251684e1947 — this comment is updated in place on each push.

Review details

No findings that block the merge.

FINDING — docs/request-for-change/rfc-crewmates-launch.md:340 — the [#12924](…/pull/12924) bullet sits under "Branches not yet open as PRs; each will add its number to implementation-prs when it opens:" while the same diff adds 12924 to implementation-prs, so § 8 asserts that an open PR is not open and the "Open at the time of writing" list (still only #12797/#12798/#12805/#12806) is incomplete → Fix: move the #12924 bullet into the "Open at the time of writing" list and leave only unopened branch names under the trailing heading.

[OPUS-REVIEWED] 20c819e

Verdict parsed from the review's SHA-scoped output markers for commit 20c819e3d5bea7624ccfeb7968405251684e1947.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 20c819e3d5bea7624ccfeb7968405251684e1947: <one-sentence reason>

@CrysisDeu
CrysisDeu merged commit a118ae7 into main Sep 23, 2026
87 of 90 checks passed
@CrysisDeu
CrysisDeu deleted the docs/rfc-crewmates-mru-landing branch September 23, 2026 21:35
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Sep 23, 2026
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant