Repository navigation
feat(members): Crewmates page: empty hero, New crewmate dialog, MRU - #12924
Conversation
|
Intent: Make the Crewmates page the first screen a new user understands: with no crewmates, one hero says what a crewmate is and creates one in place; after the create, the crewmate's chat opens with its greeting; returning users land in the most recently used chat instead of a "pick one" sentence. Implements screens 02 and 03b of the accepted |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Post-create recovery machinery — parked greetings, per-crewmate holds, dropped-request reconciliation — outweighs the harm it removes and swells MembersPage.tsx to ~3,900 lines. WatchThe create→re-read→thread-open→greeting saga lives as interlocking refs and holds inside the page component ("a parked greeting outlives its create's hold… rides the next open of this crewmate", spec'd new in crew-mode.md this same commit — this PR's own choice, not an inherited decision). Its invariants exist only in comments and ~2,000 lines of tests, so any future change to the roster query, thread-open, or composer path on this core surface must re-thread them; the failure it insures against — a missed auto-greeting within one visit — is self-healing (the user types). The dropped-request reconciliation that prevents a duplicate POST is worth keeping; the greeting parking/riding layer is where the cost concentrates. Suggestions
[DESIGN-REVIEWED] e8f80c0 |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify the "greeting" mechanism matches the decision: the RFC decided the chat "shows its first greeting"; the diff seeds a visible user-authored turn to elicit it. What this change shipsInventory (10 items) — 10 justifiedIntent: a first-time user understands what a crewmate is and creates one on the Crewmates page itself — an ADDITION, implementing accepted RFC
[FIRST-PRINCIPLES-REVIEWED] e8f80c0 |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsEmpty/ FINDING — website/src/pages/members/MembersPage.tsx:2473 — FINDING — website/src/pages/members/MembersPage.tsx:669 — [OPUS-REVIEWED] e8f80c0 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Blind read is partial — the lane's 40-image cap dropped 5 of 45 supplied frames, so two new states were never comprehension-tested. Watch
Evidence gaps
Suggestions
[UX-REVIEWED] e8f80c0 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsFINDING -- website/src/pages/members/NewCrewmateDialog.tsx:395 -- False positive or not applicable? A repository writer can comment: |
8004ca7 to
3835182
Compare
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
|
Evidence gaps from the UX review on 8004ca7 are closed in the body for 3835182: the dialog with Advanced unfolded (workspace / model / triggers / session colour, dark + light) and the below-md hero inside the roster list at 390×844 (dark + light) are attached; all frames are state-asserted by |
|
Re Design Review's question on 8004ca7: yes — the RFC's "most recently used chat opens by default" is the standing landing rule for every visit to |
|
Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.
|
3835182 to
cf9daaf
Compare
|
First Principles verification for |
|
Design verification for |
|
First Principles verification for |
|
|
|
UX evidence gap fixed in |
|
UX evidence gap fixed in |
|
|
|
|
|
|
Design verification for |
|
First Principles verification for |
|
Current-head review dispositions for
|
The Crew Members page becomes the Crewmates page. With no crewmates it shows one hero (ghost avatar, "No crewmates yet", one line, "New crewmate") instead of the roster's small button plus the "pick a member" pane. "New crewmate" (header "+" and the hero) opens a dialog on the page itself: Name, Built from (default agent or a custom agent), "What it looks after", and an Advanced fold with workspace, model, triggers and session colour rendered by the crew editor's own field components. It posts to the same POST /api/agents the crew manager's create form uses; the job line is stored as the record's `description`. After the create the roster is re-read, the new crewmate's chat opens through the verified thread endpoint, and one first turn is seeded over the composer's send path so the chat opens with the crewmate's greeting. When crewmates exist and the URL names none, the remembered crewmate opens, else the most recently used one (greatest last_active_ts, ties keep roster order). The default follows use, never the sort, which is what #11763 objected to. Below md nothing auto-opens. Page copy says crewmate / Crewmates and "Built from" in all 12 catalogs; en-XA regenerated. Spec: crew-mode.md.
Problem / Motivation
Goal: A first-time user understands a crewmate and creates one here.
The Crew Members page assumes you already know what a "member" is and where it comes from. With none yet it shows a one-line "No crew members yet." and a small button that sends you to the crew manager; the chat column says "Pick a member". Adding one means leaving the page, filling the crew editor's full form (template, workspace, memory, triggers, colour) and coming back to an empty transcript. With members present and none chosen, the page shows the "Pick a member" sentence instead of a conversation.
Why it matters
Crewmates are the launch story: your AI teammate, give it a job, it keeps working. The first screen has to say that in one look and let you make one in one dialog. Today the first screen is a detour into configuration, and every return visit starts on a blank pane. Decisions: the accepted RFC
docs/request-for-change/rfc-crewmates-launch.md, screen 02. The returning-visit landing (remembered, else most recently used chat) is the product owner's call; #13032 rewrote the RFC's screen 03 and the sentence recording it left the RFC, so #13169 (merged) puts it back under screen 02; this head is rebased onto it.What changed (motivation → approach → change)
#6366f1#4f8ef7(HEX_COLOR_EXAMPLE), matching its placeholderApproach. One write path, two doors. The dialog (
pages/members/NewCrewmateDialog.tsx) asks Name, Built from, What it looks after, folding the rest of the crew editor's form (KiroCrewAgentsPage.tsxfields) behind Advanced. It posts the crew manager'sPOST /api/agentsbody, job asdescription. Built from lists the catalog's template rows (GET /api/agents/catalog, re-read on open),kirocrewfirst, never a member row. Every value is a draft for the dismiss guard, the sharedWorkspaceModal's too; the sharedInfoTipgainstype="button"; the parent modal becomes inert while the nested Radix overlay sits above it; in flight onefieldsetlocks every control; a failed options read is said. Names are free-form display text; server-derived member IDs stay separate.src/kiro_crew/memory_stores.pyallocation reserves live IDs, live legacy slugs, stores, and foreign DM bindings; upgrades keep the current owner.Change.
MembersPage.tsxrendersCrewmateEmptyHero(chat column above md, roster below) when no crewmates exist, including a default-only roster and mounts the dialog. After a create it re-reads the roster, opens the chat through the verified thread endpoint, seeds one turn. A failed re-read or REFUSED greeting send shows anErrorNoticewith a retry naming its step, never reading the name as gone; the count reads as a dash meanwhile; below md the roster yields to a roster-kind notice only, a greeting notice with no chat open sits in the roster; a roster failure can be dismissed only over other crewmates; the greeting notice's existingdismissLabelsays Send it again goes with it. A failed first roster read shows the notice with Try again in the chat column at md and up and holds the + (title: that sentence); before it answers the + is absent. Transport-error and response-late add no notice; the send receipt is authoritative. A request dropping with no answer is checked against the roster (bounded), never claimed: that name found is said as taken; no row: nothing created; unreadable: Not confirmed. Answers landing after the user left are dropped; a failed chat open or roster re-read parks the greeting until the crewmate's next same-page open, after any other greeting in flight. From the create until its greeting settles, and while a step is failed, every create door is held with the reason: a second create cannot lose the first's retry.resolveDefaultMember: the remembered crewmate, else greatestlast_active_ts; default-only resolvesundefined. Below md nothing auto-opens. Implements RFC screen 02 (#12813); rail, Feature Previews, sidebar keep "Crew Members" until the navigation PR. A roster name is a Name hint; a 400credential_shaped_nameis anErrorNoticemarking Name (not echoed); a 409 also refreshes the roster. 12 catalogs (32 keys added, three removed) plus the editor's member-subject hints;en-XA.jsonregenerated;docs/system-specs/modules/crew-mode.md,docs/crew-members.mdand the feature map carry the landing/create rule; chunktgrows 1,332 B (#12776). The crew manager's?new=1&from=membershand-off goes.Not a goal
This does not rename the remaining navigation labels.
Backwards compatibility
Compatible: additive only — no config, response, or record shape changes.
POST /api/agentsreceives adescriptionit already accepted;?member=<name>, the remembered-crewmate storage key and the below-md navigation are unchanged. The crew manager's own create form still works.Tests
MembersPage.test.tsx: a failed first read holds the + under the failure sentence, freed by Try again;resolveDefaultMember(remembered wins, else greatestlast_active_ts, tie keeps order, stale → MRU, empty/default-only → undefined); a fresh desktop visit opens the most recently used chat and writes the URL/memory; an empty or default-only roster renders the hero (both copies) and no in-list button; "+" and the hero open the dialog without navigating; Create is the form's submit button byform=(the Modal footer is a sibling of the form), so the form's submit event — Enter in a field — posts the create; a successful create invalidates the crew registry (['kirocrew-agents'], exact) and config caches as the crew manager's form does, so the pencil deep link finds the new crewmate, waiting at most 2.5 s for that re-read so a stalled warm-up cannot hold the dialog on Creating…; the dialog refuses a blank name with a hint and no request, posts the crew manager's payload plusdescription, re-reads the roster, opensmember-radarand seeds onesendChatnaming the crewmate and its job; a 409agent_existsis said in plain words inside the dialog and invalidates the roster query; Advanced togglesaria-expandedand mounts the editor's fields; an in-flight create disables the fieldset, the Advanced toggle, its Triggers field and Name; a workspace created from Advanced is picked at once; a late create answer after Cancel, X, Escape, parent close or unmount changes no draft or cache; the nested New workspace form refuses Escape/backdrop while it holds unsaved input (its Cancel still closes it) and that Escape does not close the crewmate dialog underneath; a typed draft, a draft in the nested workspace form, or an in-flight create registers the app-shell navigation leave guard (sidebar, palette, Back ask before unmounting the dialog; an untouched or closed dialog leaves freely); a create that resolves after the page was unmounted (the user accepted the leave prompt) performs no roster re-read, opens no chat and sends nothing; Built from offers only the catalog's template rows, never member rows; the roster count reads as a dash while a post-create roster failure is up (the same dash as a failed first read); an unclassified create failure says "Couldn't create the crewmate. Nothing was created — try again.", never the server's or the exception's sentence, a 2xx body carryingerrorincluded; a name already on the roster is refused as a hint under the field (validation, no ErrorNotice) with no request, a stale-roster 409 is said as taken through the notice and marks the Name fieldaria-invaliduntil it is edited; a 400credential_shaped_nameis said through its own notice without the name; a 400invalid_member_namegets a no-echo notice with alternative fixes for pasted/hidden text, line breaks, tabs, period-only names and the 500-character cap; both mark Name until edited; a dropped connection is reconciled against the roster — the name found there is said as taken with the list refreshed, no chat opened, no greeting and no second POST; the name absent says nothing was created; an unreadable roster says unconfirmed, and a roster read that never answers is said as unconfirmed within 2.5 s with the form unlocked again (Cancel live); the header + is held (title naming the crewmate) through the thread open and the greeting send, freed when the greeting lands or the thread open fails (the greeting then stays parked and rides that crewmate's next successful same-page open, once, not while another's greeting is in flight; a parked crewmate's failed reopen releases only its own hold, never another crewmate's), and held again while a follow-up step is failed until its retry lands; the hero CTA is held the same way while the first create's roster re-read is still in flight; a roster-kind hold over an empty roster names only the retry ("Refresh the list for X…"), every dismissable notice's hold says retry or dismiss, and the reason is the button's accessible name too; a failed re-read over a roster with other crewmates can be dismissed — the old list returns, the + is free, no greeting was sent, and the crewmate's first open after the next good roster read still seeds it once; a failed roster read at md and up says so in the chat column (member-column-load-error; the roster-column copy is below-md only), each placement with a Try again that repeats the read and clears the notice on a good answer; on an empty roster the hero is the one create door and the header + is not rendered; free-form names with spaces, accents or emoji are posted unchanged after trimming; Built from postskiro_agent: 'kirocrew'for the default; a failed roster re-read after the create shows the notice with retry and posts no thread and no greeting until the retry succeeds; a re-read cancelled mid-flight (the star mutation'scancelQueriesreverts it to the stale roster without an error) counts as failed too, never as the new name being gone; after a first create with no chat open, that notice hides the roster below md so Try again stays on screen, and dismissing it hands the width back; a refused greeting shows its notice, quote, named dismiss and safe resend; each retry carries its own label ("Refresh your crewmates" / "Send it again"); Built from is re-read on every open (understaleTime: Infinity); a chat open that answers after the page unmounted seeds no greeting; a closed chat's greeting notice keeps the roster; the help "?" toggles inside Advanced open their tip and never post the create.Modal.test.tsx:interactionDisabledmakes the parent inert and stands down its Tab trap; the nested workspace keeps input. The empty session-colour preview matches its example; Model explains inherited uses the default setting.MembersPage.filters.test.tsx,CrewRoster.test.tsx,CrewEditorSelect.test.tsx,MemberMemoryIdentity.test.tsx,MemberMemoryPanel.test.tsx: copy assertions follow the rename;CrewRoster.test.tsxandKiroCrewAgentsPage.templateEditLaterNote.test.tsxdrop the six?new=1&from=memberscases whose path no longer exists (the plain?new=1deep-link case stays). Desktop cases that relied on "nothing opens" now seed a remembered crewmate or assert the MRU open.Agentic GUI user test:
test/gui_user/scenarios/crewmate-create-first.yaml(tiernightly, featuremembers) drives the real dashboard from Settings → Feature Previews → Crewmates page → New crewmate → "Radar" with a job → Create, and expects the dialog closed, Radar's chat open and the greeting bubble visible.test/gui_user/test_scenarios_and_report.pypins the new name and the 41-scenario / 9-nightly counts. Static schema check run locally; the scenario itself runs only in the nightly lane.Manual verification
Static gates run locally:
tsc -b --force, eslint on the changed files,node scripts/i18n-check.mjs(19 checks PASS), the per-locale style suites,scripts/docs-lint.sh,npm run build. Test suites are left to CI per the launch contract. Screenshots: real components rendered against stubbed/api(Vite + Playwright,scripts/capture-crewmates-page-create.mjs, every frame state-asserted before capture); backend exercised by CI only.Screenshots / video
Real components rendered against stubbed
/api(Vite + Playwright, every frame state-asserted before capture); backend exercised by CI only. 1440×900 desktop (1440×1100 for the unfolded dialog, so its last field is in frame), 390×844 phone. Every frame and the recording were captured from one commit, named under the recording: this PR's single commit at capture time. The head is that commit or its rebase onto a newer main (a rebase changes the SHA, not thewebsite/tree). The harness asserts that commit's own copy (hints, default label, placeholder) in the dialog frames.Empty state (dark / light):
New crewmate dialog (dark / light):
The same dialog with Advanced unfolded — workspace, model, triggers, session colour (dark / light):
Advanced unfolding and folding back (recording):
every frame above and below, and this recording (it opens the dialog, then unfolds Advanced): captured from
563cfba0311afdaf335866a708c6dd440ce197c3, the four roster-load-failed frames from5937ed8543bbefe7a4f9a8a912d4e15fa03893ab, the two phone greeting frames from0519a4e3bba0467b8325091e2f3946d4f20a202a(its other changes move no pixel) ·kirodotdev/KiroCrewbranchfeat/crewmates-page-empty-create· mode: Vite dev server + Playwright,/apistubbed by the harness · real components, no backendAfter create — Radar's chat open with the seeded first turn and its greeting (dark / light):
The create landed but the roster re-read failed — the notice centred in the chat column with Refresh your crewmates under it, no dismiss (the cached roster is empty), the roster count a dash (the same dash as a failed first read) and the header + held until the retry (dark / light):
The same failure below md (390×844) after a first create — no chat is open, so the roster yields and the notice is the screen, nothing off to the right (dark / light):
The same failure below md with another crewmate already on the roster — the notice carries a dismiss, so Oncall's chat is never locked behind the failing read; closing it shows the old list again (dark / light):
The roster's first read failed at md and up — the chat column carries the one notice, with Try again under it and the ask link beside, instead of a blank pane or the empty hero, and the header + is held (its title the failure sentence); the roster-column copy is below-md only (dark / light), where the ask link sits on its own line under the sentence (390×844, dark / light):
The create and the re-read landed but the seeded first message was refused — Radar's chat is open under a notice with a dismiss, Send it again, and the message it would send quoted beneath (dark / light):
The same refused greeting below md (390×844) after the header back closed Radar's chat — the roster is the screen, so the notice sits in it: dismiss and Send it again on screen, the header + held until one of them acts (dark / light):
The dialog's own states (dark / light): blank name refused in the error tone, name taken, create failed with the next step (server body not echoed, draft kept), choices failed to load, naming the list, creating with every control locked and Cancel dimmed, a dropped request with an unreadable roster shown with a **Not confirmed** lead
Below md (390×844): the hero inside the roster list
Related Issues
Follow-ups: #14392 returns stable create identity; #14418 aligns Meet Crewmates with free-form names. Launch work remains tracked in the CrewMates review doc (Taskei T18684, T18693, T18676).
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)