Skip to content

feat(members): Crewmates page: empty hero, New crewmate dialog, MRU - #12924

Merged
iamwhatever merged 1 commit into
mainfrom
feat/crewmates-page-empty-create
Sep 27, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/crewmates-page-empty-create

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A first-time user understands a crewmate and creates one here.

The Crew Members page assumes you already know what a "member" is and where it comes from. With none yet it shows a one-line "No crew members yet." and a small button that sends you to the crew manager; the chat column says "Pick a member". Adding one means leaving the page, filling the crew editor's full form (template, workspace, memory, triggers, colour) and coming back to an empty transcript. With members present and none chosen, the page shows the "Pick a member" sentence instead of a conversation.

Why it matters

Crewmates are the launch story: your AI teammate, give it a job, it keeps working. The first screen has to say that in one look and let you make one in one dialog. Today the first screen is a detour into configuration, and every return visit starts on a blank pane. Decisions: the accepted RFC docs/request-for-change/rfc-crewmates-launch.md, screen 02. The returning-visit landing (remembered, else most recently used chat) is the product owner's call; #13032 rewrote the RFC's screen 03 and the sentence recording it left the RFC, so #13169 (merged) puts it back under screen 02; this head is rebased onto it.

What changed (motivation → approach → change)

Surface Before After
Page title / copy Crew Members, "member", "Agent template" Crewmates, "crewmate", "Built from"
Empty roster small in-list button + "Pick a member" pane one hero: ghost avatar, "No crewmates yet", one line, New crewmate; no header +
"+" and hero navigate to the crew manager's create form open New crewmate dialog on the page
After create land on an empty transcript new crewmate's chat opens with its first greeting
Crewmates exist, none chosen "Pick a member" sentence remembered crewmate, else the most recently used chat opens
Shared session-color preview empty swatch #6366f1 #4f8ef7 (HEX_COLOR_EXAMPLE), matching its placeholder

Approach. One write path, two doors. The dialog (pages/members/NewCrewmateDialog.tsx) asks Name, Built from, What it looks after, folding the rest of the crew editor's form (KiroCrewAgentsPage.tsx fields) behind Advanced. It posts the crew manager's POST /api/agents body, job as description. Built from lists the catalog's template rows (GET /api/agents/catalog, re-read on open), kirocrew first, never a member row. Every value is a draft for the dismiss guard, the shared WorkspaceModal's too; the shared InfoTip gains type="button"; the parent modal becomes inert while the nested Radix overlay sits above it; in flight one fieldset locks every control; a failed options read is said. Names are free-form display text; server-derived member IDs stay separate. src/kiro_crew/memory_stores.py allocation reserves live IDs, live legacy slugs, stores, and foreign DM bindings; upgrades keep the current owner.

Change. MembersPage.tsx renders CrewmateEmptyHero (chat column above md, roster below) when no crewmates exist, including a default-only roster and mounts the dialog. After a create it re-reads the roster, opens the chat through the verified thread endpoint, seeds one turn. A failed re-read or REFUSED greeting send shows an ErrorNotice with a retry naming its step, never reading the name as gone; the count reads as a dash meanwhile; below md the roster yields to a roster-kind notice only, a greeting notice with no chat open sits in the roster; a roster failure can be dismissed only over other crewmates; the greeting notice's existing dismissLabel says Send it again goes with it. A failed first roster read shows the notice with Try again in the chat column at md and up and holds the + (title: that sentence); before it answers the + is absent. Transport-error and response-late add no notice; the send receipt is authoritative. A request dropping with no answer is checked against the roster (bounded), never claimed: that name found is said as taken; no row: nothing created; unreadable: Not confirmed. Answers landing after the user left are dropped; a failed chat open or roster re-read parks the greeting until the crewmate's next same-page open, after any other greeting in flight. From the create until its greeting settles, and while a step is failed, every create door is held with the reason: a second create cannot lose the first's retry. resolveDefaultMember: the remembered crewmate, else greatest last_active_ts; default-only resolves undefined. Below md nothing auto-opens. Implements RFC screen 02 (#12813); rail, Feature Previews, sidebar keep "Crew Members" until the navigation PR. A roster name is a Name hint; a 400 credential_shaped_name is an ErrorNotice marking Name (not echoed); a 409 also refreshes the roster. 12 catalogs (32 keys added, three removed) plus the editor's member-subject hints; en-XA.json regenerated; docs/system-specs/modules/crew-mode.md, docs/crew-members.md and the feature map carry the landing/create rule; chunk t grows 1,332 B (#12776). The crew manager's ?new=1&from=members hand-off goes.

Not a goal

This does not rename the remaining navigation labels.

Backwards compatibility

Compatible: additive only — no config, response, or record shape changes. POST /api/agents receives a description it already accepted; ?member=<name>, the remembered-crewmate storage key and the below-md navigation are unchanged. The crew manager's own create form still works.

Tests

MembersPage.test.tsx: a failed first read holds the + under the failure sentence, freed by Try again; resolveDefaultMember (remembered wins, else greatest last_active_ts, tie keeps order, stale → MRU, empty/default-only → undefined); a fresh desktop visit opens the most recently used chat and writes the URL/memory; an empty or default-only roster renders the hero (both copies) and no in-list button; "+" and the hero open the dialog without navigating; Create is the form's submit button by form= (the Modal footer is a sibling of the form), so the form's submit event — Enter in a field — posts the create; a successful create invalidates the crew registry (['kirocrew-agents'], exact) and config caches as the crew manager's form does, so the pencil deep link finds the new crewmate, waiting at most 2.5 s for that re-read so a stalled warm-up cannot hold the dialog on Creating…; the dialog refuses a blank name with a hint and no request, posts the crew manager's payload plus description, re-reads the roster, opens member-radar and seeds one sendChat naming the crewmate and its job; a 409 agent_exists is said in plain words inside the dialog and invalidates the roster query; Advanced toggles aria-expanded and mounts the editor's fields; an in-flight create disables the fieldset, the Advanced toggle, its Triggers field and Name; a workspace created from Advanced is picked at once; a late create answer after Cancel, X, Escape, parent close or unmount changes no draft or cache; the nested New workspace form refuses Escape/backdrop while it holds unsaved input (its Cancel still closes it) and that Escape does not close the crewmate dialog underneath; a typed draft, a draft in the nested workspace form, or an in-flight create registers the app-shell navigation leave guard (sidebar, palette, Back ask before unmounting the dialog; an untouched or closed dialog leaves freely); a create that resolves after the page was unmounted (the user accepted the leave prompt) performs no roster re-read, opens no chat and sends nothing; Built from offers only the catalog's template rows, never member rows; the roster count reads as a dash while a post-create roster failure is up (the same dash as a failed first read); an unclassified create failure says "Couldn't create the crewmate. Nothing was created — try again.", never the server's or the exception's sentence, a 2xx body carrying error included; a name already on the roster is refused as a hint under the field (validation, no ErrorNotice) with no request, a stale-roster 409 is said as taken through the notice and marks the Name field aria-invalid until it is edited; a 400 credential_shaped_name is said through its own notice without the name; a 400 invalid_member_name gets a no-echo notice with alternative fixes for pasted/hidden text, line breaks, tabs, period-only names and the 500-character cap; both mark Name until edited; a dropped connection is reconciled against the roster — the name found there is said as taken with the list refreshed, no chat opened, no greeting and no second POST; the name absent says nothing was created; an unreadable roster says unconfirmed, and a roster read that never answers is said as unconfirmed within 2.5 s with the form unlocked again (Cancel live); the header + is held (title naming the crewmate) through the thread open and the greeting send, freed when the greeting lands or the thread open fails (the greeting then stays parked and rides that crewmate's next successful same-page open, once, not while another's greeting is in flight; a parked crewmate's failed reopen releases only its own hold, never another crewmate's), and held again while a follow-up step is failed until its retry lands; the hero CTA is held the same way while the first create's roster re-read is still in flight; a roster-kind hold over an empty roster names only the retry ("Refresh the list for X…"), every dismissable notice's hold says retry or dismiss, and the reason is the button's accessible name too; a failed re-read over a roster with other crewmates can be dismissed — the old list returns, the + is free, no greeting was sent, and the crewmate's first open after the next good roster read still seeds it once; a failed roster read at md and up says so in the chat column (member-column-load-error; the roster-column copy is below-md only), each placement with a Try again that repeats the read and clears the notice on a good answer; on an empty roster the hero is the one create door and the header + is not rendered; free-form names with spaces, accents or emoji are posted unchanged after trimming; Built from posts kiro_agent: 'kirocrew' for the default; a failed roster re-read after the create shows the notice with retry and posts no thread and no greeting until the retry succeeds; a re-read cancelled mid-flight (the star mutation's cancelQueries reverts it to the stale roster without an error) counts as failed too, never as the new name being gone; after a first create with no chat open, that notice hides the roster below md so Try again stays on screen, and dismissing it hands the width back; a refused greeting shows its notice, quote, named dismiss and safe resend; each retry carries its own label ("Refresh your crewmates" / "Send it again"); Built from is re-read on every open (under staleTime: Infinity); a chat open that answers after the page unmounted seeds no greeting; a closed chat's greeting notice keeps the roster; the help "?" toggles inside Advanced open their tip and never post the create. Modal.test.tsx: interactionDisabled makes the parent inert and stands down its Tab trap; the nested workspace keeps input. The empty session-colour preview matches its example; Model explains inherited uses the default setting. MembersPage.filters.test.tsx, CrewRoster.test.tsx, CrewEditorSelect.test.tsx, MemberMemoryIdentity.test.tsx, MemberMemoryPanel.test.tsx: copy assertions follow the rename; CrewRoster.test.tsx and KiroCrewAgentsPage.templateEditLaterNote.test.tsx drop the six ?new=1&from=members cases whose path no longer exists (the plain ?new=1 deep-link case stays). Desktop cases that relied on "nothing opens" now seed a remembered crewmate or assert the MRU open.

Agentic GUI user test: test/gui_user/scenarios/crewmate-create-first.yaml (tier nightly, feature members) drives the real dashboard from Settings → Feature Previews → Crewmates page → New crewmate → "Radar" with a job → Create, and expects the dialog closed, Radar's chat open and the greeting bubble visible. test/gui_user/test_scenarios_and_report.py pins the new name and the 41-scenario / 9-nightly counts. Static schema check run locally; the scenario itself runs only in the nightly lane.

Manual verification

Static gates run locally: tsc -b --force, eslint on the changed files, node scripts/i18n-check.mjs (19 checks PASS), the per-locale style suites, scripts/docs-lint.sh, npm run build. Test suites are left to CI per the launch contract. Screenshots: real components rendered against stubbed /api (Vite + Playwright, scripts/capture-crewmates-page-create.mjs, every frame state-asserted before capture); backend exercised by CI only.

Screenshots / video

Real components rendered against stubbed /api (Vite + Playwright, every frame state-asserted before capture); backend exercised by CI only. 1440×900 desktop (1440×1100 for the unfolded dialog, so its last field is in frame), 390×844 phone. Every frame and the recording were captured from one commit, named under the recording: this PR's single commit at capture time. The head is that commit or its rebase onto a newer main (a rebase changes the SHA, not the website/ tree). The harness asserts that commit's own copy (hints, default label, placeholder) in the dialog frames.

Empty state (dark / light):

Crewmates page, no crewmates yet, dark
Crewmates page, no crewmates yet, light

New crewmate dialog (dark / light):

New crewmate dialog, dark
New crewmate dialog, light

The same dialog with Advanced unfolded — workspace, model, triggers, session colour (dark / light):

New crewmate dialog, Advanced open, dark
New crewmate dialog, Advanced open, light
New workspace dialog over inert New crewmate parent, dark
New workspace dialog over inert New crewmate parent, light

Advanced unfolding and folding back (recording):

New crewmate dialog, Advanced unfolds and refolds

every frame above and below, and this recording (it opens the dialog, then unfolds Advanced): captured from 563cfba0311afdaf335866a708c6dd440ce197c3, the four roster-load-failed frames from 5937ed8543bbefe7a4f9a8a912d4e15fa03893ab, the two phone greeting frames from 0519a4e3bba0467b8325091e2f3946d4f20a202a (its other changes move no pixel) · kirodotdev/KiroCrew branch feat/crewmates-page-empty-create · mode: Vite dev server + Playwright, /api stubbed by the harness · real components, no backend

After create — Radar's chat open with the seeded first turn and its greeting (dark / light):

Radar's chat after create, dark
Radar's chat after create, light

The create landed but the roster re-read failed — the notice centred in the chat column with Refresh your crewmates under it, no dismiss (the cached roster is empty), the roster count a dash (the same dash as a failed first read) and the header + held until the retry (dark / light):

Post-create notice centred with Refresh your crewmates, count a dash, header + held, dark
Post-create notice centred with Refresh your crewmates, count a dash, header + held, light

The same failure below md (390×844) after a first create — no chat is open, so the roster yields and the notice is the screen, nothing off to the right (dark / light):

Post-create notice on a phone, Refresh your crewmates on screen, dark
Post-create notice on a phone, Refresh your crewmates on screen, light

The same failure below md with another crewmate already on the roster — the notice carries a dismiss, so Oncall's chat is never locked behind the failing read; closing it shows the old list again (dark / light):

Post-create notice on a phone over an existing roster, with a dismiss, dark
Post-create notice on a phone over an existing roster, with a dismiss, light

The roster's first read failed at md and up — the chat column carries the one notice, with Try again under it and the ask link beside, instead of a blank pane or the empty hero, and the header + is held (its title the failure sentence); the roster-column copy is below-md only (dark / light), where the ask link sits on its own line under the sentence (390×844, dark / light):

Roster load failed at md and up: one notice, in the chat column, held +, dark
Roster load failed at md and up: one notice, in the chat column, held +, light
Roster load failed on a phone: roster-column notice, ask link on its own line, held +, dark
Roster load failed on a phone: roster-column notice, ask link on its own line, held +, light

The create and the re-read landed but the seeded first message was refused — Radar's chat is open under a notice with a dismiss, Send it again, and the message it would send quoted beneath (dark / light):

Greeting refused, Send it again over Radar's chat, dark
Greeting refused, Send it again over Radar's chat, light

The same refused greeting below md (390×844) after the header back closed Radar's chat — the roster is the screen, so the notice sits in it: dismiss and Send it again on screen, the header + held until one of them acts (dark / light):

Greeting refused on a phone, chat closed: the notice in the roster, held +, dark
Greeting refused on a phone, chat closed: the notice in the roster, held +, light

The dialog's own states (dark / light): blank name refused in the error tone, name taken, create failed with the next step (server body not echoed, draft kept), choices failed to load, naming the list, creating with every control locked and Cancel dimmed, a dropped request with an unreadable roster shown with a **Not confirmed** lead

Blank name: refusal in the error tone, dark
Blank name: refusal in the error tone, light
Name already taken, said with the name, dark
Name already taken, said with the name, light
Create request unconfirmed for Radar, dark
Create request unconfirmed for Radar, light
Invalid member name refusal, dark
Invalid member name refusal, light
Held New crewmate menu item, dark
Held New crewmate menu item, light
Create failed on a server 500 (body "config lock held"), said in the product's words, the typed draft kept, dark
Create failed on a server 500 (body "config lock held"), said in the product's words, the typed draft kept, light
Built from choices failed to load, inline notice, dark
Built from choices failed to load, inline notice, light
Creating…, every control locked, Cancel dimmed, dark
Creating…, every control locked, Cancel dimmed, light
Credential-shaped name refused without echoing it, Name marked, dark
Credential-shaped name refused without echoing it, Name marked, light

Below md (390×844): the hero inside the roster list

Crewmates page on a phone, no crewmates yet, dark
Crewmates page on a phone, no crewmates yet, light

Related Issues

Follow-ups: #14392 returns stable create identity; #14418 aligns Meet Crewmates with free-form names. Launch work remains tracked in the CrewMates review doc (Taskei T18684, T18693, T18676).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and Zedmor September 22, 2026 22:06
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Intent: Make the Crewmates page the first screen a new user understands: with no crewmates, one hero says what a crewmate is and creates one in place; after the create, the crewmate's chat opens with its greeting; returning users land in the most recently used chat instead of a "pick one" sentence. Implements screens 02 and 03b of the accepted rfc-crewmates-launch.md.
Not a goal: the opt-in step for existing custom agents (#12798), the Customize page tabs, chat bubble grouping, Notes/Work log tabs, teams, or any change to the crew record, its API or the crew manager's editor.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — 🟡 CONCERNS

Design-level review of e8f80c032a29b266309b9d2c8a63d75a5ef21ebd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

Post-create recovery machinery — parked greetings, per-crewmate holds, dropped-request reconciliation — outweighs the harm it removes and swells MembersPage.tsx to ~3,900 lines.

Watch

The create→re-read→thread-open→greeting saga lives as interlocking refs and holds inside the page component ("a parked greeting outlives its create's hold… rides the next open of this crewmate", spec'd new in crew-mode.md this same commit — this PR's own choice, not an inherited decision). Its invariants exist only in comments and ~2,000 lines of tests, so any future change to the roster query, thread-open, or composer path on this core surface must re-thread them; the failure it insures against — a missed auto-greeting within one visit — is self-healing (the user types). The dropped-request reconciliation that prevents a duplicate POST is worth keeping; the greeting parking/riding layer is where the cost concentrates.
Clears when: the parked-greeting layer is dropped in favor of notice-only degradation (greeting lost, chat still opens), or the whole post-create flow is extracted into a dedicated hook whose invariants live with it, or a maintainer accepts the crew-mode.md parking spec as intended.

Suggestions

  • Extract the post-create orchestration out of MembersPage.tsx into a usePostCreateFlow-style module before the navigation PR adds more to this page.

[DESIGN-REVIEWED] e8f80c0

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of e8f80c032a29b266309b9d2c8a63d75a5ef21ebd — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the "greeting" mechanism matches the decision: the RFC decided the chat "shows its first greeting"; the diff seeds a visible user-authored turn to elicit it.

What this change ships

Inventory (10 items) — 10 justified

Intent: a first-time user understands what a crewmate is and creates one on the Crewmates page itself — an ADDITION, implementing accepted RFC rfc-crewmates-launch.md screen 02 (status accepted on the base list).

  1. Page and copy say Crewmates / crewmate / "Built from" instead of Crew Members / member — justified
  2. Empty roster is one hero (ghost, "No crewmates yet", one New crewmate button); the in-list button, "Pick a member" pane and header "+" are gone there — justified
  3. "+" and hero open an in-page create dialog (Name, Built from, job, Advanced fold) replacing the ?new=1&from=members hand-off to the crew manager, whose member-worded form variant is deleted — justified
  4. After create, the new crewmate's chat opens with a seeded first turn and its greeting — justified
  5. With crewmates and none named, the remembered else most-recently-used chat opens (below md nothing auto-opens); reverses ux(members): I expected "Nova Sky" to be the first member card but it's at the bottom of the list, not… #11763's "user picks" default on the RFC's record — justified
  6. A failed post-create step (roster re-read, refused greeting, no-answer create) gets a notice with a step-naming retry; every create door is held until it settles — justified
  7. A failed first roster read shows the notice with Try again in both columns and withholds the "+" — justified
  8. Backend id allocation reserves live legacy slugs and retained DM bindings, so a namesake never inherits a deleted crewmate's thread; upgrades keep their own slug — justified
  9. Shared form plumbing: nested New workspace dialog guards its draft, the parent modal goes inert beneath it, InfoTip no longer submits its owner form — justified
  10. Empty session-color swatch now shows the placeholder's own constant (HEX_COLOR_EXAMPLE, deleting a second hardcoded literal) — justified

[FIRST-PRINCIPLES-REVIEWED] e8f80c0

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed e8f80c032a29b266309b9d2c8a63d75a5ef21ebd — this comment is updated in place on each push.

Review details

Empty/default-only roster hides the whole "+" menu, so "New team" has no remaining entry point.

FINDING — website/src/pages/members/MembersPage.tsx:2473 — {loaded && !(!loadError && hasNoCrewmates(members)) && ( drops the entire <DropdownMenu>, and member-add-team (onSelect={() => setTeamDialog({})}, the page's only create-a-team call site — 2925 edits an already-open team) goes with it, so on a fresh install whose roster holds only the built-in default row a team cannot be created at all → Fix: move the gate onto the crewmate item, keeping <DropdownMenu> and member-add-team rendered while hasNoCrewmates(members).

FINDING — website/src/pages/members/MembersPage.tsx:669 — aria-label={held ?? undefined} on the hero CTA replaces the button's content-derived name, so while createHeld is set (e.g. add_member_settling during the first create's in-flight follow-up, with the hero still rendered) a screen reader announces only the hold sentence and never "New crewmate", and the visible label no longer appears in the accessible name → Fix: drop aria-label and point aria-describedby at a rendered hold line, or set aria-label={held ? \${t('pages.membersPage.add_member')} — ${held}` : undefined}`.

[OPUS-REVIEWED] e8f80c0

Verdict parsed from the review's SHA-scoped output markers for commit e8f80c032a29b266309b9d2c8a63d75a5ef21ebd.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e8f80c032a29b266309b9d2c8a63d75a5ef21ebd: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of e8f80c032a29b266309b9d2c8a63d75a5ef21ebd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Blind read is partial — the lane's 40-image cap dropped 5 of 45 supplied frames, so two new states were never comprehension-tested.

Watch

  • Twin failure notices invite the wrong retry: reader's own words on shot-30 vs shot-36 — "If I weren't reading carefully I could easily retry the wrong one." In the create_unconfirmed state Create stays enabled, and while the roster stays unreadable a resubmit can mint a duplicate (rare × moderate × once). Smallest fix: hold or relabel the submit under the Not confirmed lead until Name is edited or the list refreshes.

Evidence gaps

  • create_name_credential_shaped refusal (shots 51c41e5e / a5c719e5) and the below-md empty hero (aa479c24; 26842b4d absent from the map) were supplied but truncated out of the blind read — lane failure, caps at CONCERNS; remedy: re-run this workflow (the 40-image listing cap, not the author, dropped them).

Suggestions

  • The greeting notice's dismiss consequence ("Send it again won't be offered after this") lives only in the ×'s accessible name; the reader read × as "just hides it" (shot-22). Put the consequence in visible text beside the control.

[UX-REVIEWED] e8f80c0

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of e8f80c032a29b266309b9d2c8a63d75a5ef21ebd and found no blocking issues.

This comment is updated in place on each push.

Review details

FINDING -- website/src/pages/members/NewCrewmateDialog.tsx:395 -- "api.members()" bypasses React Query, so reconciliation can report an existing crewmate while a failed invalidation leaves it absent from the roster -> Fix: fetch through the roster query with queryClient.fetchQuery. (origin: validation)
[GPT-REVIEWED] e8f80c0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e8f80c032a29b266309b9d2c8a63d75a5ef21ebd: <one-sentence reason>

@CrysisDeu
CrysisDeu force-pushed the feat/crewmates-page-empty-create branch from 8004ca7 to 3835182 Compare September 22, 2026 22:43
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 22, 2026
@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • Default crew alias is persisted as a template binding span=39f3b2550435

fixed in 3835182: the dialog no longer reads /api/config/default-agent at all. Built from lists installed kiro agents only (private fork copies excluded), with the built-in kirocrew leading and labelled "Default agent (kirocrew)"; a crew alias can never reach kiro_agent.
class: a crew NAME stored where a template name belongs. Test pins it: a configured default crew default is not offered and the create posts kiro_agent: 'kirocrew'.

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • Template and advanced drafts bypass accidental-dismiss protection span=39f3b2550435

fixed in 3835182: guardAccidentalDismiss now reads a dirty flag over every editable value — name, job, Built from, workspace (≠ default), model (≠ inherit), triggers, session colour — so an Advanced pick is protected exactly like a typed name.

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • Dialog failures violate the shared error-notice contract span=39f3b2550435

fixed in 3835182: the dialog uses useAvailableModelsQuery and folds its error into optionsError, so a failed model read renders the options notice instead of a silent placeholder list. Both ErrorNotice sites carry a No hand-off comment naming the unsaved form draft (name, job, Advanced picks live only in dialog state; the hand-off navigates and unmounts them).

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • Post-create request failures are discarded span=e7ac5689c151

fixed in 3835182: handleCreated branches on res.isError (react-query keeps the stale roster as data, so the created name would otherwise read as gone and open someone else) and seedGreeting awaits the sendTurn receipt (refused / transport-error / response-late). Either failure renders an ErrorNotice above the chat column with one Try again that repeats exactly that step; unknown (2xx received) is deliberately not retried to avoid a duplicate turn. Two tests pin both paths.

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • Crew Members feature-map row remains stale (origin: validation) span=e7ac5689c151

fixed in 3835182: the Crew Members row of docs/feature-map/README.md now names the empty hero, the in-page New crewmate dialog (NewCrewmateDialog.tsx), POST /api/agents + the dialog's option reads + POST /api/chat for the seeded turn, and the remembered → most-recently-used landing rule; the "Pick a member" wording is gone. Feature Map Gate passes locally against origin/main.

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • failed roster refetch after create routes to the gone-member path span=84c72a0aa725

fixed in 3835182: handleCreated checks res.isError before looking the name up; on error it keeps the created record, shows an ErrorNotice ("Radar was created, but the list didn't refresh.") with Try again, and never writes ?member=, so the gone-member fallback cannot fire on a stale roster. Test: rejected refetch → notice, no thread POST, no gone notice; retry with the roster back opens member-radar and seeds the greeting.

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • Item 5 — duplicate Field wrapper span=386bb4ea8afd

fixed in 3835182: the local Field is deleted; the dialog imports the editor's Field (exported from KiroCrewAgentsPage.tsx alongside WorkspaceModal / INHERIT_MODEL). The "· optional" tag rides the label string it already takes.

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • Schedule expectation gap span=266b6d07f8d8

fixed in 3835182: "What it looks after" now carries a hint under the field — "Plain words are fine. If it should run on its own, add a schedule under Wake sources after creating." — in all 12 catalogs, so a cadence-shaped job is told where the schedule lives before the panel says nothing wakes the crewmate. Visible in the dialog screenshots.

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • member/crewmate drift inside the renamed surface span=d2bedfab88d2

fixed in 3835182: workspace_hint_member, triggers_hint_member, session_color_hint_member, template_hint_member, private_memory_owned and private_memory_legacy now say crewmate in all 12 catalogs ("This crewmate has its own memory (V2)."). The Advanced-open screenshot shows the renamed hints.

@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • built_from_hint wording span=dbe96ef55bde

fixed in 3835182: "The starting setup it copies — tools, connections and instructions. You can change it later." (matching template_hint_member), in all 12 catalogs.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Evidence gaps from the UX review on 8004ca7 are closed in the body for 3835182: the dialog with Advanced unfolded (workspace / model / triggers / session colour, dark + light) and the below-md hero inside the roster list at 390×844 (dark + light) are attached; all frames are state-asserted by scripts/capture-crewmates-page-create.mjs before capture.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Re Design Review's question on 8004ca7: yes — the RFC's "most recently used chat opens by default" is the standing landing rule for every visit to /members with crewmates and no ?member=, not only after the opt-in add. Order: the remembered crewmate if still on the roster, else the most recently used (last_active_ts); below md nothing auto-opens. It is spelled out that way in crew-mode.md and the feature-map row in this PR.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 22, 2026
@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Superseded: this lane re-ran and re-judged later heads; kept as history, not a live disposition record.

  • Extract the shared form pieces to a shared module span=64462a5cdfcf

accepted-and-deferred: #12936 (label deferred-finding, assignee CrysisDeu, Due 2026-10-06). A pure move of Field / the four field components / WorkspaceModal / INHERIT_MODEL into a shared module and the removal of the "also mounted by" comments; kept out of this PR so the launch change stays the dialog and the landing rule, not a relocation of the editor's internals.

@CrysisDeu
CrysisDeu force-pushed the feat/crewmates-page-empty-create branch from 3835182 to cf9daaf Compare September 22, 2026 23:16
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

First Principles verification for bd88d27aebf734bc6cd9d16e0e699307d3530e9e: acceptance requires a new install to reach the crewmate’s first greeting through New crewmate (rfc-crewmates-launch.md:324-325). The seed is a visible, fixed prompt on the normal user-turn path; it neither injects assistant output nor hides an envelope. That preserves the transcript’s causal record while meeting the no-extra-confirmation decision. No code change is needed.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Design verification for 14ac28c0cd4fd9ddaed8a288a72474c88ba69d11: the committed crewmate-create-first gui_user scenario drives the real dashboard through Create, chat open, and visible greeting. It is intentionally nightly-only. The user explicitly forbids local test-suite execution, so CI/nightly remains the real-backend executor; static gates and limited component evidence do not claim otherwise. No code change is needed.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

First Principles verification for 14ac28c0cd4fd9ddaed8a288a72474c88ba69d11: RFC screen 01 separates Crewmates from Custom agents and says a custom agent is what a crewmate is built from (rfc-crewmates-launch.md:103-105). Screen 02 then makes Built from either the default agent or a custom agent (:123-125). Therefore the built-in default row is a template choice, not a crewmate; a default-only roster correctly means no crewmates, shows the hero, and must not become MRU. Existing hasNoCrewmates behavior and this PR’s tests pin that reading. No code change is needed.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Seeded greeting attribution is ambiguous span=42aa12226740

accepted-and-deferred to #14468: the fixed seed is visible and the person initiated it through Create, but it renders like an ordinary typed user turn. A focused follow-up will carry explicit automatic-origin metadata through storage, rendering, export, and accessibility.
#14468 has the deferred-finding label, owner CrysisDeu, and Due: 2026-10-27. This PR keeps the RFC-approved visible normal-send-path mechanism rather than adding partial display-only attribution.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Create Workspace Name and Directory are unclear span=de52ddb4166a

accepted-and-deferred to #14469: this PR exposes the existing shared dialog from Advanced but does not own its cross-product field contract. The focused follow-up will explain Directory as the folder location, choose a non-colliding default, and update every entry point together.
#14469 has the deferred-finding label, owner CrysisDeu, and Due: 2026-10-27. Keeping the shared dialog unchanged here avoids one flow diverging from its other callers.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

UX evidence gap fixed in a7c93a4af860184d6c8fd2229868a6466c15814b: the server invalid_member_name state now has deterministic dark and light frames. The capture asserts the exact long recovery copy, 480px dialog, invalid Name field, retained draft, unlocked form, and no raw name or server reason.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

UX evidence gap fixed in a7c93a4af860184d6c8fd2229868a6466c15814b: the open header + menu now has deterministic dark and light frames while a refused greeting holds New crewmate. The capture asserts the menu is open, item disabled, full muted reason visible under its label, New team still live, no dialog, and the held item inert.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Dropped create responses reconcile by name span=be59ee51f538

accepted-and-deferred to #14392: the current bounded name reconcile is an explicit interim trade-off. A committed create whose response drops can be reported as taken and does not auto-open or greet; this PR records that behavior rather than claiming stable identity.
#14392 now carries deferred-finding, owner CrysisDeu, and Due: 2026-10-27. It owns a stable created identity, idempotent lost-response path, compatibility tests, and later removal of name-based reconciliation.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Allocator hardening shares the UI feature commit span=ec90bb851797

accepted trade-off for this PR: free-form creation is not safe without reserving live legacy slugs and retained DM bindings, because a namesake could inherit another crewmate’s thread. The backend invariant and UI path must land atomically.
The branch remains one commit by the user’s explicit history rule. A future UI rollback can revert its files selectively while retaining memory_stores.py; splitting now would create a stacked dependency without reducing the shipped invariant.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Roster retry label can sound like it changes crewmates span=f64465e43507

accepted-and-deferred to #14474: Refresh the list is clearer, but this label spans 12 locale catalogs, focused tests, and six existing desktop/mobile evidence frames. A focused follow-up will update them together without leaving mixed copy.
#14474 has deferred-finding, owner CrysisDeu, and Due: 2026-10-27. The current action still performs only the roster read and never repeats create.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Unconfirmed and failed-create notices sound alike span=9b0e363b20e2

fixed in 687ed08: create_unconfirmed now leads with the trimmed attempted name in all 13 catalogs, while create_failed remains nameless and says nothing was created.
Both unconfirmed tests pin the named copy; the stalled reconcile still makes exactly one create POST. Refreshed dark/light 07g frames render the named state, and all 386 capture assertions passed. No local test suite ran.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Advanced recording first-frame claim was wrong span=072925855eb0

fixed in the complete PR body published with 687ed08: it now says the recording opens the dialog and then unfolds Advanced; it no longer claims the first frame is already the dialog.
FFmpeg comparison confirmed the first GIF frame is closer to the empty-page reference than either dialog reference. The recording itself remains the evidence for the unfold sequence.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Design verification for 687ed087f72c190e6e7b45a5fe00119285e59070: the product owner’s accepted trade-off still applies. Parked greetings are page-memory only; reload or leaving can drop them and reopen an empty first transcript. The system spec and PR body now state that limit plainly, while #14392 owns the durable server identity/reconcile path. This head changed only unconfirmed-copy attribution and evidence, not greeting lifetime.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

First Principles verification for 687ed087f72c190e6e7b45a5fe00119285e59070: the accepted mechanism remains the visible fixed seed through the normal user-turn path. RFC screen 02 requires Create to open the chat and show its first greeting without another confirmation; acceptance requires New crewmate to reach that greeting. The visible prompt preserves the causal transcript instead of injecting hidden assistant output. Clear automatic attribution is deferred to #14468. This head did not change that mechanism.

@CrysisDeu

CrysisDeu commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Current-head review dispositions for e8f80c032a29b266309b9d2c8a63d75a5ef21ebd:

  • Design — client-owned post-create saga: accepted and deferred to Return created agent identity from POST /api/agents #14392. That issue now explicitly requires deciding whether greeting ownership remains client-side or moves to a server composite/persisted pending-greeting flow, documenting failure and reload behavior, and removing client parking/hold branches if the server takes ownership. The current PR keeps the bounded same-page saga as the documented interim behavior.
  • First Principles — allocator hardening in this UI PR: confirmed intentional. Free-form creation is unsafe unless live legacy slugs and retained DM bindings are reserved atomically with the UI path; otherwise a namesake can inherit another crewmate’s thread. The one-commit history rule is deliberate, and Return created agent identity from POST /api/agents #14392 owns the later stable-identity simplification.

The Crew Members page becomes the Crewmates page. With no crewmates it
shows one hero (ghost avatar, "No crewmates yet", one line, "New
crewmate") instead of the roster's small button plus the "pick a member"
pane. "New crewmate" (header "+" and the hero) opens a dialog on the
page itself: Name, Built from (default agent or a custom agent), "What
it looks after", and an Advanced fold with workspace, model, triggers
and session colour rendered by the crew editor's own field components.
It posts to the same POST /api/agents the crew manager's create form
uses; the job line is stored as the record's `description`. After the
create the roster is re-read, the new crewmate's chat opens through the
verified thread endpoint, and one first turn is seeded over the
composer's send path so the chat opens with the crewmate's greeting.

When crewmates exist and the URL names none, the remembered crewmate
opens, else the most recently used one (greatest last_active_ts, ties
keep roster order). The default follows use, never the sort, which is
what #11763 objected to. Below md nothing auto-opens.

Page copy says crewmate / Crewmates and "Built from" in all 12
catalogs; en-XA regenerated. Spec: crew-mode.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants