Repository navigation
fix(sidebar): rail label reads Crewmates, not Crew Members - #14796
Conversation
|
Opened via the prepare-pr skill. Goal: the |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Translated locales now pair the renamed label with tooltips still naming the old label — the exact two-names-for-one-place bug this PR fixes in English. Watch
Suggestions
[UX-REVIEWED] d682ac3 Description read[DESCRIPTION-READ] 4a856f9c4d2d163fecbaa72c88e46203682753bceb71398e369be5410ec168cb That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Eleven locales now show the mismatch this PR exists to remove: label renamed, adjacent descriptions still quote the old word. WatchThe PR's own rationale — "leaving them was the same two-names-for-one-place bug one layer down" — is applied only to English. In every translated catalog the label keys change (es label now "Compañeros") while the blurbs beside them still name the old label (es [DESIGN-REVIEWED] d682ac3 Description read[DESCRIPTION-READ] e64326679a8232180a831702407b3e10bdfbd9e588f92e43c2698b5b4fccf05f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Eleven translated catalogs get new labels the description says are "unchanged here", and the 55 blurbs beside them still quote the old name. Not justified as shipped
What this change shipsInventory (8 items) — 6 justifiedIntent: FIX — make the sidebar rail item read "Crewmates", the same word as the page title (accepted
[FIRST-PRINCIPLES-REVIEWED] d682ac3 Description read[DESCRIPTION-READ] 4f5d31cad9e3f704120c86d32e38e8bf336ac76750538faeb69522c5a3cc8dcc That sha256 names the PR description this verdict read. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsNothing blocks — but the rename stops at the label: the prose that names it still reads "Crew Members" in all 11 translated catalogs, in the English source catalog, and in the packaged docs. FINDING — website/src/i18n/locales/de.json:11385 — every translated catalog got the label but not its own subtitle: FINDING — website/src/i18n/locales/de.json:9336 — FINDING — website/src/i18n/locales/en.json:4966 — FINDING — src/kiro_crew/docs/crew-members.md:20 — the packaged user doc still gives literal directions to a renamed control: [OPUS-REVIEWED] d682ac3 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
cb40725 to
a2265c6
Compare
|
|
|
|
|
|
a2265c6 to
9cf871f
Compare
9cf871f to
e54ee97
Compare
e54ee97 to
87a8a2a
Compare
The left rail item for /members read "Crew Members" while the page title already read "Crewmates" (PR #12924). Align the rail, the sidebar create-menu entry, and the Feature Previews card on the accepted product word (rfc-crewmates-launch.md): crewmate. Updates nav.crew_members, pages.chatSidebar.open_crew_members and pages.developer.featurePreviewsTab.crew_members in en.manual.json and every translated catalog (each copies that language's existing pages.membersPage.title), regenerates en-XA and the settings command-palette registry, and follows the label-derived settings id from developer.crew-members to developer.crewmates with a legacy-id migration so saved deep links keep working.
87a8a2a to
d682ac3
Compare
|
Rebased again: main moved into |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed on behalf of the maintainers (sweep 2026-09-29): readiness passed, required checks green on d682ac3, no blocking review threads, security posture unchanged. Approving and merging.
Problem / Motivation
Goal: The left sidebar rail item for the
/memberspage reads "Crewmates", the same word as the page title.The page title already reads "Crewmates" (
pages.membersPage.title, set by #12924), but the rail item still read "Crew Members". Two names for one place is the symptom.Why it matters
The accepted product vocabulary (
docs/request-for-change/rfc-crewmates-launch.md) is crewmate. A rail that says "Crew Members" while the page it opens says "Crewmates" makes the sidebar and the page look like two different features.Not a goal
/membersroute, thePREVIEW_CREWflag, themember-*slot vocabulary, or any wire/API identifier — this is display copy only.What changed (motivation → approach → change)
The rail label and the page title came from different strings, so #12924's rename of the title left the rail behind. The fix points the label at the product word wherever the label is shown, and fixes the copy that quotes the old label right next to it.
/members)The English strings live in
en.manual.json. Two kinds of string change. The label itself (nav.crew_members,pages.chatSidebar.open_crew_members,pages.developer.featurePreviewsTab.crew_members) is set to "Crewmates". The English blurbs shown right under those labels — the New-menu tooltip, the Feature Previews card summary, where-to-find line, media caption and card description — quoted "Crew Members" back at the user, so they now read "Crewmates" too; leaving them was the same two-names-for-one-place bug one layer down. Each of the eleven translated catalogs already carried that language's own word for the label (itspages.membersPage.titleword, e.g. de "Crewmates", es "Compañeros", ja "クルーメイト"); those label keys are unchanged here.The generated
en-XApseudolocale and the settings command-palette registry (website/src/components/commandPalette/settingsRegistry.gen.ts+src/kiro_crew/docs/settings-registry.generated.json) are regenerated from the English source, not hand-edited. The rail's English display fallback inwebsite/src/surfaces/builtins.tsxchanges, because it is copy, not a stable id, and its two comments plus the label comments inwebsite/src/pages/settings/FeaturePreviewsSection.tsxandwebsite/src/utils/previewFlags.tsname the new label. The feature-map row indocs/feature-map/README.mdnames the new menu label, the ringed card and the deep-link id.One knock-on in
website/src/hooks/useSettingHighlight.ts: the settings registry derives an entry's id from its label, so the card's id shifted fromdeveloper.crew-memberstodeveloper.crewmates. The deep-link constant follows it and a legacy-id mapping carries the old id (and the olderdeveloper.crew-members-and-crew-mode) to the new one, so saved links and palette history still land on the card. The nightlygui_userscenariotest/gui_user/scenarios/members-dm-hello.yaml, which drives an agent to enable the preview and click the rail item, is updated to the new label (older labels kept as fallbacks).Backwards compatibility
Compatible: only display copy and a label-derived settings id change. No route, flag, slot key, or wire field changes, and the shifted settings id is covered by a legacy-id migration so existing deep links keep resolving.
Tests
Updated the tests that assert the rendered label to expect "Crewmates": the rail surface label (
website/src/test/CrewMemberMark.test.tsx), the create-menu entry, its tooltip copy and the gated/ungated gloss guard (website/src/test/ChatSidebar.createMenu.test.tsx), the Feature Previews toggle (website/src/test/DeveloperPanel.test.tsx,website/src/test/FeaturePreviewIntro.test.tsx,website/src/test/previewSurfaces.test.tsx,website/src/pages/settings/decisionsCard.test.tsx), and the unresumable-resume notice that names the surface (website/src/test/ChatPage.unresumableNotice.test.tsx). The i18n key-parity, en-XA-sync, per-locale style and settings-registry doc gates lock in that the catalogs and generated files stay consistent.Manual verification
Ran locally and green:
tsc -p tsconfig.app.json,eslint src --max-warnings 0,npm run i18n:check(key parity, en-XA sync, DNT, manifest sync, per-locale style), the full frontend scoped-test set (321 files, 9551 tests), and the backend settings-registry doc tests. The screenshot below was captured against a locally builtwebsite/distserved by the repo test harness.Screenshots / video
Crew preview on, English. All three renamed surfaces read "Crewmates".
Left rail item and page header:
Sidebar "New" menu entry and its tooltip ("Opens the Crewmates page…"):
Settings › Developer › Feature Previews card:
Related Issues
Pattern harvest
Not generalizable: a single string that #12924 missed when it renamed the page title, plus the blurbs that quoted the old label beside it; there is no rule class here beyond "rename all spellings of a label together", which the existing legacy-id migration table already institutionalizes for the derived-id half.