Repository navigation
fix(i18n): rename Crew Members to the crewmate product word in 11 translated Feature-Previews blurbs - #17732
Conversation
UX Review (Opus 5.5) — ✅ human override accepted@chenmingwei23 overrode this lane for |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (2 items) — 2 justifiedIntent: a reader using any of the 11 translated locales sees the Crewmates feature blurbs use the same product word as the rail, the page and the English copy. This is a FIX (#14959).
[FIRST-PRINCIPLES-REVIEWED] 90a0fae Description read[DESCRIPTION-READ] f2f12073d23e7e2f79b6b24ab80f68e774c6aabfacc55398c80d1aba8aee0eab That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the fr/ru/bn register change (vous→tu, вы→ты, আপনি→তুমি) doesn't leave mixed registers on the same card. These surfaces are mostly informal, but not all of them. Suggestions
[DESIGN-REVIEWED] 90a0fae Description read[DESCRIPTION-READ] 3439b57a978cc62afc59b86051b6ef9ae27ddd8c6ab29363989b0059a56e0763 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
cafd658 to
c99c1e9
Compare
61016a3 to
9a1d6d2
Compare
|
Thanks — addressing both items. Both reduce to the same root: these five values mirror the English source ( Watch — caption vs. image name disagree.
Suggestion —
Evidence that the register change (the part this PR does own) is correct and gate-enforced: |
iamwhatever
left a comment
There was a problem hiding this comment.
The locale string changes look right. One blocker: this is a same-repository PR, and it commits four PNGs under temp-screenshots/14959/. Please drop them from the commit and attach them to the description instead (gh pr edit --attach or drag-and-drop). Once merged, committed binaries stay in main history for good.
|
Thanks for the review. On the screenshots: the project keeps review screenshots committed under |
9a1d6d2 to
6db02ae
Compare
|
Thanks for the review. You were right about committing the PNGs — a committed binary stays in The French/Russian render evidence now lives on a separate
Rebased onto current |
|
Thanks for the UX read. The caption naming the localized page word (e.g. fr "Coéquipiers", ru "Напарники") is intentional and is the whole point of this change: the sidebar rail, the page title, and the English source copy all use the localized product word, and before this PR these blurbs were the one place that still said "Crew Members" in every non-English locale. The inner media image is the shared English capture ( Shrinking the caption to drop the page name would re-introduce the exact rail-vs-blurb mismatch #14959 exists to fix, so I've kept the localized word and left the media swap to the follow-up media pass noted in the description. |
|
/ai-review override ux 6db02ae: maintainer asked not to commit binaries; screenshots are linked in the description from branch screenshots/14959; collector cannot read them |
Human judgment recorded@chenmingwei23 marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
…nslated Feature-Previews blurbs
6db02ae to
90a0fae
Compare
|
Rebased onto current |
|
/ai-review override ux 90a0fae: evidence-only block — no admissible screenshots. The maintainer asked not to commit binaries, so the fr/ru frames live on the separate screenshots/14959 branch (linked in the description) and the collector cannot read them. This is a text-only change to the translated Feature-Previews blurbs; the UX verdict names no contrast, layout, or wording defect, only the missing images. |
Human judgment recorded@chenmingwei23 marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
iamwhatever
left a comment
There was a problem hiding this comment.
This fixes the five Feature-Previews / New-menu blurbs in the 11 translated catalogs, which still named the retired "Crew Members" label after #14796 renamed it in English. Each value now uses that locale's own pages.membersPage.title word. iamwhatever's earlier request is addressed: the four PNGs under temp-screenshots/14959/ are no longer in the PR, which now touches exactly the 11 locale JSON files (+55/-55), with the evidence frames moved to a separate screenshots branch linked from the description. I spot-checked bn, de and es. Only the five keys change, the product word matches each catalog's page title, and the bn/fr/ru informal-register shift matches the surrounding surface, as the description explains. Design, First Principles, GPT and Opus PASS on head 90a0fae, and the UX evidence-only block has an author override that explains why the frames cannot be collected. Checks are green, and the base is main. — crew-pr-reviewer
Problem / Motivation
Goal: Make the five Feature-Previews / New-menu "Crewmates" blurbs read with the right product word in all 11 translated locales, matching the English they already shadow.
#14796 renamed the rail / New-menu / Feature-Previews label to Crewmates and fixed the English sibling copy (
open_crew_members_desc,crew_summary,crew_where,crew_media_members,crew_members_descinen.manual.json). The same five strings in the 11 translated catalogs (bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN) still named the old "Crew Members" label — either the literal English phrase or a translated equivalent ("Membres de l’équipe", "Участники команды", "ক্রু সদস্য", …) — so those locales described the page by a word the product no longer uses.Why it matters
A reader on any non-English locale saw the Feature-Previews card and New-menu tooltip call the page "Crew Members" while the sidebar rail, the page itself, and the English copy all say the crewmate product word. The blurb that introduces the feature was the one place still using the retired name.
Not a goal
open_crewmates, theerror_name_taken/error_create_unknownstrings,empty_roster,crewmatesSection.title). Those still say "Crew Members" / "crew members" in the English source too, so the translations correctly mirror English and are a separate relabel task, not this follow-up.What changed (motivation → approach → change)
en.manual.jsonfor these five description keys; the 11 translated catalogs were left quoting the old label.pages.membersPage.title(fr Coéquipiers, ru Напарники, bn সঙ্গীরা, de Crewmates, es Compañeros, hi साथी, it Compagni, ja クルーメイト, ko 크루메이트, pt Colegas, zh-CN 队友). The surrounding sentence is otherwise unchanged.[changed-values]catalog-QA gate. For fr, ru and bn the pre-existing values used a formal "you" register (vous / вы / আপনি) while the rest of thefeaturePreviewsTab+membersPagesurface in those catalogs is predominantly informal (tu / ты / তুমি); the rewritten sentences in those three locales are brought into that informal register so they match their surface. All other locales keep their existing register and only swap the word.website/src/i18n/locales/—bn.json,de.json,es.json,fr.json,hi.json,it.json,ja.json,ko.json,pt.json,ru.json,zh-CN.json. Five values each; the Englishen.json/en.manual.jsonare not touched. Render-evidence PNGs are not committed to this branch; they live on the separatescreenshots/14959branch (see Screenshots).node scripts/i18n-check.mjs(baseorigin/main): 19 checks PASS, including the two diff-scoped gates[changed-values](0 QA findings) and[changed-passthrough](0 values still read as English).Backwards compatibility
Compatible — Removes nothing: only the text of five existing catalog values changes in each locale; no keys are added, renamed, or removed, and the English catalogs are untouched.
Tests
N/A — no code paths change. The repository's i18n gate (
i18n:check) is the authority on catalog edits; it validates key parity, catalog QA on changed values, and the no-English-passthrough rule, and all pass againstorigin/main.Manual verification
Ran
node scripts/i18n-check.mjswithI18N_BASE_REF=origin/mainon the committed branch:[i18n] 19 checks · PASS. Confirmed the diff is exactly the five keys × 11 files (55 insertions / 55 deletions) and every catalog still parses as valid JSON.Screenshots / video
Rendered headless from the real
FeaturePreviewIntroDialog/FeaturePreviewsSection/ New-menu components with i18next set to each locale (no gateway, no pod — a vite dev server plus Playwright over thewebsite/capture/harness). Every one of the five changed strings is visible across the frames; the inner media image is the existing public asset, unchanged by this PR.French (
fr) — "Coéquipiers", informal tu:The Feature-Previews card hint (
crew_members_desc) and the New-menu row (open_crew_members+open_crew_members_desc):The intro dialog (
crew_summary,crew_where,crew_media_members):Russian (
ru) — "Напарники", informal ты:Notes for the UX lane:
public/app-assets/feature-previews/crew-members-*.png); this PR changes only the surrounding copy. Regenerating per-locale media is tracked separately — it is the same per-locale image pass fix(sidebar): rail label reads Crewmates, not Crew Members #14796 left for the catalogs, out of scope for this string rename.crew_summaryEN: "a thread per member";crew_media_membersEN: "one member selected"). "Coéquipiers" / "Напарники" is the feature/page name; "membre" / "участник" is one person on it. Changing the per-person noun would diverge from the English this PR mirrors.The PNGs are not committed to this PR branch (committed binaries would remain in
mainhistory permanently); they live on the separatescreenshots/14959branch, which is never opened as a PR, and are linked above.Related Issues
Fixes #14959
Pattern harvest
Not generalizable: a one-off catalog follow-up — the English rename in #14796 landed without the matching translated-catalog pass, which this PR completes. No defect class to lint for.
Checklist