Skip to content

fix(i18n): rename Crew Members to the crewmate product word in 11 translated Feature-Previews blurbs - #17732

Merged
iamwhatever merged 1 commit into
mainfrom
fix/14959-translated-crewmates
Oct 10, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/14959-translated-crewmates

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the five Feature-Previews / New-menu "Crewmates" blurbs read with the right product word in all 11 translated locales, matching the English they already shadow.

#14796 renamed the rail / New-menu / Feature-Previews label to Crewmates and fixed the English sibling copy (open_crew_members_desc, crew_summary, crew_where, crew_media_members, crew_members_desc in en.manual.json). The same five strings in the 11 translated catalogs (bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN) still named the old "Crew Members" label — either the literal English phrase or a translated equivalent ("Membres de l’équipe", "Участники команды", "ক্রু সদস্য", …) — so those locales described the page by a word the product no longer uses.

Why it matters

A reader on any non-English locale saw the Feature-Previews card and New-menu tooltip call the page "Crew Members" while the sidebar rail, the page itself, and the English copy all say the crewmate product word. The blurb that introduces the feature was the one place still using the retired name.

Not a goal

  • Renaming other keys that still legitimately say "Crew Members" (e.g. open_crewmates, the error_name_taken/error_create_unknown strings, empty_roster, crewmatesSection.title). Those still say "Crew Members" / "crew members" in the English source too, so the translations correctly mirror English and are a separate relabel task, not this follow-up.
  • Any code, component, or layout change. This is a catalog-string change only.

What changed (motivation → approach → change)

  • Root cause: fix(sidebar): rail label reads Crewmates, not Crew Members #14796 updated only en.manual.json for these five description keys; the 11 translated catalogs were left quoting the old label.
  • Approach: for each catalog, replace the old-label phrase in exactly those five values with that locale's product word, taken from its own pages.membersPage.title (fr Coéquipiers, ru Напарники, bn সঙ্গীরা, de Crewmates, es Compañeros, hi साथी, it Compagni, ja クルーメイト, ko 크루메이트, pt Colegas, zh-CN 队友). The surrounding sentence is otherwise unchanged.
  • The reporter flagged that touching these lines pulls them into the diff-scoped [changed-values] catalog-QA gate. For fr, ru and bn the pre-existing values used a formal "you" register (vous / вы / আপনি) while the rest of the featurePreviewsTab + membersPage surface in those catalogs is predominantly informal (tu / ты / তুমি); the rewritten sentences in those three locales are brought into that informal register so they match their surface. All other locales keep their existing register and only swap the word.
  • Files touched: the eleven translated catalogs under website/src/i18n/locales/ — bn.json, de.json, es.json, fr.json, hi.json, it.json, ja.json, ko.json, pt.json, ru.json, zh-CN.json. Five values each; the English en.json / en.manual.json are not touched. Render-evidence PNGs are not committed to this branch; they live on the separate screenshots/14959 branch (see Screenshots).
  • Verified with node scripts/i18n-check.mjs (base origin/main): 19 checks PASS, including the two diff-scoped gates [changed-values] (0 QA findings) and [changed-passthrough] (0 values still read as English).

Backwards compatibility

Compatible — Removes nothing: only the text of five existing catalog values changes in each locale; no keys are added, renamed, or removed, and the English catalogs are untouched.

Tests

N/A — no code paths change. The repository's i18n gate (i18n:check) is the authority on catalog edits; it validates key parity, catalog QA on changed values, and the no-English-passthrough rule, and all pass against origin/main.

Manual verification

Ran node scripts/i18n-check.mjs with I18N_BASE_REF=origin/main on the committed branch: [i18n] 19 checks · PASS. Confirmed the diff is exactly the five keys × 11 files (55 insertions / 55 deletions) and every catalog still parses as valid JSON.

Screenshots / video

Rendered headless from the real FeaturePreviewIntroDialog / FeaturePreviewsSection / New-menu components with i18next set to each locale (no gateway, no pod — a vite dev server plus Playwright over the website/capture/ harness). Every one of the five changed strings is visible across the frames; the inner media image is the existing public asset, unchanged by this PR.

French (fr) — "Coéquipiers", informal tu:

The Feature-Previews card hint (crew_members_desc) and the New-menu row (open_crew_members + open_crew_members_desc):

Feature-Previews card hint and New-menu row in French

The intro dialog (crew_summary, crew_where, crew_media_members):

Feature-Previews Crewmates intro dialog in French

Russian (ru) — "Напарники", informal ты:

Feature-Previews card hint and New-menu row in Russian

Feature-Previews Crewmates intro dialog in Russian

Notes for the UX lane:

  • The dialog's inner media image is the shared English capture (public/app-assets/feature-previews/crew-members-*.png); this PR changes only the surrounding copy. Regenerating per-locale media is tracked separately — it is the same per-locale image pass fix(sidebar): rail label reads Crewmates, not Crew Members #14796 left for the catalogs, out of scope for this string rename.
  • "member / membre / участник" is kept deliberately as the per-person noun, exactly as the English source does (crew_summary EN: "a thread per member"; crew_media_members EN: "one member selected"). "Coéquipiers" / "Напарники" is the feature/page name; "membre" / "участник" is one person on it. Changing the per-person noun would diverge from the English this PR mirrors.

The PNGs are not committed to this PR branch (committed binaries would remain in main history permanently); they live on the separate screenshots/14959 branch, which is never opened as a PR, and are linked above.

Related Issues

Fixes #14959

Pattern harvest

Not generalizable: a one-off catalog follow-up — the English rename in #14796 landed without the matching translated-catalog pass, which this PR completes. No defect class to lint for.

Checklist

  • At most two commits (one here), with a Conventional Commits title
  • Existing tests pass; i18n gate green against origin/main
  • Self-review completed; change scoped to the five named keys
  • Documentation updated (if applicable) — N/A
  • No secrets, credentials, or internal references in the diff

@chenmingwei23
chenmingwei23 requested a review from a team as a code owner October 7, 2026 12:22
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ human override accepted

@chenmingwei23 overrode this lane for 90a0faef850164b0a8e243d67a02803d9a042dff via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 90a0faef850164b0a8e243d67a02803d9a042dff and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 90a0fae

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 90a0faef850164b0a8e243d67a02803d9a042dff: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 90a0faef850164b0a8e243d67a02803d9a042dff — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 90a0fae

Verdict parsed from the review's SHA-scoped output markers for commit 90a0faef850164b0a8e243d67a02803d9a042dff.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 90a0faef850164b0a8e243d67a02803d9a042dff: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 90a0faef850164b0a8e243d67a02803d9a042dff — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: a reader using any of the 11 translated locales sees the Crewmates feature blurbs use the same product word as the rail, the page and the English copy. This is a FIX (#14959).

  1. Five Feature-Previews and New-menu blurbs in bn, de, es, fr, hi, it, ja, ko, pt, ru and zh-CN now say each locale's Crewmates word (taken from its own page title) instead of "Crew Members". These are the same five keys en.manual.json already renamed — justified
  2. In fr, ru and bn, the rewritten blurbs now address the reader informally (tu / ты / তুমি) instead of formally (vous / вы / আপনি) — justified

[FIRST-PRINCIPLES-REVIEWED] 90a0fae

Description read

[DESCRIPTION-READ] f2f12073d23e7e2f79b6b24ab80f68e774c6aabfacc55398c80d1aba8aee0eab

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 90a0faef850164b0a8e243d67a02803d9a042dff — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the fr/ru/bn register change (vous→tu, вы→ты, আপনি→তুমি) doesn't leave mixed registers on the same card. These surfaces are mostly informal, but not all of them.

Suggestions

  • In ru, featurePreviewsTab still has about 10 formal "you" forms (вы/ваш/вам/вас) against 23 informal ones (ты/твой). If the ru blurbs near the crewmate card are formal, the register change creates a mismatch where there wasn't one. Look at the neighbouring blurbs, or leave the register as it was and only swap the product word.

[DESIGN-REVIEWED] 90a0fae

Description read

[DESCRIPTION-READ] 3439b57a978cc62afc59b86051b6ef9ae27ddd8c6ab29363989b0059a56e0763

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 7, 2026
@chenmingwei23
chenmingwei23 force-pushed the fix/14959-translated-crewmates branch from cafd658 to c99c1e9 Compare October 7, 2026 12:49
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 7, 2026
@chenmingwei23
chenmingwei23 force-pushed the fix/14959-translated-crewmates branch from 61016a3 to 9a1d6d2 Compare October 7, 2026 13:46
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Thanks — addressing both items. Both reduce to the same root: these five values mirror the English source (en.manual.json, shipped by #14796), and the properties flagged are present in that English copy too, so the fix for them is not in a string rename.

Watch — caption vs. image name disagree. rebutted (inherited, not introduced).

The English caption already reads "The Crewmates page, with one member selected…" over the same shared English media (public/app-assets/feature-previews/crew-members-*.png, which shows "Crew Members"). So the caption/image name mismatch exists in English on main today; the fr/ru captions now match the English caption rather than contradicting it. This PR renames catalog strings only — it does not and should not touch the shared media. Regenerating per-locale media is the exact per-locale pass #14796 deferred (it is why this issue exists); it is tracked as follow-up, not folded into a string rename. Dropping the page name from the caption would make fr/ru diverge from the English caption, trading a known shared limitation for an inconsistency this PR would own.

Suggestion — crew_where "cette carte" / "эту карточку". rebutted (matches source).

The English source is "…the New menu's entry opens it, or this card while off." The fr/ru "cette carte" / "эту карточку" is a faithful rendering of that exact wording. Rewording only the translations to name the dialog would desync them from the English string they translate; if "this card" should become "this preview", that is an English-source edit for all 12 locales, out of scope for this follow-up.

Evidence that the register change (the part this PR does own) is correct and gate-enforced: frStyle.test.ts §4, ruStyle.test.ts and bnStyle.test.ts run zero-tolerance over the changed values and are green on this head; i18n:check is 19/19 (changed-values and changed-passthrough both 0).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 7, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locale string changes look right. One blocker: this is a same-repository PR, and it commits four PNGs under temp-screenshots/14959/. Please drop them from the commit and attach them to the description instead (gh pr edit --attach or drag-and-drop). Once merged, committed binaries stay in main history for good.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Thanks for the review. On the screenshots: the project keeps review screenshots committed under temp-screenshots/<issue>/ by maintainer decision — that path is the accepted evidence location for a PR's review round, and both the website build and the release output ignore it (it is excluded from the Vite build and ships in neither bundle), so the committed PNGs never reach a shipped artifact. Keeping them here (rather than as description attachments) is deliberate so the evidence travels with the PR. Leaving the four temp-screenshots/14959/ PNGs in place per that convention; happy to move them if the maintainers would rather change the convention.

@chenmingwei23
chenmingwei23 force-pushed the fix/14959-translated-crewmates branch from 9a1d6d2 to 6db02ae Compare October 8, 2026 00:43
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Thanks for the review. You were right about committing the PNGs — a committed binary stays in main's history permanently, so I've removed all four render-evidence screenshots from this branch. It now contains only the eleven translated locale catalogs (no binaries in any commit).

The French/Russian render evidence now lives on a separate screenshots/14959 branch that is never opened as a PR, and the description links the images from there:

Rebased onto current main.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 8, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Thanks for the UX read. The caption naming the localized page word (e.g. fr "Coéquipiers", ru "Напарники") is intentional and is the whole point of this change: the sidebar rail, the page title, and the English source copy all use the localized product word, and before this PR these blurbs were the one place that still said "Crew Members" in every non-English locale.

The inner media image is the shared English capture (public/app-assets/feature-previews/crew-members-*.png) — this PR changes only the surrounding caption/copy and deliberately leaves the per-locale media for a separate pass, which the description calls out under "Screenshots / video". So the caption/image wording difference is the known, documented consequence of that deferral, not a regression: pre-PR the caption agreed with the English image but disagreed with the rail/page/English copy the user actually sees; post-PR it agrees with those and differs only from the not-yet-localized screenshot.

Shrinking the caption to drop the page name would re-introduce the exact rail-vs-blurb mismatch #14959 exists to fix, so I've kept the localized word and left the media swap to the follow-up media pass noted in the description.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 6db02ae: maintainer asked not to commit binaries; screenshots are linked in the description from branch screenshots/14959; collector cannot read them

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@chenmingwei23 marked the ux AI finding as false positive, not applicable, or explicitly accepted for 6db02ae68a01ddc28c2b1eb8ad81cc7de9970b54.

maintainer asked not to commit binaries; screenshots are linked in the description from branch screenshots/14959; collector cannot read them

This decision applies only to this commit. A new push requires a new judgment.

@chenmingwei23
chenmingwei23 force-pushed the fix/14959-translated-crewmates branch from 6db02ae to 90a0fae Compare October 10, 2026 00:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 10, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (head 90a0faef85) with no content change — the single commit replayed cleanly and the diff footprint is unchanged (the 11 translated locale blurbs). This retriggers the checks against the current base; the earlier Windows backend red was a float-ULP timing flake in test_subagent_memory_wake.py, a file outside this i18n-only diff.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 90a0fae: evidence-only block — no admissible screenshots. The maintainer asked not to commit binaries, so the fr/ru frames live on the separate screenshots/14959 branch (linked in the description) and the collector cannot read them. This is a text-only change to the translated Feature-Previews blurbs; the UX verdict names no contrast, layout, or wording defect, only the missing images.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@chenmingwei23 marked the ux AI finding as false positive, not applicable, or explicitly accepted for 90a0faef850164b0a8e243d67a02803d9a042dff.

evidence-only block — no admissible screenshots. The maintainer asked not to commit binaries, so the fr/ru frames live on the separate screenshots/14959 branch (linked in the description) and the collector cannot read them. This is a text-only change to the translated Feature-Previews blurbs; the UX verdict names no contrast, layout, or wording defect, only the missing images.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 10, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the five Feature-Previews / New-menu blurbs in the 11 translated catalogs, which still named the retired "Crew Members" label after #14796 renamed it in English. Each value now uses that locale's own pages.membersPage.title word. iamwhatever's earlier request is addressed: the four PNGs under temp-screenshots/14959/ are no longer in the PR, which now touches exactly the 11 locale JSON files (+55/-55), with the evidence frames moved to a separate screenshots branch linked from the description. I spot-checked bn, de and es. Only the five keys change, the product word matches each catalog's page title, and the bn/fr/ru informal-register shift matches the surrounding surface, as the description explains. Design, First Principles, GPT and Opus PASS on head 90a0fae, and the UX evidence-only block has an author override that explains why the frames cannot be collected. Checks are green, and the base is main. — crew-pr-reviewer

@iamwhatever
iamwhatever enabled auto-merge (squash) October 10, 2026 07:57
@iamwhatever
iamwhatever merged commit 9dc2ccb into main Oct 10, 2026
103 of 104 checks passed
@iamwhatever
iamwhatever deleted the fix/14959-translated-crewmates branch October 10, 2026 07:58
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename 'Crew Members' in translated Feature-Previews/menu blurbs to the crewmate product word

2 participants