Repository navigation
fix(build): regenerate stale ui-index (after #18362 and #17732) - #18800
chenmingwei23 wants to merge 1 commit into
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Before merging, re-run What this change shipsInventory (3 items) — 3 justifiedIntent: get
[FIRST-PRINCIPLES-REVIEWED] 9136180 Description read[DESCRIPTION-READ] 3cb27ba0e42796318e5d7e0db18a0f6a4d8b72215445f8975ac1852f45602660 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check: [DESIGN-REVIEWED] 9136180 Description read[DESCRIPTION-READ] 11d02a2276f383a8fade8eee0ea496e7e9ca0d4a1aa6662a6cd7ae085c2b98c6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Superseded: #18782 (merged 09:11) already regenerated the ui-index against current main; rebuilding this branch on it is an empty diff. |
Problem / Motivation
Goal: Make
mainbuild again by regenerating the stale UI index so the frontend/wheel/desktop builds pass.mainhas been red since ~06:20Z. TheBuild WheelandBuild Desktopjobs fail at the frontend build step with:The dashboard UI source changed across several recently merged PRs, but
src/kiro_crew/docs/ui-index.generated.jsonwas not regenerated alongside them, sonode scripts/gen-ui-index.mjs --checkfails the build.Why it matters
Every
mainbuild (wheel + desktop on all platforms) is red, blocking releases and every downstream PR's required checks until the generated index matches the current UI source.Not a goal
What changed (motivation → approach → change)
Symptom:
Build Wheel/Build Desktopfail atgen-ui-index --check.Root cause: the committed
ui-index.generated.jsoncarriesinput_digestb6a65a9…, which matched source at the last green main (4e7b854). Two later merges moved the UI source digest without regenerating the index:b16b26b(fix(sidebar): restore the folder geometry decided in #3905 #18362,fix(sidebar): restore the folder geometry) — first stale commit; source digest →26e6582….9dc2ccb(fix(i18n): rename Crew Members to the crewmate product word in 11 translated Feature-Previews blurbs #17732,fix(i18n): rename Crew Members to the crewmate product word) — moved the source digest again →66f846c8…, the value currentmainneeds.Change: ran
npm run gen:uiinwebsite/against currentorigin/mainand committed only the regeneratedsrc/kiro_crew/docs/ui-index.generated.json(newinput_digest66f846c8…). After this,node scripts/gen-ui-index.mjs --checkreports "up to date".This supersedes #18753, which regenerates to the
#18362digest (26e6582…) only; becausemainmoved again after #17732,--checkstill fails against currentmainon that branch. This PR regenerates against currentmain.Backwards compatibility
Removes nothing: the only change is the content of a build-time generated artifact; no contract, field, type, or public symbol changes.
Tests
N/A — no test added. Correctness is proven by the generator's own gate:
node scripts/gen-ui-index.mjs --checknow passes (it failed before), which is exactly whatBuild Wheel/Build Desktoprun.Manual verification
Ran in
website/on the branch head:node scripts/gen-ui-index.mjs --check→ "gen-ui-index: up to date". Confirmed the same command fails on currentorigin/main.Screenshots / video
N/A — no user-visible UI change; this PR only updates a generated JSON artifact.
Related Issues
N/A — build breakage from merge drift, no linked issue.
Pattern harvest
Rule candidate: ci
Pattern: a UI-source change that feeds
ui-index.generated.jsonwas merged without regenerating the index; a pre-merge check (or a required status that runsgen-ui-index --checkon PRs touchingwebsite/src/**) would catch the drift before it reachesmain.Checklist
--checkgate passes