Skip to content

fix(build): regenerate stale ui-index (after #18362 and #17732) - #18800

Closed
chenmingwei23 wants to merge 1 commit into
mainfrom
fix/build-ui-index-stale
Closed

chenmingwei23 wants to merge 1 commit into
mainfrom
fix/build-ui-index-stale

Conversation

@chenmingwei23

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make main build again by regenerating the stale UI index so the frontend/wheel/desktop builds pass.

main has been red since ~06:20Z. The Build Wheel and Build Desktop jobs fail at the frontend build step with:

gen-ui-index: src/kiro_crew/docs/ui-index.generated.json is stale. Run `npm run gen:ui` in website/ and commit the result.

The dashboard UI source changed across several recently merged PRs, but src/kiro_crew/docs/ui-index.generated.json was not regenerated alongside them, so node scripts/gen-ui-index.mjs --check fails the build.

Why it matters

Every main build (wheel + desktop on all platforms) is red, blocking releases and every downstream PR's required checks until the generated index matches the current UI source.

Not a goal

  • No UI source change: this PR only regenerates the committed generated artifact. It does not alter any component, page, string, or the generator script.

What changed (motivation → approach → change)

Symptom: Build Wheel / Build Desktop fail at gen-ui-index --check.

Root cause: the committed ui-index.generated.json carries input_digest b6a65a9…, which matched source at the last green main (4e7b854). Two later merges moved the UI source digest without regenerating the index:

Change: ran npm run gen:ui in website/ against current origin/main and committed only the regenerated src/kiro_crew/docs/ui-index.generated.json (new input_digest 66f846c8…). After this, node scripts/gen-ui-index.mjs --check reports "up to date".

This supersedes #18753, which regenerates to the #18362 digest (26e6582…) only; because main moved again after #17732, --check still fails against current main on that branch. This PR regenerates against current main.

Backwards compatibility

Removes nothing: the only change is the content of a build-time generated artifact; no contract, field, type, or public symbol changes.

Tests

N/A — no test added. Correctness is proven by the generator's own gate: node scripts/gen-ui-index.mjs --check now passes (it failed before), which is exactly what Build Wheel/Build Desktop run.

Manual verification

Ran in website/ on the branch head: node scripts/gen-ui-index.mjs --check → "gen-ui-index: up to date". Confirmed the same command fails on current origin/main.

Screenshots / video

N/A — no user-visible UI change; this PR only updates a generated JSON artifact.

Related Issues

N/A — build breakage from merge drift, no linked issue.

Pattern harvest

Rule candidate: ci
Pattern: a UI-source change that feeds ui-index.generated.json was merged without regenerating the index; a pre-merge check (or a required status that runs gen-ui-index --check on PRs touching website/src/**) would catch the drift before it reaches main.

Checklist

  • At most two commits (one here), Conventional Commits title
  • Existing tests pass; the generator --check gate passes
  • Self-review completed
  • Documentation updated (if applicable) — N/A
  • No secrets, credentials, or internal references in the diff

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 9136180c7ffe2a24fbe6fe34575777fd233e3805 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Before merging, re-run gen-ui-index --check on the newest main. Also, the only entry added is the dictation notification setting, which neither cited merge (#18362, #17732) explains.

What this change ships

Inventory (3 items) — 3 justified

Intent: get main's wheel and desktop builds passing again by bringing the committed UI index back in line with the current dashboard source. This is a FIX.

  1. The generated UI index carries a new input_digest that matches current UI source, so the build's staleness check passes. — justified
  2. Command-palette and settings search now find the "Interrupted dictation" setting under Settings → Notifications → per-category, in all 12 locales. — justified
  3. The coverage counts in the index go up by one (setting 238→239, generated 328→329). — justified

[FIRST-PRINCIPLES-REVIEWED] 9136180

Description read

[DESCRIPTION-READ] 3cb27ba0e42796318e5d7e0db18a0f6a4d8b72215445f8975ac1852f45602660

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 9136180c7ffe2a24fbe6fe34575777fd233e3805 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check: gen-ui-index --check passes against main at merge time. Any UI merge that lands first makes this digest stale again.

[DESIGN-REVIEWED] 9136180

Description read

[DESCRIPTION-READ] 11d02a2276f383a8fade8eee0ea496e7e9ca0d4a1aa6662a6cd7ae085c2b98c6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 9136180c7ffe2a24fbe6fe34575777fd233e3805 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 9136180

Verdict parsed from the review's SHA-scoped output markers for commit 9136180c7ffe2a24fbe6fe34575777fd233e3805.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 9136180c7ffe2a24fbe6fe34575777fd233e3805: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 9136180c7ffe2a24fbe6fe34575777fd233e3805 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 9136180c7ffe2a24fbe6fe34575777fd233e3805 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 9136180

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 9136180c7ffe2a24fbe6fe34575777fd233e3805: <one-sentence reason>

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Superseded: #18782 (merged 09:11) already regenerated the ui-index against current main; rebuilding this branch on it is an empty diff.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 10, 2026
@bolichen97
bolichen97 deleted the fix/build-ui-index-stale branch November 6, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant