Skip to content

chore(ui-index): regenerate ui-index.generated.json after #18362 - #18753

Closed
CrysisDeu wants to merge 1 commit into
mainfrom
chore/ui-index-regenerate-18362
Closed

CrysisDeu wants to merge 1 commit into
mainfrom
chore/ui-index-regenerate-18362

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: main builds again on every platform.

Every Build run on main since b16b26b (#18362) is red on all platforms (Build Wheel, Build Desktop on ubuntu-22.04 / ubuntu-22.04-arm / macos-15, and E2E). Latest failing run: https://github.com/kirodotdev/KiroCrew/actions/runs/38032036684 (head 7d90af7). npm run build in website/ fails at its first step:

gen-ui-index: src/kiro_crew/docs/ui-index.generated.json is stale. Run `npm run gen:ui` in website/ and commit the result.

Cause: #18362 changed inputs of the UI index without regenerating src/kiro_crew/docs/ui-index.generated.json, so the committed input_digest no longer matches what gen-ui-index --check computes.

Why it matters

Nothing merged to main since #18362 has produced a wheel, a desktop build or an E2E result, so every later PR's release-path checks are blind and nightly cannot publish.

Not a goal

What changed (motivation → approach → change)

Symptom: gen-ui-index --check fails on main. Root cause: the committed index's input_digest is stale. Change: ran npm run gen:ui in website/ on the current main tip and committed the result. The only change in the diff is the input_digest line of src/kiro_crew/docs/ui-index.generated.json; gen:ui reported no change to website/src/uiLocations/guidePlans.gen.ts.

Backwards compatibility

Compatible: a generated artifact is brought back in sync with its inputs; no code or schema changes.

Removes nothing: the diff is a one-line digest update.

Tests

N/A — no test is added; the existing gen-ui-index --check step in npm run build is the gate this PR turns green.

Manual verification

In website/ on this branch (rebased on main @ c9c3cfd):

node scripts/gen-ui-index.mjs --check --auto-out node_modules/.cache/kc-ui-auto/ui-index.auto.json --sites-out node_modules/.cache/kc-ui-auto/sites.json

exits 0 (it reported the stale-digest error on main before the regeneration).

Related Issues

Follow-up to #18362. PR #18751 depends on main building again.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

#18362 changed inputs of the UI index without regenerating
src/kiro_crew/docs/ui-index.generated.json, so its input_digest no
longer matched and gen-ui-index --check failed npm run build on every
platform (Build Wheel, Build Desktop, E2E) for every main run since
b16b26b. Only the digest changes.
@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 10, 2026 06:52
@CrysisDeu
CrysisDeu requested a review from buluoray October 10, 2026 06:52
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 59b8dea8eb3b0e41b5043c99999e13b94c37b4f2 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 59b8dea8eb3b0e41b5043c99999e13b94c37b4f2 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 59b8dea

Description read

[DESCRIPTION-READ] 9b697c6d79e92a53f99eb495ef4d129a3f567093d0311bbd9d1eb7865b1d497d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 59b8dea8eb3b0e41b5043c99999e13b94c37b4f2 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 59b8dea

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 59b8dea8eb3b0e41b5043c99999e13b94c37b4f2: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 59b8dea8eb3b0e41b5043c99999e13b94c37b4f2 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (1 items) — 1 justified

Intent: get main building on every platform again by bringing a stale generated artifact back in sync with its inputs. This is a FIX.

  1. The committed UI index's input_digest now matches what gen-ui-index --check computes, so npm run build and the CI gate (ci.yml:2476) pass again — justified

[FIRST-PRINCIPLES-REVIEWED] 59b8dea

Description read

[DESCRIPTION-READ] dbe8a76651f19c9962ad58c753f2ebd920c743bb38bb1dabdeb1cf630eb2fc3b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 59b8dea8eb3b0e41b5043c99999e13b94c37b4f2 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 59b8dea

Verdict parsed from the review's SHA-scoped output markers for commit 59b8dea8eb3b0e41b5043c99999e13b94c37b4f2.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 59b8dea8eb3b0e41b5043c99999e13b94c37b4f2: <one-sentence reason>

@cruisercohen cruisercohen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The regenerated file is correct for the base it was cut from (d84eee5: gen:ui --check is up to date on this head), and the diff touches only the generated index.

main has moved since (now afb24ab), and the index is stale again against it. Regenerating on afb24ab gives a different input_digest (line 4):

  • this PR: sha256:26e6582aba35eccf56fa9f5caa2e0c36a8618cb40c9905d69aef6e55edb89b07
  • regenerated on afb24ab: sha256:39f9e968e47b2a874966659322d58a51bec8ed22edca149b6c008fb9a88f156f

Nothing else in the file differs, and guidePlans.gen.ts is unchanged. To refresh: rebase onto current main, then in website/ run npm run gen:ui (node scripts/gen-ui-index.mjs) and commit src/kiro_crew/docs/ui-index.generated.json. Happy to re-check the new head.

@chenmingwei23

Copy link
Copy Markdown
Contributor

Heads-up: this regenerates to the #18362 digest only; main also moved after #17732, so node scripts/gen-ui-index.mjs --check still fails against current main. #18800 regenerates against current main. Fine to close one in favor of the other.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Superseded: main regenerated ui-index.generated.json via #18958 and #18975, and Build on main is green again (3e92a42). Closing; branch kept.

@CrysisDeu CrysisDeu closed this Oct 12, 2026
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 12, 2026
@bolichen97
bolichen97 deleted the chore/ui-index-regenerate-18362 branch November 6, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants