Repository navigation
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 59b8dea Description read[DESCRIPTION-READ] 9b697c6d79e92a53f99eb495ef4d129a3f567093d0311bbd9d1eb7865b1d497d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (1 items) — 1 justifiedIntent: get
[FIRST-PRINCIPLES-REVIEWED] 59b8dea Description read[DESCRIPTION-READ] dbe8a76651f19c9962ad58c753f2ebd920c743bb38bb1dabdeb1cf630eb2fc3b That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
cruisercohen
left a comment
There was a problem hiding this comment.
Thanks for this. The regenerated file is correct for the base it was cut from (d84eee5: gen:ui --check is up to date on this head), and the diff touches only the generated index.
main has moved since (now afb24ab), and the index is stale again against it. Regenerating on afb24ab gives a different input_digest (line 4):
- this PR:
sha256:26e6582aba35eccf56fa9f5caa2e0c36a8618cb40c9905d69aef6e55edb89b07 - regenerated on afb24ab:
sha256:39f9e968e47b2a874966659322d58a51bec8ed22edca149b6c008fb9a88f156f
Nothing else in the file differs, and guidePlans.gen.ts is unchanged. To refresh: rebase onto current main, then in website/ run npm run gen:ui (node scripts/gen-ui-index.mjs) and commit src/kiro_crew/docs/ui-index.generated.json. Happy to re-check the new head.
Problem / Motivation
Goal:
mainbuilds again on every platform.Every
Buildrun onmainsince b16b26b (#18362) is red on all platforms (Build Wheel, Build Desktop on ubuntu-22.04 / ubuntu-22.04-arm / macos-15, and E2E). Latest failing run: https://github.com/kirodotdev/KiroCrew/actions/runs/38032036684 (head 7d90af7).npm run buildinwebsite/fails at its first step:Cause: #18362 changed inputs of the UI index without regenerating
src/kiro_crew/docs/ui-index.generated.json, so the committedinput_digestno longer matches whatgen-ui-index --checkcomputes.Why it matters
Nothing merged to
mainsince #18362 has produced a wheel, a desktop build or an E2E result, so every later PR's release-path checks are blind and nightly cannot publish.Not a goal
What changed (motivation → approach → change)
Symptom:
gen-ui-index --checkfails onmain. Root cause: the committed index'sinput_digestis stale. Change: rannpm run gen:uiinwebsite/on the currentmaintip and committed the result. The only change in the diff is theinput_digestline ofsrc/kiro_crew/docs/ui-index.generated.json;gen:uireported no change towebsite/src/uiLocations/guidePlans.gen.ts.Backwards compatibility
Compatible: a generated artifact is brought back in sync with its inputs; no code or schema changes.
Removes nothing: the diff is a one-line digest update.
Tests
N/A — no test is added; the existing
gen-ui-index --checkstep innpm run buildis the gate this PR turns green.Manual verification
In
website/on this branch (rebased onmain@ c9c3cfd):exits 0 (it reported the stale-digest error on
mainbefore the regeneration).Related Issues
Follow-up to #18362. PR #18751 depends on
mainbuilding again.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.