Skip to content

fix(ui-index): regenerate ui-index.generated.json for the dictation sound setting - #18803

Closed
amadsalmon wants to merge 1 commit into
kirodotdev:mainfrom
amadsalmon:fix/ui-index-dictation-sound
Closed

amadsalmon wants to merge 1 commit into
kirodotdev:mainfrom
amadsalmon:fix/ui-index-dictation-sound

Conversation

@amadsalmon

Copy link
Copy Markdown
Member

Problem / Motivation

Goal: main builds again on every platform.

npm run build in website/ fails at its first step on main (head d3f462f23), which turns Build Wheel and the three Build Desktop jobs red:

gen-ui-index: src/kiro_crew/docs/ui-index.generated.json is stale. Run `npm run gen:ui` in website/ and commit the result.

Failing job: https://github.com/kirodotdev/KiroCrew/actions/runs/38036318549/job/114167446391 (reported in #17923 (comment)).

Cause: #17923 added the notifications.sound-category-dictation setting to the settings registry and the 12 locale catalogs, but not to the committed UI index. The gen-ui-index --check build step that catches this arrived with #18443 after #17923's last CI run, so that PR's checks never ran it. main was also already stale from #18362 (the digest-only fix for that is #18753).

Why it matters

Until the index matches its inputs, nothing merged to main produces a wheel, a desktop build or an E2E result, and the find_ui tool cannot locate the new Interrupted dictation setting.

Not a goal

What changed (motivation → approach → change)

Symptom: gen-ui-index --check fails on main. Root cause: the committed index lacks the dictation setting entry and carries a stale input_digest. Change: ran npm run gen:ui in website/ on the current main tip and committed the result. The diff in src/kiro_crew/docs/ui-index.generated.json is the new setting:notifications.sound-category-dictation location, its label in the 12 locales, the updated setting count and the new input_digest. gen:ui reported no change to website/src/uiLocations/guidePlans.gen.ts.

This regeneration also covers the stale digest #18753 fixes, so #18753 becomes unnecessary once this merges (the two PRs edit the same input_digest line).

Backwards compatibility

Compatible: a generated artifact is brought back in sync with its inputs; no code or schema changes.

Removes nothing: the diff only adds the missing entry and updates the digest and count.

Tests

N/A, no test is added: the existing gen-ui-index --check step in npm run build is the gate this PR turns green. The find_ui / guide suites that read this file pass locally (test/test_find_ui*.py, test/test_guide_*.py, test/test_brand_name_gate.py: 640 passed).

Manual verification

In website/ on this branch (based on main @ d3f462f23):

node scripts/gen-ui-index.mjs --check --auto-out node_modules/.cache/kc-ui-auto/ui-index.auto.json --sites-out node_modules/.cache/kc-ui-auto/sites.json

exits 0. On main before the regeneration it reported the stale-index error above.

Related Issues

Follow-up to #17923. Supersedes the digest line of #18753 (follow-up to #18362).

Pattern harvest

Not generalizable: the stale-index check was added to main (#18443) after #17923's last CI run, so that PR's green CI predated the gate. This is a stale-base merge, not a code pattern a lint or semgrep rule can catch.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@amadsalmon
amadsalmon requested review from a team and KiroCrewCaptain as code owners October 10, 2026 09:08
@amadsalmon
amadsalmon requested a review from CrysisDeu October 10, 2026 09:08
@github-actions github-actions Bot added the fork Pull request from a fork (external contributor) label Oct 10, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 6d89a0ee76452bd32032755a3b9055f47e5b70ef touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 6d89a0ee76452bd32032755a3b9055f47e5b70ef via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check before merge: confirm that #18753 (the digest-only fix) is closed or rebased, because both PRs rewrite the same input_digest line.

What this change ships

Inventory (3 items) — 3 justified

Intent: get main building again by bringing the committed UI index back in line with its inputs. This is a FIX that unwedges a red build.

  1. find_ui can now locate the Interrupted dictation sound setting, with its label in all 12 locales — justified
  2. The setting count in the index coverage rises from 238 to 239 — justified
  3. input_digest is refreshed, which also covers fix(sidebar): restore the folder geometry decided in #3905 #18362's stale digest — justified

[FIRST-PRINCIPLES-REVIEWED] 6d89a0e

Description read

[DESCRIPTION-READ] 33cfa5e8c39e6d7efddcf7e4b1fd061a6f360accdc1551352fec9b4ab3361966

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 6d89a0ee76452bd32032755a3b9055f47e5b70ef via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Merge one of this PR and #18753, then close the other. Both edit the same input_digest line.

[DESIGN-REVIEWED] 6d89a0e

Description read

[DESCRIPTION-READ] 908075fd32f0b9a145edfb3826498cb42a0e8420bcf10c3d1b623d813d19640e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 6d89a0ee76452bd32032755a3b9055f47e5b70ef via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6d89a0e

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 6d89a0ee76452bd32032755a3b9055f47e5b70ef via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6d89a0e

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 10, 2026
@amadsalmon

Copy link
Copy Markdown
Member Author

Closing as superseded: main already has the notifications.sound-category-dictation entry and its labels, added by #18782 (d32c084), and later regenerations (#18958, #18975) keep it. Nothing left for this PR to fix.

@amadsalmon amadsalmon closed this Oct 11, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant