Repository navigation
fix(ui-index): regenerate ui-index.generated.json for the dictation sound setting - #18803
amadsalmon wants to merge 1 commit into
Conversation
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check before merge: confirm that #18753 (the digest-only fix) is closed or rebased, because both PRs rewrite the same What this change shipsInventory (3 items) — 3 justifiedIntent: get
[FIRST-PRINCIPLES-REVIEWED] 6d89a0e Description read[DESCRIPTION-READ] 33cfa5e8c39e6d7efddcf7e4b1fd061a6f360accdc1551352fec9b4ab3361966 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Merge one of this PR and #18753, then close the other. Both edit the same [DESIGN-REVIEWED] 6d89a0e Description read[DESCRIPTION-READ] 908075fd32f0b9a145edfb3826498cb42a0e8420bcf10c3d1b623d813d19640e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Problem / Motivation
Goal:
mainbuilds again on every platform.npm run buildinwebsite/fails at its first step onmain(headd3f462f23), which turns Build Wheel and the three Build Desktop jobs red:Failing job: https://github.com/kirodotdev/KiroCrew/actions/runs/38036318549/job/114167446391 (reported in #17923 (comment)).
Cause: #17923 added the
notifications.sound-category-dictationsetting to the settings registry and the 12 locale catalogs, but not to the committed UI index. Thegen-ui-index --checkbuild step that catches this arrived with #18443 after #17923's last CI run, so that PR's checks never ran it.mainwas also already stale from #18362 (the digest-only fix for that is #18753).Why it matters
Until the index matches its inputs, nothing merged to
mainproduces a wheel, a desktop build or an E2E result, and thefind_uitool cannot locate the new Interrupted dictation setting.Not a goal
What changed (motivation → approach → change)
Symptom:
gen-ui-index --checkfails onmain. Root cause: the committed index lacks the dictation setting entry and carries a staleinput_digest. Change: rannpm run gen:uiinwebsite/on the currentmaintip and committed the result. The diff insrc/kiro_crew/docs/ui-index.generated.jsonis the newsetting:notifications.sound-category-dictationlocation, its label in the 12 locales, the updated setting count and the newinput_digest.gen:uireported no change towebsite/src/uiLocations/guidePlans.gen.ts.This regeneration also covers the stale digest #18753 fixes, so #18753 becomes unnecessary once this merges (the two PRs edit the same
input_digestline).Backwards compatibility
Compatible: a generated artifact is brought back in sync with its inputs; no code or schema changes.
Removes nothing: the diff only adds the missing entry and updates the digest and count.
Tests
N/A, no test is added: the existing
gen-ui-index --checkstep innpm run buildis the gate this PR turns green. Thefind_ui/ guide suites that read this file pass locally (test/test_find_ui*.py,test/test_guide_*.py,test/test_brand_name_gate.py: 640 passed).Manual verification
In
website/on this branch (based onmain@d3f462f23):exits 0. On
mainbefore the regeneration it reported the stale-index error above.Related Issues
Follow-up to #17923. Supersedes the digest line of #18753 (follow-up to #18362).
Pattern harvest
Not generalizable: the stale-index check was added to
main(#18443) after #17923's last CI run, so that PR's green CI predated the gate. This is a stale-base merge, not a code pattern a lint or semgrep rule can catch.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.