Skip to content

refactor(agents): remove the Session Color editor from the create/edit modals - #9494

Open
xuejinT wants to merge 1 commit into
mainfrom
feat/agents-session-color-removal
Open

xuejinT wants to merge 1 commit into
mainfrom
feat/agents-session-color-removal

Conversation

@xuejinT

@xuejinT xuejinT commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Remove the Session Color picker from the agent create and edit modals while every stored colour keeps working.

The agent create and edit modals carry a Session Color picker almost nobody uses. It adds a swatch row, a native colour input, a hex field and a Clear button to both forms, plus four strings in every website/src/i18n/locales catalog and its own dirty-pane tracking in website/src/pages/KiroCrewAgentsPage.tsx. The clutter costs every user attention on every open of the form.

Why it matters

The create form is the first thing a new user meets. Every control it carries makes the next control harder to find. A colour picker for a niche cosmetic setting does not earn that space, and the maintainer ruled it out of the modals.

Not a goal

  • Removing, migrating or clearing stored session_color values, or the session tint and roster stripe they drive.
  • A UI clear path for a stored colour.

What changed (motivation → approach → change)

Redone on current main (the old branch was 5883 commits behind). On main the crew manager modals no longer mount the picker; it survived only in the New mate dialog and the crew editor's state.

Place Before After
New mate dialog, Advanced picker after Triggers ends at Triggers
Crew editor state (useCrewEditor.ts) sessionColor state, dirty line, sent on save gone; save omits the key
SessionColorField (crewFields.tsx) and its re-export exported deleted
Five session_color* strings per locale present deleted
A stored session_color tints sessions and the roster stripe unchanged

The crew editor's save no longer sends session_color. crew_update.py writes only the keys a body carries, so the stored colour stays as it is. The New mate create still sends session_color: ''. The SessionColorField unit test and the orphaned capture-crew-color-presets.mjs harness are deleted. capture-crewmates-page-create.mjs now checks the Advanced section has no colour input. The crew docs (src/kiro_crew/docs/crew-members.md, docs/system-specs/modules/crew-mode.md) stop listing the colour among the form fields.

This reverses the UI half of #6106 and was split out of #8497 at maintainer request (approved 2026-09-10). A stored colour is cleared by removing the session_color key from the agent's config.

flowchart LR
  subgraph Before
    A1[Create / Edit forms]:::ctx --> B1[SessionColorField]:::removed --> C1[session_color field]:::ctx
  end
  subgraph After
    A2[Create / Edit forms]:::ctx --> C2[session_color field]:::ctx
  end
  classDef removed fill:#FEE2E2,stroke:#DC2626,color:#7F1D1D,stroke-dasharray:4 3
  classDef ctx fill:#E0F2FE,stroke:#0284C7,color:#0C4A6E
  linkStyle 0,1 stroke:#DC2626,stroke-dasharray:4 3
  linkStyle 2 stroke:#16A34A,stroke-width:2px
Loading

🟩 added · 🟨 changed · 🟥 removed · 🟦 unchanged

The forms no longer edit the colour; the stored colour and everything that reads it are untouched.

Backwards compatibility

Compatible: the session_color config key, its API field and every reader stay as they are; only the editing control is removed.

Tests

  • New: KiroCrewAgentsPage.reasoningEffort.test.tsx › "shows no colour control and leaves a stored colour out of the save body" (crew with session_color: '#123456'). Red on main, green here.
  • Changed: MembersPage.newCrewmateOutcomes.test.tsx Advanced test now asserts no colour input (red on main). CrewRoster.test.tsx payload-shape test drops session_color. KiroCrewAgentsPage.owners.test.tsx facade list drops SessionColorField.
  • Deleted: SessionColorField.test.tsx with its component.
  • Determinism: the four touched test files, 5 runs with --sequence.shuffle and random seeds, 131/131 each time.
  • tsc -b, eslint on changed files, npm run i18n:check, and the crew/members test set (82 files, 1450 tests) pass locally.

Manual verification

Ran the 02b (Advanced unfolded) scene of capture-crewmates-page-create.mjs against the Vite dev server with a stubbed API, both themes. Advanced shows Goal, Workspace, Model, Triggers and no colour control; all scene checks print OK.

Screenshots / video

New mate dialog, Advanced open, ends at Triggers (dark)

Light theme

New mate dialog, Advanced open, ends at Triggers (light)

Related Issues

no linked issue: UI declutter split out of #8497 at maintainer request; #6106 tracks the feature this partially reverses.

Pattern harvest

Not generalizable: a product decision to remove one editing surface, not a defect class.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@xuejinT
xuejinT requested review from a team and cixuuz September 8, 2026 16:47
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6cd877097b29c648b5a911c96054fe66ae3ff8d0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: stored colours survive because the server's partial update only touches session_color when the key is present (crew_update.py:594).

Notes

  • Phantom description: scripts/lib/agents-page-harness.mjs and capture-session-color-removal.mjs are not in this diff or the tree, and the diff never touches capture-hover-no-geometry.mjs. Its scene 18 hovers the session-actions menu swatch, which this PR keeps. Correct the prose or add the files.
  • The description says "State, load on open, write-back on save … keep working", but useCrewEditor.ts drops the state, the load and the save key. That is a better design, since the server keeps the value when the key is absent, but the description should say so rather than claim the write-back stays.

[DESIGN-REVIEWED] 6cd8770

Description read

[DESCRIPTION-READ] 648383873fab73eb0d851e2746b27adad59dbc9b1b195c4b9ea5fe1c5346fe18

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🔴 BLOCK

Premise-level review of 6cd877097b29c648b5a911c96054fe66ae3ff8d0 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: BLOCK

This is a product-shape change without an accepted RFC. The PR removes the only UI that edits an agent's session colour, and accepted rfc-crewmates-launch says the New crewmate dialog carries session colour under Advanced settings.

Notes

  • Item 6: undeclared. The description says the code "lives in scripts/lib/agents-page-harness.mjs" and that "the capture-hover-no-geometry.mjs scene that hovered the deleted swatch is gone". Neither change is in the diff. Scene 24-crew-color-swatch-hovered is still there and hovers the deleted swatch. Subtraction: delete scene 24 from capture-hover-no-geometry.mjs.

What this change ships

Inventory (6 items) — 3 justified

Intent: declutter the crew create and edit forms by dropping the session-colour picker while stored colours keep working. This is an ADDITION (a removal of UI), not a fix.

  1. The crew manager's "Add crew member" modal no longer shows the colour picker under Routing. — unjustified move: removes a capability; only support is "the maintainer ruled it out"
  2. The Triggers pane of the edit modal no longer shows the colour picker. — unjustified move: same removal, same support
  3. The New crewmate dialog's Advanced section no longer offers session colour. — unjustified move: reverses a decision the accepted RFC records
  4. Users can no longer set or clear an agent's colour from the UI; only by editing the JSON config. — rides along: an existing capability removed
  5. Four colour strings are removed from every locale catalog, along with the colour pane's dirty-state tracking. — justified
  6. The crew docs and spec stop describing the picker; one orphaned capture script is deleted. — justified

Blockers

  • product-shape change without accepted RFC: removing agent session-colour editing from the UI. Tag: unjustified move.
    Trigger: items 1–4. The description says "the maintainer ruled it out of the modals". The base RFC docs/request-for-change/rfc-crewmates-launch.md (status accepted) says under "Decided:": "the workspace, model, triggers and session colour) sits behind Advanced settings". No RFC on the base covers removing it.
    Outcome: every user loses the only UI way to set or clear a crew colour, and the reversal of the RFC's decision is not on record.
    Clears when: an RFC covering removal of the session-colour editor is merged non-draft on the base (then push or rebase), or a maintainer posts /ai-review override first-principles 6cd877097b29c648b5a911c96054fe66ae3ff8d0 product-shape: <decision>.

[FIRST-PRINCIPLES-REVIEWED] 6cd8770

Description read

[DESCRIPTION-READ] fb1f7c552de4d3deb16cf3f730f5c456688099f96d8e7625d55716c39f214355

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6cd877097b29c648b5a911c96054fe66ae3ff8d0 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6cd8770

Verdict parsed from the review's SHA-scoped output markers for commit 6cd877097b29c648b5a911c96054fe66ae3ff8d0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6cd877097b29c648b5a911c96054fe66ae3ff8d0 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 6cd877097b29c648b5a911c96054fe66ae3ff8d0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: this PR only removes the colour picker, and screenshots show each of the three forms without it.

[UX-REVIEWED] 6cd8770

Description read

[DESCRIPTION-READ] 303250613ecf883b26d3fd5a1c9c6767cd02c75d24c96abcc3d5b2ef53599259

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6cd877097b29c648b5a911c96054fe66ae3ff8d0 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6cd8770

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6cd877097b29c648b5a911c96054fe66ae3ff8d0 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 8, 2026
@xuejinT
xuejinT force-pushed the feat/agents-session-color-removal branch from 3b877f9 to 61d463c Compare September 8, 2026 17:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Sep 8, 2026
@xuejinT

xuejinT commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=ae95a8d0a871 — trapped state shipped unresolved: needs-a-decision

The decision this item waits on is exactly the one this PR was split out to host, per the maintainer's review on #8497 (#8497 (review)). @bolichen97: please pick (a) minimal clear-colour control, (b) land auto-assign first, or (c) drop the feature outright — or accept shipping the trapped state as-is. This ruling covers every finding that reduces to "the (a)/(b)/(c) choice is unmade".

@xuejinT

xuejinT commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=af534b344df4 — option (a) is the proportionate resolution: needs-a-decision

Noted as the leading candidate — a conditional clear control is also what the UX lane suggested on #8497. Implementation is deliberately withheld until the maintainer rules on (a)/(b)/(c) in this thread (#8497 (review)); shipping (a) unprompted would preempt the decision this PR exists to host.

@xuejinT

xuejinT commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=698b693f8571 — justification rests on unlinked direction: rebutted

The pointable record exists: the maintainer's review on #8497 (#8497 (review)) directed this exact split and framed the three candidate resolutions this PR's body lists. The direction is that review plus the design owner's authorship of this PR; findings requiring a linked record of the direction are covered by that pointer.

@xuejinT

xuejinT commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=4c6c32a9fa5e — removal premise needs a pointable record: rebutted

Same record as span 698b693f8571: the maintainer's review on #8497 (#8497 (review)) is the linked discussion; the decision itself is being recorded in this PR's review thread as that review requested. The "few touch it" usage claim is the design owner's product judgment under review here, not a shipped assertion.

@xuejinT

xuejinT commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=bcb114145c88 — stranded colours with zero UI writers: needs-a-decision

This is the (a)/(b)/(c) question the PR body hosts, awaiting the maintainer's ruling in this thread (#8497 (review)). The round-trip on save is deliberate: it keeps existing tints stable while the decision is pending instead of silently clearing them.

@xuejinT

xuejinT commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=cffd4bac97ea — delete the orphaned capture-crew-color-presets.mjs: fixed

Deleted in 61d463c: the script existed solely to screenshot the preset swatch row this PR removes, its "after" state can never render again, and nothing referenced it (grep shows only its own usage line).

@xuejinT

xuejinT commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

self-added: no

  • span=b6828f55c27d — stored colour keeps tinting with no modal explanation: needs-a-decision

Covered by the (a)/(b)/(c) decision this PR hosts (#8497 (review)). If (a) is chosen the edit modal regains a conditional control that explains and clears the tint; (b) and (c) each dissolve the unexplained state differently. Held for the maintainer's ruling.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 8, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) September 9, 2026 07:22
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 27, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Item 1 — product-shape change without accepted RFC span=0245963a40f2

needs-a-decision: the removal rests on the approval review bolichen97 gave this PR on 2026-09-10, which approved removing the editing UI and keeping the stored field.
The lane accepts only a merged RFC or a maintainer override, so the ruling belongs to the maintainer; the override line pinned to this head is in #9494 (comment)
No code change can clear this span; the stored session_color field and every reader stay untouched.

@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Blocker — product-shape change without accepted RFC span=d9bbbe6221c0

needs-a-decision: removing the only UI editor of session_color is the change bolichen97 approved on 2026-09-10, with a clear control left as a follow-up.
Clearing this Blocker takes a merged RFC or the maintainer override; the paste-ready override line for this head is in #9494 (comment)
A stored colour stays clearable by removing the session_color key from the agent JSON config, as the PR body states.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 27, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Stored Session Color loses every UI edit path span=63a70f1360cd

rebutted as out of goal: the frozen Not a goal section excludes a UI clear path for a stored colour, and the maintainer approval (bolichen97, 2026-09-10) named that control a follow-up.
The remedy is documented: remove the session_color key from the agent JSON config (PR body, What changed); the packaged crew-members.md Session color row states the same route in the next head.
Frequency is low by the PR premise and the cost is friction only; no data is lost and the tint keeps working.

@NicholasRBowers
NicholasRBowers force-pushed the feat/agents-session-color-removal branch from aa422d6 to 1c86b80 Compare September 27, 2026 23:24
@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • spec and packaged user docs still advertise the deleted editor span=12e36d708fb2

fixed in 1c86b80: crew-mode.md and crew-members.md no longer list session colour among the New crewmate Advanced fields or the crew manager editor fields.
The crew-members.md Session color row keeps the stored field and states that no dashboard control sets it; a stored colour is cleared by removing the key from the crewmate entry in config.json.
test_crew_members_doc.py and test_members_preview_speech_only.py pass (36 tests).

@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • hover harness scene 24 targets the deleted swatch span=8e08d6ef46ae

fixed in 1c86b80: scene 24-crew-color-swatch-hovered and its docstring mention are removed from capture-hover-no-geometry.mjs.
The selector had no other match inside the crew dialog; the frame total derives from SCENES.length, so nothing renumbers.
eslint passes on the script.

@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Items 1-3 — product-shape change without accepted RFC span=369fda7062be

needs-a-decision: the removal rests on the approval review bolichen97 gave this PR on 2026-09-10, which approved removing the editing UI and keeping the stored field.
The lane accepts only a merged RFC or a maintainer override, so the ruling belongs to the maintainer; the override line pinned to this head is in #9494 (comment)
No code change can clear this span; the stored session_color field and every reader stay untouched.

@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Blocker — product-shape change without accepted RFC span=54608e1848a7

needs-a-decision: removing the Session Color editor from the create, edit and New crewmate forms is the change bolichen97 approved on 2026-09-10, with a clear control left as a follow-up.
Clearing this Blocker takes a merged RFC or the maintainer override; the paste-ready override line for this head is in #9494 (comment)
A stored colour stays clearable by removing the session_color key from the agent JSON config, as the PR body and crew-members.md state.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 27, 2026
@NicholasRBowers
NicholasRBowers force-pushed the feat/agents-session-color-removal branch from 1c86b80 to dfcdae9 Compare September 27, 2026 23:49
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 27, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • NewCrewmateDialog header still names the removed session colour field span=7272e91e5c0c

fixed in dfcdae9: the header parenthetical now lists workspace, model and routing triggers, the three fields the Advanced fold mounts.
No other comment in the PR files names the removed control; the session_color type field and the empty payload default stay because the stored field is kept.
eslint and MembersPage.test.tsx pass.

@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Items 1-3 — product-shape change without recorded decision span=e6626f8d593e

needs-a-decision: the removal rests on the approval review bolichen97 gave this PR on 2026-09-10, which approved removing the editing UI and keeping the stored field.
The lane accepts only a merged RFC or a maintainer override, so the ruling belongs to the maintainer; the override line pinned to this head is in #9494 (comment)
No code change can clear this span; the stored session_color field and every reader stay untouched.

@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Blocker — product-shape change without accepted RFC span=b0e0cee44bfd

needs-a-decision: removing the Session Color editing controls from all three forms is the change bolichen97 approved on 2026-09-10, with a clear control left as a follow-up.
Clearing this Blocker takes a merged RFC or the maintainer override; the paste-ready override line for this head is in #9494 (comment)
A stored colour stays clearable by removing the session_color key from the agent JSON config, as the PR body and crew-members.md state.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 28, 2026
@NicholasRBowers
NicholasRBowers force-pushed the feat/agents-session-color-removal branch from dfcdae9 to deada60 Compare September 28, 2026 03:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 28, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Items 1-3 — product-shape change without recorded decision span=ccf2ee3fa061

needs-a-decision: the removal rests on the approval review bolichen97 gave this PR on 2026-09-10, which approved removing the editing UI and keeping the stored field.
The lane accepts only a merged RFC or a maintainer override, so the ruling belongs to the maintainer; the override line pinned to this head is in #9494 (comment)
No code change can clear this span; the stored session_color field and every reader stay untouched.

@NicholasRBowers

Copy link
Copy Markdown
Contributor
  • Blocker — product-shape change without accepted RFC span=ecc47df550b8

needs-a-decision: removing the Session Color editing controls from all three forms is the change bolichen97 approved on 2026-09-10, with a clear control left as a follow-up.
Clearing this Blocker takes a merged RFC or the maintainer override; the paste-ready override line for this head is in #9494 (comment)
A stored colour stays clearable by removing the session_color key from the agent JSON config, as the PR body and crew-members.md state.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Sep 28, 2026

Copy link
Copy Markdown
Contributor

Open-PR triage (2026-10-05), checked against origin/main ef61a9aa. This PR's head is deada60c, with merge-base cd783d22, and main is now 1116 commits ahead of that base.

Verdict: DISTINCT. Rebase needed. I found no breaking change to any API, config or schema and no P0. No other open PR and nothing on main removes the Session Color editor. The maintainer decision recorded in @bolichen97's review covers the product question.

The branch is stale, and the scope has grown since the last rebase:

  1. git merge-tree origin/main origin/pr/9494 reports content conflicts in 14 files: docs/system-specs/modules/crew-mode.md, website/scripts/capture-template-edit-later-note.mjs, website/src/pages/KiroCrewAgentsPage.tsx, and 11 locale catalogs (bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN).
  2. feat: edit a bot in a modal on the crewmates page #15275 (merged 2026-10-01) added a new mount site that this diff doesn't touch. The crewmates-page edit modal, website/src/components/crew/CrewEditorDialog.tsx, imports SessionColorField (L52) and renders it in the routing pane (L361). Its state and dirty check live in website/src/components/crew/useCrewEditor.ts (L393, L808). This PR deletes the SessionColorField export from KiroCrewAgentsPage.tsx. After a rebase, tsc -b will fail unless that mount and the routing dirty line are removed too. If they stay, the editor survives in one of the edit surfaces, which goes against the PR's stated goal.
  3. feat(crews): open the simple create dialog from the crew manager #15052 (merged 2026-10-02) reworked NewCrewmateDialog.tsx so the crew manager can open the simple create dialog. Please recheck that the picker removal there still applies cleanly.
  4. The open feat(i18n): add Traditional Chinese (Taiwan) #16962 (zh-TW catalog) adds session_color_clear/hex/hint/hint_member strings. Whichever PR lands second should drop or keep those keys to match.

Recommendation: rebase onto current main, extend the removal to CrewEditorDialog.tsx and useCrewEditor.ts, then re-run tsc -b, i18n:check and the crew editor tests.

Remove the Session Color editing UI everywhere it is still mounted on
main: the New mate dialog's Advanced section and the crew editor's state.
The SessionColorField component, its re-export, its unit test, its five
strings in every locale catalog and the orphaned
capture-crew-color-presets.mjs harness go with it.

The stored session_color stays: the server tint and the roster stripe
still read it. The crew editor's save no longer sends the key, so the
server keeps the stored value (crew_update only writes keys the body
carries); the New mate create still sends session_color ''. The crew
docs and the crew-mode spec stop listing the colour among the form
fields.

Redone on current main per the maintainer decision of 2026-09-10;
reverses the UI half of #6106, split out of #8497.

Co-authored-by: Bolin Chen <bolichen97@users.noreply.github.com>
Co-authored-by: Kiro Crew <noreply@kirodotdev.github.io>
@iamwhatever

Copy link
Copy Markdown
Contributor

Redone on current main (caada2ea), per the 2026-11-01 triage. New head 6cd877097b29c648b5a911c96054fe66ae3ff8d0, one commit, Serena Tan authorship kept.

On main the crew manager modals no longer mount the picker, so this head removes what was left: the picker in the New mate dialog's Advanced section, the sessionColor state and its dirty line in useCrewEditor.ts, SessionColorField and its re-export, its unit test, the five session_color* strings in every locale, and the orphaned capture-crew-color-presets.mjs. The editor's save now omits session_color, so crew_update.py keeps the stored value; the stored colour, server tint and roster stripe are untouched. A new test pins that (red on main, green here). tsc -b, eslint, i18n:check and the crew/members test set (1450 tests) pass locally. Fresh screenshots are in the description.

@bolichen97, two human steps remain:

  1. First Principles still returns BLOCK (asks for a recorded decision). Your 2026-09-10 approval is that decision. If you still stand by it, the override line re-pinned to this head:
/ai-review override first-principles 6cd877097b29c648b5a911c96054fe66ae3ff8d0: Approved as written in my 2026-09-10 review — remove the editing UI, keep the stored field; a stored-colour-only clear control is a follow-up, not a blocker.
  1. Re-approval: the reset push dismissed the earlier approval.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

drive-to-green PR claimed by drive-to-green pipeline merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants