Repository navigation
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: stored colours survive because the server's partial update only touches Notes
[DESIGN-REVIEWED] 6cd8770 Description read[DESCRIPTION-READ] 648383873fab73eb0d851e2746b27adad59dbc9b1b195c4b9ea5fe1c5346fe18 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK This is a product-shape change without an accepted RFC. The PR removes the only UI that edits an agent's session colour, and accepted Notes
What this change shipsInventory (6 items) — 3 justifiedIntent: declutter the crew create and edit forms by dropping the session-colour picker while stored colours keep working. This is an ADDITION (a removal of UI), not a fix.
Blockers
[FIRST-PRINCIPLES-REVIEWED] 6cd8770 Description read[DESCRIPTION-READ] fb1f7c552de4d3deb16cf3f730f5c456688099f96d8e7625d55716c39f214355 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: this PR only removes the colour picker, and screenshots show each of the three forms without it. [UX-REVIEWED] 6cd8770 Description read[DESCRIPTION-READ] 303250613ecf883b26d3fd5a1c9c6767cd02c75d24c96abcc3d5b2ef53599259 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
3b877f9 to
61d463c
Compare
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
self-added: no
|
|
|
|
aa422d6 to
1c86b80
Compare
|
|
|
|
1c86b80 to
dfcdae9
Compare
|
|
|
dfcdae9 to
deada60
Compare
|
|
|
Open-PR triage (2026-10-05), checked against Verdict: DISTINCT. Rebase needed. I found no breaking change to any API, config or schema and no P0. No other open PR and nothing on main removes the Session Color editor. The maintainer decision recorded in @bolichen97's review covers the product question. The branch is stale, and the scope has grown since the last rebase:
Recommendation: rebase onto current main, extend the removal to |
Remove the Session Color editing UI everywhere it is still mounted on main: the New mate dialog's Advanced section and the crew editor's state. The SessionColorField component, its re-export, its unit test, its five strings in every locale catalog and the orphaned capture-crew-color-presets.mjs harness go with it. The stored session_color stays: the server tint and the roster stripe still read it. The crew editor's save no longer sends the key, so the server keeps the stored value (crew_update only writes keys the body carries); the New mate create still sends session_color ''. The crew docs and the crew-mode spec stop listing the colour among the form fields. Redone on current main per the maintainer decision of 2026-09-10; reverses the UI half of #6106, split out of #8497. Co-authored-by: Bolin Chen <bolichen97@users.noreply.github.com> Co-authored-by: Kiro Crew <noreply@kirodotdev.github.io>
|
Redone on current main ( On main the crew manager modals no longer mount the picker, so this head removes what was left: the picker in the New mate dialog's Advanced section, the @bolichen97, two human steps remain:
|
Problem / Motivation
Goal: Remove the Session Color picker from the agent create and edit modals while every stored colour keeps working.
The agent create and edit modals carry a Session Color picker almost nobody uses. It adds a swatch row, a native colour input, a hex field and a Clear button to both forms, plus four strings in every
website/src/i18n/localescatalog and its own dirty-pane tracking inwebsite/src/pages/KiroCrewAgentsPage.tsx. The clutter costs every user attention on every open of the form.Why it matters
The create form is the first thing a new user meets. Every control it carries makes the next control harder to find. A colour picker for a niche cosmetic setting does not earn that space, and the maintainer ruled it out of the modals.
Not a goal
session_colorvalues, or the session tint and roster stripe they drive.What changed (motivation → approach → change)
Redone on current
main(the old branch was 5883 commits behind). Onmainthe crew manager modals no longer mount the picker; it survived only in the New mate dialog and the crew editor's state.useCrewEditor.ts)sessionColorstate, dirty line, sent on saveSessionColorField(crewFields.tsx) and its re-exportsession_color*strings per localesession_colorThe crew editor's save no longer sends
session_color.crew_update.pywrites only the keys a body carries, so the stored colour stays as it is. The New mate create still sendssession_color: ''. TheSessionColorFieldunit test and the orphanedcapture-crew-color-presets.mjsharness are deleted.capture-crewmates-page-create.mjsnow checks the Advanced section has no colour input. The crew docs (src/kiro_crew/docs/crew-members.md,docs/system-specs/modules/crew-mode.md) stop listing the colour among the form fields.This reverses the UI half of #6106 and was split out of #8497 at maintainer request (approved 2026-09-10). A stored colour is cleared by removing the
session_colorkey from the agent's config.flowchart LR subgraph Before A1[Create / Edit forms]:::ctx --> B1[SessionColorField]:::removed --> C1[session_color field]:::ctx end subgraph After A2[Create / Edit forms]:::ctx --> C2[session_color field]:::ctx end classDef removed fill:#FEE2E2,stroke:#DC2626,color:#7F1D1D,stroke-dasharray:4 3 classDef ctx fill:#E0F2FE,stroke:#0284C7,color:#0C4A6E linkStyle 0,1 stroke:#DC2626,stroke-dasharray:4 3 linkStyle 2 stroke:#16A34A,stroke-width:2px🟩 added · 🟨 changed · 🟥 removed · 🟦 unchanged
The forms no longer edit the colour; the stored colour and everything that reads it are untouched.
Backwards compatibility
Compatible: the
session_colorconfig key, its API field and every reader stay as they are; only the editing control is removed.Tests
KiroCrewAgentsPage.reasoningEffort.test.tsx› "shows no colour control and leaves a stored colour out of the save body" (crew withsession_color: '#123456'). Red onmain, green here.MembersPage.newCrewmateOutcomes.test.tsxAdvanced test now asserts no colour input (red onmain).CrewRoster.test.tsxpayload-shape test dropssession_color.KiroCrewAgentsPage.owners.test.tsxfacade list dropsSessionColorField.SessionColorField.test.tsxwith its component.--sequence.shuffleand random seeds, 131/131 each time.tsc -b,eslinton changed files,npm run i18n:check, and the crew/members test set (82 files, 1450 tests) pass locally.Manual verification
Ran the 02b (Advanced unfolded) scene of
capture-crewmates-page-create.mjsagainst the Vite dev server with a stubbed API, both themes. Advanced shows Goal, Workspace, Model, Triggers and no colour control; all scene checks print OK.Screenshots / video
Light theme
Related Issues
no linked issue: UI declutter split out of #8497 at maintainer request; #6106 tracks the feature this partially reverses.
Pattern harvest
Not generalizable: a product decision to remove one editing surface, not a defect class.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)