Repository navigation
Conversation
|
Intent: Let one Switch All Sessions pass set reasoning effort together with the model, and make a changed Settings default effort show in the composer without a reload. |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the bulk effort path reuses the session control's live-push step ( Notes
[DESIGN-REVIEWED] d5a1b41 Description read[DESCRIPTION-READ] 3d3b6cdd45bc1935f41c23fede5fa18f32b717fd81dea7a9071d458b9b8a96cf That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the blind reader identified the new Effort select and its outcome lines correctly, and all six panel states appear in screenshots in both themes. Notes
[UX-REVIEWED] d5a1b41 Description read[DESCRIPTION-READ] f84b9d036d6032fd62eb56e7cd76d1d9ab3fe0fbdadac37abfc103906e421a7c That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- src/kiro_crew/dashboard/chat_api/slot_model.py:1034 -- Effort-only pushes race incoming channel turns
Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — UPHOLD. Harm is LOW-to-MEDIUM: a Slack turn fails visibly in a short window, and resending the message recovers it.
False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The effort pick and the composer-chip fix each remove a named harm. The extra outcome lines in the panel go beyond the Goal and are noted. Notes
What this change shipsInventory (10 items) — 8 justifiedIntent: let one bulk switch set every session's reasoning effort with the model, and make the composer show a changed Settings default effort at once. ADDITION plus a FIX.
[FIRST-PRINCIPLES-REVIEWED] d5a1b41 Description read[DESCRIPTION-READ] abe63c45d9eed9b4529c9b80ef3572fe1f838bd892a37df7cfec52c8d1743bae That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
6280dfd to
766b715
Compare
|
mechanism: _bulk_effort_only_switch -- effort-only slots take the single-slot no-reset ladder
|
|
|
|
|
|
|
|
|
|
|
|
|
|
cruisercohen
left a comment
There was a problem hiding this comment.
Thanks for this. Naming the sessions in each notice, and splitting the ones a switch resets from the ones that keep their conversation, looks like exactly what #11231 asks for. A few things stand between this head (48e03ef) and a merge:
- Rebase onto main. The bulk-switch panel has moved out of
ChatSidebar.tsxintowebsite/src/pages/chat-sidebar/bulkModelSwitch.tsx(#20524), so this needs a port, not just a conflict fix. Main also reworded the reset copy after this branched (#18843), so please build on main's current strings instead of theresets_its_conversationtext here. - The "already on this model" bucket. #17670 added that bucket after this branched, and on main it is still a count only. If it names its sessions the same way the other notices here do, the panel stays consistent.
- The open UX Review and Design Review findings on this PR still need answers on the rebased head.
This is a comment only, not a review verdict. Happy to take another look once it is rebased.
|
Thanks for this PR. It now conflicts with main. Could you rebase onto the latest main and resolve the conflicts? We will review it again once it is rebased and CI is green. This branch has had no activity for over 30 days. If there is no further activity in the next 14 days, we may close it. You can always reopen it or open a new PR later. |
|
Porting this branch onto current main now, as requested above: the bulk-switch panel moved to |
|
resolution: removed
|
|
@cruisercohen ported onto main at
The lanes are re-running on the new head; anything they raise gets its own reply. |
|
|
|
resolution: removed
|
|
resolution: removed
|
mechanism: one shared push helper, |
self-added: no |
mechanism: Default is never deferred mid-turn, and one vocabulary check runs before the busy branch |
self-added: no |
self-added: no |
self-added: no |
|
resolution: narrowed -- the effort-only live push no longer runs for a slot a fallback model serves; that slot returns to main's existing reset path
|
|
self-added: yes
|
|
self-added: no
|
|
resolution: narrowed -- bulk Default is removed, so no bulk path commits Default without the live clear_effort; Default stays on each session's own effort dropdown
|
Switch All Sessions gains an Effort select beside its model list, so one pass can move every session to a model and an effort level. "Keep current effort" (the default) sends no level. The select offers the levels but no Default: a session goes back to its default from its own effort dropdown. The select stays disabled, with one line saying why, until a model that uses effort is picked. POST /api/chat/slots/model takes an optional reasoning_effort. An empty level is refused with 400 invalid_reasoning_effort, because a reset cannot clear kiro-cli's workspace effort overlay. A model change commits the level with the reset, as before for the model. A session already on the picked model is never reset: it takes the level through the effort dropdown's live push. A running one is skipped unless skip_running is false. A session that can take the level only at its next start records it and is named in the new effort_deferred list, and the panel stays open to say so. The panel also names the sessions already on the pick, as its failure notice already does. The composer's effort chip now reads the configured default from the shared ['kirocrewConfig'] entry that Settings invalidates on save, so a changed default shows without a reload. The private ['default-effort'] query, ProviderAdapter.resolveDefaultEffort and useKirocrewConfigReader go away.
|
self-added: yes
|
|
self-added: yes
|
Problem / Motivation
Goal: Let one Switch All Sessions pass set reasoning effort together with the model, and make a changed Settings default effort show in the composer without a reload.
Switch All Sessions moves every session to one model, but it cannot set their reasoning effort. To run everything at, say, High, a user has to open each session's effort control one by one.
Separately, changing Settings → Chat → Default reasoning effort did not reach the composer. The effort chip kept naming the old level until a hard refresh, even though sessions already ran at the new one.
Why it matters
Effort is the other half of "what does this session run on". A bulk model switch that cannot set it leaves the job half done. The stale chip tells the user their sessions run at a level they do not.
Not a goal
What changed (motivation → approach → change)
One Switch All Sessions pass now sets effort with the model, and a changed Settings default shows in the composer at once. This head is a port onto current main: the panel lives in
website/src/pages/chat-sidebar/bulkModelSwitch.tsx(#20524), and the endpoint insrc/kiro_crew/dashboard/chat_api/slot_model.py.chat-sidebar/bulkModelSwitch.tsx,lib/bulkModelSwitch.ts,api/client/chatSlotSettings.tsPOST /api/chat/slots/modelmodel,skip_runningreasoning_effort; response addseffort_deferreddashboard/chat_api/slot_model.pybulkModelSwitch.tsxhooks/useDefaultEffort.tsKeep current effort is the default and sends no level. The select offers the levels and no Default. The route refuses an empty
reasoning_effortwith 400invalid_reasoning_effort, as main'sset_model_targetdoes, because a reset cannot clear kiro-cli's workspace effort overlay. Default is set per session, from its own effort dropdown. Bulk Default can return once #39090 fixes the stored-level clear. The select is disabled, with one line saying why, until a model that uses effort is picked.A model change commits the level with the reset, the same point main commits the model. A session already on the model is reset only while a fallback model serves it and it is idle. It takes the level through
_push_live_effortinchat_api/slot_effort.py, the one push step the session effort route also calls. Like that route, the bulk route writes the effort restore marker first, and answers 503effort_marker_unavailablebefore any slot changes when it cannot. A running one is skipped unless the Skip box is cleared; then it records the level for its next start, as the session control does mid-turn. A level the live session does not offer lands infailed. A push the live session can take only on a restart records the level and lands ineffort_deferred. A refused or failed push lands infailedwith nothing changed. A relay archive keeps its effort, as the session effort route refuses it. The red "reply is stopped" caveat counts only running sessions whose model changes.After a switch that skipped busy sessions or deferred an effort, the panel stays open. It lists the switched, busy and deferred sessions by name, each session in one line only, and its Cancel reads Close, since leaving undoes nothing. When a skipped busy session goes idle, one more line names it and says Switch now moves it without stopping a reply. Picking another model or effort retires those lines, which described the previous pick.
The panel copy is main's (#18843): every switch keeps the conversation. So this head drops the earlier "resets / keeps its conversation" lists. The remote turn relay is retired on main (
dashboard/relay_archive.py), so the peer-effort handling and its 409 are gone too. The bulk path uses the session control's own mid-turn guard, so the earlier ACP turn-lock rework is gone.New strings and the named on-target line are translated in every catalog under
website/src/i18n/.The composer chips read the configured default from the shared
['kirocrewConfig']entry, which Settings invalidates on save. The private['default-effort']query,ProviderAdapter.resolveDefaultEffortanduseKirocrewConfigReaderare removed.Backwards compatibility
Compatible:
reasoning_effortis optional and an absent field behaves as before;effort_deferredis a new list beside the existing ones.Reader: website/src/components/useChatPanePickers.ts:defaultEffort -- chat -- reads
useDefaultEffortinstead ofresolveDefaultEffort;useDefaultEffort.test.tsxReader: website/src/pages/chat/page/composerChips.ts:defaultEffort -- chat -- same;
useChatPageComposerChips.test.tsxReader: website/src/providers/types.ts:ProviderAdapter -- chat -- no other implementer or caller of
resolveDefaultEfforton origin/main @ 974172eTests
test/test_bulk_model_switch_effort.py: a model change commits the level with the reset; an effort-only change pushes live through_push_live_effortand never resets, and the session effort route uses the same step; the restore marker is written once, and a marker failure is 503 with nothing changed; a push the session takes only on a restart is recorded and deferred; a running session is skipped by default and deferred when Skip is cleared, except an unoffered level, which fails; a raised or refused push and an unoffered level change nothing; no live session records the level; a relay archive keeps its effort; an absent level leaves every effort alone; an invalid level is 400invalid_reasoning_effort; an empty level is 400invalid_reasoning_effortbefore any slot, reset, push or marker change.website/src/lib/bulkModelSwitch.test.ts: an effort pick moves a session on the model but not on the effort intoaffected; every slot still lands in exactly one bucket; an effort-only running session never counts as one whose reply stops.website/src/test/ChatSidebar.bulkModelRosterError.test.tsx: the disabled select and its hint; the count and the sent level; the list offers Keep current effort and the levels, with no Default row; a deferred or busy outcome keeps the panel open, names the switched, busy and deferred sessions once each and reads Close, a new pick retires it, and a clean switch closes the panel; the caveat follows model changes only; the on-target line names its sessions and mentions effort while one is picked; a busy session that goes idle is named as the one Switch now moves.website/src/test/useDefaultEffort.test.tsx: one GET shared with the sidebar's observer; a Settings save that invalidates the key shows the new level;""when unset, failed or disabled.Manual verification
Vitest drives the real panel in jsdom; the backend tests drive the real handler over HTTP with a mocked session manager. Not yet exercised against a running gateway.
Real-machine verification
Machine: the author's Linux dev box, x86_64, 48 vCPU / 186 GiB
Before (main eecf4c1):
pytest -n0 test/test_bulk_model_switch_effort.py-> 34 failed, 3 passed (main ignoresreasoning_effort, so only the cases that send no level, or change nothing, pass)After (head d5a1b41):
pytest -n0 test/test_bulk_model_switch_effort.py-> 37 passedCleanup: own computer
Screenshots / video
Captured from a
vite buildof this head against stubbed API routes (no gateway), sidebar at 300 px.High picked on
claude-opus-4.8: the session already on the model and at High is named, the other two are counted:The Effort list: Keep current effort, then the levels. It has no Default row; each session's own dropdown sets Default:
After the switch, one session takes High only at its next restart. The panel names what was switched and what waits, each session once, and its exit reads Close:
A busy session was left alone and is named. Once it goes idle, the panel says Switch moves it without stopping a reply:
Before a model is picked, and the light theme
Related Issues
no linked issue: requested directly by a user; no tracking issue exists.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)