Repository navigation
fix(chat): say what Switch All Sessions keeps and what it stops - #18843
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that the conversation really survives a bulk reset on every selectable harness, not just kiro-cli. The new copy promises this to everyone who opens the dialog. What this change shipsInventory (6 items) — 6 justifiedIntent: stop the Switch All Sessions dialog from saying a bulk model switch wipes the conversation, and warn only when a running reply will really be cut off. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 6b79378 Description read[DESCRIPTION-READ] 980fa0a05b897194f93942501c9ec13e7ccb345fe31f348901467ff57c2ec5f3 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that "their current reply is stopped" makes clear the half-written reply is lost. The blind reader could not tell whether it was lost or kept. Suggestions
[UX-REVIEWED] 6b79378 Description read[DESCRIPTION-READ] 75789277b69edb326fa97247e79d149f084ce3ec8deb6cb43b6e0dd60f5f5a2b That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 6b79378 Description read[DESCRIPTION-READ] a4c5a07c3e8ff9a894b46211262a1048d5a3aa261e83dc9d0b44119275de4447 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
3386705 to
6b79378
Compare
|
|
|
|
iamwhatever
left a comment
There was a problem hiding this comment.
This replaces the red "Switching a session resets its conversation" warning in the Switch All Sessions dialog with copy that matches what a switch does: the conversation is kept, and only an unskipped running reply is stopped. The fix is at the root. The one misleading sentence, which was split across two keys, is now two whole-sentence keys in all 12 locales plus en-XA and en.context.json. The red caveat renders only when bulkRunningCount > 0 and the skip box is cleared, which is the only case where anything is lost (ChatSidebar.tsx:4685). The new ChatSidebarCoverage tests check the kept-conversation text and that the old text is gone. They also check the caveat is absent by default and when nothing is running, and present once Skip is cleared, so they would fail on main. All checks are green, base is main, and all three design lanes plus GPT and Opus pass. Every UX item from earlier heads has a disposition, and the current-head "stopped vs lost" note is rebutted with a reasonable not-verified argument. Copy-only change with no behaviour or API change. — crew-pr-reviewer
Problem / Motivation
Goal: The Switch All Sessions dialog tells the user what a switch really does: the conversation is kept, and only a running reply that is not skipped gets stopped.
The dialog says, in red, "Switching a session resets its conversation". Most people read that as "my messages are gone". They are not. A bulk switch restarts the session's agent process, and the conversation comes back on the next message.
Why it matters
Everyone who opens the dialog sees the warning. An overstated warning either scares people off a safe action, or teaches them to ignore red text in the one case where it matters: a session that is mid-reply and not skipped really does lose that reply.
Not a goal
What changed (motivation → approach → change)
Symptom: the warning says a switch "resets its conversation", but on main nothing in the switch path deletes the conversation.
What a switch does, read from main's
src/kiro_crew/dashboard/chat_handlers.pyandsrc/kiro_crew/session_lifecycle.py:session/load). If that load fails, or the provider changes, the conversation is replayed from the log instead. Either way the conversation continues on the new model.Change: the copy now says this. In
website/src/pages/ChatSidebar.tsxthe description reads "Pick a model for every session. The conversation is kept and continues on the new model." The red caveat, "Running sessions switch too, and their current reply is stopped.", shows only when sessions are running and the user has cleared the Skip box, because that is the only case where anything is lost. With the default (Skip ticked), there is no red text. The old two-fragment pair (one sentence split across two keys) is replaced by two complete sentences, so translators work with whole sentences.website/src/i18nholds the catalogs. All 12 authored locales are translated, each in its style guide's register (du / tú / tu / ты / तुम / তুমি / 你, です・ます, 합니다체). The old fragments had several of these wrong (for example German "Sie", French "vous").en-XAis regenerated withnpm run i18n:pseudo, anden.context.jsongets translator context for both keys.npm run gen:uiproduced no change toui-index.generated.json, because this text is not indexed.Rejected alternatives:
Backwards compatibility
Compatible: copy only. No API, setting or behaviour changes.
Two catalog keys are removed and replaced (
pages.chatSidebar.pick_a_model_for_every_session_switching_a_sessi,pages.chatSidebar.resets_its_conversation):Reader: website/src/pages/ChatSidebar.tsx:ChatSidebar -- chat -- the only reader on origin/main; it now reads the replacement keys (
ChatSidebarCoverage.test.tsx)Tests
website/src/test/ChatSidebarCoverage.test.tsx: the panel says the conversation is kept, and the old "resets its conversation" text is gone. The red caveat is absent while Skip is ticked and appears once it is cleared. It is also absent when no session is running.src/i18nsuites (parity, QA on changed values, per-locale style tests) are green withI18N_BASE_REF=origin/main.lint:i18n,i18n:check,check-i18n-keys,tscand eslint also pass. The related frontend set passes too: 146 files, 2213 tests.Manual verification
Built the SPA and opened the panel against stubbed APIs in Playwright, with one running session: English with Skip ticked (default), English with Skip cleared, and German with Skip cleared. The capture asserts that the caveat is present or absent in each case. Text wraps cleanly at sidebar width.
Screenshots / video
Default, Skip ticked (nothing at risk, no caveat):
Skip cleared (running sessions will switch, caveat shown):
German, Skip cleared
Before: "Pick a model for every session. Switching a session resets its conversation." (red, always shown).
Related Issues
Part of #11231. Naming the affected sessions is deferred to a follow-up slice.
Open PR #13619 also touches this dialog (it adds effort picking) and keeps the old reset copy. Whichever lands second rebases.
Pattern harvest
Rule candidate: review-prompt
Pattern: destructive-sounding UI warning copy that is not checked against what the handler actually destroys
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)