Repository navigation
fix: admit approved global steering symlinks - #14007
vinayshah1998 wants to merge 3 commits into
Conversation
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
UX Review (Fable 5, fork) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK Cannot evaluate: missing a screenshot of the Security page governance section showing the new "Linked steering sources" row. Watch
Evidence gaps
[UX-REVIEWED] edab1a7 |
Design Review (Fable 5, fork) — 🔴 BLOCK (blocking)Design-level review of Design-Verdict: BLOCK Cannot evaluate: missing screenshot of the Security panel's new "Linked steering sources — Nothing allowed" governance row; backend design itself is sound. BlockersMissing rendered evidence for a reshaped Security panel [DESIGN-REVIEWED] edab1a7 |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS An opt-in capability shipped as Not justified as shipped
Everything else holds up under counting: no existing mechanism reads an external canonical file (absolute resources outside the admitted roots are refused, member_essential_context.py:174), What this change shipsInventory (7 items) — 6 justifiedIntent: let members read shared global steering through symlinks from one canonical source, gated by explicit host approval — an ADDITION, despite the
[FIRST-PRINCIPLES-REVIEWED] edab1a7 |
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed 1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- src/kiro_crew/member_essential_context.py:244 -- Steering authorization bypasses required SEL auditing
Adjudication (Opus 5) — is blocking on each finding proportionate?Harm rung — unbounded-class as fenced (governance authorization without an audit record); conditions are ordinary, not extreme. [ADJUDICATION] edab1a7 total=0 uphold=0 downgrade=0 |
Opus 5 Review (fork) — 🔴 changes requested (blocking)Reviewed BLOCKING — the new BLOCKING — src/kiro_crew/member_essential_context.py:245
FINDING — src/kiro_crew/platform/governance.py:1297 — the added |
|
Thanks for the reviews. This comment covers the items that need no code and says where the code items stand. Nothing below claims a bot verdict resolved; those re-run on the next head. Description sections (dwu96). The four required sections have been present since the earlier edit. This edit adds the rest of the template: Backwards compatibility, Manual verification, Screenshots / video, Related Issues, Pattern harvest, and the Checklist, and records the current state of CI on this head. Title stays Bare Code findings: prepared locally, not on the remote. The SEL audit gap (GPT 5.6, Opus 5), the module-level imports, the CAPABILITY-DEFAULT CONTRACT comment, the InfoTip on the ungoverned "Nothing allowed" row, and the Windows test-pattern spelling behind the 48 shard-4 failures all have a prepared revision, verified locally as described under "Pending revision" in the description. Publishing it means amending the two existing commits and force-pushing with lease (two-commit cap), which waits on the branch owner's approval, so the bot verdicts on |
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author. Assessment: Reviewers accept the design (Design Review calls the backend "sound"); every blocker is mechanical. The GPT and Opus BLOCKs are the same one defect — Note: on 2026-09-26 you mentioned a local revision addressing the code findings was ready but not pushed — the head here is still If you'd prefer I don't touch this PR, add the |
|
Overlap note from #16263 (symlinked-home member sources, fixes #16255): that PR touches |
|
PR triage (automated, 2026-10-05): REBASE + CONTINUE-DEVELOPMENT I compared head
Relationship to other PRs:
Open blockers on this head (already raised, not repeated here as new findings):
The "pending revision" mentioned in the description has not been pushed yet. Please push it onto a branch rebased on current main. |
Pin single-source steering delivery, default-deny diagnostics, and filesystem isolation across the member and native capture paths. The authorized-link checks fail against the previous loader.
Read shared steering from its canonical source without copied files. Use protected host policy and profile rules to authorize linked targets, and preserve exact-file confinement, memory isolation, and input limits. Preserve implicit link omissions and declared escape refusals. Screen metadata before classifying an unselected link, without reading its contents, traversing its target, or authorizing an unselected source. Audit grants and denials through the existing signed SEL seam. Use pysqlite3 0.6.x to avoid the bundled SQLite WAL open/close deadlock. Require Linux glibc 2.28, validate compatible dependency wheels in CI, and keep install guidance aligned with the selected distribution. Linux systems with glibc older than 2.28 are no longer supported. Amp-Thread-ID: https://ampcode.com/threads/T-01a15526-7ea0-7558-b252-e0dc869fc0fa
Use the empty-array-safe expansion required by the workflow compatibility gate while preserving the generated platform arguments. Amp-Thread-ID: https://ampcode.com/threads/T-01a15526-7ea0-7558-b252-e0dc869fc0fa
edab1a7 to
604d9a3
Compare
Problem / Motivation
Crew mode rejects symlinked global steering with
linked document or directory. Members cannot load shared steering from its canonical source, even when the document is readable.Why it matters
Users need one source of truth. Copying steering documents creates duplicates that drift and require synchronization.
What changed
Global steering leaf links can load only when protected host policy or a host-bound profile explicitly permits the resolved target.
steering.sourcesruleset. Missing approval denies in enforcement, policy explanations, and the Security page.Pending revision
The following fixes are prepared locally but are NOT in the published head: audited ruleset decisions through
vet_and_audit, portable Windows test patterns, module-level imports, corrected contract documentation, and an explanatory InfoTip beside "Nothing allowed". Publishing requires folding them into the existing two commits, subject to approval for a lease-guarded force-push. Review blockers remain open until publication and CI verification.Backwards compatibility
Compatible. Omitting the new scope continues to refuse links. Existing scopes retain their behavior. Older versions reject a policy naming the new scope, so upgrade before configuring it.
Tests
Manual verification
The candidate production bundle passed 42 Playwright assertions with controlled governance API responses. Both governance states, keyboard activation, and 390px layout passed. This verifies rendering, not live host approval. Windows path behavior was emulated, not executed on Windows.
Screenshots / video
Candidate screenshots are captured for the ungoverned row, its InfoTip, and the governed policy row. Attachment is pending publication of that revision. No screenshot exemption is claimed.
Related Issues
None. The reported loader failure is described above.
Pattern harvest
Not generalizable: the repository already requires audited governance decisions. This revision applies that existing rule and adds allow, deny, and audit-failure regression coverage rather than proposing another broad lint rule.
Limits
Approval governs Crew-managed essentials, not independent native CLI readers. Either explicitly configured host-controlled tier can grant; an explicit empty allow-set in the ceiling keeps access closed. Windows junctions and macOS case-only aliases remain unqualified. No running installation or live approval has changed.
Checklist