Skip to content

docs(rfc): Preserve superseded Autopilot evidence - #14043

Closed
junjiequ wants to merge 4 commits into
kirodotdev:mainfrom
junjiequ:docs/rfc-autopilot-stage-budget
Closed

junjiequ wants to merge 4 commits into
kirodotdev:mainfrom
junjiequ:docs/rfc-autopilot-stage-budget

Conversation

@junjiequ

@junjiequ junjiequ commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Preserve the Autopilot timeout incident evidence while recording that the stage-budget proposal was superseded before acceptance.

Six distinct 30-minute stage timeouts occurred in nine days. Two native ACP records proved that work continued after the dashboard said the stage had stopped. Since this RFC opened, the accepted Autopilot retirement landed its backend removal in #15362, so the stage-budget decision no longer applies.

Why it matters

The incident record should remain reviewable without misleading maintainers into approving behavior for a deleted feature. The evidence also identifies a narrower lifecycle defect that still exists at the ordinary chat-turn ceiling: _bounded_turn cancels _run_chat without first sending native session/cancel.

Not a goal

  • Restore or replace Autopilot.
  • Revive draft implementation #13992.
  • Implement the separate ordinary-turn native-cancellation fix in this docs PR.

What changed (motivation → approach → change)

The branch now includes current main and resolves the RFC-index conflict by keeping every newer row. The stage-budget RFC is marked superseded, points to the accepted retirement RFC, and opens with a prominent note that its design is historical context rather than current direction.

The retirement RFC links back to the superseded proposal and records the live rollout state: backend removal has merged, while frontend cleanup #15359 remains open. The sanitized appendix still preserves six deduplicated incidents, two confirmed dashboard/native split-brain continuations, source-record hashes, and reproduction details without publishing raw transcripts.

Backwards compatibility

Compatible: documentation and audit metadata only. No runtime, configuration, stored session, or public interface changes.

Tests

  • ./scripts/docs-lint.sh — passed across 391 Markdown files.
  • pytest -n0 -q test/test_docs_lint_fact_checks.py test/test_configuration_doc_defaults.py — 103 passed.
  • git diff --check origin/main...HEAD — passed.

Manual verification

  • Confirmed #15362 merged.
  • Confirmed chat_orchestrator.py, prompt-orchestrator.md, and the Autopilot system spec are absent from current main.
  • Confirmed "orchestrator" is a retired mode and restores as plain chat.
  • Confirmed #15359 remains open.
  • Confirmed the ordinary chat-turn deadline still cancels _run_chat without a pre-unwind session/cancel; this PR records but does not fix that separate defect.

Screenshots / video

N/A — this PR changes documents only. The source screenshots contained unrelated session content; the appendix preserves only sanitized lifecycle facts.

Related Issues

  • Superseded implementation prototype: #13992
  • Backend retirement: #15362
  • Frontend retirement: #15359
  • No linked issue: the generic chat-turn cancellation defect is intentionally left for a focused follow-up.

Checklist

  • At most two commits — existing published commits were preserved; conflict resolution used a merge commit rather than rewriting shared history.
  • Existing tests pass and new tests added for new functionality — docs-only; focused documentation checks passed.
  • Self-review completed; documentation follows project conventions.
  • Documentation updated.
  • No secrets, credentials, or internal references in the diff.

Contribution License Agreement

Document six recurrent timeout incidents and two confirmed dashboard/native split-brain continuations. Define stage budgets as automatic admission gates, preserve independent turn safeguards, and require pre-unwind lease-owned native cancellation.
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 26, 2026
@junjiequ junjiequ mentioned this pull request Sep 26, 2026
5 tasks done
@dwu96

dwu96 commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 5f91adc01f15a17050ea01d4cdd93f9a7caa6d47 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 5f91adc

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — 🟡 CONCERNS

Design-level review of 5f91adc01f15a17050ea01d4cdd93f9a7caa6d47 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

The still-live cancellation defect — this PR's stated reason the record matters — is filed nowhere trackable, only inside a doc marked superseded.

Watch

A reader triaging the ceiling bug will not open a superseded RFC — that status label tells them to skip it — so the one live finding (_bounded_turn cancels _run_chat with no pre-unwind native session/cancel, verified real at turn_dispatch.py:327-331) effectively disappears with the dead proposal; the description's "No linked issue… intentionally left for a focused follow-up" leaves no artifact a follow-up can start from.
Clears when: a tracking issue (or draft bug RFC) for the chat-turn pre-unwind native-cancel defect exists and the superseded RFC/appendix link to it.

Suggestions

  • assets/README.md claims to index the directory but names 3 of its 14 files; index all of them or scope the README to the one new evidence doc.
  • The index README's audit-history paragraph records every prior row addition and re-audit in prose; add matching sentences for the new row and the 191c9d35c re-audit so the trail stays complete.

[DESIGN-REVIEWED] 5f91adc

Description read

[DESCRIPTION-READ] 11f7c1242a4a6c63b81513f7bc5649cb2c351239441dad632d2806b148218510

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 163d669731862285351955a4eb5f32afd92b9676 via the fork AI-review pipeline; updated in place on each push.

Review details

Docs-only RFC; one advisory inaccuracy — the Backward-compatibility section states manual Go behaviour is unchanged while §1 changes exactly that admission path.

FINDING — docs/request-for-change/rfc-autopilot-stage-budgets.md:383 — "manual\n Go/Cancel behavior remain" is false for Go: on base main chat_orchestrator.py:1441 runs if tracker.is_stage_timed_out(): with no auto_run guard (unlike the plan check at :1409), and _stage_start is only re-armed in start_stage (context_management.py:204) — never on a manual pause/resume — so a manual Go clicked more than stage_timeout_seconds after the previous start_stage is refused today with Stage N timed out after 30m. Auto-run stopped., which the same document's §1 ("An explicit human Go ... may admit the next stage even when the previous automatic budget was spent") reverses; a maintainer pricing the change from the Backward-compatibility section is told the one attended path that does change is untouched → Fix: move manual Go out of the "remain" bullet and state that it newly admits a stage after an elapsed automatic budget, leaving Cancel, max_plan_duration_seconds, failure counts, round caps and approvals in the list.

[OPUS-REVIEWED] 163d669

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 26, 2026
@junjiequ
junjiequ requested a review from a team as a code owner September 28, 2026 14:36
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 28, 2026
@junjiequ junjiequ changed the title docs(rfc): Define safe Autopilot stage budgets docs(rfc): Preserve superseded Autopilot evidence Oct 1, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Oct 1, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 1, 2026
@junjiequ

junjiequ commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #15987. This PR now has four commits because its published conflict-resolution history was preserved, while repository hygiene permits at most two. #15987 reapplies the same five-file incident record to current main in two commits, records both Autopilot removal PRs as merged, and links #14058 as the owner of the remaining generic cancellation defect. Please review and merge #15987 instead; this PR should remain unmerged.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 1, 2026
@junjiequ

junjiequ commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #16146, the final clean current-main replacement for this incident record.

@junjiequ junjiequ closed this Oct 2, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants