Skip to content

docs(rfc): Preserve superseded Autopilot evidence - #15987

Closed
junjiequ wants to merge 2 commits into
kirodotdev:mainfrom
junjiequ:docs/autopilot-evidence-current-main
Closed

junjiequ wants to merge 2 commits into
kirodotdev:mainfrom
junjiequ:docs/autopilot-evidence-current-main

Conversation

@junjiequ

@junjiequ junjiequ commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Preserve the Autopilot timeout incident evidence while recording that the stage-budget proposal was superseded before acceptance.

Six distinct 30-minute stage timeouts occurred in nine days. Two native ACP records proved that work continued after the dashboard said the stage had stopped. Since the original RFC opened, backend removal #15362 and frontend removal #15359 have both merged, so the stage-budget decision no longer applies.

This replaces #14043. Its conflict-resolution merge left four commits, while repository hygiene permits at most two. The published branch is preserved; this PR reapplies the five-file documentation result as one commit on current main.

Why it matters

The incident record should remain reviewable without misleading maintainers into approving behavior for a deleted feature. Issue #14058 owns the narrower lifecycle defect that remains at the ordinary chat-turn ceiling: _bounded_turn cancels _run_chat without first sending native session/cancel.

Not a goal

What changed (motivation → approach → change)

The superseded stage-budget RFC and sanitized evidence appendix are applied to current main as one commit. They now link issue #14058 as the owner of the remaining cancellation defect. The retirement RFC and index record both backend and frontend removal as implemented. The assets README explicitly indexes Markdown evidence only, avoiding an incomplete inventory of unrelated binary assets. Six deduplicated incidents, two confirmed dashboard/native continuations, provenance hashes, and reproduction details remain preserved without raw transcripts.

Backwards compatibility

Compatible: documentation and audit metadata only. No runtime, configuration, stored session, or public interface changes.

Tests

  • python3.12 scripts/docs_lint.py --test — passed.
  • ./scripts/docs-lint.sh — passed across 391 Markdown files.
  • git diff --check origin/main...HEAD — passed.
  • Focused pytest metadata suite — not run locally because this clean worktree has no project test environment. Full CI is expected to run it.

Manual verification

Screenshots / video

N/A — this PR changes documents only. The source screenshots contained unrelated session content; the appendix preserves only sanitized lifecycle facts.

Related Issues

  • Replaces blocked RFC PR: #14043
  • Remaining lifecycle defect: #14058
  • Superseded implementation prototype: #13992
  • Backend retirement: #15362
  • Frontend retirement: #15359

Checklist

  • At most two commits — this branch has one commit on current main.
  • Existing documentation checks pass.
  • Self-review completed; documentation follows project conventions.
  • Documentation updated.
  • No secrets, credentials, raw transcripts, or internal references in the diff.

Contribution License Agreement

@junjiequ
junjiequ requested a review from a team as a code owner October 1, 2026 19:58
@junjiequ
junjiequ requested a review from dodgeblaster October 1, 2026 19:58
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of 84aa1169f4b3b2ead92148f6dcfddd40a0f311f0 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the reapplied single commit matches the reviewed content of #14043, since this PR inherits that review rather than restating it.

All index claims checked against base: Autopilot's stage loop, prompt, and spec are absent; _RETIRED_MODES contains "orchestrator" (src/kiro_crew/dashboard/chat_persistence.py:840); StageBoundary/_in_stage_execution references remain, matching the dead-code note. Marking the new RFC superseded on arrival is the correct shape here — the index explicitly notes the First Principles lane reads statuses as decisions, so landing the evidence without an accepted/draft status is what keeps automation from treating a dead proposal as live direction. Docs-only, nothing renders; the evidence file's empty list is consistent.

[DESIGN-REVIEWED] 84aa116

Description read

[DESCRIPTION-READ] c83873d96fc72ab98b15e72ddd4f8cf970d3f7275c20f9f73a8efc5ee0a7d2ff

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 84aa1169f4b3b2ead92148f6dcfddd40a0f311f0 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 84aa116

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 84aa1169f4b3b2ead92148f6dcfddd40a0f311f0 via the fork AI-review pipeline; updated in place on each push.

Review details

The retirement RFC is flipped to implemented while its own Rollout step 3 is unlanded on main.

FINDING — docs/request-for-change/rfc-retire-chat-autopilot.md:3 — status: implemented asserts the README's definition "Every phase is verifiably on main", but the document's own unchanged Rollout step 3 ("no reference to either name remains under src/") fails at 133869280 — StageBoundary/_in_stage_execution still appear in dashboard/state.py:2528, slot_projection.py:441, chat_runner.py, chat_handlers.py, slack/gateway.py:8139, subagent.py and spec_builder/.../turn_guard.py — so the "Accepted and bounded by step 3" commitment in Risks loses its only tracker while tracking-issues stays [] → Fix: set status: partial and have the prose status line plus the README row name step 3 as the remaining open phase, instead of reclassifying it out of the Rollout as "dead-code cleanup".

[OPUS-REVIEWED] 84aa116

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 1, 2026
@junjiequ

junjiequ commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #16146, rebuilt from current main as one commit with the Opus partial-status correction and current RFC index preserved.

@junjiequ junjiequ closed this Oct 2, 2026
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant