Repository navigation
feat(topbar): show the system metrics card on hover in every desktop form - #14097
Conversation
|
Intent: Let the top-bar system metrics card, with its absolute GB figures, show on hover in every desktop form of the metrics control, including when the readings are expanded inline. |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the failed-fetch hand-off is reachable without a pointer: the ArrowDown-opened card never takes focus, and Suggestions
[DESIGN-REVIEWED] b06b44c |
e255dcd to
08fc436
Compare
|
self-added: yes
|
|
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify keyboard-only access to the readings in the rung-collapsed readout, where the deleted button What this change shipsInventory (10 items) — 10 justifiedIntent: let users see the metrics card (absolute GB figures) by hovering the top-bar control in every desktop form — an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] b06b44c |
UX Review (Fable 5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS "Ask the agent" in the hover error dialog is keyboard-unreachable outside the narrow band, and no blind reader has cold-read any of these states. Watch
Suggestions
[UX-REVIEWED] b06b44c |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNothing blocks; one advisory — the new metrics hover card breaks the header's FINDING — website/src/App.tsx:4154 — all three new hover triggers fail the [OPUS-REVIEWED] b06b44c |
08fc436 to
b8bebf2
Compare
|
self-added: yes
|
|
self-added: yes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
…dle budget Turns the red CI jobs on main green. Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/ unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet claim. Register the six as IDENTITY_SITES. Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added today tipped it to 9. Convert their Bengali digits to Western. Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the host capability with a witness independent of the production constant and skip only when that witness fails; a broken ctypes path still fails. Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged since #12927 set it (#12924, #14097). The growth is irreducible catalog strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a comment attributing the drift, per the gate's documented convention.
…dle budget Turns the red CI jobs on main green. Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/ unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet claim. Register the six as IDENTITY_SITES. Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added today tipped it to 9. Convert their Bengali digits to Western. Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the host capability with a witness independent of the production constant and skip only when that witness fails; a broken ctypes path still fails. Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged since #12927 set it (#12924, #14097). The growth is irreducible catalog strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a comment attributing the drift, per the gate's documented convention.
…dle budget Turns the red CI jobs on main green. Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/ unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet claim. Register the six as IDENTITY_SITES. Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added today tipped it to 9. Convert their Bengali digits to Western. Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the host capability with a witness independent of the production constant and skip only when that witness fails; a broken ctypes path still fails. Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged since #12927 set it (#12924, #14097). The growth is irreducible catalog strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a comment attributing the drift, per the gate's documented convention.
…dle budget Turns the red CI jobs on main green. Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/ unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet claim. Register the six as IDENTITY_SITES. Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added today tipped it to 9. Convert their Bengali digits to Western. Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the host capability with a witness independent of the production constant and skip only when that witness fails; a broken ctypes path still fails. Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged since #12927 set it (#12924, #14097). The growth is irreducible catalog strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a comment attributing the drift, per the gate's documented convention.
…dle budget Turns the red CI jobs on main green. Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/ unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet claim. Register the six as IDENTITY_SITES. Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added today tipped it to 9. Convert their Bengali digits to Western. Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the host capability with a witness independent of the production constant and skip only when that witness fails; a broken ctypes path still fails. Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged since #12927 set it (#12924, #14097). The growth is irreducible catalog strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a comment attributing the drift, per the gate's documented convention.
…dle budget Turns the red CI jobs on main green. Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/ unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet claim. Register the six as IDENTITY_SITES. Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added today tipped it to 9. Convert their Bengali digits to Western. Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the host capability with a witness independent of the production constant and skip only when that witness fails; a broken ctypes path still fails. Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged since #12927 set it (#12924, #14097). The growth is irreducible catalog strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a comment attributing the drift, per the gate's documented convention.
…dle budget Turns the red CI jobs on main green. Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/ unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet claim. Register the six as IDENTITY_SITES. Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added today tipped it to 9. Convert their Bengali digits to Western. Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the host capability with a witness independent of the production constant and skip only when that witness fails; a broken ctypes path still fails. Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged since #12927 set it (#12924, #14097). The growth is irreducible catalog strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a comment attributing the drift, per the gate's documented convention.
Problem / Motivation
Goal: Hovering the top-bar system metrics control shows the metrics card in every desktop form, including when the readings are expanded inline.
The top-bar system metrics card lists CPU, MEM and DSK with the used and total GB. It only appeared when a click pinned it, and only in the narrow band where the inline readings do not fit. With the readings expanded inline, the only way to see the GB figures was a native title tooltip on each reading.
Why it matters
The expanded readout shows percentages only. Users who keep it expanded could not get the absolute memory and disk figures from the card, and the native tooltips stacked on top of each other and looked out of place next to the card.
Not a goal
What changed (motivation → approach → change)
Hovering the metrics control now previews the same card in every desktop form of the control: the bare icon, the narrow-band popover trigger, and the expanded inline readout.
website/src/App.tsxbinds the existinguseHoverIntenthook (320 ms open delay, 250 ms close grace) to the metrics trigger. The card renders asrole="tooltip"on hover, never takes focus, and the trigger points at it witharia-describedby. A click in the narrow band still pins it as therole="dialog"popover, and the hover path is disabled while it is pinned. On the expanded readout the card adds a "Click to hide" line, since that button no longer carries a nativetitle. The per-readingtitles are gone too, and so is the "System metrics"titleon the bare-icon and narrow-band buttons, which keep it as theiraria-label. The readings are visible text in that form, so they stay in the button's accessible name, and the inline percentages now go throughfmtPercent. A failed metrics fetch shows in the card, hovered or pinned, as an inlineErrorNoticereading "The last metrics update failed", with the ask-the-agent hand-off. Data that is only old keeps the readout's dim and the card adds a muted "Last updated more than 90 seconds ago" line, with no error styling. While the notice is present the hover card is a non-modalrole="dialog"with anaria-label, the trigger drops itsaria-describedbyso the name is not read twice, and hovering still moves no focus. A window resize closes the hover card, as it already closes the pinned one, because the card's position is measured once when it opens. The card text uses two new keys (app.metrics_card_old_data,app.metrics_card_fetch_failed) in all 13 locales, andapp.metrics_are_stale_latest_fetch_failedis removed. While any form of the card is open, the metrics query polls every 30 s instead of 60 s and the 10 s staleness tick runs, the same cadence the pinned popover and the expanded readout already use. The plain tooltip form carries noaria-label, so the trigger's description resolves to the card's readings. An invalid reading still shows a dash for its percentage, and its card row names the reason with the existingapp.cpu_unavailable,app.memory_unavailableorapp.disk_unavailablecopy, which the removed titles used to carry.app.stale_fetch_failingonly fed a removed title, so it is deleted from every locale inwebsite/src/i18n/locales/.Backwards compatibility
Compatible: the click behaviour of every form of the control is unchanged, and no stored preference or API changes.
Tests
website/src/test/App.metricsPopover.test.tsx: hovering the expanded readout opens the tooltip card with the GB figures and "Click to hide", links it througharia-describedby, closes on leave, and leaves the click-to-hide toggle working without reopening under the resting pointer. A failed fetch shows theErrorNoticein the hover card over both the expanded readout and the bare icon, age-only staleness keeps a plain tooltip with no notice and shows the "Last updated" line, the dialog form leaves the trigger undescribed, a resize closes the hover card, and the tooltip has noaria-label. Hovering the narrow-band icon opens the tooltip, and a click replaces it with the pinned dialog. Both fail on main and pass here.website/src/test/App.test.tsxandwebsite/src/test/AppRootCoverage.test.tsx: queries that read the removedtitleattributes now read the label and the visible readings.mem_total_gb: 0shows "Memory: unavailable" in the hover card instead of a bare dash.Manual verification
Ran an isolated gateway from this branch (
kiro_crew.testing.harness.spawn_feature_gateway, fixtureminimal) and drove it with Playwright at 1600 px and 1100 px. The card rendered on screen under the trigger in both widths, closed when the pointer left, and showed no module or render errors.Screenshots / video
Expanded readout, then the same readout hovered:
Narrow band, icon hovered:
Data older than 90 seconds with no failed fetch, readout hovered:
A failed fetch after a good frame, readout hovered:
An invalid reading, here a host that reports 0 GB total memory, readout hovered:
Related Issues
no linked issue: small UX request from a user, filed directly as this PR.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)