Skip to content

feat(topbar): show the system metrics card on hover in every desktop form - #14097

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:feat/system-metrics-hover-card
Sep 27, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:feat/system-metrics-hover-card

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Hovering the top-bar system metrics control shows the metrics card in every desktop form, including when the readings are expanded inline.

The top-bar system metrics card lists CPU, MEM and DSK with the used and total GB. It only appeared when a click pinned it, and only in the narrow band where the inline readings do not fit. With the readings expanded inline, the only way to see the GB figures was a native title tooltip on each reading.

Why it matters

The expanded readout shows percentages only. Users who keep it expanded could not get the absolute memory and disk figures from the card, and the native tooltips stacked on top of each other and looked out of place next to the card.

Not a goal

  • Changing the mobile top bar, which has no hover.
  • Showing the exact age of old metrics. The card only says when the data is more than 90 seconds old.
  • Changing what the metrics endpoint reports or how often the dashboard polls when no form of the card is open.

What changed (motivation → approach → change)

Hovering the metrics control now previews the same card in every desktop form of the control: the bare icon, the narrow-band popover trigger, and the expanded inline readout.

website/src/App.tsx binds the existing useHoverIntent hook (320 ms open delay, 250 ms close grace) to the metrics trigger. The card renders as role="tooltip" on hover, never takes focus, and the trigger points at it with aria-describedby. A click in the narrow band still pins it as the role="dialog" popover, and the hover path is disabled while it is pinned. On the expanded readout the card adds a "Click to hide" line, since that button no longer carries a native title. The per-reading titles are gone too, and so is the "System metrics" title on the bare-icon and narrow-band buttons, which keep it as their aria-label. The readings are visible text in that form, so they stay in the button's accessible name, and the inline percentages now go through fmtPercent. A failed metrics fetch shows in the card, hovered or pinned, as an inline ErrorNotice reading "The last metrics update failed", with the ask-the-agent hand-off. Data that is only old keeps the readout's dim and the card adds a muted "Last updated more than 90 seconds ago" line, with no error styling. While the notice is present the hover card is a non-modal role="dialog" with an aria-label, the trigger drops its aria-describedby so the name is not read twice, and hovering still moves no focus. A window resize closes the hover card, as it already closes the pinned one, because the card's position is measured once when it opens. The card text uses two new keys (app.metrics_card_old_data, app.metrics_card_fetch_failed) in all 13 locales, and app.metrics_are_stale_latest_fetch_failed is removed. While any form of the card is open, the metrics query polls every 30 s instead of 60 s and the 10 s staleness tick runs, the same cadence the pinned popover and the expanded readout already use. The plain tooltip form carries no aria-label, so the trigger's description resolves to the card's readings. An invalid reading still shows a dash for its percentage, and its card row names the reason with the existing app.cpu_unavailable, app.memory_unavailable or app.disk_unavailable copy, which the removed titles used to carry. app.stale_fetch_failing only fed a removed title, so it is deleted from every locale in website/src/i18n/locales/.

Backwards compatibility

Compatible: the click behaviour of every form of the control is unchanged, and no stored preference or API changes.

Tests

  • website/src/test/App.metricsPopover.test.tsx: hovering the expanded readout opens the tooltip card with the GB figures and "Click to hide", links it through aria-describedby, closes on leave, and leaves the click-to-hide toggle working without reopening under the resting pointer. A failed fetch shows the ErrorNotice in the hover card over both the expanded readout and the bare icon, age-only staleness keeps a plain tooltip with no notice and shows the "Last updated" line, the dialog form leaves the trigger undescribed, a resize closes the hover card, and the tooltip has no aria-label. Hovering the narrow-band icon opens the tooltip, and a click replaces it with the pinned dialog. Both fail on main and pass here.
  • website/src/test/App.test.tsx and website/src/test/AppRootCoverage.test.tsx: queries that read the removed title attributes now read the label and the visible readings.
  • A frame with mem_total_gb: 0 shows "Memory: unavailable" in the hover card instead of a bare dash.

Manual verification

Ran an isolated gateway from this branch (kiro_crew.testing.harness.spawn_feature_gateway, fixture minimal) and drove it with Playwright at 1600 px and 1100 px. The card rendered on screen under the trigger in both widths, closed when the pointer left, and showed no module or render errors.

Screenshots / video

Expanded readout, then the same readout hovered:

Expanded readout without hover

Expanded readout hovered, card with GB figures and "Click to hide"

Narrow band, icon hovered:

Narrow band icon hovered, same card

Data older than 90 seconds with no failed fetch, readout hovered:

Hover card with the muted Last updated more than 90 seconds ago line

A failed fetch after a good frame, readout hovered:

Hover card as a dialog with the ErrorNotice The last metrics update failed and Ask the agent

An invalid reading, here a host that reports 0 GB total memory, readout hovered:

Hover card with the MEM row reading Memory: unavailable next to its dash

Related Issues

no linked issue: small UX request from a user, filed directly as this PR.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Pearcekieser
Pearcekieser requested review from a team and chenmingwei23 September 26, 2026 03:08
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Intent: Let the top-bar system metrics card, with its absolute GB figures, show on hover in every desktop form of the metrics control, including when the readings are expanded inline.
Not a goal: Changing what a click does in any form, the card's contents or layout, the mobile readout, or the hover-intent hook itself.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 26, 2026
@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of b06b44ce8a96b51408749b888cbca04d96b58776 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the failed-fetch hand-off is reachable without a pointer: the ArrowDown-opened card never takes focus, and openedBy: 'keyboard' is ignored.

Suggestions

  • In the expanded-readout and bare-icon forms the error card exists only while hovered; honoring the hook's openedBy === 'keyboard' contract by moving focus into the card would make the ErrorNotice button usable there.

[DESIGN-REVIEWED] b06b44c

@Pearcekieser
Pearcekieser force-pushed the feat/system-metrics-hover-card branch from e255dcd to 08fc436 Compare September 26, 2026 03:38
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 26, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: stale detection and refetch cadence gated on the pinned popover only; hover card never renders the stale line

  • Hover-only query failures bypass the required error surface (span=1461f955f94d)

fixed in 08fc436: the finding holds. This PR had widened sysMetricsStale, the refetch interval and the stale tick from metricsPopoverOpen to the hover-inclusive card state, so a failed refetch put fetch-failure text inside the hover tooltip.
All three conditions are back to (metricsOpen || metricsPopoverOpen) exactly as on main, and the stale line renders only when the card is the click-pinned dialog, so the tooltip form carries no error text.
Regression test does not expose a failed metrics refetch in the hover tooltip (App.metricsPopover.test.tsx) errors the query, hovers the expanded readout, and asserts the card shows readings but not the stale warning; it fails with the widened condition and passes here.
The pinned popover's stale line is unchanged main behaviour and out of this PR's scope.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Verify one flow live: after "Click to hide", the pointer still rests on the icon, so the card re-opens 320 ms later

rebutted: it does not re-open. The click handler calls metricsHover.close() before toggling, and the control stays the same key="metrics" button element, so a pointer resting on it raises no new mouseenter and the 320 ms open timer is never armed again.
The expanded-readout test in App.metricsPopover.test.tsx now clicks while hovered and asserts the tooltip is gone both immediately and 450 ms later.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 26, 2026
@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed b06b44ce8a96b51408749b888cbca04d96b58776 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b06b44c

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — ✅ PASS

Premise-level review of b06b44ce8a96b51408749b888cbca04d96b58776 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify keyboard-only access to the readings in the rung-collapsed readout, where the deleted button title was the only non-hover path.

What this change ships

Inventory (10 items) — 10 justified

Intent: let users see the metrics card (absolute GB figures) by hovering the top-bar control in every desktop form — an ADDITION.

  1. Hovering the metrics control previews the card in all three desktop forms — justified
  2. Native title tooltips removed from the readings and metrics buttons — justified
  3. Card names an invalid reading's reason instead of a bare dash — justified
  4. Card shows "Click to hide" over the expanded readout — justified
  5. Failed fetch renders an ErrorNotice with ask-agent hand-off, hovered or pinned — justified
  6. Age-only old data gets a muted "90 seconds" line, no failure wording — justified
  7. Inline percentages localized through fmtPercent — justified
  8. Polling tightens to 30 s while any card form is open — justified
  9. Window resize closes the hover card — justified
  10. Six evidence screenshots committed under temp-screenshots/ (documented fork convention, .gitignore:108-120) — justified

[FIRST-PRINCIPLES-REVIEWED] b06b44c

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — 🟡 CONCERNS

UX-level review of b06b44ce8a96b51408749b888cbca04d96b58776 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

"Ask the agent" in the hover error dialog is keyboard-unreachable outside the narrow band, and no blind reader has cold-read any of these states.

Watch

  • Keyboard parity: the failed-fetch card (ErrorNotice with askAgent, attachment-05) opens only on hover/ArrowDown, focus never enters it (tabIndex={-1}, no openedBy === 'keyboard' focus move in the diff), and Tab off the trigger closes it — so on the expanded-readout and bare-icon forms a keyboard user can never activate "Ask the agent". Rare (fetch failure × keyboard use) but the action is fully unreachable each time. Fix: when metricsHover.openedBy === 'keyboard', move focus into the card the way the pinned popover already does.
  • All six states are shown in the committed screenshots, but no first-time reader has seen them in this fork lane; a maintainer wanting the blind read can push the branch to this repository.

Suggestions

  • app.click_to_hide now renders inside the card ("Click to hide", attachments 02/04/05), where it reads as "click this card"; the click target is the readout button. Name the object, e.g. "Click the readout to hide it".

[UX-REVIEWED] b06b44c

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 26, 2026
@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed b06b44ce8a96b51408749b888cbca04d96b58776 via the fork AI-review pipeline; updated in place on each push.

Review details

Nothing blocks; one advisory — the new metrics hover card breaks the header's aria-haspopup pinning contract, so focus mode slides the header out from under it.

FINDING — website/src/App.tsx:4154 — all three new hover triggers fail the headerPopoverOpen contract at App.tsx:2097 (ref={metricsBtnRef} {...metricsHover.triggerProps} … aria-pressed={true} carries no aria-haspopup/aria-expanded; 4095 the same; 4093 has aria-haspopup="dialog" but aria-expanded={metricsPopoverOpen}, which is false for a hover open), so in focus mode moving the pointer from the trigger into the card — the only way to read the absolute GB figures or click the askAgent hand-off — produces mousemoves at clientY > 48, topPeek's departWhen votes departed, headerPopoverOpen stays false, topChromeShown goes false and the 42px header translates to -100% while the z-[70] card stays on screen anchored to a box that is gone → Fix: render aria-haspopup="dialog" with aria-expanded={metricsCardOpen} on all three triggers (or add metricsCardOpen to topChromeShown at App.tsx:2119, outside this diff).

[OPUS-REVIEWED] b06b44c

@Pearcekieser
Pearcekieser force-pushed the feat/system-metrics-hover-card branch from 08fc436 to b8bebf2 Compare September 26, 2026 04:06
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: fetch failures render through ErrorNotice with askAgent in both card forms; age-only staleness adds no error surface

  • Metrics fetch failure bypasses the required error surface (span=1461f955f94d)

fixed in b8bebf2: the hand-written text-warn stale div is gone. When the card is open and the metrics query has errored (sysMetricsError), the card renders ErrorNotice variant="inline" with askAgent on, since this read failure sits on a surface with no draft input.
Age-only staleness (last success over 90 s old, no error) is kept separate as the fix text asks: it is not a failure, so it adds no error surface and relies on the readout's existing dim.
Tests: "shows a failed metrics refetch in the expanded-readout hover dialog" and "shows a failed metrics fetch in the bare-icon hover dialog" assert the notice; an age-only test asserts no alert and a plain tooltip.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: stale gate covers the hover-open card; failure note always rendered via ErrorNotice

  • deletes the only rendering of the metrics query's isError in the expanded inline state (span=18e45ae36123)

fixed in b8bebf2: the metricsPopoverOpen guard is gone. sysMetricsStale, the refetch interval and the stale tick are gated on metricsOpen or any open card (hover included), and a failed fetch renders through the already-imported ErrorNotice in the hover card over the expanded readout and over the bare icon.
The test that pinned the note's absence was replaced by tests asserting the ErrorNotice is present in both hover forms.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • the card the new aria-describedby points at carries aria-label, so the description duplicates the trigger's name (span=39fe7386cb19)

fixed in b8bebf2: the card's role is computed once (metricsCardRole) and aria-label is set only in the dialog form. The tooltip form is unlabelled, so the trigger's aria-describedby resolves to the card text, including the GB rows.
The expanded-readout hover test asserts the tooltip has no aria-label and that its text carries the GB figures.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Failure-path information loss (span=c927009e71da)

fixed in b8bebf2: the hover card renders the failure state again, now as an ErrorNotice rather than a text-warn div, over both the expanded readout and the bare icon; the contradicting "never shows the stale warning" comment and PR-body sentence are gone.
Covered by the two failed-fetch hover tests in App.metricsPopover.test.tsx.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • extend the sysMetricsStale gate to the hover state (span=748280e7f1d4)

fixed in b8bebf2: sysMetricsStale, the refetch interval and the 10 s stale tick are gated on metricsOpen || metricsCardOpen, where metricsCardOpen includes the hover anchor, so the bare-icon hover form evaluates freshness.
The bare-icon failed-fetch hover test exercises that path.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • undeclared removal of the expanded readout's stale titles (span=974dca58d127)

fixed in b8bebf2: the expanded readout's failure disclosure moved into its hover card as an ErrorNotice instead of being dropped, and the PR body now states it: the per-reading titles are gone, failures show in the card, and age-only staleness keeps the existing dim.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Stale disclosure regression on the expanded readout (span=0ad8f66c5ed9)

fixed in b8bebf2: the metricsPopoverOpen gate is removed; hovering the expanded readout during a fetch failure shows the ErrorNotice with the ask-the-agent hand-off, covered by the expanded-readout failed-fetch hover test.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • No first-time read in the fork lane

accepted as a lane limit: the blind first-reader pass does not run on fork PRs, so nothing in this PR can close it.
The next head adds screenshot 06 of the unavailable-reading row, the evidence gap this lane named. The PR body now shows all six card states.
A maintainer who wants the blind read can push this branch to the main repository.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • "Click to hide" in the card names no target

rebutted: the owner chose "Click to hide" after this PR had shipped "Click the readout to hide it" on an earlier head. It matches the dashboard's other hide hints, and the card reuses the existing app.click_to_hide key.
The line shows only while the pointer rests on the expanded readout, and clicking that readout hides it. One more click brings the readout and its stored preference back.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Bare-icon and narrow-band buttons lose their title undeclared

fixed in the description: What changed now says the bare-icon and narrow-band buttons also drop their "System metrics" title and keep it as their aria-label. No code change. The hover card shows the same name as its heading.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Move focus into the error card when opened by keyboard

rebutted as out of scope: on main, the expanded-readout and bare-icon forms show no card at all, and their failure text was a native title, which a keyboard user could not reach either. So this PR adds a hover path without taking away any keyboard path.
The narrow-band click still pins the card as a focusable dialog, and the notice's button works there. A keyboard-open focus move for the other two forms would be a new interaction model, and it belongs in its own change.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Name the click target in "Click to hide"

rebutted: the owner chose "Click to hide" after this PR shipped "Click the readout to hide it" on an earlier head. It matches the dashboard's other hide hints, and the card reuses the existing app.click_to_hide key. It will not change in this PR.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Keyboard parity for the failed-fetch card

rebutted, not a regression: on main, the expanded-readout and bare-icon forms had no card, and their failure hint was a native title, which no keyboard reaches. This PR adds a hover path and removes no keyboard path.
The narrow-band click still pins the card as a focusable dialog with a working "Ask the agent" button. A keyboard-open focus move for the other two forms is a new interaction and is outside this PR's Goal.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • No first-time read in the fork lane

accepted as a lane limit: the blind first-reader pass does not run on fork PRs, so nothing in this PR can close it. All six card states are in the committed screenshots. A maintainer who wants the blind read can push this branch to the main repository.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 27, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

readiness: passed on b06b44ce8a. All 88 checks are green, and every review item on this head has a posted disposition. This is a fork PR, so I can't turn on auto-merge. Could a maintainer approve and merge it?

@iamwhatever
iamwhatever enabled auto-merge (squash) September 27, 2026 17:32
@iamwhatever
iamwhatever merged commit 35a5844 into kirodotdev:main Sep 27, 2026
100 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 27, 2026
iamwhatever pushed a commit that referenced this pull request Sep 27, 2026
…dle budget

Turns the red CI jobs on main green.

Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six
identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/
unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet
claim. Register the six as IDENTITY_SITES.

Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added
today tipped it to 9. Convert their Bengali digits to Western.

Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any
runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the
host capability with a witness independent of the production constant and skip
only when that witness fails; a broken ctypes path still fails.

Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight
shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged
since #12927 set it (#12924, #14097). The growth is irreducible catalog
strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a
comment attributing the drift, per the gate's documented convention.
iamwhatever pushed a commit that referenced this pull request Sep 27, 2026
…dle budget

Turns the red CI jobs on main green.

Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six
identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/
unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet
claim. Register the six as IDENTITY_SITES.

Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added
today tipped it to 9. Convert their Bengali digits to Western.

Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any
runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the
host capability with a witness independent of the production constant and skip
only when that witness fails; a broken ctypes path still fails.

Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight
shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged
since #12927 set it (#12924, #14097). The growth is irreducible catalog
strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a
comment attributing the drift, per the gate's documented convention.
iamwhatever pushed a commit that referenced this pull request Sep 27, 2026
…dle budget

Turns the red CI jobs on main green.

Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six
identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/
unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet
claim. Register the six as IDENTITY_SITES.

Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added
today tipped it to 9. Convert their Bengali digits to Western.

Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any
runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the
host capability with a witness independent of the production constant and skip
only when that witness fails; a broken ctypes path still fails.

Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight
shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged
since #12927 set it (#12924, #14097). The growth is irreducible catalog
strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a
comment attributing the drift, per the gate's documented convention.
iamwhatever pushed a commit that referenced this pull request Sep 27, 2026
…dle budget

Turns the red CI jobs on main green.

Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six
identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/
unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet
claim. Register the six as IDENTITY_SITES.

Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added
today tipped it to 9. Convert their Bengali digits to Western.

Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any
runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the
host capability with a witness independent of the production constant and skip
only when that witness fails; a broken ctypes path still fails.

Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight
shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged
since #12927 set it (#12924, #14097). The growth is irreducible catalog
strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a
comment attributing the drift, per the gate's documented convention.
iamwhatever pushed a commit that referenced this pull request Sep 27, 2026
…dle budget

Turns the red CI jobs on main green.

Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six
identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/
unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet
claim. Register the six as IDENTITY_SITES.

Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added
today tipped it to 9. Convert their Bengali digits to Western.

Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any
runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the
host capability with a witness independent of the production constant and skip
only when that witness fails; a broken ctypes path still fails.

Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight
shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged
since #12927 set it (#12924, #14097). The growth is irreducible catalog
strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a
comment attributing the drift, per the gate's documented convention.
iamwhatever pushed a commit that referenced this pull request Sep 27, 2026
…dle budget

Turns the red CI jobs on main green.

Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six
identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/
unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet
claim. Register the six as IDENTITY_SITES.

Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added
today tipped it to 9. Convert their Bengali digits to Western.

Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any
runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the
host capability with a witness independent of the production constant and skip
only when that witness fails; a broken ctypes path still fails.

Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight
shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged
since #12927 set it (#12924, #14097). The growth is irreducible catalog
strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a
comment attributing the drift, per the gate's documented convention.
iamwhatever pushed a commit that referenced this pull request Sep 27, 2026
…dle budget

Turns the red CI jobs on main green.

Electron Shell Tests: #13344's successorOwnsPort/reuse guard added six
identity-owner decisions (probeGatewayPortOwner + kirocrew/service/foreign/
unknown verdicts) that port-owner-self-asserted-identity.test.js did not yet
claim. Register the six as IDENTITY_SITES.

Frontend Tests: bnStyle.test.ts caps Bengali-digit debt at 8; two values added
today tipped it to 9. Convert their Bengali digits to Western.

Backend Tests (3.12,2): the pidfd fallback test (added by #14229) reds on any
runner whose kernel/seccomp refuses the raw pidfd_open syscall. Decide the
host capability with a witness independent of the production constant and skip
only when that witness fails; a broken ctypes path still fails.

Bundle Size Gate: chunk 't' (the always-loaded i18n fallback + highlight
shared chunk) drifted 28 B over its 955 KB ceiling from feature strings merged
since #12927 set it (#12924, #14097). The growth is irreducible catalog
strings; bump the budget to 965 KB (~1% over the 955.03 KB measurement) with a
comment attributing the drift, per the gate's documented convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants