Skip to content

fix(sidebar): tighten the folder indent so nested titles get more room - #14717

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/sidebar-folder-indent
Sep 29, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/sidebar-folder-indent

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Session titles inside sidebar folders start much closer to the left edge, so more of each title fits.

Every folder level pushes its sessions 19px to the right. The folder's vertical guide line sits where the session text starts, and a full row pad follows it, so each level pays for its indent twice. Two or three levels deep, a narrow sidebar truncates most session titles.

Why it matters

Anyone who files sessions into folders reads titles through the sidebar all day. Deep folders are where people keep the most sessions, and that is where titles get cut shortest.

Not a goal

  • Changing the folder header's content, icons, menus, drag and drop, or the sticky header behavior.
  • Changing the session row's contents or the recency tint.
  • Reworking the Members page, which only shares the root row pad.

What changed (motivation → approach → change)

Session titles inside folders now start up to 32px further left, because each folder level costs 10px of indent instead of 19px.

main this PR
cost of one folder level 19px 10px
session text, top level 259 255
session text in a folder 278 264
in a subfolder 297 274
three levels deep 316 284

x positions are CSS px, measured on the built dashboard with website/scripts/capture-folder-glyph.mjs under MEASURE=1.

The guide line now runs inside the standard left pad, under the folder icon, instead of on the session text column. The folder icon hangs into the left gutter like a file tree. The folder name still lines up exactly with the titles of its sessions at every depth, so the text column reads straight down. That icon-on-text-column rule is the one alignment rule dropped; keeping it forced every level to cost at least the icon plus its gap. The folder icon shrinks from 14px to 12px and its gap to the name from 5px to 4px, so the header's icon plus gap costs 16px instead of 19px and the name still lands on its sessions' text.

Rows inside a folder use a 9px left pad instead of 10px. The recency tint paints a stripe up to 7px wide at the row's left edge, and 9px keeps 2px between that stripe and the title. The in-folder pads live in FOLDER_ROW_PAD_CLS in ChatSidebar.tsx, shared by the list view's FOLDER_BODY_CLS and the board view's BOARD_FOLDER_BODY_CLS, so the row component is unchanged. Each view puts a folder's rows on that folder's name. The row divider, the "N dormant" toggle, the empty-folder "new chat" button, the "N hidden folders" reveal row and the pinned divider follow the same column through small data- hooks.

The shared root row pad in listShell.ts goes from 14px to 10px, which also moves the Members roster 4px left. The roster's team indent in MembersPage.tsx drops from pl-7 to pl-6, so team rows keep their 14px indent over ungrouped rows. The flat list's "Today"/"Yesterday" date header drops from px-3 to pl-2 pr-3, so it still sits 2px left of the session titles it labels, as on main.

The capture script uses a fixed crop and dates its fixture sessions to now, so before and after frames line up and the sessions render instead of folding into dormant rows.

Backwards compatibility

Compatible: only spacing classes and an exported class constant change; no prop, API, or stored setting changes.

Tests

  • ChatSidebar.folderAlignment.test.tsx pins the geometry in both views: the folder name sits on its sessions' text column at every depth, each list level costs 10px, the tint gap is 2px, and both body classes carry every shared in-folder pad.
  • playwright/sidebar-folder-alignment.spec.ts measures the rendered sidebar in the offline E2E gate: the connector runs under the folder glyph, the name sits on its sessions' text, the glyph hangs 7px left of root-lane text and 6px left inside a folder, and each level adds exactly 10px.
  • ChatSidebar.boardFolderCreateInTab.test.tsx checks a rendered board folder body uses BOARD_FOLDER_BODY_CLS and its empty-folder button carries the pad hook.
  • listShellParity.test.ts pins ROW_BOX_CLS and asserts the Members team indent stays 14px over it; ChatSidebar.statusMarker.test.tsx pins the root row pad.

Manual verification

Rendered the built dashboard with the capture script against this branch and origin/main, with the same fixture and crop, and measured every x position in the table above. A second fixture set the recency tint count to 5 so the newest session sits inside a folder with the full 7px stripe, added dormant sessions to an open folder, and gave the Members roster one team. On that render the title starts 2px after the stripe and the "2 dormant sessions hidden" toggle's chevron sits on the session text column (x 264), with its label after the chevron as on main. A third fixture rendered both views with pinned sessions in the root lane and inside a folder, plus an expanded empty folder. In the list view the pinned dividers sit at 253 (root) and 262 (in folder), 2px inside the row text at 255 and 264, and the empty folder's "new chat" label sits on its folder name at 264. In the board view the folder rows, the pinned divider and the "new chat" label land on the board folder name column, with the dividers again 2px inside the row text. A fourth fixture hid one root folder and one nested folder with the folder filter; both "1 hidden folder" rows start their chevron on the session text column (255 at the root, 264 inside the folder).

Screenshots / video

Same fixture and same crop. Nested folders to depth 3.

Before (main):

Sidebar on main: nested folders, each level indented 19px

After:

Sidebar on this branch: same folders, each level indented 10px

Recency tint, dormant toggle and Members roster

Newest session inside a folder with the widest (7px) recency tint, and a folder with two dormant sessions hidden:

Sidebar with recency tint count 5 and a folder showing its 2 dormant sessions hidden toggle

Close-up of an in-folder row with the 7px tint stripe and a 2px gap before the title

Crew Members roster with one team, after the shared row-pad change:

Crew Members roster with an Ops team of two indented crewmates and one ungrouped crewmate

Board view with a folder of sessions (one pinned), an expanded empty folder, and pinned sessions in the root lane:

Board view column: folder Kiro with a pinned session, a pinned divider and two sessions aligned on the folder name; empty folder showing its New chat row; pinned root session and divider

The same fixture in the list view:

List view with pinned sessions in a folder and the root lane, their pinned dividers, and an expanded empty folder with its New chat row

The "N hidden folders" reveal row with one root folder and one nested folder hidden by the folder filter. Its chevron sits on the session text column in both places (x 255 at the root, 264 inside the folder):

List view with a folder filter hiding one nested folder and one root folder, each announced by a 1 hidden folder row aligned with the session text

The flat list sorted by date, with "Today" and "Yesterday" headers over root-lane rows. Each header's text starts at x 253, 2px left of the session titles at 255, the same relation it had on main:

Flat list with Today and Yesterday date headers, each 2px left of the session titles below it

Related Issues

no linked issue: user-reported sidebar readability request.

Pattern harvest

Not generalizable: a spacing choice in one component, not a defect class.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Pearcekieser
Pearcekieser requested a review from a team September 28, 2026 15:04
@Pearcekieser
Pearcekieser requested a review from a team as a code owner September 28, 2026 15:04
@github-actions github-actions Bot added the fork Pull request from a fork (external contributor) label Sep 28, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Intent: Give session titles inside sidebar folders more horizontal room by cutting the indent each folder level adds, while keeping folder names lined up with their sessions' titles.
Not a goal: Changing folder header content, menus, drag and drop, sticky headers, the recency tint, or any row contents.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed b92e91b8a8d3061c2739b1dd73d9d294211de9b4 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b92e91b

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — ✅ PASS

Premise-level review of b92e91b8a8d3061c2739b1dd73d9d294211de9b4 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

The dropped pin — "that equality is the mechanism, not a coincidence" (glyph on the text column) — is reversed openly; a human should eyeball the new 6px glyph outdent before merge.

The reversal is declared ("That icon-on-text-column rule is the one alignment rule dropped") and grounded in a measured cost: the base classes (ml-3 + border + pl-1 + row pl-3.5) confirm each level paid 19px twice-over. The root row-pad change (ROW_BOX_CLS 14→10) reaches beyond "titles inside folders", but it is load-bearing — a 12px glyph at pl-[3px] spans to x 15, so a 14px root content column would overlap it — and its two off-goal consumers (MembersPage, TeamGroupHeader; grep ROW_BOX_CLS, 3 consuming components) are compensated or move harmlessly. No docs/decisions entry covers sidebar indent or the row pad (grepped sidebar|folder|indent|row pad|roster: one hit, the "New" button label).

What this change ships

Inventory (10 items) — 8 justified

Intent: FIX — reclaim the doubled per-level folder indent so nested session titles stop truncating.

  1. Session titles inside folders start up to 32px further left (10px per level, was 19px) — justified
  2. Folder glyph hangs into the left gutter instead of sitting on the session text column — justified
  3. Folder icon shrinks 14→12px with a 4px gap so the name stays on its sessions' text — justified
  4. Every root-lane session row moves 4px left (shared row pad 14→10) — justified
  5. Members roster moves 4px left, team indent compensated to stay 14px — rides along (shared ROW_BOX_CLS, declared)
  6. Board-view folder rows now align to the board folder's name (was flush connector) — justified
  7. Flat-list date headers keep their 2px outdent over titles — justified
  8. Pinned divider, dormant toggle, empty-folder button and hidden-folders reveal follow the in-folder column via data hooks; the reveal row loses its compounding inline per-depth pad — justified
  9. Capture script: fixed crop and fixture dates rebased to now — rides along (measurement tooling for the fix)
  10. Three exported class constants (FOLDER_ROW_PAD_CLS, FOLDER_BODY_CLS, BOARD_FOLDER_BODY_CLS) importable elsewhere — justified

[FIRST-PRINCIPLES-REVIEWED] b92e91b

Description read

[DESCRIPTION-READ] 887ea02739b256490935abe0ead4b88c97e5dae2a7e4dbe7169a0d785f801dfb

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — 🟡 CONCERNS

UX-level review of b92e91b8a8d3061c2739b1dd73d9d294211de9b4 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No first-time reader has judged whether the tighter 10px indent and the outdented, smaller folder glyph still read as nesting; every surface is shown, none cold-read.

Watch

  • Every screenshot is dark-theme. The widest recency tint leaves only 2px between the accent stripe and the title (attachment-04, [&_.session-row]:pl-[9px] / "9 keeps 2px"); on the light theme that stripe-to-text crowding is unverified. Frequency: every recent session, all day; impact: friction, not failure. Smallest fix: one light-theme capture of the tint fixture.
  • The folder glyph drops 14px→12px and hangs alone in the gutter (FolderGlyph … size={12}), so the only collapse-state indicator gets smaller on a daily-use surface; attachment-02 reads fine at depth 3, but a human should confirm open/closed is still distinguishable at a glance on a 100%-scale display. Frequency: constant; impact: minor scanning cost; deliberate trade for title room.

[UX-REVIEWED] b92e91b

Description read

[DESCRIPTION-READ] 88018537ecb74525fa438eea364fdffd3aa41d4eb6ab94582b4aee58c29173c2

That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of b92e91b8a8d3061c2739b1dd73d9d294211de9b4 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify from the before/after shots that folders reading as tree-outdents (glyph in the gutter) — the one alignment rule this deliberately drops — is wanted.

Suggestions

  • The per-level cost now diverges between views (list 10px, board 16px) because the board header keeps its own 11px-glyph/gap-2 geometry; if board folders ever nest deep, unifying the two headers on the list algebra is the follow-up that keeps one constant true everywhere.

[DESIGN-REVIEWED] b92e91b

Description read

[DESCRIPTION-READ] 0c01003a91b0d99179e193eaae50c2b62aab928260ea93390957b261d6862c90

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed b92e91b8a8d3061c2739b1dd73d9d294211de9b4 via the fork AI-review pipeline; updated in place on each push.

Review details

No blocking defects; one stale invariant left behind.

FINDING — website/src/pages/ChatSidebar.tsx:1715 — the FOLDER_BODY_INSET_PX docstring still asserts the header's own pad has to be \D + ml-3` to keep the folder glyph on the connector line, but the PR sets the header to pl-[3px](P=3) againstD + ml-1= 6 and replaces that equality with the containmentP <= D + M < P + G, so the exported constant the alignment test imports documents a rule its own code no longer follows → Fix: rewrite that sentence in the same commit to the new relation (header pad P = 3, body ml-1, guide 1 as P <= D + M < P + G) and drop the ml-3` reference.

[OPUS-REVIEWED] b92e91b

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • CROP_X env override has no consumer

fixed in 30df6f9: the crop x in website/scripts/capture-folder-glyph.mjs is a literal 200; the process.env.CROP_X override and its comment are deleted.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • 1px between a max-rank recency tint stripe and in-folder row text

fixed in 30df6f9: in-folder rows use a 9px pad (FOLDER_ROW_PAD_CLS), so a 7px stripe leaves 2px before the title; the folder header pad is 3px so folder names stay on their sessions' text column.
Verified on a render with recent_tint_count 5 and the newest session inside a folder; the close-up is in the PR body under "Recency tint, dormant toggle and Members roster".

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • board-view folder body kept main's spacing, so its rows drifted from the list view

fixed in 30df6f9: the board body is BOARD_FOLDER_BODY_CLS (ml-2 pl-[5px] plus the shared FOLDER_ROW_PAD_CLS), which lands board rows on the board folder name (x 25 from the header edge). The board header is 6px + 11px glyph + 8px gap, so reusing FOLDER_BODY_CLS would have put them 6px left of it.
Locked by ChatSidebar.folderAlignment.test.tsx (board arithmetic) and ChatSidebar.boardFolderCreateInTab.test.tsx (rendered body class).

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • empty-folder affordance and pinned divider miss the in-folder row column

fixed in 30df6f9: the empty-folder "new chat" button carries data-folder-new-chat and the pinned divider data-pinned-divider; FOLDER_ROW_PAD_CLS sets them to the 9px row pad and 7px (row pad minus 2, main's relation). The root-lane divider is ml-2 mr-3, restoring main's 2px-inside relation.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Members team indent is a hardcoded pl-7 that no longer tracks ROW_BOX_CLS

fixed in 30df6f9: MembersPage.tsx indented rows use pl-6 (24 = the 10px ROW_BOX_CLS pad + 14), so team rows keep main's 14px indent. listShellParity.test.ts now asserts that difference is 14.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Evidence the UX and Design lanes asked for on cc1e3a40e9d4 is now in the PR body, under "Recency tint, dormant toggle and Members roster":

  • the Crew Members roster after the shared row-pad change, with one team (Ops) so the indented rows and the team header show;
  • an open folder with its "2 dormant sessions hidden" toggle, whose label sits on the session text column (x 264);
  • a close-up of an in-folder row with the widest (7px) recency tint.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 28, 2026
@Pearcekieser

Pearcekieser commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor Author
  • size={12} changes folder-header icons despite icons being explicitly out of scope

rebutted: the 12px glyph is part of this PR's indent mechanism, not an icon change. The body's "What changed" names it ("The folder icon is 12px with a 4px gap to its name"); the "Not a goal" line excludes changing which icon a folder shows, not its box size.
The per-level cost is the glyph plus its gap to the name. Keeping 14px with a 2px gap holds that sum at 16, but a 2px gap tried during development read cramped on the render, and the folder name then crowds its own icon on every row.
Reverting to 14px would also move every folder name 2px right, off its sessions' text column (guide 2) at every depth, unless the header pad went negative.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Board-view folder geometry verified only by class arithmetic, never rendered

fixed (evidence, no code change): the PR body now carries a board-view render of this revision with a folder of sessions, a pinned session and divider, an expanded empty folder, and root-lane pinned rows.
Measured on that render: in-folder row text 277, pinned divider 275 (2px inside), "new chat" label 277; root-lane text 262, divider 260. Folder rows and the empty-folder row sit on the board folder name column in the screenshot.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

The UX lane's evidence gaps on 30df6f951d (board-view folder body, pinned-session divider in the root lane and inside a folder, expanded empty folder) are now covered in the PR body under "Recency tint, dormant toggle and Members roster": one board-view render and one list-view render of the same fixture, with the measured x positions in "Manual verification". The review lanes only re-read the body on a push; the next push re-syncs on current main.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 28, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Accepted as stated. The folder icon now hangs in the gutter like a file tree, and I made that trade deliberately: keeping the icon on the text column forced every level to cost at least the icon plus its gap, 16 to 19px. The folder name still lands exactly on its sessions' titles at every depth, so the text column a reader scans hasn't moved. Only the icon moved. The icon and the name are still one toggle button, so the click target didn't shrink. A blind read with a first-time user needs a same-repo branch, which a fork PR can't provide, so I'm leaving that to the maintainers.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 29, 2026
…more room

The folder guide line now sits inside the standard row pad instead of adding its own full indent, so each folder level costs 10px instead of 19px. Session rows inside a folder use an 8px left pad.
@Pearcekieser
Pearcekieser force-pushed the fix/sidebar-folder-indent branch from a079e87 to b92e91b Compare September 29, 2026 16:15
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased onto main 0b83a2e1d4. The new head is b92e91b8a8. The rebase applied without conflicts and changes no behaviour.

On a079e87927, every review lane had finished. Opus and GPT had no findings. Design passed. UX and First Principles returned advisory concerns, and each one has a disposition comment above. The only blocking item was Backend Tests (Windows) shard 3, which failed test_slack_gateway_cron_exec_coverage.py::test_the_harness_can_observe_a_duplicate_at_all with "the harness cannot observe concurrency: peak 1". This PR touches no backend code, and that test passed 3 out of 3 times locally on that head. Fork contributors can't rerun jobs, so this push gives it a fresh run. tsc and 1,350 sidebar, list-shell and Members tests pass on the new head.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 29, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Accepted as a watch item. The folder glyph shrinks from 14px to 12px, and that is what brings the header's icon plus gap from 19px down to 16px so the folder name still lands on its sessions' titles. The open and closed states are still two different icons (open folder and closed folder), not one icon rotated, and the collapse control is still the whole icon-plus-name button, so the click target didn't shrink. The screenshots in the body show open and closed folders side by side at 12px. I'd welcome a human glance at a glance-distance read.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Accepted as a watch item. The 2px gap comes from geometry, not theme: the stripe is an inset box-shadow 7px wide (recencyTintShadow, pinned in recencyTint.test.ts), and the in-folder row pad is 9px. Both widths are identical in every theme, and the light theme changes only the stripe's colour and the row background. I tried a light-theme capture, but the stub harness kept the dark theme, so I have no light-theme render to attach. Whether 2px reads as crowded against a light background is a contrast question for a human pass, and 9px is the smallest pad that keeps any gap at all.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Agreed as a follow-up and left out of this PR. The board view keeps its own folder header geometry (11px glyph, gap-2), so its level cost stays 16px while the list view drops to 10px. This PR only makes board rows land on the board folder's name. Moving the board header onto the list's arithmetic would restyle the board lane, which is a separate change.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 29, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Spacing adds up (header pad 3 + glyph 12 + gap 4 = 2+4+1+3+9), each nesting level costs a flat 10px via FOLDER_BODY_CLS, TeamGroupHeader shares ROW_BOX_CLS so Members parity holds, flat-view date header keeps its 2px offset, header hit box unchanged. CSS only. Playwright spec measures real positions.

Non-blocking: 'Not a goal: changing the folder header's icons' but the glyph shrinks 14px to 12px; header pr-2.5 vs rows pr-3 leaves right-side controls 2px out of line; the hidden-folder reveal row now depends solely on the descendant selector, checked only by Playwright.

@iamwhatever
iamwhatever merged commit 620b390 into kirodotdev:main Sep 29, 2026
103 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 29, 2026
@Pearcekieser
Pearcekieser deleted the fix/sidebar-folder-indent branch September 30, 2026 00:45
@CrysisDeu

Copy link
Copy Markdown
Contributor

Reverting this PR. This breaks the designed indentation architecture of folders in Kiro Crew

CrysisDeu added a commit that referenced this pull request Oct 9, 2026
#14717 outdented the folder glyph off its connector line and cut the
folder header pad to 3px to tighten the per-level indent. The maintainer
saw the result on main and asked for the #3905 geometry back: the glyph
on the x of the border-l line that runs down under it, the folder header
on the same 14px pad as a session row, and a folder name on one edge
with the agent label, title and subtitle of the sessions inside it.

A plain revert conflicts in five places, so this restores the values on
top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1,
ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the
per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to
re-pad rows inside a 3px header. Measured on the built SPA: glyph box x
== connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane
content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the
same numbers #3905 recorded.

The geometry is recorded under docs/decisions/ so the
recorded-decisions-are-not-regressions rule blocks the next change.

Refs #18359
Reverts #14717
CrysisDeu added a commit that referenced this pull request Oct 9, 2026
#14717 outdented the folder glyph off its connector line and cut the
folder header pad to 3px to tighten the per-level indent. The maintainer
saw the result on main and asked for the #3905 geometry back: the glyph
on the x of the border-l line that runs down under it, the folder header
on the same 14px pad as a session row, and a folder name on one edge
with the agent label, title and subtitle of the sessions inside it.

A plain revert conflicts in five places, so this restores the values on
top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1,
ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the
per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to
re-pad rows inside a 3px header. Measured on the built SPA: glyph box x
== connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane
content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the
same numbers #3905 recorded.

The geometry is recorded under docs/decisions/ so the
recorded-decisions-are-not-regressions rule blocks the next change.

Refs #18359
Reverts #14717
CrysisDeu added a commit that referenced this pull request Oct 9, 2026
#14717 outdented the folder glyph off its connector line and cut the
folder header pad to 3px to tighten the per-level indent. The maintainer
saw the result on main and asked for the #3905 geometry back: the glyph
on the x of the border-l line that runs down under it, the folder header
on the same 14px pad as a session row, and a folder name on one edge
with the agent label, title and subtitle of the sessions inside it.

A plain revert conflicts in five places, so this restores the values on
top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1,
ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the
per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to
re-pad rows inside a 3px header. Measured on the built SPA: glyph box x
== connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane
content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the
same numbers #3905 recorded.

The geometry is recorded under docs/decisions/ so the
recorded-decisions-are-not-regressions rule blocks the next change.

Refs #18359
Reverts #14717
CrysisDeu added a commit that referenced this pull request Oct 9, 2026
#14717 outdented the folder glyph off its connector line and cut the
folder header pad to 3px to tighten the per-level indent. The maintainer
saw the result on main and asked for the #3905 geometry back: the glyph
on the x of the border-l line that runs down under it, the folder header
on the same 14px pad as a session row, and a folder name on one edge
with the agent label, title and subtitle of the sessions inside it.

A plain revert conflicts in five places, so this restores the values on
top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1,
ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the
per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to
re-pad rows inside a 3px header. Measured on the built SPA: glyph box x
== connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane
content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the
same numbers #3905 recorded.

The geometry is recorded under docs/decisions/ so the
recorded-decisions-are-not-regressions rule blocks the next change.

Refs #18359
Reverts #14717
CrysisDeu added a commit that referenced this pull request Oct 9, 2026
folder header pad to 3px to tighten the per-level indent. The maintainer
saw the result on main and asked for the #3905 geometry back: the glyph
on the x of the border-l line that runs down under it, the folder header
on the same 14px pad as a session row, and a folder name on one edge
with the agent label, title and subtitle of the sessions inside it.

A plain revert conflicts in five places, so this restores the values on
top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1,
ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the
per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to
re-pad rows inside a 3px header. Measured on the built SPA: glyph box x
== connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane
content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the
same numbers #3905 recorded.

The geometry is recorded under docs/decisions/ so the
recorded-decisions-are-not-regressions rule blocks the next change.

Refs #18359
Reverts #14717
CrysisDeu added a commit that referenced this pull request Oct 9, 2026
folder header pad to 3px to tighten the per-level indent. The maintainer
saw the result on main and asked for the #3905 geometry back: the glyph
on the x of the border-l line that runs down under it, the folder header
on the same 14px pad as a session row, and a folder name on one edge
with the agent label, title and subtitle of the sessions inside it.

A plain revert conflicts in five places, so this restores the values on
top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1,
ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the
per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to
re-pad rows inside a 3px header. Measured on the built SPA: glyph box x
== connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane
content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the
same numbers #3905 recorded.

The geometry is recorded under docs/decisions/ so the
recorded-decisions-are-not-regressions rule blocks the next change.

Refs #18359
Reverts #14717
buluoray pushed a commit that referenced this pull request Oct 10, 2026
folder header pad to 3px to tighten the per-level indent. The maintainer
saw the result on main and asked for the #3905 geometry back: the glyph
on the x of the border-l line that runs down under it, the folder header
on the same 14px pad as a session row, and a folder name on one edge
with the agent label, title and subtitle of the sessions inside it.

A plain revert conflicts in five places, so this restores the values on
top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1,
ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the
per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to
re-pad rows inside a 3px header. Measured on the built SPA: glyph box x
== connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane
content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the
same numbers #3905 recorded.

The geometry is recorded under docs/decisions/ so the
recorded-decisions-are-not-regressions rule blocks the next change.

Refs #18359
Reverts #14717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants