Repository navigation
fix(sidebar): tighten the folder indent so nested titles get more room - #14717
Conversation
|
Intent: Give session titles inside sidebar folders more horizontal room by cutting the indent each folder level adds, while keeping folder names lined up with their sessions' titles. |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The dropped pin — "that equality is the mechanism, not a coincidence" (glyph on the text column) — is reversed openly; a human should eyeball the new 6px glyph outdent before merge. The reversal is declared ("That icon-on-text-column rule is the one alignment rule dropped") and grounded in a measured cost: the base classes ( What this change shipsInventory (10 items) — 8 justifiedIntent: FIX — reclaim the doubled per-level folder indent so nested session titles stop truncating.
[FIRST-PRINCIPLES-REVIEWED] b92e91b Description read[DESCRIPTION-READ] 887ea02739b256490935abe0ead4b88c97e5dae2a7e4dbe7169a0d785f801dfb That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Fable 5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has judged whether the tighter 10px indent and the outdented, smaller folder glyph still read as nesting; every surface is shown, none cold-read. Watch
[UX-REVIEWED] b92e91b Description read[DESCRIPTION-READ] 88018537ecb74525fa438eea364fdffd3aa41d4eb6ab94582b4aee58c29173c2 That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify from the before/after shots that folders reading as tree-outdents (glyph in the gutter) — the one alignment rule this deliberately drops — is wanted. Suggestions
[DESIGN-REVIEWED] b92e91b Description read[DESCRIPTION-READ] 0c01003a91b0d99179e193eaae50c2b62aab928260ea93390957b261d6862c90 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo blocking defects; one stale invariant left behind. FINDING — website/src/pages/ChatSidebar.tsx:1715 — the [OPUS-REVIEWED] b92e91b |
cc1e3a4 to
30df6f9
Compare
|
|
|
|
|
|
Evidence the UX and Design lanes asked for on
|
|
|
|
The UX lane's evidence gaps on |
|
Accepted as stated. The folder icon now hangs in the gutter like a file tree, and I made that trade deliberately: keeping the icon on the text column forced every level to cost at least the icon plus its gap, 16 to 19px. The folder name still lands exactly on its sessions' titles at every depth, so the text column a reader scans hasn't moved. Only the icon moved. The icon and the name are still one toggle button, so the click target didn't shrink. A blind read with a first-time user needs a same-repo branch, which a fork PR can't provide, so I'm leaving that to the maintainers. |
…more room The folder guide line now sits inside the standard row pad instead of adding its own full indent, so each folder level costs 10px instead of 19px. Session rows inside a folder use an 8px left pad.
a079e87 to
b92e91b
Compare
|
Rebased onto main On |
|
Accepted as a watch item. The folder glyph shrinks from 14px to 12px, and that is what brings the header's icon plus gap from 19px down to 16px so the folder name still lands on its sessions' titles. The open and closed states are still two different icons (open folder and closed folder), not one icon rotated, and the collapse control is still the whole icon-plus-name button, so the click target didn't shrink. The screenshots in the body show open and closed folders side by side at 12px. I'd welcome a human glance at a glance-distance read. |
|
Accepted as a watch item. The 2px gap comes from geometry, not theme: the stripe is an inset |
|
Agreed as a follow-up and left out of this PR. The board view keeps its own folder header geometry (11px glyph, |
iamwhatever
left a comment
There was a problem hiding this comment.
Reviewed. Spacing adds up (header pad 3 + glyph 12 + gap 4 = 2+4+1+3+9), each nesting level costs a flat 10px via FOLDER_BODY_CLS, TeamGroupHeader shares ROW_BOX_CLS so Members parity holds, flat-view date header keeps its 2px offset, header hit box unchanged. CSS only. Playwright spec measures real positions.
Non-blocking: 'Not a goal: changing the folder header's icons' but the glyph shrinks 14px to 12px; header pr-2.5 vs rows pr-3 leaves right-side controls 2px out of line; the hidden-folder reveal row now depends solely on the descendant selector, checked only by Playwright.
|
Reverting this PR. This breaks the designed indentation architecture of folders in Kiro Crew |
#14717 outdented the folder glyph off its connector line and cut the folder header pad to 3px to tighten the per-level indent. The maintainer saw the result on main and asked for the #3905 geometry back: the glyph on the x of the border-l line that runs down under it, the folder header on the same 14px pad as a session row, and a folder name on one edge with the agent label, title and subtitle of the sessions inside it. A plain revert conflicts in five places, so this restores the values on top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1, ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to re-pad rows inside a 3px header. Measured on the built SPA: glyph box x == connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the same numbers #3905 recorded. The geometry is recorded under docs/decisions/ so the recorded-decisions-are-not-regressions rule blocks the next change. Refs #18359 Reverts #14717
#14717 outdented the folder glyph off its connector line and cut the folder header pad to 3px to tighten the per-level indent. The maintainer saw the result on main and asked for the #3905 geometry back: the glyph on the x of the border-l line that runs down under it, the folder header on the same 14px pad as a session row, and a folder name on one edge with the agent label, title and subtitle of the sessions inside it. A plain revert conflicts in five places, so this restores the values on top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1, ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to re-pad rows inside a 3px header. Measured on the built SPA: glyph box x == connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the same numbers #3905 recorded. The geometry is recorded under docs/decisions/ so the recorded-decisions-are-not-regressions rule blocks the next change. Refs #18359 Reverts #14717
#14717 outdented the folder glyph off its connector line and cut the folder header pad to 3px to tighten the per-level indent. The maintainer saw the result on main and asked for the #3905 geometry back: the glyph on the x of the border-l line that runs down under it, the folder header on the same 14px pad as a session row, and a folder name on one edge with the agent label, title and subtitle of the sessions inside it. A plain revert conflicts in five places, so this restores the values on top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1, ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to re-pad rows inside a 3px header. Measured on the built SPA: glyph box x == connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the same numbers #3905 recorded. The geometry is recorded under docs/decisions/ so the recorded-decisions-are-not-regressions rule blocks the next change. Refs #18359 Reverts #14717
#14717 outdented the folder glyph off its connector line and cut the folder header pad to 3px to tighten the per-level indent. The maintainer saw the result on main and asked for the #3905 geometry back: the glyph on the x of the border-l line that runs down under it, the folder header on the same 14px pad as a session row, and a folder name on one edge with the agent label, title and subtitle of the sessions inside it. A plain revert conflicts in five places, so this restores the values on top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1, ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to re-pad rows inside a 3px header. Measured on the built SPA: glyph box x == connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the same numbers #3905 recorded. The geometry is recorded under docs/decisions/ so the recorded-decisions-are-not-regressions rule blocks the next change. Refs #18359 Reverts #14717
folder header pad to 3px to tighten the per-level indent. The maintainer saw the result on main and asked for the #3905 geometry back: the glyph on the x of the border-l line that runs down under it, the folder header on the same 14px pad as a session row, and a folder name on one edge with the agent label, title and subtitle of the sessions inside it. A plain revert conflicts in five places, so this restores the values on top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1, ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to re-pad rows inside a 3px header. Measured on the built SPA: glyph box x == connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the same numbers #3905 recorded. The geometry is recorded under docs/decisions/ so the recorded-decisions-are-not-regressions rule blocks the next change. Refs #18359 Reverts #14717
folder header pad to 3px to tighten the per-level indent. The maintainer saw the result on main and asked for the #3905 geometry back: the glyph on the x of the border-l line that runs down under it, the folder header on the same 14px pad as a session row, and a folder name on one edge with the agent label, title and subtitle of the sessions inside it. A plain revert conflicts in five places, so this restores the values on top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1, ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to re-pad rows inside a 3px header. Measured on the built SPA: glyph box x == connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the same numbers #3905 recorded. The geometry is recorded under docs/decisions/ so the recorded-decisions-are-not-regressions rule blocks the next change. Refs #18359 Reverts #14717
folder header pad to 3px to tighten the per-level indent. The maintainer saw the result on main and asked for the #3905 geometry back: the glyph on the x of the border-l line that runs down under it, the folder header on the same 14px pad as a session row, and a folder name on one edge with the agent label, title and subtitle of the sessions inside it. A plain revert conflicts in five places, so this restores the values on top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1, ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to re-pad rows inside a 3px header. Measured on the built SPA: glyph box x == connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the same numbers #3905 recorded. The geometry is recorded under docs/decisions/ so the recorded-decisions-are-not-regressions rule blocks the next change. Refs #18359 Reverts #14717
Problem / Motivation
Goal: Session titles inside sidebar folders start much closer to the left edge, so more of each title fits.
Every folder level pushes its sessions 19px to the right. The folder's vertical guide line sits where the session text starts, and a full row pad follows it, so each level pays for its indent twice. Two or three levels deep, a narrow sidebar truncates most session titles.
Why it matters
Anyone who files sessions into folders reads titles through the sidebar all day. Deep folders are where people keep the most sessions, and that is where titles get cut shortest.
Not a goal
What changed (motivation → approach → change)
Session titles inside folders now start up to 32px further left, because each folder level costs 10px of indent instead of 19px.
x positions are CSS px, measured on the built dashboard with
website/scripts/capture-folder-glyph.mjsunderMEASURE=1.The guide line now runs inside the standard left pad, under the folder icon, instead of on the session text column. The folder icon hangs into the left gutter like a file tree. The folder name still lines up exactly with the titles of its sessions at every depth, so the text column reads straight down. That icon-on-text-column rule is the one alignment rule dropped; keeping it forced every level to cost at least the icon plus its gap. The folder icon shrinks from 14px to 12px and its gap to the name from 5px to 4px, so the header's icon plus gap costs 16px instead of 19px and the name still lands on its sessions' text.
Rows inside a folder use a 9px left pad instead of 10px. The recency tint paints a stripe up to 7px wide at the row's left edge, and 9px keeps 2px between that stripe and the title. The in-folder pads live in
FOLDER_ROW_PAD_CLSinChatSidebar.tsx, shared by the list view'sFOLDER_BODY_CLSand the board view'sBOARD_FOLDER_BODY_CLS, so the row component is unchanged. Each view puts a folder's rows on that folder's name. The row divider, the "N dormant" toggle, the empty-folder "new chat" button, the "N hidden folders" reveal row and the pinned divider follow the same column through smalldata-hooks.The shared root row pad in
listShell.tsgoes from 14px to 10px, which also moves the Members roster 4px left. The roster's team indent inMembersPage.tsxdrops frompl-7topl-6, so team rows keep their 14px indent over ungrouped rows. The flat list's "Today"/"Yesterday" date header drops frompx-3topl-2 pr-3, so it still sits 2px left of the session titles it labels, as on main.The capture script uses a fixed crop and dates its fixture sessions to now, so before and after frames line up and the sessions render instead of folding into dormant rows.
Backwards compatibility
Compatible: only spacing classes and an exported class constant change; no prop, API, or stored setting changes.
Tests
ChatSidebar.folderAlignment.test.tsxpins the geometry in both views: the folder name sits on its sessions' text column at every depth, each list level costs 10px, the tint gap is 2px, and both body classes carry every shared in-folder pad.playwright/sidebar-folder-alignment.spec.tsmeasures the rendered sidebar in the offline E2E gate: the connector runs under the folder glyph, the name sits on its sessions' text, the glyph hangs 7px left of root-lane text and 6px left inside a folder, and each level adds exactly 10px.ChatSidebar.boardFolderCreateInTab.test.tsxchecks a rendered board folder body usesBOARD_FOLDER_BODY_CLSand its empty-folder button carries the pad hook.listShellParity.test.tspinsROW_BOX_CLSand asserts the Members team indent stays 14px over it;ChatSidebar.statusMarker.test.tsxpins the root row pad.Manual verification
Rendered the built dashboard with the capture script against this branch and
origin/main, with the same fixture and crop, and measured every x position in the table above. A second fixture set the recency tint count to 5 so the newest session sits inside a folder with the full 7px stripe, added dormant sessions to an open folder, and gave the Members roster one team. On that render the title starts 2px after the stripe and the "2 dormant sessions hidden" toggle's chevron sits on the session text column (x 264), with its label after the chevron as on main. A third fixture rendered both views with pinned sessions in the root lane and inside a folder, plus an expanded empty folder. In the list view the pinned dividers sit at 253 (root) and 262 (in folder), 2px inside the row text at 255 and 264, and the empty folder's "new chat" label sits on its folder name at 264. In the board view the folder rows, the pinned divider and the "new chat" label land on the board folder name column, with the dividers again 2px inside the row text. A fourth fixture hid one root folder and one nested folder with the folder filter; both "1 hidden folder" rows start their chevron on the session text column (255 at the root, 264 inside the folder).Screenshots / video
Same fixture and same crop. Nested folders to depth 3.
Before (main):
After:
Recency tint, dormant toggle and Members roster
Newest session inside a folder with the widest (7px) recency tint, and a folder with two dormant sessions hidden:
Crew Members roster with one team, after the shared row-pad change:
Board view with a folder of sessions (one pinned), an expanded empty folder, and pinned sessions in the root lane:
The same fixture in the list view:
The "N hidden folders" reveal row with one root folder and one nested folder hidden by the folder filter. Its chevron sits on the session text column in both places (x 255 at the root, 264 inside the folder):
The flat list sorted by date, with "Today" and "Yesterday" headers over root-lane rows. Each header's text starts at x 253, 2px left of the session titles at 255, the same relation it had on main:
Related Issues
no linked issue: user-reported sidebar readability request.
Pattern harvest
Not generalizable: a spacing choice in one component, not a defect class.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)