Skip to content

fix(sidebar): restore the folder geometry decided in #3905 - #18362

Merged
buluoray merged 1 commit into
mainfrom
fix/folder-indent-restore-3905
Oct 10, 2026
Merged

buluoray merged 1 commit into
mainfrom
fix/folder-indent-restore-3905

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The sidebar folder glyph sits on its connector line again, with the folder geometry the maintainer set and measured in #3905.

#14717 outdented the sidebar folder glyph off its connector line (3px left of it) and cut the folder header pad from 14px to 3px to tighten the per-level indent. The maintainer saw this on main and asked for the #3905 geometry back (#18359).

Why it matters

The glyph on the line is the picture the tree view draws: a glyph hanging in the gutter next to a line that does not reach it reads as two unrelated marks, at every depth. The maintainer decided this geometry once; without a recorded decision the next indent change can move it again.

Not a goal

What changed (motivation → approach → change)

Part main (#14717) this PR (#3905)
folder header pad pl-[3px] pr-2.5 px-3.5
folder glyph / gap 12px, gap-[4px] 14px, gap-[5px]
list folder body ml-1 pl-[3px] + FOLDER_ROW_PAD_CLS ml-3 pl-1
board folder body ml-2 pl-[5px] + FOLDER_ROW_PAD_CLS ml-3 pl-1 (rows at the x of #3905's ml-4; the 4px pad clears FolderRail)
ROW_BOX_CLS pl-2.5 pl-3.5
row divider / dormant toggle / empty-folder "New chat" / hidden-folders reveal / pinned divider / flat-view date header 10px column 14px column
MembersPage grouped-row indent pl-6 pl-7 (tracks the row pad)
  • FOLDER_ROW_PAD_CLS is removed: it only existed to re-pad rows inside a 3px header. The data-* hooks it targeted stay (used by tests and by the capture harness below).
  • The hidden-folders reveal row takes pl-3.5 (the content column) instead of fix(sidebar): tighten the folder indent so nested titles get more room #14717's pl-2.5.
  • FOLDER_BODY_CLS keeps relative for FolderRail (feat(sidebar): collapse a folder by clicking its connector line #15442): its hit strip spans -5..3 of the body's padding box and the body pad is now 4px, so it still never overlaps a row.
  • BOARD_FOLDER_BODY_CLS is ml-3 pl-1, not fix(sidebar): put folder rows and session rows on one left edge #3905's byte-for-byte ml-4: fix(sidebar): put folder rows and session rows on one left edge #3905 predates FolderRail, and a body with no left pad puts the rail's strip over the first 3px of every board row, where a click folds the folder instead of opening the session. ml-3 + 1px border + pl-1 lands the rows at the same x (17) and gives the rail the list body's 4px clearance. Pinned by a new test and by the harness's elementFromPoint probe (below).
  • docs/decisions/2026-10-09-folder-glyph-sits-on-its-connector-line.md + README row. @CrysisDeu: per docs/decisions/README.md rule 4, please restate the decision in a comment on this PR (one line is enough, e.g. "Decided: the folder glyph sits on its connector line and folder rows share the session rows' 14px pad; fix(sidebar): tighten the folder indent so nested titles get more room #14717's indent is reverted"). The entry cites this PR as the on-record artifact.
  • TeamGroupHeader.tsx: the team header shares ROW_BOX_CLS, so its 4px wider pad squeezed a header that had zero slack at the default roster width, and flex shrank the name and the count together ("Inta…" / "1 crewma…"): flex shrinks every shrinkable item in proportion to its basis, so even a sub-pixel squeeze of the name becomes an ellipsis. The name is now shrink-0 max-w-[calc(100%-100px)] and the rule min-w-0, which is the order the component's own comment promised (rule, then count, then name). The cap is the header's width less what must stay beside the name (icon 13 + four gaps 32 + "Open team" ~55), so it bites only under real width pressure: at any roster width a name may take every pixel the count and the rule can give up, and a long name truncates only once the header is narrower than it. (An earlier revision used max-w-[40%], which clipped names of ~15+ characters at every width beside an empty rule.) Defect in code this PR changes, so in scope; the header's geometry (pad, icon, gap) is untouched.
  • website/scripts/capture-folder-indent-surfaces.mjs: a capture harness for the surfaces beyond the folder header (list rows, flat view, board, Crewmates), with a MEASURE probe. It also hit-tests the first three pixels of a board folder row (elementFromPoint must land in the row, never on .folder-rail) and checks every team name at the 264 and 400 roster widths (an ellipsis is allowed only when the name is wider than the header's budget). It produced the evidence below; run against head 5c36791bfc both probes fail, against this head both pass.

Backwards compatibility

Compatible: Tailwind class values and one exported constant (FOLDER_ROW_PAD_CLS, no reader outside ChatSidebar.tsx and its tests) change; no API, schema or stored data changes.

Removes nothing: FOLDER_ROW_PAD_CLS had no reader outside the file that defined it; the data-* hooks it targeted stay in the DOM.

Tests

  • ChatSidebar.folderAlignment.test.tsx and playwright/sidebar-folder-alignment.spec.ts back to their fix(sidebar): put folder rows and session rows on one left edge #3905 versions byte-for-byte: they pin px-3.5 on the header, ml-3 pl-1 on the body, pl-3.5 on the row and the three alignment guides at every depth.
  • The fix(sidebar): tighten the folder indent so nested titles get more room #14717 hunks in ChatSidebar.boardFolderCreateInTab, ChatSidebar.flatFolderFilter, ChatSidebar.flatView, ChatSidebar.statusMarker and listShellParity reversed, so each asserts the restored class.
  • ChatSidebar.boardFolderCollapse.test.tsx: the board folder body carries relative border-l pl-1 ml-3 and not ml-4, so the rail's hit strip never covers a row.
  • DECISIONS_BASE_REF=origin/main scripts/check_decisions_history.py: 6 entries intact. scripts/docs-lint.sh: passed.

Manual verification

Built SPA, capture-folder-glyph.mjs MEASURE=1 and capture-folder-indent-surfaces.mjs (its MEASURE lines) against origin/main and this branch; x in CSS px.

Folder header (as recorded in #3905):

x main (#14717) this PR #3905 recorded
root glyph box 248 259 259
root connector line 251 259 —
glyph − connector −3 0 0 (guide 1)
root folder name 264 278 278
root-lane session text 255 259 259
depth 1 glyph / connector 258 / 261 278 / 278 278
depth 1 session text 264 278 278
depth 2 glyph / connector 268 / 271 297 / 297 297
depth 3 session text 284 316 316

The other surfaces, each on the same content column as the rows beside it:

x main (#14717) this PR
list: row text inside "Kiro" / row divider / empty-folder "New chat" text / hidden-folders reveal chevron 264 / 264 / 264 / 264 278 / 278 / 278 / 278
list: pinned divider inside "Kiro" (2px left of the column) 262 276
list: nested folder glyph == sibling row text 258 ≠ 264 278 = 278 (guide 3)
flat: row text / pinned divider 255 / 253 259 / 257
board: root-lane row text / folder row text / nested folder row text 262 / 277 / 293 266 / 285 / 304
Crewmates: team header icon / indented crewmate row 255 / 269 259 / 273

Glyph box x equals connector x at every depth (0px apart); every header number matches what #3905 recorded.

Screenshots / video

Folder header, list view (before left, after right):

folder tree before and after

root folder head at 4x

List view rows: pinned divider, row divider, dormant toggle, empty-folder "New chat in Archive", hidden-folders reveal at the root and inside "Kiro", nested folder body:

list rows before and after

Flat view: date headers and the pinned divider:

flat view before and after

The same flat view at 4x (first date header, pinned row, pinned divider, first automatic row): the 4px shift of header text, row text and divider.

flat view at 4x before and after

Board view: folder bodies nested inside a column:

board view before and after

Crewmates page grouped by team (two teams and a "No team" group), the Meet CrewMates first-run flow dismissed: team header rows and their indented crewmate rows:

crewmates grouped rows before and after

Team header name cap, two long team names ("Docs and support" 99px, "Platform reliability engineering" 175px), head 5c36791bfc (left, max-w-[40%]) vs this head (right). Default roster 264: the 40% cap clipped "Docs and support" to 80px beside an empty rule; now it reads whole, and only the 175px name truncates, because the header has 100px for a name there:

crewmates team names at roster 264, before and after

Wide roster 400: the 40% cap still clipped the 175px name to 134px; now every name reads whole:

crewmates team names at roster 400, before and after

Board rail clearance has no visible frame (the rail is transparent at rest); the harness probe is the evidence: on 5c36791bfc elementFromPoint at x+0.5/1.5/2.5 of a folder row returns .folder-rail three times, on this head it returns the row three times.

Related Issues

Closes #18359. Reverts the geometry of #14717.

Pattern harvest

Rule candidate: review-prompt
Pattern: a layout value the maintainer measured and recorded in a PR is moved by a later PR without that record being read; the decision file now exists so recorded-decisions-are-not-regressions can block it.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 9, 2026 06:19
@CrysisDeu
CrysisDeu requested a review from dodgeblaster October 9, 2026 06:19
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 9, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/folder-indent-restore-3905 branch from 5dd0f95 to 1ad854c Compare October 9, 2026 06:19
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of da83400ca74fa82fb539518c0c1387c3591a0d62 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] da83400

False positive or not applicable? A repository writer can comment:
/ai-review override gpt da83400ca74fa82fb539518c0c1387c3591a0d62: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of da83400ca74fa82fb539518c0c1387c3591a0d62 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Before merge, check that @CrysisDeu has restated the decision on this PR. The new docs/decisions/ entry names them as decider and cites that comment as its record.

What this change ships

Inventory (8 items) — 8 justified

Intent: put the sidebar folder glyph back on its connector line, restoring the folder geometry the maintainer set in #3905. This is a FIX that reverts #14717 (see #18359).

  1. The folder glyph sits on its connector line again; the header pad goes from 3px back to 14px, the glyph from 12px to 14px, the gap from 4px to 5px. — justified
  2. Session rows go back to a 14px left pad in every lane, so the in-folder override FOLDER_ROW_PAD_CLS is removed. — justified
  3. The row divider, dormant toggle, empty-folder "New chat", hidden-folders reveal, pinned divider and flat-view date header move to the 14px column. — justified
  4. The board folder body uses ml-3 pl-1, so rows return to their fix(sidebar): put folder rows and session rows on one left edge #3905 x and the rail's hit strip stays clear of them. — justified
  5. Crewmates grouped rows are indented with pl-7, tracking the row pad. — justified
  6. Team header names no longer get an ellipsis at the default roster width. This fixes a squeeze the wider pad caused (rides along). — justified
  7. A recorded decision pins the geometry against the next indent change. — justified
  8. A new capture harness covers list, flat, board and Crewmates surfaces. It follows the repo's existing website/scripts/capture-*.mjs convention (over 700 such scripts). — justified

[FIRST-PRINCIPLES-REVIEWED] da83400

Description read

[DESCRIPTION-READ] c7dcecf2b9ef90292abcf6b5f158006de4b846ffdc7ebb722ea4c14eb9786b8d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of da83400ca74fa82fb539518c0c1387c3591a0d62 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that @CrysisDeu restated the decision in a comment on this PR before merge. Rule 4 does not let an agent-written docs/decisions/ entry stand on its own.

[DESIGN-REVIEWED] da83400

Description read

[DESCRIPTION-READ] c6af322ca2a9277dd3e2a47d6b1a2527bcd0231c0d4df84a3faed97b0d2d5b9d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of da83400ca74fa82fb539518c0c1387c3591a0d62 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

At the default roster width the team crewmate count now disappears without a trace; in shot-08 "Docs and support" has no count at all.

Watch

  • The team count vanishes without any mark. In TeamGroupHeader.tsx, the name is now shrink-0 max-w-[calc(100%-100px)] and the count is still truncate min-w-0 [flex-shrink:8]. When space runs out, the count shrinks to zero width and leaves no ellipsis. In the right copy of shot-08, "Docs and support" shows no count while "Intake 1 crewmate" just above it does. The blind reader said: "I can't tell how many crewmates it has." This happens on every team with a long name at the default width, every time the panel renders. It costs the user information, though nothing breaks. Smallest fix: keep at least the digit visible, for example by giving the count a min-w wide enough for the number, or by switching to a number-only form like "1" when space is tight.

Suggestions

  • TeamGroupHeader.tsx: let the name give up a few pixels before the count's last digit does, so neither field is lost entirely.

[UX-REVIEWED] da83400

Description read

[DESCRIPTION-READ] 879e33f9aaebfc8cf908c883b11712e8646429fc1ea3d660f3f3b51f50047346

That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed da83400ca74fa82fb539518c0c1387c3591a0d62 — this comment is updated in place on each push.

Review details

No findings that block the merge; two advisory layout regressions.

FINDING — website/src/pages/ChatSidebar.tsx:783 — In board view, session rows inside a folder now start 8px to the right of the folder's name. BOARD_FOLDER_BODY_CLS = 'relative border-l border-border ml-3 pl-1' drops the 9px in-folder row pad, but the board header still has paddingLeft: '6px', an 11px glyph and gap-2. That puts the folder name at 25px, while rows land at 2 + 12 + 1 + 4 + 14 = 33px, which breaks guide 2 (P + G + g = D + M + B + p + R) of the decision entry this PR adds. → Fix: resize the board header so its pad + glyph + gap reaches 33 (e.g. paddingLeft: '14px' with the 11px glyph and gap-2), or keep a board-only row pad.

FINDING — website/src/pages/members/TeamGroupHeader.tsx:70 — The name is now shrink-0 with max-w-[calc(100%-100px)], and that cap assumes "Open team" is about 55px wide. In ru ("Открыть команду"), fr ("Ouvrir l'équipe") and en-XA the label is wider. With a long team name, the icon, the gaps, the capped name and the label (all shrink-0) add up to more than the button's content box, so the "Open team" label runs under the absolutely positioned fold chevron or past the row edge. Before this PR the name could shrink. → Fix: let the name shrink as a last resort (min-w-0 with a small [flex-shrink:...] instead of shrink-0), or give the label its own auto grid column instead of the hard-coded 100px.

[OPUS-REVIEWED] da83400

Verdict parsed from the review's SHA-scoped output markers for commit da83400ca74fa82fb539518c0c1387c3591a0d62.

False positive or not applicable? A repository writer can comment:
/ai-review override fable da83400ca74fa82fb539518c0c1387c3591a0d62: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/folder-indent-restore-3905 branch from 1ad854c to 1eff447 Compare October 9, 2026 09:09
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/folder-indent-restore-3905 branch from 1eff447 to 0eb4974 Compare October 9, 2026 09:20
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 9, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/folder-indent-restore-3905 branch from 0eb4974 to 975f7d6 Compare October 9, 2026 10:24
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/folder-indent-restore-3905 branch from 975f7d6 to 5c36791 Compare October 9, 2026 21:23
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 9, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes on 5c36791bfc. The list-view restore itself is right: the header pad, glyph, body inset and ROW_BOX_CLS match #3905, the restored tests pin the three guides, and the list body's 4px pad still clears FolderRail's -5..3 hit strip. Two behaviour regressions sit outside the list body, plus one merge precondition on the decision entry.

1. Board view: the folder rail now covers the first 3px of every board session row. BOARD_FOLDER_BODY_CLS = 'relative border-l border-border ml-4' (ChatSidebar.tsx:779) has no left pad, while .folder-rail is position:absolute; left:-5px; width:8px; z-index:1 (index.css:3001). Rows start at x=0 of the body's padding box, so the rail spans 0..3 of each row and sits above it. A click there runs toggleColumnCollapse (ChatSidebar.tsx:3298) and collapses the folder instead of opening the session. On main the body's pl-[5px] kept the rail clear. #3905's ml-4 predates FolderRail (#15442), so a byte-for-byte restore of that value collides with it. The description's "still never overlaps a row" holds for FOLDER_BODY_CLS only. Suggested fix: ml-3 pl-1 keeps board rows at the same x as ml-4 (12 + 1 + 4 = 16 + 1) and gives the rail a 4px pad, the same clearance the list body has. A test asserting the board body carries a pad of at least 4px would pin it. (I derived this from the CSS and DOM order; I did not click it in a browser.)

2. Crewmates: long team names now truncate at every roster width, not only under pressure. shrink-0 max-w-[40%] on the name (TeamGroupHeader.tsx) caps it at 40% of the header even when the flex-1 rule beside it is filling empty space. At the default 264px roster that is roughly 87px, so a name of about 15+ characters gets an ellipsis next to a long empty line. That reverses the component's own contract ("the rule gives way first ... and only then the name") and affects every user with a longer team name, every time the roster renders. On main the name could take the full width. The squeeze being fixed is real (it comes from this PR's 4px wider ROW_BOX_CLS), but the cap should only bite under pressure: for example keep shrink-0 and replace the percentage cap with max-w-[calc(100%-<icon + gaps + count + Open team>px)], or keep the name flexible and let the rule (basis 0) and the count absorb the squeeze. A capture at the default and a wider roster width with a long team name would show it; the shot in the description only uses short names.

3. Before merge: the maintainer restatement the decision entry cites. docs/decisions/2026-10-09-folder-glyph-sits-on-its-connector-line.md says "the maintainer restates the decision in a comment there" (this PR), and README rule 4 requires that comment. It is not on the PR yet. Rule 2 makes the entry immutable once merged, so if it lands first the ledger carries a permanent entry whose evidence is missing, and fixing it would take a superseding entry plus an override. @CrysisDeu, a one-line comment here clears it.

Verified on the head: CI 89 passed, 9 skipped, 0 failed. Auto-merge is off. I read the source and CSS for both findings; I did not run the tests locally.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Evidence upload for the review round (board rail clearance + team-name cap); the PR body embeds these.

pair-members-264

pair-members-400

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 9, 2026
folder header pad to 3px to tighten the per-level indent. The maintainer
saw the result on main and asked for the #3905 geometry back: the glyph
on the x of the border-l line that runs down under it, the folder header
on the same 14px pad as a session row, and a folder name on one edge
with the agent label, title and subtitle of the sessions inside it.

A plain revert conflicts in five places, so this restores the values on
top of main: header px-3.5, 14px glyph, gap-[5px], body ml-3 pl-1,
ROW_BOX_CLS pl-3.5, divider ml-[14px], board body ml-4, and drops the
per-body row-pad override (FOLDER_ROW_PAD_CLS) that only existed to
re-pad rows inside a 3px header. Measured on the built SPA: glyph box x
== connector x at depth 1, 2 and 3 (259/278/297), 0px apart; root lane
content 259 == root glyph, depth 1 content 278 == depth 1 glyph, the
same numbers #3905 recorded.

The geometry is recorded under docs/decisions/ so the
recorded-decisions-are-not-regressions rule blocks the next change.

Refs #18359
Reverts #14717
@CrysisDeu
CrysisDeu force-pushed the fix/folder-indent-restore-3905 branch from 5c36791 to da83400 Compare October 9, 2026 23:58
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Addressed on da83400ca7.

  1. Board rail over the rows — BOARD_FOLDER_BODY_CLS is now ml-3 pl-1 (rows at the same x as ml-4, rail gets the list body's 4px clearance). Pinned by a new test in ChatSidebar.boardFolderCollapse.test.tsx and by an elementFromPoint probe in the capture harness: on 5c36791bfc the first 0.5/1.5/2.5px of a folder row all resolve to .folder-rail; on this head all three resolve to the row.
  2. Team name cap — max-w-[40%] → max-w-[calc(100%-100px)] (icon 13 + four gaps 32 + "Open team" ~55). The harness now renders two long names at roster 264 and 400 and fails on any ellipsis that appears while the name is narrower than the header's budget; the PR body has both before/after frames. "Docs and support" (99px) reads whole at 264 where 40% clipped it to 80px; the 175px name reads whole at 400 and truncates only at 264, where the header has 100px for a name.
  3. Rule 4 comment — still owed by @CrysisDeu, who will post it before merge.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Decided: the folder glyph sits on its connector line and folder rows share the session rows' 14px pad; #14717's indent is reverted.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 10, 2026
@buluoray
buluoray enabled auto-merge (squash) October 10, 2026 02:07

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at da83400. This supersedes my CHANGES_REQUESTED on 5c36791: all three items are resolved.

  1. Board view rail no longer covers the rows. BOARD_FOLDER_BODY_CLS is now relative border-l border-border ml-3 pl-1 (ChatSidebar.tsx:783): 12 + 1px border + 4px pad lands the rows at the same x as #3905, and the 4px pad keeps the .folder-rail hit zone off the row edge.
  2. Crewmates team names read whole. TeamGroupHeader caps the name at max-w-[calc(100%-100px)] (the icon, the gaps and "Open team") instead of a flat 40%, and the capture script now fails if a team name truncates without width pressure at either roster width.
  3. The decision entry has its source. CrysisDeu restated the decision on this PR (#18362 (comment)), which the new docs/decisions/2026-10-09-folder-glyph-sits-on-its-connector-line.md entry references.

CI on this head: 89 success, 9 skipped, 0 failures. I read the diff and the capture script; I did not run the tests locally or click through the board view in a browser, so item 1 rests on the class geometry and the CSS order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(sidebar): restore the #3905 folder geometry that #14717 moved

2 participants