Repository navigation
Conversation
The header arrows took space in the most crowded part of the top bar and duplicated the Cmd/Ctrl+Left/Right chords. Remove them and add View > Back / Forward to the desktop app menu instead, which is where macOS apps put history navigation. - The menu items send a history-step IPC; the renderer takes the step through useGuardedHistoryStep, so the draft guard and the nowhere-to-go check are the same as for the chords. - No menu item registers the chord: a registered accelerator would take Cmd+Left from every text field. On Windows/Linux the chord is shown but not bound; macOS has no display-only accelerator, so it shows none. - RouteHistoryTracker stays (renamed file); the unused tooltip strings are removed from every locale. Refs #8258
Removes the arrows from the top bar, adds View > Back / Forward to the desktop menu (history-step IPC, taken through useGuardedHistoryStep), and drops the now-unused tooltip strings. No menu item registers Cmd/Ctrl+Left/ Right, so text fields keep those keys. Refs #8258
UX Review (Fable 5) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK Cannot evaluate: missing screenshot of the new View → Back/Forward menu items — the PR's replacement control appears in no supplied image. Evidence gaps
Watch
[UX-REVIEWED] cc4a957 |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify View → Back/Forward by hand in the packaged app (macOS menu bar and Windows titlebar menu) — the PR itself flags this as not yet done. [DESIGN-REVIEWED] cc4a957 |
First Principles Review (Fable 5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK Removing the shipped header Back/Forward arrows is product shape with no recorded decision, and the web dashboard is left with no on-screen replacement. Not justified as shipped
What this change shipsInventory (10 items) — 7 justifiedIntent: stop showing Back/Forward as header buttons and offer them as desktop View-menu items instead — a MOVE/removal, not a FIX. (The patch also carries already-merged main commits — session-control #14185, question-card RFC #13253, unread-badge opt-in, docked webview — from a stale diff base; the merge target
Blockersproduct-shape change without accepted RFC — the header arrows are an existing user-facing capability, removed and replaced by desktop-only menu items. The deleted component's own comment pinned "the visible, surface-independent affordance"; the replacement is surface-dependent (Electron shell only), and the description's support is analogy ("Most sidebar-driven desktop apps … show no history arrows") — a proposal, not a decision. Base RFC list: nothing covers header navigation chrome ( [FIRST-PRINCIPLES-REVIEWED] cc4a957 |
GPT 5.6 Review — 🔴 changes requested (blocking)GPT 5.6 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- src/kiro_crew/dashboard/session_control.py:5570 -- Tree truncation makes the omission count false Adjudication (Opus 5) — is blocking on each finding proportionate?Harm: MEDIUM — [ADJUDICATION] cc4a957 total=1 uphold=1 downgrade=0 False positive or not applicable? A repository writer can comment: |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsNothing blocks — one advisory finding: the replacement View menu items never disable, so they are silently dead in every state where the renderer suppresses the step. FINDING — website/electron/app-menu.js:102 — the two new items carry no [OPUS-REVIEWED] cc4a957 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Triage (automated, against Rebase needed. The merge base Needs a merge discussion with #15656 (open, "collapse the desktop top bar instead of clipping it"). That PR treats the arrows as a live part of the top bar. It adds a collapse rung for them ( Not in conflict: #11891 (open PR) maps the mouse buttons to the session MRU walk. That is a different input, and the description here already leaves it out of scope. #8258 is an issue (still open), not a PR. There is no Breaking-Change or P0 finding, so this is a comment, not a change request. The new bridge method |
|
Thanks for working on moving Back/Forward into the View menu, @xuejinT. We're closing this draft because it has had no activity for over two weeks and main has moved on since (for example, website/src/test/RouteHistoryTracker.test.tsx that this PR edits no longer exists). You're welcome to reopen this or open a fresh PR against current main whenever you're ready. |
Problem / Motivation
#9550 added Back/Forward arrow buttons to the top-left of the header. #8258, the issue it answered, asked for ⌘←/⌘→, mouse back/forward buttons, and optionally menu items. It did not ask for on-screen buttons. The header's left cluster is the most crowded part of the top bar (window controls, instance selector, crew chips), and the arrows duplicate the chords. Most sidebar-driven desktop apps (Discord, ChatGPT, Claude, Figma) show no history arrows. Apps that do show them (Slack, Notion, Spotify) are built around deep browse-style navigation.
What changed
NavHistoryArrowsis gone.RouteHistoryTrackerstays, moved tocomponents/RouteHistoryTracker.tsx, because the chords still read its store. The narrow-header drop rung for the arrows is removed fromindex.css.history-stepIPC (-1/1) to the focused dashboard. The renderer takes the step throughuseGuardedHistoryStep, so the draft guard and the "nowhere to go" check are the same as for ⌘←/⌘→. Menu clicks are not gated on the keyboard-shortcuts toggle, because a click is not a keystroke.registerAccelerator: false, the same pattern as Settings…). macOS has no display-only accelerator, so the items show no chord there. The chord is still listed in the Shortcuts modal.onHistoryStepis optional on the bridge type, so a renderer on an older desktop shell still works.app.nav_back_title*,app.nav_forward_title*) from every locale and the context sidecar.app.nav_back/app.nav_forwardstay because the Shortcuts modal uses them.Not in this PR
Testing
npm run typecheck, eslint on the touched files,i18n:check,lint:i18n: clean.npm test: 2255 tests, 0 failed. Newapp-menu.test.jscases check the View order (Back, Forward, separator), the click wiring, and that neither item registers an accelerator on any platform.useKeyboardShortcutstests: a menu step goes back when there is history, even with shortcuts off; it does nothing when there is nowhere to go; the listener unsubscribes on unmount.Screenshots
Real built SPA with the API stubbed, 1280px, dark theme, after one in-app step (Settings → Schedule) so Back shows enabled. Before is base
e88e807786, after is this branch. Nothing else in the header moves.Before: Back/Forward arrows at the top left
After: arrows gone, the rest of the header unchanged
The new View → Back / Forward items are drawn by macOS in the system menu bar, outside any web page. The repo's Electron-shell harness (
capture-electron-shell.mjs) only runs on Linux/Xvfb, so the menu isn't in these shots.app-menu.test.jscovers the item order and wiring, and the menu will be checked by hand in the desktop app.