Repository navigation
Conversation
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
UX Review (Fable 5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has judged the dock-aware glyphs; whether the 12–15 px bottom-pane icon reads as "panel below" is unverified. Watch
[UX-REVIEWED] 1c78625 Description read[DESCRIPTION-READ] 51db2e696d0e9f3804952a4d57e93a359de911f4fe4f592c886df4de74352641 That sha256 names everything this verdict read: the PR description, plus the 20 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS
What this change shipsInventory (10 items) — 10 justifiedIntent: FIX — the side panel's open/close icons should depict where the panel actually docks; today they always draw the right-dock glyph.
Evidence run: [FIRST-PRINCIPLES-REVIEWED] 1c78625 Description read[DESCRIPTION-READ] 291f20b0adf8657be96349385c8daf5c8328a050feb471b6fd7d853062045d3e That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Mobile width was never hand-checked; confirm the phone overflow item and inline panel still draw the right glyph on a real narrow window. Suggestions
[DESIGN-REVIEWED] 1c78625 Description read[DESCRIPTION-READ] 94d34a2310b97d82d16c7f1bc942f8faea222187121f93dc05f1bfa18565237f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed |
f10fa42 to
168b095
Compare
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
|
Thanks @dwu96! I've marked it ready for review, so the workflow runs can be approved on the next cycle. |
Every control that opens or closes the side panel drew the right-dock glyph even when the panel was docked below the chat: the panel header's close button, the chat header's open button, the tool-call "open in side panel" link, and the subagent and workflow run/completion cards. Add SidePanelGlyph, which reads the dock setting and draws the bottom or right pane to match, and use it at all seven sites so the choice lives in one place. Mobile keeps the right glyph, since the panel always opens on the right there. Includes the review screenshots under temp-screenshots/, committed because gh --attach is unavailable to a fork PR.
1243922 to
06d68bd
Compare
Security Scope Review (fork) — 🔴 BLOCK (blocking)Which legitimate operations does no leg reported, and this was not the nothing-to-adjudicate short circuit No |
SidePanelGlyph read only the stored dock preference, but two hosts always open the panel on the right: the chat page's inline panel (embed frames, popouts, mobile) and the Members page. With the preference set to bottom, the tool-call chip and the run/completion cards there drew the bottom glyph for a panel that opens right. Add a SidePanelDockHost context. ChatPage provides whether the shell's activity bar hosts the panel, MembersPage provides false, and SidePanel provides its own canDockBottom, so every glyph resolves the dock the way the panel does. The per-call bottom override is removed. Adds bottom- and right-dock review screenshots of the four remaining controls.
06d68bd to
1c78625
Compare
|
Thank you for this fix, @aahung! 🙏 To get it through the branch-protection and CI checks (which a fork PR cannot fully satisfy), the change has landed as an in-repo replacement PR: #16773. Your work is preserved exactly:
Closing this one in favor of #16773. Thanks again for improving the side-panel glyphs! |
Problem / Motivation
Goal: The side panel's open and close buttons show an icon that matches where the panel is docked.
With Dock panel below chat selected, the close button in the side panel header and the "Open activity panel" button in the chat header both still draw the right-dock glyph (a panel on the right edge). The icon tells the user the panel lives somewhere it does not.
Why it matters
Anyone who docks the panel below the chat sees an icon that points to the wrong place every time they open or close it. It is a small but constant mismatch between the control and the layout it controls.
Not a goal
What changed (motivation → approach → change)
PanelRightSolidorPanelRightLight), regardless of the dock setting.website/src/components/SidePanelGlyph.tsx:useEffectiveSidePanelDock()resolves where the panel actually docks from the stored preference, the mobile check, and aSidePanelDockHostcontext saying whether the current host can dock bottom.SidePanelGlyphdraws the bottom-dock pane or the right-dock pane from that;lightselects the open-state variant.ChatPagepasses whether the shell's activity bar hosts the panel (the inline panel in embed frames, popouts and mobile always opens right),MembersPagepassesfalse, andSidePanelpasses its owncanDockBottom. So a chip or card inside a right-only host never shows the bottom glyph.pages/chat/SidePanel.tsx: the panel header's close button.pages/ChatPage.tsx: the chat header's "Open activity panel" button.pages/chat/ToolCallLine.tsx: the "open in side panel" link.pages/chat/SubagentRunCard.tsxandpages/chat/SubagentCompletionCard.tsx: the subagent cards' panel buttons.pages/chat/WorkflowRunCard.tsxandpages/chat/WorkflowCompletionCard.tsx: the workflow cards' panel buttons.components/icons/panels.tsx: exportsPanelIconPropsso the wrapper can forward icon props.The phone overflow menu's "Open activity panel" item in
ChatPage.tsxkeepsPanelRightSolid. It only renders on mobile, where the panel always docks right.Backwards compatibility
Compatible: only the icon each control draws changes. Behavior, labels and settings are unchanged, and the right-dock rendering is identical.
Tests
New
website/src/test/SidePanelGlyph.test.tsxcovers the right dock, a live flip to the bottom dock, the light variant for each dock, the mobile override, and hosts that can and cannot dock bottom.tsc --noEmitand eslint on the touched files are clean.vitest runon the SidePanelGlyph, SidePanel, ChatPage, MembersPage, ToolCallLine and subagent/workflow card suites passes (108 files, 1233 tests). One unrelated suite,serveDist.routes.test.ts, could not spawn its probe inside the local sandbox.npm run buildsucceeds.Manual verification
The built dashboard was exercised in headless Chromium with fixture-backed API responses (screenshots below). All seven controls were checked in each dock. The real app, and a mobile-width window, were not checked by hand.
Screenshots / video
Captured from the built dashboard in headless Chromium with fixture-backed API responses. The control under test is outlined in orange.
Panel docked below the chat
main)Subagent completion card's Panel button (after), right dock then bottom dock
Other panel controls (after), right dock → bottom dock
Panel docked right (unchanged)
Full frame, docked below, after:
Related Issues
N/A — reported directly; no issue filed.
Pattern harvest
Rule candidate: a control that opens or closes the side panel renders
SidePanelGlyphinstead of a fixedPanelRight*icon, so the glyph always matches where the panel docks. The first review round found five such sites the original two-button fix had missed.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement