Repository navigation
fix: match side panel glyphs to the dock position - #16773
Conversation
Every control that opens or closes the side panel drew the right-dock glyph even when the panel was docked below the chat: the panel header's close button, the chat header's open button, the tool-call "open in side panel" link, and the subagent and workflow run/completion cards. Add SidePanelGlyph, which reads the dock setting and draws the bottom or right pane to match, and use it at all seven sites so the choice lives in one place. Mobile keeps the right glyph, since the panel always opens on the right there. Includes the review screenshots under temp-screenshots/, committed because gh --attach is unavailable to a fork PR.
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the dock rule in Suggestions
[DESIGN-REVIEWED] be3adb1 Description read[DESCRIPTION-READ] 5bd5a857cc8d0b6ca46515ab1fcf7949bd51061a237a3c26059f72683ea3d613 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The Not justified as shipped
What this change shipsInventory (8 items) — 7 justifiedIntent: the open/close glyphs on the side panel should show where the panel really docks (FIX, #16772).
[FIRST-PRINCIPLES-REVIEWED] be3adb1 Description read[DESCRIPTION-READ] e6863b32ff41c41f0b2190b42c7f7276cde118d0d954a162984d73da0efe0b29 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check one thing before merge: on a bottom-docked panel, the bottom-strip glyph should change to the right-bar glyph live when a phone-width window forces the panel right. [UX-REVIEWED] be3adb1 Description read[DESCRIPTION-READ] da0fb8a4e2a70aee7e9084925146699d37aa878fd1b802b8938ac9f1e68b49a1 That sha256 names everything this verdict read: the PR description, plus the 20 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
SidePanelGlyph read only the stored dock preference, but two hosts always open the panel on the right: the chat page's inline panel (embed frames, popouts, mobile) and the Members page. With the preference set to bottom, the tool-call chip and the run/completion cards there drew the bottom glyph for a panel that opens right. Add a SidePanelDockHost context. ChatPage provides whether the shell's activity bar hosts the panel, MembersPage provides false, and SidePanel provides its own canDockBottom, so every glyph resolves the dock the way the panel does. The per-call bottom override is removed. Adds bottom- and right-dock review screenshots of the four remaining controls. Co-authored-by: aahung <3804518+aahung@users.noreply.github.com>
070eb43 to
be3adb1
Compare
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: The side panel open/close glyphs match where the panel actually docks instead of always showing the right-dock icon.
Every control that opens or closes the chat side panel drew the right-dock glyph even when the panel was docked below the chat — the panel header close button, the chat header open button, the tool-call "open in side panel" link, and the subagent and workflow run/completion cards.
Why it matters
The glyph is the only cue for where a click sends the panel. When it shows "right" for a panel that opens at the bottom, the icon lies about the outcome, so users on a bottom dock cannot trust the control.
Not a goal
What changed (motivation → approach → change)
SidePanelGlyph, which reads the dock setting and draws the bottom or right pane to match, and use it at all seven sites so the choice lives in one place. A follow-on commit adds aSidePanelDockHostcontext so the glyph resolves against the host's actual dock ability: two hosts always open the panel on the right (the chat page's inline panel for embeds/popouts/mobile, and the Members page), and they now provide that fact to the glyph instead of relying on the stored preference alone.Backwards compatibility
Removes nothing: this is additive UI wiring — a new component and a new context — plus a one-character
exportonPanelIconProps. No field, kind, validator, route, or public function is renamed, removed, or tightened.Tests
website/src/test/SidePanelGlyph.test.tsx(new, 6 tests): locks in thatSidePanelGlyphrenders the bottom-pane geometry when the resolved dock is bottom and the right-pane geometry otherwise, and that theSidePanelDockHostcontext overrides the stored preference.Manual verification
Captured before/after screenshots of the four remaining controls in both bottom- and right-dock states (committed under
temp-screenshots/side-panel-dock-icon/). TypeScripttsc --noEmitand the new vitest file both pass locally.Screenshots / video
The author committed review screenshots under
temp-screenshots/side-panel-dock-icon/(the gitignored evidence directory, force-added per the template). Representative shots:Bottom-dock close button (after):
Full before/after set
Related Issues
Fixes #16772
Supersedes #14845 (fork PR by @aahung).
Pattern harvest
Not generalizable: this is a single missing state-to-glyph wiring in one UI component family; there is no broader class of defect a rule would catch.
Checklist
fix: ...)