Repository navigation
Conversation
|
Intent: Fullscreen the existing workspace panel without remounting its tabs, drafts, browser frames, or PTYs, while keeping panel controls geometrically stable. |
eb653d9 to
b10a947
Compare
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Attachment-09 shows the side panel clipped on its left edge, and no first-time reader has seen the icon-only Fullscreen, Bottom panel and Side panel toggles. Watch
[UX-REVIEWED] eab8e65 Description read[DESCRIPTION-READ] c0c9dd94c8b77cd39bf38e41a71c264efe8d9de6dc7badc35021a521f3b0432b That sha256 names everything this verdict read: the PR description, plus the 17 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Fullscreen makes every shell child inert unless it is on a hand-kept allowlist, so a shell-level surface showing at entry stays visible above the panel but stops responding. Watch
[DESIGN-REVIEWED] eab8e65 Description read[DESCRIPTION-READ] 10e163eadebf325320aba2dd44f64e02ef96ba9fb7228389d1ef333860b0aaaa That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK product-shape change without accepted RFC: desktop workspace files lose their own fullscreen action, and the RFC (#15942) cited for it isn't on base. Not justified as shipped
Inventory (8 items) — 6 justifiedIntent: let a desktop user fullscreen the whole workspace panel in place, with a Side-panel toggle that doesn't move. ADDITION.
Blockers
[FIRST-PRINCIPLES-REVIEWED] eab8e65 Description read[DESCRIPTION-READ] f269eb48fa5fca8163b6d983e1b566df679d2b0604536b9c01dab1f9ae3870e8 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
72daf47 to
d90afaf
Compare
|
|
|
|
|
|
🤖 Kiro Crew [operator: dwu96#8c08bee0]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
I am not claiming this PR for automated fixes: every blocking item resolves to a design or product decision that is yours or a maintainer's, and the pipeline must not change a PR's design direction. When you've addressed these, the pipeline will re-assess on its next cycle. |
673ecfc to
feba2f6
Compare
feba2f6 to
bf23145
Compare
33ad784 to
8c2abe9
Compare
|
PR triage (automated, 2026-10-05): rebase needed, plus an overlap to discuss Checked head Rebase. Not covered by main. Workspace fullscreen is not on main. #10119 (PR) added it and #10626 reverted it, and main has no Overlap that needs a merge discussion:
No new P0 was found. The product-shape change (files hosted in the workspace lose their file-only Full screen on desktop) is already raised by the First Principles BLOCK and by the 2026-09-21 comment, so this triage adds no separate request-changes review. |
Expand the existing workspace panel without remounting its tabs, drafts, or terminal sessions. Keep panel controls on one shared geometry so opening the side panel does not move its toggle. Fullscreen covers the content rows only: the 42px topbar stays visible and interactive, so the keyboard-scope walk stops below the dashboard shell instead of marking the topbar inert. The side panel's browser tabs stay 32px chips fused to the strip's bottom edge, so the strip shows above them and they keep their tab silhouette. Their center sits 4px below the strip's 28px action cells; the new-tab trigger follows the tabs, the way Chrome bottom-aligns its new-tab button, while the trailing Fullscreen, Bottom and Side actions keep the row's center. Rejected: 40px chips (fill the strip, stop reading as tabs), a row-centered trigger (floats above the tab glyphs beside it), and lowering the trailing actions (moves the Side toggle away from its closed-state position). The title-row Bottom-panel toggle is the chat page's pointer entry to the docked terminal, and the nav rail keeps its Terminal row: it is the only pointer entry on other routes and in the phone drawer, where neither host of the toggles renders. Both entries read the panel's one open flag, and both, like the rebindable terminal chord, exit workspace fullscreen before toggling so the panel never opens behind it. Placing the Bottom-panel toggle beside the Side-panel one puts two panel glyphs side by side; the base SidePanel comment that kept them apart is retired for the recorded layout. Each toggle is named by its action and the name follows the panel's state (Show / Hide terminal, Show / Hide side panel), as tooltip and accessible name alike, with no aria-pressed. The "Popped out" and "In split" state chips keep their visible labels at the shared 28px row height. The toggles reuse the panel glyph family the title rows already draw; no new icon is introduced. PanelToggles takes no showWorkspace flag. Every title row that hosts these controls owns the side panel's edge, so a row without its toggle would leave that panel with no way to open it; the terminal toggle stays conditional because the docked terminal can be disabled by config.
Raise the focus-mode topbar and rail above workspace fullscreen, keep the title-row panel toggles while conversation search owns the dock, and keep the phone connect dialog above the raised chrome. A docked terminal covered by fullscreen reads as hidden, and its entries reveal it instead of closing it. The computer-use live view stays above fullscreen and out of its inert walk. App-root dialogs sit above that chrome too, and the dock menu is hidden while fullscreen covers both dock positions. The Side-panel toggle draws SidePanelGlyph, so its pane follows where the panel docks, as every other side-panel control does. The Bottom-panel toggle draws the nav rail Terminal row's SquareTerminal, because a bottom-pane glyph would match the Side-panel toggle whenever the side panel docks bottom.
|
Thank you @Skymore for the careful work here, including the accessibility and Focus Mode handling. We are closing this PR because the design in #10722 has not received a maintainer sign-off yet, and the branch now conflicts heavily with main. The need stays tracked in #10722. Once the design is approved there, a fresh PR on current main (ideally splitting the panel-toggle alignment from workspace fullscreen) would be very welcome. |
Problem / Motivation
Goal: Let users fullscreen the whole workspace panel in place, keeping its tabs, drafts, browser pages and terminals, with panel toggles that stay under the pointer when the panel opens.
The dashboard can fullscreen one file preview, but it cannot fullscreen the whole workspace panel. Its Sessions, chat, and SidePanel title actions also use slightly different geometry, so opening SidePanel moves its toggle.
Why it matters
Workspace tabs own live editor drafts, browser frames, and terminal sessions. Fullscreening the whole panel lets users focus that work without replacing or remounting it. Stable controls also keep the same action under the pointer when the panel opens.
Not a goal
What changed (motivation → approach → change)
The workspace panel now expands its existing mounted subtree across the dashboard content grid. Tabs, drafts, terminal scrollback, and browser state remain mounted. A focused PTY keeps Escape for its running program; the visible fullscreen control exits the workspace instead.
Workspace fullscreen covers the content rows only; the 42px topbar stays visible and keeps taking input, while the covered content grid (chat, sidebar, rail) is inert for keyboard and screen-reader navigation (the keyboard-scope walk skips the shell's header, and in Focus Mode also the peek triggers and the rail overlay, which paint above the panel and must stay usable). Each panel toggle is named by what its click does, for both its tooltip and its accessible name, and the name follows the panel's state.
Focus Mode keeps both its topbar and navigation rail above workspace fullscreen while leaving banners, sheets, and modals above the chrome. Fullscreen also lifts the peek triggers above its own layer, so the window edges still summon that chrome, and the rail's inert exemption follows Focus Mode, so toggling Focus Mode during fullscreen takes effect immediately. When conversation search temporarily owns the dock, the title-row panel toggles remain visible; choosing Side panel closes search and restores the panel.
A docked terminal that is open when workspace fullscreen starts is covered by it, so every terminal entry (the strip's Bottom-panel toggle, the nav rail Terminal row and the
terminalchord) reads it as hidden while fullscreen is on: unlit and named "Show terminal". Activating one leaves fullscreen and brings that terminal back, instead of toggling it closed behind the layer. Theterminal-newchord (Ctrl+Shift+`, which adds a tab) also leaves fullscreen first, because the tab it adds lands in that same covered panel. The computer-use live view, which shows and controls an agent driving the real desktop, stays above the fullscreen layer and out of its inert walk; it is non-modal, so it does not take Escape from the workspace. The phone Connect dialog sits above the Focus Mode chrome that this PR raised, and so do the three other dialogs the App shell mounts inside its own root (the update-ready, update-found and startup-video dialogs, z-[65] → z-[68]); at z-[65] the raised Focus Mode rail and topbar painted over them. While the workspace is fullscreen the panel's dock menu (Dock bottom / Dock right) is hidden: the fullscreen layer covers both dock positions, so the choice changed nothing visible.Workspace fullscreen is desktop-only: the phone renders no activity-bar slot for it to expand, so the shell does not provide the fullscreen context there and a file on the phone keeps its own full-screen action; narrowing the window to a phone width exits workspace fullscreen. On desktop, workspace-hosted files no longer offer a second file-only fullscreen action. Standalone file previews retain it. On Windows and Linux Electron, the fullscreen strip reserves the caption-control band only in Focus Mode, the one case where it reaches the window's top corner; outside Focus Mode the strip sits under the topbar, which already clears it, and macOS hides its traffic lights with the Focus Mode chrome. The SidePanel keeps the recorded fused browser tabs and half-card frame.
Sessions, chat, and SidePanel title rows now share 40px rows, 28px action cells, 14px icons, and 6px spacing within each action region. The closed title row separates session-window actions (Pop out and Split) from workspace-visibility actions (Bottom panel and Side panel) with a hairline and 8px inset. The open SidePanel likewise separates panel-shape actions (dock and Fullscreen) from workspace-visibility actions. Every region has at most two actions while all four controls remain directly accessible. The "Popped out" and "In split" state chips keep their visible labels at that 28px height; they report a session state rather than trigger an action, so they are not reduced to icon-only cells. With SidePanel closed the order is Pop out, Split, Bottom panel, Side panel. With it open the order is Fullscreen, Bottom panel, Side panel. The Side toggle has the exact same bounding box in both states. Bottom-docked SidePanel also keeps Fullscreen as a direct button. Each toggle is named by its action for both tooltip and accessible name ("Show terminal" / "Hide terminal", "Show side panel" / "Hide side panel"), matching the Sessions toggle's "Show / Hide sessions" in the same row; a name that states the action carries no
aria-pressed, and neither does the workspace Fullscreen control, whose name already switches between "Full screen" and "Exit full screen"; while the terminal is popped out the terminal control reads "Focus popped-out window", because the click focuses that window and toggles nothing here. The panel root is a region named "Side panel", so it no longer shares the "Activity" name with the Activity view inside it.The product decision and acceptance criteria are recorded in #10722, and written down as an RFC for the base branch in #15942 (
docs/request-for-change/rfc-workspace-fullscreen.md). This is the first focused re-submission of the justified parts reverted with #10119; it deliberately does not restore that PR's pill tabs or flattened panel frame.Implementation areas:
website/src/App.tsxowns route-level fullscreen state;website/src/index.cssexpands the activity slot;website/src/pages/ChatPage.tsxandwebsite/src/pages/chat/SidePanel.tsxown the two control placements; the shared components and hooks own geometry, Escape precedence, and mounted-state continuity.Design decisions
Browser tabs stay 32px; the
+follows the tabs, not the header cells. The title rows share 28px action cells centered on a 40px row. The side panel's tabs are fused to the strip's bottom edge, so a tab that also shared the action cells' center would have to be 40px tall — it fills the whole strip and stops reading as a tab. The tabs therefore keep the 32px chip recorded onmain, with 8px of strip above them, and their center sits 4px below the action cells. The new-tab+belongs to the tab row and is bottom-aligned with the chips (Chrome's new-tab placement), so its glyph shares the tab icon/label center; the trailing Fullscreen / Bottom / Side group keeps the row's center, which is what holds the Side toggle's bounding box identical between the closed and open states.Rejected: 40px chips (fill the strip, lose the tab silhouette — this was tried in an earlier revision of this PR and reverted), a row-centered
+beside 32px chips (its glyph floats 4px above the tab glyphs next to it — the state onmain), and lowering the trailing action group instead (moves the Side toggle off its closed-state position). The decision is recorded in the+trigger's comment inSidePanel.tsx, pinned bysidePanelBrowserTabs.test.tsx, and described inwebsite/docs/page-layout.mdand the dashboard system spec.The Side-panel toggle draws
SidePanelGlyph; the Bottom-panel toggle draws the nav rail Terminal row'sSquareTerminal. This overrides the previous revision, where both toggles drew the project's panel family (PanelBottomSolid/PanelBottomLightandPanelRightSolid/PanelRightLight). #16773, merged after that revision, made every control that opens or closes the side panel drawSidePanelGlyph, whose pane follows where the panel docks; the two controls this PR replaces (the chat header's opener and the open panel's Close) are two of its seven sites. Keeping a fixed right-pane glyph here would undo that fix for these two controls, so the Side-panel toggle usesSidePanelGlyphtoo. That made the old Bottom-panel glyph collide: with the side panel docked bottom, both toggles drew the same bottom pane side by side. Alternatives considered:SquareTerminalon the terminal toggle (chosen): it never matches the side toggle in either dock, the two pointer entries to the docked terminal share one glyph, and it is not a panel-shape glyph, so it does not read as a dock position (the UX lane's earlier note that the bottom-pane icon read as "the panel docked at the bottom", not "terminal").The cost: the terminal toggle no longer has the panel family's filled/dimmed pane, so its open state is shown by the accent background alone, as on the nav rail Terminal row. The Side-panel toggle keeps the family's filled/dimmed pane, and the Sessions toggle in the same row is unchanged. This PR still adds no
<svg>;SquareTerminalis the Lucide iconApp.tsxalready imports for the rail row.One fullscreen concept, Escape stays with a focused PTY, two-action title regions, direct Fullscreen in the bottom dock, and four directly accessible title-row actions are the other product decisions. They are recorded in #10722 and were confirmed with @CrysisDeu before this PR was opened; the single fullscreen concept, PTY-Escape handling and workspace fullscreen are also the parts of #10119 the owner named as welcome back in #10619.
The nav rail keeps its Terminal row beside the new title-row Bottom-panel toggle. An earlier revision of this PR removed the row so the docked terminal would have a single pointer entry. The Opus review of that revision showed the cost: the title-row toggle renders only on the desktop chat route (the phone hides the title row, and the side-panel strip has no fullscreen context there), while the docked terminal still renders on every route and the
terminalchord ships unbound, so on a phone and on every non-chat page the terminal could no longer be opened. This revision restores the row exactly as onmain(label, icon, catalog key and its lit-state test) and keeps the new title-row toggle for the chat page; both read the same open flag, so their pressed states cannot disagree. The row, like the toggle and the chord, now exits workspace fullscreen before toggling, so the docked panel is never opened behind the fullscreen layer, and a terminal already open beneath fullscreen is revealed rather than closed. The page-layout spec, the dashboard spec and the feature map record both entries.Panel toggles are named by their action, Show or Hide, and carry no
aria-pressed. An earlier revision named them "Toggle terminal" and "Toggle side panel" witharia-pressed. That put two naming schemes in one row, because the Sessions toggle beside them onmainis "Show sessions" / "Hide sessions" with no pressed state, and it lost the wordingmainuses for this pair ("Open activity panel" when closed, "Close panel" when open). The open panel's Close button is folded into the Side-panel toggle: sameSidePanelGlyph, same position, same action, so "Hide side panel" keeps the close action findable by name. Show / Hide rather than Open / Close: hiding the docked terminal ends no shell, and "Close terminal" already names closing a shell tab. Keepingaria-pressedbeside a name that changes would announce the state twice, so both toggles and the Fullscreen control drop it; the accent background still marks an open panel.The side-panel toggle is unconditional. Both real call sites displayed it, and every title row hosting these controls owns that panel edge. The terminal toggle remains conditional because the terminal can be disabled by configuration.
Review-lane mechanics on this fork PR. The two-action grouping blocker is addressed in code. The icon finding is answered with the reasons under Design decisions above rather than by a code change; accepting it is part of the maintainer decision this PR already needs. Focus-mode chrome remains above workspace fullscreen, and panel toggles remain reachable while conversation search owns the dock; both paths have regression tests. With the nav-rail Terminal row restored, the single-fullscreen concept (and the open panel's Close folding into the Side-panel toggle) is the one remaining product-shape decision that requires an accepted RFC or maintainer same-repo override; fork lanes consume no
/ai-review overridemarker. #15942 is that RFC; once it merges, a push or rebase here lets the First Principles lane read it. The layout hooks on the title-row and strip regions aredata-testidattributes, the repo's test-hook convention, rather than bespokedata-panel-controls-*attributes no production code reads.Tests
useWorkspaceFullscreenPanel.test.tsx: mounted-state continuity, nested Escape ownership, annotation portals, focused PTY Escape, the topbar staying interactive while the covered content row and docked rail are inert, and the Focus Mode peek triggers and rail overlay staying interactive, with the rail's exemption following a Focus Mode toggle mid-fullscreen.PanelToggles.test.tsx: each closed panel is named by Show and each open panel by Hide, the tooltip equals the accessible name, and no toggle carriesaria-pressed.PanelToggles.test.tsx: Bottom/Side order, 28px cells, 14px icons, active state, terminal popout behavior, and the side-panel toggle rendering with no props and with terminals disabled.WorkspacePanelControls.test.tsx: the panel root region named "Side panel", browser-tab/half-card retention, direct fullscreen in right and bottom docks, control order, geometry classes, and two separated action regions capped at two controls each.sidePanelBrowserTabs.test.tsx: the 32px bottom-fused tab chip, no content offset, the+trigger pinned to the tab row (self-end, neverself-center) while the trailing action group stays row-centered.ChatPage.responsivePanel.test.tsx: closed-state order, separate session-window and workspace-visibility regions, shared row/cell/icon geometry, mobile access, resize behavior, and caption reserve.MarkdownPanelCoverage.test.tsx: file-only fullscreen is absent inside the workspace and retained outside it.App.mobileSingleTopbar.test.tsx: the phone chat page receives no workspace-fullscreen context, so its files keep their own full-screen action.App.focusMode.test.tsx: the fullscreen strip's Windows/Linux caption reserve exists only underbody.mc-focus-mode, matches the docked header's band (Windows through the same zoom-aware--mc-win-caption-reservethe header uses, Linux at its fixed 112px), and has no macOS rule; in fullscreen the peek triggers sit above the fullscreen layer and below the Focus Mode topbar.PanelToggles.test.tsx: the Side-panel toggle renders the panel family's filled pane when closed and its dimmed pane when open.App.terminalNavActive.test.tsx(restored frommain): the nav-rail Terminal row's pressed state follows the docked panel, plus one new case: clicking the row while the workspace is fullscreen exits fullscreen and opens the panel. The new case was confirmed to fail with the row's fullscreen exit reverted.main; the fullscreen strip's Windows caption reserve follows fix(windows): keep the caption reserve zoom-correct and repaint the overlay on every zoom path #17664's zoom-aware--mc-win-caption-reserveinstead of a fixed 142px; feat(shortcuts): VS Code terminal keys: Ctrl+and Ctrl+Shift+#17587'sterminal-newchord leaves workspace fullscreen before adding a tab):App.focusMode.test.tsxpins the Windows strip rule to the shared variable and the Linux rule to the docked header's 112px;App.terminalNavActive.test.tsxpins the new-terminal chord leaving fullscreen and opening the docked terminal. Both assertions were confirmed to fail with their fix reverted. 3,470 tests across 247 files related to the change passed;npm run typecheck,npm run i18n:check, ESLint with zero warnings on every changed file, documentation lint, the feature-map gate, the comment-history gate, jscpd with zero clones and the production build passed. No UI changed in the captured states, so the screenshots are unchanged.mainwith fix: match side panel glyphs to the dock position #16773'sSidePanelGlyph; terminal toggle glyph; App-root dialog layer; dock menu hidden in fullscreen; GUI smoke scenarios and capture scripts follow the renamed toggles):PanelToggles.test.tsxpins the Side-panel toggle drawing the bottom pane under a host that docks bottom and the right pane under one that cannot, the terminal toggle drawingSquareTerminalclosed and open, and the two never sharing a glyph;WorkspacePanelControls.test.tsxpins the open panel's Side toggle following the dock and the dock menu absent only while fullscreen;AppRootDialogZIndex.test.tsxandAppRootDialogs.stacking.test.tsxnow readTOPBAR_FOCUS_Zas part of the chrome ceiling, so the three dialogs must clear it. Each new assertion was confirmed to fail with its fix reverted. 4,860 tests across 301 files related to the change passed;npm run typecheck,npm run i18n:check, ESLint with zero warnings on every changed file, documentation lint, the feature-map gate, the comment-history gate, jscpd with zero clones and the production build passed.test/gui_user/scenarios/chat-activity-side-panel-toggle.yamlandchat-files-side-panel-browse.yamlnow click "Show side panel" / "Hide side panel", and fivewebsite/scripts/capture-*.mjsscripts open the panel by "Show side panel"; neither was run here.main; a terminal covered by fullscreen is revealed instead of closed; the computer-use live view stays above fullscreen; the phone Connect dialog sits above the Focus Mode chrome;PanelTogglesrequiresworkspaceOpen):terminalEntry.test.tspins every terminal-entry case;PanelToggles.test.tsxandApp.terminalNavActive.test.tsxcover a terminal covered by fullscreen (unlit, "Show terminal", and a click exits fullscreen with the terminal still open);useWorkspaceFullscreenPanel.test.tsxcovers the live view staying out of the inert walk without holding Escape;App.focusMode.test.tsxpins its layer between the fullscreen layer and the Focus Mode topbar and its place as a shell child;MobileConnectModal.test.tsxreads the rail's named layer. Each new assertion was confirmed to fail with its fix reverted. 4,964 tests across 333 files passed;npm run i18n:check,tsc -p tsconfig.app.json, ESLint on every changed file, documentation lint, the feature-map gate, jscpd with zero clones and the production build passed.main; layout hooks moved todata-testid; Bengali toggle names in the তুমি register the catalog's style guide requires, matching the adjacent Sessions toggle; the now-unusedPanelRightSolidimport dropped aftermainmoved the phone menu intopages/chat/page/MobileTopBar.tsx): 7,041 tests across 467 files (every ChatPage, SidePanel, Workspace, PanelToggles, App, MarkdownPanel, Focus Mode, terminal, mobile and i18n suite, with the per-locale style tests run againstorigin/mainas CI does) passed;npm run i18n:check,tsc, ESLint on every changed file, documentation lint and the production build passed.src/i18n) passed;npm run i18n:check,tsc -p tsconfig.app.json, ESLint on every changed file, documentation lint and the production build passed. The four new catalog keys are translated in all twelve catalogs and the pseudolocale is regenerated.mainwith theSidePanel.tsxclose-button conflict resolved to this PR's control region): 986 tests across 57 files (every changed test file plus the App, i18n and mobile-topbar suites) passed;tsc -b, ESLint on every changed file,npm run i18n:check, documentation lint, the feature-map gate, jscpd with zero clones and the production build passed.npm run i18n:check(19 checks),tsc -p tsconfig.app.json, ESLint and the production build passed; both new assertions were confirmed to fail with their fix reverted. The phone-width reset has no dedicated test.main: 3,047 tests across 234 files (i18n, App, ChatPage, SidePanel and the workspace-control suites) passed; each new assertion was confirmed to fail with its fix reverted;tsc -p tsconfig.app.json, ESLint on every changed file, documentation lint, the feature-map gate, jscpd with zero clones, and the production build passed. Earlier: 57 tests across the five directly affected files passed;tsc, targeted ESLint, documentation lint, jscpd with zero clones, and the production build passed. The preceding action-region patch passed 37 tests, and the earlier post-rebase head passed 201 targeted tests, the 803-test i18n suite, and the 674-test terminal/App/navigation regression set.deadKeys,catalogParity,duplicateKeys,pseudolocaleandnpm run i18n:checkpass with the catalogs unchanged. CI is the authoritative full matrix.docs/feature-map/README.mdgains the Workspace fullscreen and panel toggles row (Chat and sessions section).Manual verification
An isolated production bundle was exercised in Google Chrome on macOS at 1440×900. The test opened, closed, reopened, and fullscreened SidePanel while measuring the live DOM.
aria-pressed="true"and the two toggles are named "Hide terminal" and "Hide side panel"; none of the three title-row controls carriesaria-pressed.x=1403, y=51, width=28, height=28x=1403, y=51, width=28, height=28x=1403, y=51, width=28, height=28y=53, height=32, bottom fused aty=85, 8px of strip above it+cell:y=55, height=28;+, active-tab icon, and active-tab label centers:y=69; all measured deltas:0pxy=51, height=28, centery=65— 4px above the tab row by designinert,elementFromPointon its search field resolves inside the header, and a Playwright click on it succeeds; the shell's content grid (chat and sidebar) is inert.rect.pi-pane, no Lucidesvg) and the terminal toggle renderssvg.lucide-square-terminal(norect.pi-pane), both at 14×14 in 28×28 cells. With the side panel docked bottom, the closed title row's Side toggle draws the bottom pane (y=16.35, width 15), the open strip's draws the open bottom pane (y=13.25), and in both rows its glyph differs from the terminal toggle's.Popped out90×28 andIn split64×28 aty=51, the same row as the 28px toggles.elementFromPointat the strip's Exit full screen (x=1326, y=16) and Hide side panel (x=1403, y=16) resolves to those controls and neither is inside aninertsubtree. Hovering the top edge brings the topbar over the strip and its Focus Mode toggle is the hit target; hovering the left edge brings the rail overlay over the fullscreen layer and its Schedule row is the hit target, not inert. The Windows/Linux Electron caption reserve was not exercised here; it is covered byApp.focusMode.test.tsx.Screenshots / video
Before → after — annotated browser-tab geometry and centerline
Thin outlines identify the browser tab and adjacent
+; all measurement text sits below the UI. The PR base measures tab centery=67vs+centery=66.5(+0.5px); this PR measuresy=69for both (0px). The tab stays 32px with its lower edge fused to the panel body; the+moves onto the tab row, the trailing action cells stay centered on the 40px header.Before — PR base with the changed area labeled
Closed SidePanel — Pop out, Split, Bottom, Side
Open SidePanel — fused browser tabs, half-card frame, two separated action regions
Workspace fullscreen — the same tab subtree remains mounted
Closed title row with both state chips — labels visible at the 28px row height
Bottom-docked SidePanel, closed — the Side toggle draws the bottom pane, the terminal toggle the rail's Terminal glyph
Bottom-docked SidePanel — Fullscreen is a direct button, not a dock-menu item
A file hosted in the workspace — its ⋯ menu carries no file-only Full screen
Side panel and docked terminal open together — both toggles highlighted and named Hide, the nav rail Terminal row pressed
Conversation search owns the dock — panel toggles remain visible
Focus Mode over workspace fullscreen — chrome hidden, the strip's controls take the top edge
Focus Mode over workspace fullscreen — the top edge summons the topbar above the fullscreen layer
Focus Mode over workspace fullscreen — the left edge summons the navigation rail, Terminal row included
Open → close → reopen → fullscreen recording
04-side-panel-toggle-stability.webm
Related Issues
Fixes #10722
Related: #10119, #10619
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)