Skip to content

feat: add workspace fullscreen and stable panel controls - #10757

Closed
Skymore wants to merge 2 commits into
kirodotdev:mainfrom
Skymore:feat/workspace-fullscreen-controls-v2
Closed

Skymore wants to merge 2 commits into
kirodotdev:mainfrom
Skymore:feat/workspace-fullscreen-controls-v2

Conversation

@Skymore

@Skymore Skymore commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let users fullscreen the whole workspace panel in place, keeping its tabs, drafts, browser pages and terminals, with panel toggles that stay under the pointer when the panel opens.

The dashboard can fullscreen one file preview, but it cannot fullscreen the whole workspace panel. Its Sessions, chat, and SidePanel title actions also use slightly different geometry, so opening SidePanel moves its toggle.

Why it matters

Workspace tabs own live editor drafts, browser frames, and terminal sessions. Fullscreening the whole panel lets users focus that work without replacing or remounting it. Stable controls also keep the same action under the pointer when the panel opens.

Not a goal

What changed (motivation → approach → change)

The workspace panel now expands its existing mounted subtree across the dashboard content grid. Tabs, drafts, terminal scrollback, and browser state remain mounted. A focused PTY keeps Escape for its running program; the visible fullscreen control exits the workspace instead.

Workspace fullscreen covers the content rows only; the 42px topbar stays visible and keeps taking input, while the covered content grid (chat, sidebar, rail) is inert for keyboard and screen-reader navigation (the keyboard-scope walk skips the shell's header, and in Focus Mode also the peek triggers and the rail overlay, which paint above the panel and must stay usable). Each panel toggle is named by what its click does, for both its tooltip and its accessible name, and the name follows the panel's state.

Focus Mode keeps both its topbar and navigation rail above workspace fullscreen while leaving banners, sheets, and modals above the chrome. Fullscreen also lifts the peek triggers above its own layer, so the window edges still summon that chrome, and the rail's inert exemption follows Focus Mode, so toggling Focus Mode during fullscreen takes effect immediately. When conversation search temporarily owns the dock, the title-row panel toggles remain visible; choosing Side panel closes search and restores the panel.

A docked terminal that is open when workspace fullscreen starts is covered by it, so every terminal entry (the strip's Bottom-panel toggle, the nav rail Terminal row and the terminal chord) reads it as hidden while fullscreen is on: unlit and named "Show terminal". Activating one leaves fullscreen and brings that terminal back, instead of toggling it closed behind the layer. The terminal-new chord (Ctrl+Shift+`, which adds a tab) also leaves fullscreen first, because the tab it adds lands in that same covered panel. The computer-use live view, which shows and controls an agent driving the real desktop, stays above the fullscreen layer and out of its inert walk; it is non-modal, so it does not take Escape from the workspace. The phone Connect dialog sits above the Focus Mode chrome that this PR raised, and so do the three other dialogs the App shell mounts inside its own root (the update-ready, update-found and startup-video dialogs, z-[65] → z-[68]); at z-[65] the raised Focus Mode rail and topbar painted over them. While the workspace is fullscreen the panel's dock menu (Dock bottom / Dock right) is hidden: the fullscreen layer covers both dock positions, so the choice changed nothing visible.

Workspace fullscreen is desktop-only: the phone renders no activity-bar slot for it to expand, so the shell does not provide the fullscreen context there and a file on the phone keeps its own full-screen action; narrowing the window to a phone width exits workspace fullscreen. On desktop, workspace-hosted files no longer offer a second file-only fullscreen action. Standalone file previews retain it. On Windows and Linux Electron, the fullscreen strip reserves the caption-control band only in Focus Mode, the one case where it reaches the window's top corner; outside Focus Mode the strip sits under the topbar, which already clears it, and macOS hides its traffic lights with the Focus Mode chrome. The SidePanel keeps the recorded fused browser tabs and half-card frame.

Sessions, chat, and SidePanel title rows now share 40px rows, 28px action cells, 14px icons, and 6px spacing within each action region. The closed title row separates session-window actions (Pop out and Split) from workspace-visibility actions (Bottom panel and Side panel) with a hairline and 8px inset. The open SidePanel likewise separates panel-shape actions (dock and Fullscreen) from workspace-visibility actions. Every region has at most two actions while all four controls remain directly accessible. The "Popped out" and "In split" state chips keep their visible labels at that 28px height; they report a session state rather than trigger an action, so they are not reduced to icon-only cells. With SidePanel closed the order is Pop out, Split, Bottom panel, Side panel. With it open the order is Fullscreen, Bottom panel, Side panel. The Side toggle has the exact same bounding box in both states. Bottom-docked SidePanel also keeps Fullscreen as a direct button. Each toggle is named by its action for both tooltip and accessible name ("Show terminal" / "Hide terminal", "Show side panel" / "Hide side panel"), matching the Sessions toggle's "Show / Hide sessions" in the same row; a name that states the action carries no aria-pressed, and neither does the workspace Fullscreen control, whose name already switches between "Full screen" and "Exit full screen"; while the terminal is popped out the terminal control reads "Focus popped-out window", because the click focuses that window and toggles nothing here. The panel root is a region named "Side panel", so it no longer shares the "Activity" name with the Activity view inside it.

The product decision and acceptance criteria are recorded in #10722, and written down as an RFC for the base branch in #15942 (docs/request-for-change/rfc-workspace-fullscreen.md). This is the first focused re-submission of the justified parts reverted with #10119; it deliberately does not restore that PR's pill tabs or flattened panel frame.

Implementation areas: website/src/App.tsx owns route-level fullscreen state; website/src/index.css expands the activity slot; website/src/pages/ChatPage.tsx and website/src/pages/chat/SidePanel.tsx own the two control placements; the shared components and hooks own geometry, Escape precedence, and mounted-state continuity.

Design decisions

Browser tabs stay 32px; the + follows the tabs, not the header cells. The title rows share 28px action cells centered on a 40px row. The side panel's tabs are fused to the strip's bottom edge, so a tab that also shared the action cells' center would have to be 40px tall — it fills the whole strip and stops reading as a tab. The tabs therefore keep the 32px chip recorded on main, with 8px of strip above them, and their center sits 4px below the action cells. The new-tab + belongs to the tab row and is bottom-aligned with the chips (Chrome's new-tab placement), so its glyph shares the tab icon/label center; the trailing Fullscreen / Bottom / Side group keeps the row's center, which is what holds the Side toggle's bounding box identical between the closed and open states.

Rejected: 40px chips (fill the strip, lose the tab silhouette — this was tried in an earlier revision of this PR and reverted), a row-centered + beside 32px chips (its glyph floats 4px above the tab glyphs next to it — the state on main), and lowering the trailing action group instead (moves the Side toggle off its closed-state position). The decision is recorded in the + trigger's comment in SidePanel.tsx, pinned by sidePanelBrowserTabs.test.tsx, and described in website/docs/page-layout.md and the dashboard system spec.

The Side-panel toggle draws SidePanelGlyph; the Bottom-panel toggle draws the nav rail Terminal row's SquareTerminal. This overrides the previous revision, where both toggles drew the project's panel family (PanelBottomSolid / PanelBottomLight and PanelRightSolid / PanelRightLight). #16773, merged after that revision, made every control that opens or closes the side panel draw SidePanelGlyph, whose pane follows where the panel docks; the two controls this PR replaces (the chat header's opener and the open panel's Close) are two of its seven sites. Keeping a fixed right-pane glyph here would undo that fix for these two controls, so the Side-panel toggle uses SidePanelGlyph too. That made the old Bottom-panel glyph collide: with the side panel docked bottom, both toggles drew the same bottom pane side by side. Alternatives considered:

  • keep the bottom-pane glyph on the terminal toggle: the two toggles are identical whenever the side panel docks bottom;
  • keep a fixed right-pane glyph on the Side-panel toggle: points right while the panel opens below, and reverts fix: match side panel glyphs to the dock position #16773 on these two controls;
  • draw the nav rail Terminal row's SquareTerminal on the terminal toggle (chosen): it never matches the side toggle in either dock, the two pointer entries to the docked terminal share one glyph, and it is not a panel-shape glyph, so it does not read as a dock position (the UX lane's earlier note that the bottom-pane icon read as "the panel docked at the bottom", not "terminal").

The cost: the terminal toggle no longer has the panel family's filled/dimmed pane, so its open state is shown by the accent background alone, as on the nav rail Terminal row. The Side-panel toggle keeps the family's filled/dimmed pane, and the Sessions toggle in the same row is unchanged. This PR still adds no <svg>; SquareTerminal is the Lucide icon App.tsx already imports for the rail row.

One fullscreen concept, Escape stays with a focused PTY, two-action title regions, direct Fullscreen in the bottom dock, and four directly accessible title-row actions are the other product decisions. They are recorded in #10722 and were confirmed with @CrysisDeu before this PR was opened; the single fullscreen concept, PTY-Escape handling and workspace fullscreen are also the parts of #10119 the owner named as welcome back in #10619.

The nav rail keeps its Terminal row beside the new title-row Bottom-panel toggle. An earlier revision of this PR removed the row so the docked terminal would have a single pointer entry. The Opus review of that revision showed the cost: the title-row toggle renders only on the desktop chat route (the phone hides the title row, and the side-panel strip has no fullscreen context there), while the docked terminal still renders on every route and the terminal chord ships unbound, so on a phone and on every non-chat page the terminal could no longer be opened. This revision restores the row exactly as on main (label, icon, catalog key and its lit-state test) and keeps the new title-row toggle for the chat page; both read the same open flag, so their pressed states cannot disagree. The row, like the toggle and the chord, now exits workspace fullscreen before toggling, so the docked panel is never opened behind the fullscreen layer, and a terminal already open beneath fullscreen is revealed rather than closed. The page-layout spec, the dashboard spec and the feature map record both entries.

Panel toggles are named by their action, Show or Hide, and carry no aria-pressed. An earlier revision named them "Toggle terminal" and "Toggle side panel" with aria-pressed. That put two naming schemes in one row, because the Sessions toggle beside them on main is "Show sessions" / "Hide sessions" with no pressed state, and it lost the wording main uses for this pair ("Open activity panel" when closed, "Close panel" when open). The open panel's Close button is folded into the Side-panel toggle: same SidePanelGlyph, same position, same action, so "Hide side panel" keeps the close action findable by name. Show / Hide rather than Open / Close: hiding the docked terminal ends no shell, and "Close terminal" already names closing a shell tab. Keeping aria-pressed beside a name that changes would announce the state twice, so both toggles and the Fullscreen control drop it; the accent background still marks an open panel.

The side-panel toggle is unconditional. Both real call sites displayed it, and every title row hosting these controls owns that panel edge. The terminal toggle remains conditional because the terminal can be disabled by configuration.
Review-lane mechanics on this fork PR. The two-action grouping blocker is addressed in code. The icon finding is answered with the reasons under Design decisions above rather than by a code change; accepting it is part of the maintainer decision this PR already needs. Focus-mode chrome remains above workspace fullscreen, and panel toggles remain reachable while conversation search owns the dock; both paths have regression tests. With the nav-rail Terminal row restored, the single-fullscreen concept (and the open panel's Close folding into the Side-panel toggle) is the one remaining product-shape decision that requires an accepted RFC or maintainer same-repo override; fork lanes consume no /ai-review override marker. #15942 is that RFC; once it merges, a push or rebase here lets the First Principles lane read it. The layout hooks on the title-row and strip regions are data-testid attributes, the repo's test-hook convention, rather than bespoke data-panel-controls-* attributes no production code reads.

Tests

  • useWorkspaceFullscreenPanel.test.tsx: mounted-state continuity, nested Escape ownership, annotation portals, focused PTY Escape, the topbar staying interactive while the covered content row and docked rail are inert, and the Focus Mode peek triggers and rail overlay staying interactive, with the rail's exemption following a Focus Mode toggle mid-fullscreen.
  • PanelToggles.test.tsx: each closed panel is named by Show and each open panel by Hide, the tooltip equals the accessible name, and no toggle carries aria-pressed.
  • PanelToggles.test.tsx: Bottom/Side order, 28px cells, 14px icons, active state, terminal popout behavior, and the side-panel toggle rendering with no props and with terminals disabled.
  • WorkspacePanelControls.test.tsx: the panel root region named "Side panel", browser-tab/half-card retention, direct fullscreen in right and bottom docks, control order, geometry classes, and two separated action regions capped at two controls each.
  • sidePanelBrowserTabs.test.tsx: the 32px bottom-fused tab chip, no content offset, the + trigger pinned to the tab row (self-end, never self-center) while the trailing action group stays row-centered.
  • ChatPage.responsivePanel.test.tsx: closed-state order, separate session-window and workspace-visibility regions, shared row/cell/icon geometry, mobile access, resize behavior, and caption reserve.
  • MarkdownPanelCoverage.test.tsx: file-only fullscreen is absent inside the workspace and retained outside it.
  • App.mobileSingleTopbar.test.tsx: the phone chat page receives no workspace-fullscreen context, so its files keep their own full-screen action.
  • App.focusMode.test.tsx: the fullscreen strip's Windows/Linux caption reserve exists only under body.mc-focus-mode, matches the docked header's band (Windows through the same zoom-aware --mc-win-caption-reserve the header uses, Linux at its fixed 112px), and has no macOS rule; in fullscreen the peek triggers sit above the fullscreen layer and below the Focus Mode topbar.
  • PanelToggles.test.tsx: the Side-panel toggle renders the panel family's filled pane when closed and its dimmed pane when open.
  • App.terminalNavActive.test.tsx (restored from main): the nav-rail Terminal row's pressed state follows the docked panel, plus one new case: clicking the row while the workspace is fullscreen exits fullscreen and opens the panel. The new case was confirmed to fail with the row's fullscreen exit reverted.
  • Latest revision (rebased onto current main; the fullscreen strip's Windows caption reserve follows fix(windows): keep the caption reserve zoom-correct and repaint the overlay on every zoom path #17664's zoom-aware --mc-win-caption-reserve instead of a fixed 142px; feat(shortcuts): VS Code terminal keys: Ctrl+ and Ctrl+Shift+ #17587's terminal-new chord leaves workspace fullscreen before adding a tab): App.focusMode.test.tsx pins the Windows strip rule to the shared variable and the Linux rule to the docked header's 112px; App.terminalNavActive.test.tsx pins the new-terminal chord leaving fullscreen and opening the docked terminal. Both assertions were confirmed to fail with their fix reverted. 3,470 tests across 247 files related to the change passed; npm run typecheck, npm run i18n:check, ESLint with zero warnings on every changed file, documentation lint, the feature-map gate, the comment-history gate, jscpd with zero clones and the production build passed. No UI changed in the captured states, so the screenshots are unchanged.
  • Previous revision (rebased onto current main with fix: match side panel glyphs to the dock position #16773's SidePanelGlyph; terminal toggle glyph; App-root dialog layer; dock menu hidden in fullscreen; GUI smoke scenarios and capture scripts follow the renamed toggles): PanelToggles.test.tsx pins the Side-panel toggle drawing the bottom pane under a host that docks bottom and the right pane under one that cannot, the terminal toggle drawing SquareTerminal closed and open, and the two never sharing a glyph; WorkspacePanelControls.test.tsx pins the open panel's Side toggle following the dock and the dock menu absent only while fullscreen; AppRootDialogZIndex.test.tsx and AppRootDialogs.stacking.test.tsx now read TOPBAR_FOCUS_Z as part of the chrome ceiling, so the three dialogs must clear it. Each new assertion was confirmed to fail with its fix reverted. 4,860 tests across 301 files related to the change passed; npm run typecheck, npm run i18n:check, ESLint with zero warnings on every changed file, documentation lint, the feature-map gate, the comment-history gate, jscpd with zero clones and the production build passed. test/gui_user/scenarios/chat-activity-side-panel-toggle.yaml and chat-files-side-panel-browse.yaml now click "Show side panel" / "Hide side panel", and five website/scripts/capture-*.mjs scripts open the panel by "Show side panel"; neither was run here.
  • Previous revision (rebased onto current main; a terminal covered by fullscreen is revealed instead of closed; the computer-use live view stays above fullscreen; the phone Connect dialog sits above the Focus Mode chrome; PanelToggles requires workspaceOpen): terminalEntry.test.ts pins every terminal-entry case; PanelToggles.test.tsx and App.terminalNavActive.test.tsx cover a terminal covered by fullscreen (unlit, "Show terminal", and a click exits fullscreen with the terminal still open); useWorkspaceFullscreenPanel.test.tsx covers the live view staying out of the inert walk without holding Escape; App.focusMode.test.tsx pins its layer between the fullscreen layer and the Focus Mode topbar and its place as a shell child; MobileConnectModal.test.tsx reads the rail's named layer. Each new assertion was confirmed to fail with its fix reverted. 4,964 tests across 333 files passed; npm run i18n:check, tsc -p tsconfig.app.json, ESLint on every changed file, documentation lint, the feature-map gate, jscpd with zero clones and the production build passed.
  • Previous revision (rebased onto current main; layout hooks moved to data-testid; Bengali toggle names in the তুমি register the catalog's style guide requires, matching the adjacent Sessions toggle; the now-unused PanelRightSolid import dropped after main moved the phone menu into pages/chat/page/MobileTopBar.tsx): 7,041 tests across 467 files (every ChatPage, SidePanel, Workspace, PanelToggles, App, MarkdownPanel, Focus Mode, terminal, mobile and i18n suite, with the per-locale style tests run against origin/main as CI does) passed; npm run i18n:check, tsc, ESLint on every changed file, documentation lint and the production build passed.
  • Previous revision (Show / Hide toggle names): 1,003 tests across 53 files (PanelToggles, WorkspacePanelControls, the ChatPage panel suites, the App terminal/focus/mobile suites, the shortcuts modal and src/i18n) passed; npm run i18n:check, tsc -p tsconfig.app.json, ESLint on every changed file, documentation lint and the production build passed. The four new catalog keys are translated in all twelve catalogs and the pseudolocale is regenerated.
  • Previous revision (nav-rail Terminal row restored, rebased onto current main with the SidePanel.tsx close-button conflict resolved to this PR's control region): 986 tests across 57 files (every changed test file plus the App, i18n and mobile-topbar suites) passed; tsc -b, ESLint on every changed file, npm run i18n:check, documentation lint, the feature-map gate, jscpd with zero clones and the production build passed.
  • Previous review fixes (peek triggers above fullscreen, rail inertness following Focus Mode, phone-width reset, distinct panel region name): 3,098 tests across 235 files passed; npm run i18n:check (19 checks), tsc -p tsconfig.app.json, ESLint and the production build passed; both new assertions were confirmed to fail with their fix reverted. The phone-width reset has no dedicated test.
  • Earlier review fixes (phone fullscreen context, Focus Mode inert exemptions, Focus-only caption reserve), rebased onto current main: 3,047 tests across 234 files (i18n, App, ChatPage, SidePanel and the workspace-control suites) passed; each new assertion was confirmed to fail with its fix reverted; tsc -p tsconfig.app.json, ESLint on every changed file, documentation lint, the feature-map gate, jscpd with zero clones, and the production build passed. Earlier: 57 tests across the five directly affected files passed; tsc, targeted ESLint, documentation lint, jscpd with zero clones, and the production build passed. The preceding action-region patch passed 37 tests, and the earlier post-rebase head passed 201 targeted tests, the 803-test i18n suite, and the 674-test terminal/App/navigation regression set.
  • Full website run completed 33,264 tests with the branch's source-shape pins green; deadKeys, catalogParity, duplicateKeys, pseudolocale and npm run i18n:check pass with the catalogs unchanged. CI is the authoritative full matrix.
  • docs/feature-map/README.md gains the Workspace fullscreen and panel toggles row (Chat and sessions section).

Manual verification

An isolated production bundle was exercised in Google Chrome on macOS at 1440×900. The test opened, closed, reopened, and fullscreened SidePanel while measuring the live DOM.

  • Navigation rail: one Terminal row; with the side panel and docked terminal open, the row reports aria-pressed="true" and the two toggles are named "Hide terminal" and "Hide side panel"; none of the three title-row controls carries aria-pressed.
  • Closed Side toggle: x=1403, y=51, width=28, height=28
  • Open Side toggle: x=1403, y=51, width=28, height=28
  • Closed again: x=1403, y=51, width=28, height=28
  • All three headers: 40px; action cells: 28px; icons: 14px; intra-region gap: 6px; each region: at most 2 actions; regions: 1px hairline plus 8px inner inset
  • Browser-tab chip: y=53, height=32, bottom fused at y=85, 8px of strip above it
  • + cell: y=55, height=28; +, active-tab icon, and active-tab label centers: y=69; all measured deltas: 0px
  • Trailing action cells: y=51, height=28, center y=65 — 4px above the tab row by design
  • Browser-tab shape, half-card frame, and mounted tab continuity all passed.
  • In fullscreen the topbar is not inert, elementFromPoint on its search field resolves inside the header, and a Playwright click on it succeeds; the shell's content grid (chat and sidebar) is inert.
  • Workspace-hosted file menu items: Refresh, Add to artifacts, Copy path, Copy content, Download; no Full screen.
  • Conversation search owns the dock: once the side panel's 210ms ease-out finishes, one visible title-row Side toggle in its closed state; clicking it closes search and restores SidePanel.
  • The Side-panel toggle renders the panel family (rect.pi-pane, no Lucide svg) and the terminal toggle renders svg.lucide-square-terminal (no rect.pi-pane), both at 14×14 in 28×28 cells. With the side panel docked bottom, the closed title row's Side toggle draws the bottom pane (y=16.35, width 15), the open strip's draws the open bottom pane (y=13.25), and in both rows its glyph differs from the terminal toggle's.
  • State chips: Popped out 90×28 and In split 64×28 at y=51, the same row as the 28px toggles.
  • Focus Mode over workspace fullscreen (browser, 1440×900): with the chrome hidden, elementFromPoint at the strip's Exit full screen (x=1326, y=16) and Hide side panel (x=1403, y=16) resolves to those controls and neither is inside an inert subtree. Hovering the top edge brings the topbar over the strip and its Focus Mode toggle is the hit target; hovering the left edge brings the rail overlay over the fullscreen layer and its Schedule row is the hit target, not inert. The Windows/Linux Electron caption reserve was not exercised here; it is covered by App.focusMode.test.tsx.

Screenshots / video

Before → after — annotated browser-tab geometry and centerline

Annotated browser-tab alignment comparison

Thin outlines identify the browser tab and adjacent +; all measurement text sits below the UI. The PR base measures tab center y=67 vs + center y=66.5 (+0.5px); this PR measures y=69 for both (0px). The tab stays 32px with its lower edge fused to the panel body; the + moves onto the tab row, the trailing action cells stay centered on the 40px header.

Before — PR base with the changed area labeled

PR base with browser-tab alignment area labeled

Closed SidePanel — Pop out, Split, Bottom, Side

Closed SidePanel with aligned controls

Open SidePanel — fused browser tabs, half-card frame, two separated action regions

Open SidePanel with stable toggle position

Workspace fullscreen — the same tab subtree remains mounted

Workspace fullscreen

Closed title row with both state chips — labels visible at the 28px row height

Popped out and In split chips beside the panel toggles

Bottom-docked SidePanel, closed — the Side toggle draws the bottom pane, the terminal toggle the rail's Terminal glyph

Closed title row with the side panel docked bottom

Bottom-docked SidePanel — Fullscreen is a direct button, not a dock-menu item

Bottom-docked strip with direct Fullscreen

A file hosted in the workspace — its ⋯ menu carries no file-only Full screen

Workspace-hosted file menu without Full screen

Side panel and docked terminal open together — both toggles highlighted and named Hide, the nav rail Terminal row pressed

Side panel and docked terminal open, both toggles highlighted and the nav-rail Terminal row pressed

Conversation search owns the dock — panel toggles remain visible

Conversation search with the title-row panel toggles visible

Focus Mode over workspace fullscreen — chrome hidden, the strip's controls take the top edge

Focus Mode with the workspace fullscreen and the chrome hidden

Focus Mode over workspace fullscreen — the top edge summons the topbar above the fullscreen layer

Focus Mode topbar peeked over the fullscreen workspace

Focus Mode over workspace fullscreen — the left edge summons the navigation rail, Terminal row included

Focus Mode navigation rail peeked over the fullscreen workspace

Open → close → reopen → fullscreen recording

04-side-panel-toggle-stability.webm

Related Issues

Fixes #10722

Related: #10119, #10619

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Skymore
Skymore requested review from a team and krishdhasmana September 14, 2026 10:18
@github-actions github-actions Bot added the fork Pull request from a fork (external contributor) label Sep 14, 2026
@Skymore

Skymore commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Intent: Fullscreen the existing workspace panel without remounting its tabs, drafts, browser frames, or PTYs, while keeping panel controls geometrically stable.
Not a goal: Do not restore #10119 pill tabs, flatten the half-card SidePanel, or redesign unrelated split-view chrome.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Sep 14, 2026
@Skymore
Skymore force-pushed the feat/workspace-fullscreen-controls-v2 branch 2 times, most recently from eb653d9 to b10a947 Compare September 14, 2026 10:40
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of eab8e65f9b8736f0049126c9c1927866090dd3af via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Attachment-09 shows the side panel clipped on its left edge, and no first-time reader has seen the icon-only Fullscreen, Bottom panel and Side panel toggles.

Watch

  • Clipped panel in attachment-09. With a file open and its overflow menu showing, the panel's left edge cuts through the first tab icon, the heading reads "emo project" and the body reads "file hosted inside the workspace pa…". The chat composer also extends under the panel. If this is the new 28px header geometry or the layout="position" motion on the panel's container rather than a frame caught mid-animation, every user who opens a file sees clipped content. That happens often and costs friction every time. Fix: re-capture that view once the panel has settled, or fix the width overflow.
  • Icon-only controls with no blind read. The terminal, side panel, Fullscreen (Maximize2/Minimize2) and ⋯ dock-menu cells have no visible text, and none of them is one of the few universally understood icons. Only their tooltips name them. The PR exists to add the Fullscreen control, so it is on the main path. This lane cannot confirm that a newcomer reads the diagonal-arrows icon as "fullscreen the whole workspace" rather than "fullscreen this file", which is what the file preview's own action used to mean. Fix: push the branch to this repo so the blind-read lane runs.
  • Covered terminal is labelled "Show terminal". During fullscreen the terminal is still open underneath, but its toggle is unlit and says "Show terminal", and clicking it also exits fullscreen. The tooltip doesn't say that. Users who rely on the tooltip will be surprised that the layout changes when they click. This only happens during fullscreen, so it's low severity. Fix: label it "Exit full screen and show terminal" while fullscreen is on.

[UX-REVIEWED] eab8e65

Description read

[DESCRIPTION-READ] c0c9dd94c8b77cd39bf38e41a71c264efe8d9de6dc7badc35021a521f3b0432b

That sha256 names everything this verdict read: the PR description, plus the 17 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — 🟡 CONCERNS

Design-level review of eab8e65f9b8736f0049126c9c1927866090dd3af via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

Fullscreen makes every shell child inert unless it is on a hand-kept allowlist, so a shell-level surface showing at entry stays visible above the panel but stops responding.

Watch

  • The inert walk blocks by default. Cause: useWorkspaceFullscreenPanel sets inert on every sibling at each level up to dashboard-shell. It skips only header, .focus-peek-*, .focus-chrome-rail and [data-above-workspace-fullscreen] (paintsAboveFullscreen). Mechanism: other shell children paint above the 65 layer but are not on that list. One example is the agentSwitchNotice status at App.tsx:2268 (fixed z-[70], with a Dismiss button). If one of these is on screen when fullscreen starts, it gets inert = true and stays visible on top. Consequence: the user sees a toast or banner over the workspace whose controls ignore clicks and keyboard until they leave fullscreen. Any floating shell surface added later hits the same trap silently unless its author knows to add the attribute. The PR already had to move ComputerUseLiveView and tag it for this reason.
    Clears when: either the walk inerts only the elements fullscreen actually covers (the content column and the docked rail), or a test asserts that every shell child with a z-index above 65 is exempt.
  • Backwards compatibility could not be checked. The description is cut off at 8000 bytes before any ## Backwards compatibility section. The PR removes the accessible names "Open activity panel" (title row) and "Close panel" (strip on the desktop chat). Readers that still use the old names include website/scripts/capture-findbar-escape-focus.mjs, which clicks "Close panel" on chat. No product entry point breaks: on /members and on the phone the context is null, so "Close panel" is still rendered there. The author's list of readers was still not visible to this review.
    Clears when: the section is visible within the captured description, or the remaining capture scripts are updated.

[DESIGN-REVIEWED] eab8e65

Description read

[DESCRIPTION-READ] 10e163eadebf325320aba2dd44f64e02ef96ba9fb7228389d1ef333860b0aaaa

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed eab8e65f9b8736f0049126c9c1927866090dd3af via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] eab8e65

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — 🔴 BLOCK

Premise-level review of eab8e65f9b8736f0049126c9c1927866090dd3af via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: BLOCK

product-shape change without accepted RFC: desktop workspace files lose their own fullscreen action, and the RFC (#15942) cited for it isn't on base.

Not justified as shipped

  • Item 5 — product shape, no decision on record: the description says "workspace-hosted files no longer offer a second file-only fullscreen action"; the diff has onFullscreen={workspaceFullscreen ? undefined : …}.
  • Item 4 — duplicate of the nav-rail Terminal row (website/src/App.tsx) and the terminal chord: the Goal asks for Side toggles that stay put, not a third terminal entry point. Base ChatPage.tsx has 0 toggleBottomTerminal uses.
    Subtraction: drop the terminal Btn from PanelToggles and keep only the Side toggle.
    Clears when: the title-row terminal button is removed, or a human amends the Goal to include it.
Inventory (8 items) — 6 justified

Intent: let a desktop user fullscreen the whole workspace panel in place, with a Side-panel toggle that doesn't move. ADDITION.

  1. New Fullscreen button in the open side panel expands it over the content grid — justified
  2. Side toggle moved to the trailing edge (Pop out, Split, | Bottom, Side) — justified
  3. "Open activity panel"/"Close panel" relabelled "Show/Hide side panel" — justified
  4. New Bottom-panel (terminal) toggle in the chat title row — duplicate of the nav-rail Terminal row and chord
  5. Desktop workspace files lose their own fullscreen action — product shape, no decision on record
  6. Terminal entries exit fullscreen and read as hidden while it's on — justified
  7. Dialogs moved from z-65 to z-68 and Focus Mode chrome raised above fullscreen — justified
  8. Dock menu hidden during fullscreen; Escape no longer closes a file in fullscreen — justified

Blockers

  • product-shape change without accepted RFC: file-only fullscreen removed from workspace-hosted files
    This removes an existing user-facing capability on desktop. The base RFC status list has no rfc-workspace-fullscreen.md, and issue Workspace fullscreen with aligned panel controls #10722 is neither of the two recorded forms this check accepts.
    Clears when: an RFC covering this removal is merged on base with a non-draft status (then push or rebase), or a maintainer posts /ai-review override first-principles eab8e65f9b8736f0049126c9c1927866090dd3af: <decision>.

[FIRST-PRINCIPLES-REVIEWED] eab8e65

Description read

[DESCRIPTION-READ] f269eb48fa5fca8163b6d983e1b566df679d2b0604536b9c01dab1f9ae3870e8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed eab8e65f9b8736f0049126c9c1927866090dd3af via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] eab8e65

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 14, 2026
@Skymore
Skymore force-pushed the feat/workspace-fullscreen-controls-v2 branch 2 times, most recently from 72daf47 to d90afaf Compare September 14, 2026 20:20
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 14, 2026
@Skymore

Skymore commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • Workspace toolbars exceed the two-button cap span=fd89d98b48d2

Outcome: maintainer override requested; not changed in 87ba6fc.
The four direct actions in each row (closed: Pop out, Split, Bottom panel, Side panel; open: Fullscreen, Bottom panel, Side panel after the dock menu) are the design recorded in #10722 and confirmed with CrysisDeu before the PR was opened, including that Fullscreen stays a direct button in the bottom dock and that no divider separates the groups. On the base branch the closed row already carried three direct actions (Pop out, Activity toggle, Split); this change reorders them and adds the Bottom-panel toggle.
max-two-buttons-per-row is blocking: true, so the author cannot waive it, and the fork lanes consume no override marker: clearing it needs a maintainer to push this branch to the repository and record /ai-review override gpt <head>: <decision> there.

@Skymore

Skymore commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author
  • New controls use hand-rolled icons span=550fc8634a3d

Outcome: rebutted with evidence; no code change.
components/icons/panels.tsx and all six glyphs it exports exist on main; the diff adds no <svg> and the rule's regex gate (check-added: <svg viewBox) reports nothing. The base branch already draws these exact controls with these glyphs: the chat row's activity toggle (PanelRightSolid, ChatPage.tsx), the SidePanel close control (PanelRightLight, SidePanel.tsx), the Sessions sidebar toggles (PanelLeftSolid/PanelLeftLight) and SplitGlyph (PanelBottomLight). PanelToggles.tsx is a new file that reuses that existing family; it introduces no new icon.
Switching only these two toggles to Lucide's PanelRight/PanelBottom would place two icon styles in one row beside the Sessions toggle, which is the inconsistency the shared row geometry is meant to remove. The rationale is now stated in the PR description under Design decisions.

@Skymore

Skymore commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author
  • New workspace-fullscreen feature is absent from the feature map span=492e113e5b07

Outcome: fixed in d90afaf.
docs/feature-map/README.md gains the row Workspace fullscreen and panel toggles in the Chat and sessions section, naming the fullscreen control, the title-row toggles, the Escape ownership rule and the owning files (SidePanel.tsx, PanelToggles.tsx, WorkspacePanelContext.ts, useWorkspaceFullscreenPanel.ts, ChatPage.tsx, App.tsx). scripts/check_feature_map.py passes against origin/main.

@Skymore

Skymore commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • Chat title row holds four direct actions span=7c333eae7afa

Outcome: maintainer override requested; not changed in 87ba6fc.
Same row as the GPT finding on this file: the order Pop out, Split, Bottom panel, Side panel is the design recorded in #10722 and confirmed with CrysisDeu. The base row carried three direct actions; this change reorders them and adds the Bottom-panel toggle. The rule is blocking and the fork lane consumes no override, so the clearance is a maintainer pushing the branch to the repository and recording /ai-review override opus <head>: <decision>.

@Skymore

Skymore commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor Author
  • SidePanel strip trailing group holds four direct actions span=2348f2612611

Outcome: maintainer override requested; not changed in 87ba6fc.
The dock menu, Fullscreen, Bottom panel and Side panel in one dividerless group is the design recorded in #10722 and confirmed with CrysisDeu; it also fixes Fullscreen as a direct button in the bottom dock and keeps the Side toggle's closed-state bounding box. Collapsing any of them into the dock menu would change those recorded points, so it is left for the maintainer override described in the GPT disposition.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Sep 16, 2026
@dwu96 dwu96 added the needs-pr-triage PR scanner: awaiting automated triage label Sep 21, 2026
@dwu96

dwu96 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: dwu96#8c08bee0]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:

  • Get the First Principles BLOCK cleared by a maintainer, or land the RFC. This is the irreducible blocker and it is a product-shape decision, not a code defect: workspace-hosted files lose their file-only fullscreen action (onFullscreen={workspaceFullscreen ? undefined : ...} in MarkdownPanel.tsx), and the lane holds that Workspace fullscreen with aligned panel controls #10722 is an issue, not an accepted RFC or a recorded override. Its own clearing conditions are an RFC covering workspace fullscreen merging non-draft on base followed by a push or rebase, or a maintainer pushing this branch to kirodotdev/KiroCrew and recording /ai-review override first-principles 673ecfc612972e4cf755721c02bb2fd3291b535e: <decision>. Your 2026-09-15 note already says the layout was confirmed with @CrysisDeu and that the fork lane still needs his override to record it — that override is the step this PR is waiting on, and only a maintainer can take it.
  • Decide how to resolve max-two-buttons-per-row, upheld as blocking by both GPT 5.6 and Opus 4.8. The chat title row (Pop out, Split, Toggle terminal, Toggle side panel) and the SidePanel strip (⋯, Fullscreen, Toggle terminal, Toggle side panel) each render four peer icon buttons in one dividerless gap-1.5 group, and the SidePanel row was a compliant two-button separated region whose divider this PR deletes. The lanes offer two remedies — restore a separating region between the two-button subgroups, or move the extra actions into the existing ⋯ overflow menu — and choosing between them is a layout call on your design, so I am not picking one for you.
  • Decide the use-lucide-icons resolution, also upheld as blocking. PanelToggles.tsx imports hand-rolled PanelBottomLight/Solid and PanelRightLight/Solid from ./icons/panels; the rule directs PanelBottom and PanelRight from lucide-react. Swapping them drops the light/solid pair you are using to distinguish open from closed, so this needs your intent, not a mechanical substitution.
  • Two further First Principles subtractions are scope reductions I will not make on your behalf: deleting the terminalEnabled branch in PanelToggles.tsx (item 5, called a third entry to the docked terminal beside App.tsx:4274 and the chord at App.tsx:2454), and deleting the showWorkspace prop (item 10, both real callers pass true). Each clears either by the deletion or by the maintainer decision covering it.
  • Rebase onto current main. The branch is CONFLICTING and carries the merge conflict label, so CI cannot give a clean read until it is rebased.

I am not claiming this PR for automated fixes: every blocking item resolves to a design or product decision that is yours or a maintainer's, and the pipeline must not change a PR's design direction.

When you've addressed these, the pipeline will re-assess on its next cycle.

@dwu96 dwu96 added needs-author-decision PR blocked on author input and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 21, 2026
@Skymore
Skymore force-pushed the feat/workspace-fullscreen-controls-v2 branch from 673ecfc to feba2f6 Compare September 22, 2026 09:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Sep 22, 2026
@Skymore
Skymore force-pushed the feat/workspace-fullscreen-controls-v2 branch from feba2f6 to bf23145 Compare September 22, 2026 10:54
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 22, 2026
@Skymore
Skymore force-pushed the feat/workspace-fullscreen-controls-v2 branch from 33ad784 to 8c2abe9 Compare September 22, 2026 17:57

Copy link
Copy Markdown
Contributor

PR triage (automated, 2026-10-05): rebase needed, plus an overlap to discuss

Checked head 11aab98f75 against origin/main a92dde1a6c. Merge base is 5fdc0bc958, and the branch is 234 commits behind.

Rebase. git merge-tree against main conflicts in website/src/pages/ChatPage.tsx, website/src/pages/chat/SidePanel.tsx and docs/feature-map/README.md.

Not covered by main. Workspace fullscreen is not on main. #10119 (PR) added it and #10626 reverted it, and main has no WorkspaceFullscreenContext, useWorkspaceFullscreenPanel or [data-workspace-fullscreen] rule. This PR is not superseded.

Overlap that needs a merge discussion:

No new P0 was found. The product-shape change (files hosted in the workspace lose their file-only Full screen on desktop) is already raised by the First Principles BLOCK and by the 2026-09-21 comment, so this triage adds no separate request-changes review.

Rui Tao added 2 commits October 8, 2026 23:33
Expand the existing workspace panel without remounting its tabs, drafts,
or terminal sessions. Keep panel controls on one shared geometry so
opening the side panel does not move its toggle. Fullscreen covers the
content rows only: the 42px topbar stays visible and interactive, so
the keyboard-scope walk stops below the dashboard shell instead of
marking the topbar inert.

The side panel's browser tabs stay 32px chips fused to the strip's
bottom edge, so the strip shows above them and they keep their tab
silhouette. Their center sits 4px below the strip's 28px action cells;
the new-tab trigger follows the tabs, the way Chrome bottom-aligns its
new-tab button, while the trailing Fullscreen, Bottom and Side actions
keep the row's center. Rejected: 40px chips (fill the strip, stop
reading as tabs), a row-centered trigger (floats above the tab glyphs
beside it), and lowering the trailing actions (moves the Side toggle
away from its closed-state position).

The title-row Bottom-panel toggle is the chat page's pointer entry to
the docked terminal, and the nav rail keeps its Terminal row: it is the
only pointer entry on other routes and in the phone drawer, where
neither host of the toggles renders. Both entries read the panel's one
open flag, and both, like the rebindable terminal chord, exit workspace
fullscreen before toggling so the panel never opens behind it.

Placing the Bottom-panel toggle beside the Side-panel one puts two panel
glyphs side by side; the base SidePanel comment that kept them apart is
retired for the recorded layout. Each toggle is named by its action and
the name follows the panel's state (Show / Hide terminal, Show / Hide
side panel), as tooltip and accessible name alike, with no aria-pressed. The "Popped out" and "In split" state chips keep their
visible labels at the shared 28px row height. The toggles reuse the
panel glyph family the title rows already draw; no new icon is
introduced.

PanelToggles takes no showWorkspace flag. Every title row that hosts
these controls owns the side panel's edge, so a row without its toggle
would leave that panel with no way to open it; the terminal toggle stays
conditional because the docked terminal can be disabled by config.
Raise the focus-mode topbar and rail above workspace fullscreen, keep the title-row panel toggles while conversation search owns the dock, and keep the phone connect dialog above the raised chrome. A docked terminal covered by fullscreen reads as hidden, and its entries reveal it instead of closing it. The computer-use live view stays above fullscreen and out of its inert walk. App-root dialogs sit above that chrome too, and the dock menu is hidden while fullscreen covers both dock positions.

The Side-panel toggle draws SidePanelGlyph, so its pane follows where the panel docks, as every other side-panel control does. The Bottom-panel toggle draws the nav rail Terminal row's SquareTerminal, because a bottom-pane glyph would match the Side-panel toggle whenever the side panel docks bottom.
@iamwhatever

Copy link
Copy Markdown
Contributor

Thank you @Skymore for the careful work here, including the accessibility and Focus Mode handling. We are closing this PR because the design in #10722 has not received a maintainer sign-off yet, and the branch now conflicts heavily with main. The need stays tracked in #10722. Once the design is approved there, a fresh PR on current main (ideally splitting the panel-toggle alignment from workspace fullscreen) would be very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge needs-author-decision PR blocked on author input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace fullscreen with aligned panel controls

4 participants