Repository navigation
Conversation
a89e1e3 to
69a8926
Compare
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS This is a docs-only draft RFC with no runtime surface, and it can be walked back cleanly. The only problem is that the description no longer matches the diff. Notes
[DESIGN-REVIEWED] e70d4d5 Description read[DESCRIPTION-READ] 5471c997b6ed92a9c31244e8905f60881e7f6845fb56e40e929d2d3a08b1a2b3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] e70d4d5 |
69a8926 to
85e5797
Compare
85e5797 to
5e9e599
Compare
5e9e599 to
4cb01a0
Compare
582db26 to
7417fae
Compare
7417fae to
52357c6
Compare
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
52357c6 to
5240c90
Compare
|
Thanks for this PR. It now conflicts with main. Could you rebase onto the latest main and resolve the conflicts? We will review it again once it is rebased and CI is green. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Thanks for writing this up. The RFC's claims about current main still hold. One change is needed before a maintainer can take the design decision.
- §4 records a panel-control change that goes beyond the Goal (
docs/request-for-change/rfc-workspace-fullscreen.md:63, plus the third sentence of line 21, the "and panel controls" heading at line 69, and the exit criteria at lines 80-81).- What happens: if this merges as
accepted, the record also counts these as decided: replacing the open panel's Close button with a Side-panel toggle, the "Show/Hide side panel" naming, a new Bottom-panel toggle, and the bounding-box and two-actions-per-region rules. The #10619 decision welcomes back only workspace fullscreen, the single fullscreen concept, PTY-Escape handling, hairline dividers and the title-row z-index fix. It lists the relabeled hide controls as undeclared. The comment that closed #10757 also asked for the panel-toggle alignment to be split from workspace fullscreen. - Smallest fix: delete the §4 toggle, naming and geometry rules, the matching summary sentence, exit criteria 80-81 and "and panel controls" in the Phase 1 heading. Keep one sentence from line 65: every docked-terminal entry exits workspace fullscreen before it toggles. §1-§3 stay as they are, so the Goal still holds. The panel-control shape can go in its own RFC or issue.
- What happens: if this merges as
This is a design document for a change to behaviour users already rely on, so a maintainer still needs to sign off the design before it can merge, even after the fix.
Optional:
- The
acceptedstatus (line 3) and the "confirmed with CrysisDeu" lines (17, 104) have no public record behind them. #10757 was closed because #10722 had no maintainer sign-off yet. You could land this asdraftwith "Acceptance requested from a maintainer", or link the comment that records the confirmation. - #10757 was closed unmerged on 2026-11-01, but the RFC still names it as the implementation (line 9, 17, 71, 104, and the README row). You could set
implementation-prs: []and describe Phase 1 as not started.
|
Addressed the review in 2fb97a0: §4 now keeps only that every docked-terminal entry exits workspace fullscreen first; the panel-control toggles, naming and geometry rules, the matching summary sentence, exit criteria and the "and panel controls" heading are gone (they can go in their own RFC). Also took the optional points: status is |
Code change approver recommendation: ApproveWhy: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This PR changes docs only. It adds a
The RFC's status is the same in its front matter and its index row ( An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Follow-up on the earlier review:
This review found no blocking problem on this head. The diff changes only two docs files. I re-checked the RFC's code claims on current main, and these still hold: Optional:
|
|
Stale-PR cleanup note: every other check on this head passes. The fork Security Scope Review lane failed twice (run https://github.com/kirodotdev/KiroCrew/actions/runs/44194516385, first attempt and one rerun) because the workflow's GitHub App hit the installation API rate limit ( |
Write down the owner decision from kirodotdev#10619 and the shape agreed in kirodotdev#10722 (workspace fullscreen, one fullscreen concept, Escape order, panel toggles) so the First Principles lane can read it from the base branch.
Drop the panel-control redesign from section 4 and the exit criteria, keep only that every docked-terminal entry exits fullscreen first. Mark the RFC draft with acceptance requested, since kirodotdev#10757 closed unmerged and no public record confirms the shape.
Problem / Motivation
Goal: Record the owner decision behind #10757, workspace fullscreen with one fullscreen concept, as an RFC the First Principles lane can read from the base branch.
#10757 adds fullscreen for the whole workspace panel and, on the desktop chat route, drops the file-only Full screen from files hosted in that panel. Dropping a user-facing action is product shape, so the First Principles lane needs a non-draft RFC on the base branch or a maintainer override. #10757 is a fork PR, where the override is not consumed. The decision itself already exists: CrysisDeu's owner decision in #10619 named "workspace fullscreen, the single fullscreen concept, PTY-Escape handling" as welcome back in a separate PR, and #10722 records the agreed shape. It has not been written down where the lane looks.
Why it matters
Without a recorded decision #10757 cannot pass First Principles, and the lane's reading of the one-fullscreen change has flipped between runs: it blocked on it at
673ecfc, treated it as justified at770d37055, and blocked on it again ataf8cd93a2and15127bfaa, the last time naming both the file-only fullscreen and the open panel's Close control ("existing user-facing capabilities replaced by default"). An RFC on main makes that reading deterministic.Not a goal
What changed (motivation → approach → change)
docs/request-for-change/rfc-workspace-fullscreen.md(accepted): workspace fullscreen on the desktop chat route (the panel subtree stays mounted, the topbar stays interactive, covered content is inert, Focus Mode chrome stays above), the single fullscreen concept (a workspace-hosted file omits its own Full screen; the phone and the Crew Members page keep it), Escape precedence (nested overlays, then a focused terminal, then the workspace), and the panel controls (the open panel's Close becomes the Side-panel toggle; the nav rail Terminal row stays). One phase, feat: add workspace fullscreen and stable panel controls #10757, with testable exit criteria. Its "Verified ata92dde1a6c" line names the symbols read on main. The artifact viewer's own fullscreen and a browser tab's Expand (which hides the nav rail and the sessions list) stay as they are and are listed as non-goals and open questions.README.md): a row for the new RFC and a sentence in the audit paragraph.The status is
acceptedbecause it records a decision a maintainer already made in #10619 rather than proposing one; a maintainer merging this PR confirms the shape. If you would rather accept it in a separate step, as #15144 then #15531 did, say so and I will land it asdraft.Backwards compatibility
Compatible: documentation only.
Tests
N/A — documentation only.
scripts/docs-lint.shandscripts/check_comment_history.pypass locally.Manual verification
N/A — documentation only.
Related Issues
Part of #10722
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement