Skip to content

docs(rfc): record workspace fullscreen and one fullscreen concept - #15942

Open
Skymore wants to merge 2 commits into
kirodotdev:mainfrom
Skymore:docs/rfc-workspace-fullscreen
Open

Skymore wants to merge 2 commits into
kirodotdev:mainfrom
Skymore:docs/rfc-workspace-fullscreen

Conversation

@Skymore

@Skymore Skymore commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the owner decision behind #10757, workspace fullscreen with one fullscreen concept, as an RFC the First Principles lane can read from the base branch.

#10757 adds fullscreen for the whole workspace panel and, on the desktop chat route, drops the file-only Full screen from files hosted in that panel. Dropping a user-facing action is product shape, so the First Principles lane needs a non-draft RFC on the base branch or a maintainer override. #10757 is a fork PR, where the override is not consumed. The decision itself already exists: CrysisDeu's owner decision in #10619 named "workspace fullscreen, the single fullscreen concept, PTY-Escape handling" as welcome back in a separate PR, and #10722 records the agreed shape. It has not been written down where the lane looks.

Why it matters

Without a recorded decision #10757 cannot pass First Principles, and the lane's reading of the one-fullscreen change has flipped between runs: it blocked on it at 673ecfc, treated it as justified at 770d37055, and blocked on it again at af8cd93a2 and 15127bfaa, the last time naming both the file-only fullscreen and the open panel's Close control ("existing user-facing capabilities replaced by default"). An RFC on main makes that reading deterministic.

Not a goal

What changed (motivation → approach → change)

  • New RFC, docs/request-for-change/rfc-workspace-fullscreen.md (accepted): workspace fullscreen on the desktop chat route (the panel subtree stays mounted, the topbar stays interactive, covered content is inert, Focus Mode chrome stays above), the single fullscreen concept (a workspace-hosted file omits its own Full screen; the phone and the Crew Members page keep it), Escape precedence (nested overlays, then a focused terminal, then the workspace), and the panel controls (the open panel's Close becomes the Side-panel toggle; the nav rail Terminal row stays). One phase, feat: add workspace fullscreen and stable panel controls #10757, with testable exit criteria. Its "Verified at a92dde1a6c" line names the symbols read on main. The artifact viewer's own fullscreen and a browser tab's Expand (which hides the nav rail and the sessions list) stay as they are and are listed as non-goals and open questions.
  • RFC index (README.md): a row for the new RFC and a sentence in the audit paragraph.

The status is accepted because it records a decision a maintainer already made in #10619 rather than proposing one; a maintainer merging this PR confirms the shape. If you would rather accept it in a separate step, as #15144 then #15531 did, say so and I will land it as draft.

Backwards compatibility

Compatible: documentation only.

Tests

N/A — documentation only. scripts/docs-lint.sh and scripts/check_comment_history.py pass locally.

Manual verification

N/A — documentation only.

Related Issues

Part of #10722

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@Skymore
Skymore requested a review from a team as a code owner October 1, 2026 17:20
@Skymore
Skymore requested a review from chenmingwei23 October 1, 2026 17:20
@Skymore
Skymore force-pushed the docs/rfc-workspace-fullscreen branch from a89e1e3 to 69a8926 Compare October 1, 2026 17:21
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed e70d4d502abc60a5e2c1d3f1c9247009b3c8714a via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e70d4d5

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of e70d4d502abc60a5e2c1d3f1c9247009b3c8714a via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This is a docs-only draft RFC with no runtime surface, and it can be walked back cleanly. The only problem is that the description no longer matches the diff.

Notes

  • The description is stale against the diff, so reviewers will check the wrong decision. It says the RFC is accepted, that "the open panel's Close becomes the Side-panel toggle", and that the one phase is "feat: add workspace fullscreen and stable panel controls #10757". The diff ships status: draft, says the panel-controls shape "is out of scope here", and records that feat: add workspace fullscreen and stable panel controls #10757 was "closed unmerged". Update "What changed" and the Tests note; the frozen Goal line can stay.
  • As a draft, this does not yet do what the Goal says: give the First Principles lane a decision to read. A maintainer has to flip it to accepted, in the document's Status line or in a follow-up PR, before any implementation PR can rely on it.

[DESIGN-REVIEWED] e70d4d5

Description read

[DESCRIPTION-READ] 5471c997b6ed92a9c31244e8905f60881e7f6845fb56e40e929d2d3a08b1a2b3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed e70d4d502abc60a5e2c1d3f1c9247009b3c8714a via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

Notes:

  • rfc-workspace-fullscreen.md front matter pairs audited-at: a92dde1a6c with last-audited: 2026-11-14, but the README prose says that commit was read on 2026-10-05. The RFC's claims still hold on the current tree (there is no WorkspaceFullscreenContext, and MarkdownPanel still passes onFullscreen to its menu unconditionally), so only the freshness metadata disagrees.

[OPUS-REVIEWED] e70d4d5

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 1, 2026
@Skymore
Skymore force-pushed the docs/rfc-workspace-fullscreen branch from 69a8926 to 85e5797 Compare October 2, 2026 01:40
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 2, 2026
@Skymore
Skymore force-pushed the docs/rfc-workspace-fullscreen branch from 85e5797 to 5e9e599 Compare October 2, 2026 20:49
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 2, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-workspace-fullscreen branch from 5e9e599 to 4cb01a0 Compare October 4, 2026 07:12
@iamwhatever

Copy link
Copy Markdown
Contributor

Rebased onto main (b2060d6 -> 5e9e599, now 4cb01a0) to clear the merge conflict in docs/request-for-change/README.md. CI re-running.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 4, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 7, 2026
@Skymore
Skymore force-pushed the docs/rfc-workspace-fullscreen branch from 582db26 to 7417fae Compare October 7, 2026 21:00
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 7, 2026
@Skymore
Skymore force-pushed the docs/rfc-workspace-fullscreen branch from 7417fae to 52357c6 Compare October 7, 2026 22:25
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision e70d4d502abc60a5e2c1d3f1c9247009b3c8714a ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision e70d4d502abc60a5e2c1d3f1c9247009b3c8714a touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 7, 2026
@Skymore
Skymore force-pushed the docs/rfc-workspace-fullscreen branch from 52357c6 to 5240c90 Compare October 8, 2026 20:14
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Oct 8, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Thanks for this PR. It now conflicts with main. Could you rebase onto the latest main and resolve the conflicts? We will review it again once it is rebased and CI is green.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up. The RFC's claims about current main still hold. One change is needed before a maintainer can take the design decision.

  1. §4 records a panel-control change that goes beyond the Goal (docs/request-for-change/rfc-workspace-fullscreen.md:63, plus the third sentence of line 21, the "and panel controls" heading at line 69, and the exit criteria at lines 80-81).
    • What happens: if this merges as accepted, the record also counts these as decided: replacing the open panel's Close button with a Side-panel toggle, the "Show/Hide side panel" naming, a new Bottom-panel toggle, and the bounding-box and two-actions-per-region rules. The #10619 decision welcomes back only workspace fullscreen, the single fullscreen concept, PTY-Escape handling, hairline dividers and the title-row z-index fix. It lists the relabeled hide controls as undeclared. The comment that closed #10757 also asked for the panel-toggle alignment to be split from workspace fullscreen.
    • Smallest fix: delete the §4 toggle, naming and geometry rules, the matching summary sentence, exit criteria 80-81 and "and panel controls" in the Phase 1 heading. Keep one sentence from line 65: every docked-terminal entry exits workspace fullscreen before it toggles. §1-§3 stay as they are, so the Goal still holds. The panel-control shape can go in its own RFC or issue.

This is a design document for a change to behaviour users already rely on, so a maintainer still needs to sign off the design before it can merge, even after the fix.

Optional:

  • The accepted status (line 3) and the "confirmed with CrysisDeu" lines (17, 104) have no public record behind them. #10757 was closed because #10722 had no maintainer sign-off yet. You could land this as draft with "Acceptance requested from a maintainer", or link the comment that records the confirmation.
  • #10757 was closed unmerged on 2026-11-01, but the RFC still names it as the implementation (line 9, 17, 71, 104, and the README row). You could set implementation-prs: [] and describe Phase 1 as not started.

@iamwhatever

Copy link
Copy Markdown
Contributor

Addressed the review in 2fb97a0: §4 now keeps only that every docked-terminal entry exits workspace fullscreen first; the panel-control toggles, naming and geometry rules, the matching summary sentence, exit criteria and the "and panel controls" heading are gone (they can go in their own RFC). Also took the optional points: status is draft with "Acceptance requested from a maintainer", implementation-prs: [], and #10757 is described as closed unmerged in the RFC and the README row. A maintainer still needs to sign off the design.

@KiroCrewCaptain

KiroCrewCaptain commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This PR changes docs only. It adds a draft RFC for workspace fullscreen and one fullscreen concept, plus a matching index row and an audit sentence in the RFC README. I spot-checked the code claims the RFC makes against the repo at the PR's head commit, and they hold:

  • MarkdownPanel always passes onFullscreen to its menu (MarkdownPanel.tsx:1409).
  • WebPreviewPanel has its own toggleExpand.
  • App.tsx renders #activity-bar-slot on desktop.
  • WorkspaceFullscreenContext does not exist yet.

The RFC's status is the same in its front matter and its index row (draft). It sets no new trust boundary, state or limit, and all CI and review lanes passed. The PR description claims the RFC is accepted and says #10757 is its single phase. The files say draft and that #10757 was closed unmerged. That is the description over-claiming while the files take the cautious route, so it does not block. A maintainer can move the RFC to accepted later.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 09a6900934 · 105 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Follow-up on the earlier review:

This review found no blocking problem on this head. The diff changes only two docs files. I re-checked the RFC's code claims on current main, and these still hold: MarkdownPanel passes onFullscreen with no condition, WebPreviewPanel has toggleExpand, App.tsx renders #activity-bar-slot, and WorkspaceFullscreenContext does not exist. The exit criteria are written as checks a test can make, which gives the later implementation a clear test plan.

Optional:

  • Main has had its own docked-terminal fullscreen since feat(terminal): search scrollback and go fullscreen from the dock terminal #22673 (2026-11-02): a Fullscreen item in the dock terminal's menu (BottomTerminalPanel.tsx, terminal-menu-fullscreen). The RFC still says "a terminal tab has no fullscreen at all" (line 25). You could list this fullscreen as a non-goal or an open question, the way the RFC already treats the artifact fullscreen and the browser Expand, and say how §4 relates to it.
  • The terminal chord no longer ships unbound. On main, panelToggleShortcuts.ts:88-89 binds terminal to Ctrl plus the backtick key, and terminal-new to Ctrl+Shift plus the backtick key. terminal-new also opens the docked panel. You could fix lines 63 and 95 and add terminal-new to the exit criterion on line 80.
  • The front matter pairs last-audited: 2026-11-14 with audited-at: a92dde1a6c, which is a 2026-10-05 commit. The README sentence names a third commit, 941058541. A re-audit against current main could set all three to the same commit and date.

@iamwhatever

Copy link
Copy Markdown
Contributor

Stale-PR cleanup note: every other check on this head passes. The fork Security Scope Review lane failed twice (run https://github.com/kirodotdev/KiroCrew/actions/runs/44194516385, first attempt and one rerun) because the workflow's GitHub App hit the installation API rate limit (API rate limit exceeded for installation), not because of anything in this PR. A maintainer needs to rerun that lane once the limit has reset. Nothing is needed from the author.

Rui Tao and others added 2 commits November 19, 2026 20:52
Write down the owner decision from kirodotdev#10619 and the shape agreed in kirodotdev#10722 (workspace fullscreen, one fullscreen concept, Escape order, panel toggles) so the First Principles lane can read it from the base branch.
Drop the panel-control redesign from section 4 and the exit criteria,
keep only that every docked-terminal entry exits fullscreen first.
Mark the RFC draft with acceptance requested, since kirodotdev#10757 closed
unmerged and no public record confirms the shape.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants