Skip to content

feat(crews): open the simple create dialog from the crew manager - #15052

Merged
bolichen97 merged 2 commits into
mainfrom
feat/capabilities-simple-create-bot
Oct 2, 2026
Merged

bolichen97 merged 2 commits into
mainfrom
feat/capabilities-simple-create-bot

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Clicking "Add crew member" on the Agent Capabilities → Crews manager opens the same short create dialog the Crewmates page uses, instead of the full editor sheet.

Adding a crew member from the capabilities manager dropped the user into the heavy editor sheet in create mode — the same surface used for deep editing — asking for every field up front before a member existed. The Crewmates page already had a much lighter path (name, template, one optional line, an Advanced fold), so the same product had two very different "add a crew member" experiences depending on where you started.

Why it matters

New members are created far more often than they are deeply configured, and the full editor sheet made the common case the slowest one. Converging both entry points on the one short dialog means "add a crew member" feels the same everywhere and stays a few fields, not a form.

Not a goal

  • Does not change the Crewmates list page (MembersPage) — its add trigger already opened the short dialog and is untouched.
  • Does not change how an existing member is edited — the editor sheet stays, now as an edit-only surface.
  • Does not add or change any create field or memory behaviour; only which surface the button opens. One create-flow rule does change, by ruling rather than by this PR's choice: converging both create doors on NewCrewmateDialog retires the old Discover project-level Kiro agents (.kiro/agents/) everywhere, not just in Slack #1684 "must pick a template before you can submit" guard, because the accepted rfc-crewmates-launch.md rules the New crewmate dialog's Built from field is "the default agent or a custom agent" — a default, not a required pick. So a crew created without touching Built from is built from the default kirocrew agent, exactly as the Crewmates page already behaved; a new test pins this.

What changed (motivation → approach → change)

The capabilities manager's "Add crew member" button opened the editor sheet in create mode, so the manager carried a full second create implementation — form state, template-required validation, private-fork wiring, an edit-later note — none of which the lighter NewCrewmateDialog needed. That dialog already existed and was already the Crewmates page's create path, exporting CreatedCrewmate and taking { open, onClose, onCreated, existingNames }.

The approach is to reuse it rather than reconcile two creators: point the manager's add button at NewCrewmateDialog, keep the user on the capabilities roster after a create (no navigation, no greeting seed), and make the editor sheet edit-only. All the create-only plumbing the sheet carried is removed, which is why the diff is net-negative.

Concretely, website/src/pages/KiroCrewAgentsPage.tsx now opens the shared dialog for create and reads agentCatalog / api.members for its inputs; the three create-only test files (privateForks, templateEditLaterNote, templateRequired) are deleted with the plumbing they covered; CrewRoster / CrewEditorSelect / WorkspaceModal tests and the capabilities.spec.ts Playwright flow are updated to the new open-the-dialog behaviour; and docs/system-specs/modules/crew-mode.md is updated to describe the single create path.

Removing the create-only plumbing orphaned six i18n keys under pages.kiroCrewAgentsPage.* (the create form's validation errors, section headers, and edit-later note); those keys are deleted from all 14 locale catalogs under website/src/i18n/locales/ so the dead-key ratchet returns to baseline. Review follow-ups: the resize guard on KiroCrewAgentsPage.tsx now also pins the pane while the create dialog is open (a regression test covers it); the roster-load and editor-options error notices now suppress the "Ask the agent" hand-off while the create dialog is open, so a hand-off click cannot unmount the dialog and discard a typed draft (revert-proven regression test); the create dialog's draft is now guarded on a side-panel tab switch — website/src/components/SidePanelLayout.tsx's useSidePanelLeaveGuard gained an opt-in alsoGuardAppShell so the dialog registers its unsaved-draft guard through a single channel instead of two (the double window.confirm is gone), and the four other hook callers are untouched; NewCrewmateDialog.refreshRosterReaders now invalidates both the members-roster key and the host page's ['kirocrew-agents'] key (exact) so a dropped/failed create no longer leaves a stale roster; the duplicate-name check reads display names; docs/feature-map/README.md is corrected to say the create dialog carries no Display name field; and the stale #1684 comment on kiroAgent is rewritten to describe its edit-path role now that the accepted rfc-crewmates-launch.md unifies both create doors on NewCrewmateDialog.

Backwards compatibility

Compatible with one named exception: no field, key, or type is renamed, removed, or made stricter — but create is made less strict, not more. The old #1684 template-required refusal is retired per rfc-crewmates-launch.md (see Not a goal above): a create that never touches Built from now succeeds against the default kirocrew agent instead of being blocked until a template is picked. Everything else is which dialog a button opens, and the removed code was create-only paths internal to one page.

Tests

  • website/src/test/CrewRoster.test.tsx, CrewEditorSelect.test.tsx, WorkspaceModal.test.tsx — updated to assert the add button opens NewCrewmateDialog and the editor sheet is edit-only.
  • Deleted KiroCrewAgentsPage.privateForks.test.tsx, .templateEditLaterNote.test.tsx, .templateRequired.test.tsx — they locked in create-only editor-sheet behaviour that no longer exists.
  • website/playwright/capabilities.spec.ts — the create flow now drives the short dialog.
  • website/src/test/KiroCrewAgentsPage.createRosterRefresh.test.tsx (new) — pins the dual-key roster invalidation so a dropped create re-syncs the capabilities roster.
  • website/src/test/NewCrewmateDialog.sidePanelLeaveGuard.test.tsx (new) — pins the single-channel leave guard (one confirm, not two) when the dialog opens inside the Crews-tab side panel.

Manual verification

Built the worktree SPA and served it via a provisioned pod; confirmed the served bundle carried the new-dialog markers, then walked the flow: Agent Capabilities → Crews → "Add crew member" opens the short NewCrewmateDialog; creating stays on the roster; an existing member still opens the editor sheet (edit-only). The three stills below were captured against that running build.

Screenshots / video

Agent Capabilities → Crews roster with the New crewmate entry point (create button and dashed tile):
Screenshot 2026-09-30 at 2 02 22 PM

The short "New crewmate" dialog it now opens (name, template, one optional line, collapsed Advanced fold):

Simple create dialog

The same dialog with Advanced expanded (Workspace / Model / Triggers):

Simple create dialog, Advanced expanded

Related Issues

N/A

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@dodgeblaster
dodgeblaster requested a review from a team September 29, 2026 16:53
@dodgeblaster
dodgeblaster requested a review from a team as a code owner September 29, 2026 16:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 4c66b4d16001293ce07a1d7168291a247e2d5642 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Confirm a maintainer intends rfc-crewmates-launch's "Built from is a default" ruling to retire the #1684 guard on the capabilities door too.

Suggestions

  • The PR closes an import cycle (KiroCrewAgentsPage ↔ NewCrewmateDialog) held only by the comment-documented "bindings referenced inside component bodies" convention; a follow-up moving the shared field components (WorkspaceField, ModelField, …) into a neutral module would make the convention unnecessary.

[DESIGN-REVIEWED] 4c66b4d

Description read

[DESCRIPTION-READ] c0b62a785186ea7d79580e20b106f04d5ea3f365f04930805270436e9b952cc9

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — 🟡 CONCERNS

Premise-level review of 4c66b4d16001293ce07a1d7168291a247e2d5642 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The retired #1684 must-pick-a-template guard rests on reading the Crewmates-page RFC as covering the crew manager's create door — the RFC text never names that door.

Not justified as shipped

  • Item 2 — inherited: the description retires the guard "per rfc-crewmates-launch.md", but that RFC's §02 ("New crewmate opens a dialog with… Built from (the default agent or a custom agent)") defines the Crewmates tab's dialog, and its §10 "folding the crew manager (KiroCrewAgentsPage) onto the same shared component" commitment is explicitly about the editor (CREW-18688), not create — so extending the ruling to this door, which is what deletes the templateRequired pin ("Create refuses until it is chosen… so the broken row cannot be minted"), is a coverage call, not a reading. The reversal is openly declared and twice re-pinned, so this is a premise to confirm, not a framing defect.
    Clears when: a maintainer confirms the RFC's §02 ruling covers the crew manager's create door (/ai-review override first-principles 4c66b4d16001293ce07a1d7168291a247e2d5642: <decision>), or an RFC naming that door is non-draft on base.

What this change ships

Inventory (10 items) — 9 justified

Intent: make "add a crew member" from the capabilities manager open the same short create dialog the Crewmates page uses — an ADDITION (flow convergence), net-negative.

  1. "Add crew member" on the crew manager opens the short New crewmate dialog; the editor sheet is edit-only — justified
  2. A create that never touches "Built from" now succeeds, built from the default kirocrew agent (the old refusal retired) — inherited: RFC coverage of this door is argued, not written
  3. The create button and dashed tile relabel "Add crewmate" → "New crewmate" across 14 locales — justified
  4. A create from the crew manager stays on the roster: no chat opens, no greeting seeds — justified
  5. The create-time Display name field is gone on that door (dialog's RFC-decided field set; edit still sets it) — justified
  6. A failed or dropped create now refreshes the crew manager's roster and config view, so a resubmit is refused up front — justified
  7. Narrowing past the mobile breakpoint no longer discards an open create draft — justified
  8. "Ask the agent" hand-off on roster/options errors hides while the create dialog is open — justified
  9. One confirm, not two, on leaving with a draft; useSidePanelLeaveGuard gains opt-in alsoGuardAppShell (5 callers counted, 1 passes it; the deliberate MemoryTab carve-out makes the opt-in derived) — justified
  10. Duplicate-name refusal also matches display names; spec/feature-map/i18n catalogs updated in-commit — justified

More below the cap: six orphaned i18n keys deleted from 14 catalogs; three create-only test files deleted (the privateForks pin's job survives in the catalog's pre-existing fork-copy exclusion, NewCrewmateDialog.tsx:216).

[FIRST-PRINCIPLES-REVIEWED] 4c66b4d

Description read

[DESCRIPTION-READ] 4f125621896184a2d7eacda11c8678e2a33ad02680914c588379305f3692db2c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 4c66b4d16001293ce07a1d7168291a247e2d5642 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4c66b4d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4c66b4d16001293ce07a1d7168291a247e2d5642: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of 4c66b4d16001293ce07a1d7168291a247e2d5642 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Verify the single-confirm leave guard by hand: type a draft in the Crews-tab dialog, switch tabs — exactly one confirm, draft kept on Cancel.

[UX-REVIEWED] 4c66b4d

Description read

[DESCRIPTION-READ] 73d75186bdf66b697ab1d58f4624da9222702aee369eac7a05590c3b4bcb9caa

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@dodgeblaster
dodgeblaster force-pushed the feat/capabilities-simple-create-bot branch from 3bf39ea to 9bbd2d1 Compare September 29, 2026 17:24
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 4c66b4d16001293ce07a1d7168291a247e2d5642 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4c66b4d

Verdict parsed from the review's SHA-scoped output markers for commit 4c66b4d16001293ce07a1d7168291a247e2d5642.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4c66b4d16001293ce07a1d7168291a247e2d5642: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/capabilities-simple-create-bot branch from 9bbd2d1 to 278b701 Compare September 29, 2026 18:19
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Follow-up on the Opus 5 Review (head 278b701d1)

Fixed the two findings that are real and in this diff, with a revert-proven regression test:

  • BLOCKING (resize data-loss, KiroCrewAgentsPage.tsx) — the resize guard now keys on createOpen too: (!sheet && !createOpen), with createOpen added to the dep array. New test keeps the open create dialog and its typed name when the bare capabilities route becomes mobile fails without the fix, passes with it.
  • FINDING (duplicate-name check) — existingNames now includes display_name: agents.flatMap(a => a.display_name ? [a.name, a.display_name] : [a.name]), matching MembersPage.tsx:701.

Respectfully rebutting the other two:

  • FINDING — stale roster: does not apply to this wiring. This pages agentsquery has nostaleTime, the dialogs success path already invalidates [kirocrew-agents] (NewCrewmateDialog.tsx:322, exact, refetchType all), and the callers onCreated={handleCapCreated}independently callsrefetchAgents()which invalidates[kirocrew-agents]. The MEMBERS_ROSTER_QUERY_KEY` invalidation cited is in the failure-reconcile branch. The roster refetches after a successful create.
  • FINDING — leave-guard slot collision: real but out of scope. It is a pre-existing property of the shared NewCrewmateDialog, also consumed by MembersPage (not inside a SidePanelLayout). Routing it through useSidePanelLeaveGuard would leave MembersPage`s guard unregistered. The correct fix edits the shared dialog with a present-or-fallback registration and re-tests both callers — a separate, non-blocking change.

@dodgeblaster
dodgeblaster force-pushed the feat/capabilities-simple-create-bot branch from 278b701 to 98a1aa5 Compare September 29, 2026 21:00
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Addressed the two BLOCKING review findings on head 98a1aa5c9

Also rebased onto latest origin/main (+22), which folds in fix(apps): fail closed on a Windows symlink loop in _contained_join (#15081) — the test_apps_registry_coverage.py Windows failure this PR carried was that pre-existing breakage, not this diff (zero .py touched here). It should clear on the rebased head.

GPT 5.6 Review — feature-map doc accuracy (fixed)

docs/feature-map/README.md said the display-name label appears "beside Name on the create form." The create door is now NewCrewmateDialog, whose CreateBody carries no display_name field — a new crew starts with none and the server shows name until one is set. Corrected the row to say the label is edited on the editor Overview pane only.

Design Review (Fable 5) — the #1684 concern (resolved, not reversed)

#1684 is not a docs/decisions/ entry — ls docs/decisions/ shows four files, none numbered 1684. It is a PR/issue number cited in a code comment at KiroCrewAgentsPage.tsx. So AGENTS.md’s "a recorded decision is reversed only by a superseding maintainer entry" does not apply; this is ordinary code.

The substance: #1684 guarded the old capabilities create sheet against an unselected template picker silently resolving to the default agent. That sheet is gone. Both create doors now unify on NewCrewmateDialog, per the accepted rfc-crewmates-launch.md (status: accepted on main), which specifies at lines 123–124: "New crewmate opens a dialog with four things: Name; Built from (the default agent or a custom agent); …" — i.e. the RFC deliberately makes the default agent an explicit, labelled choice ("Default · kirocrew"), which is not the #1684 "picker reverted to default" bug (a silent fallback from an unselected field).

The reviewer’s evidence was the stale #1684 comment on kiroAgent, which still described a create() rejection this page no longer has (kiroAgent is now the edit path’s template value, seeded from the crew being edited). Rewrote that comment to describe its actual role and note the #1684 concern now lives in the accepted-RFC dialog. No behaviour change was needed; the create flow already matches the accepted RFC.

If the Design lane stays red on the stale verdict, a repo writer can override it: /ai-review override design <sha>: accepted rfc-crewmates-launch.md supersedes the #1684 create-sheet guard; #1684 is a code comment, not a docs/decisions entry.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 29, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/capabilities-simple-create-bot branch from 98a1aa5 to 9ae1c81 Compare September 29, 2026 21:40
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Follow-up on Opus 5 Review (head 9ae1c8100)

Fixed the one new BLOCKING finding, with a revert-proven regression test:

  • BLOCKING — error-notice hand-off discards the create draft. KiroCrewAgentsPage.tsx:1870/1878 gated askAgent on !sheet only. With the create dialog open (draft in createOpen, not sheet), a failed GET /api/agents showed the roster/editor-options ErrorNotice with a live "Ask the agent" hand-off; clicking it navigates to chat, unmounts the page + dialog, and discards the typed draft with no confirm. Same sheet-vs-createOpen guard class as the resize fix, at a different sink. Fixed both notices to askAgent={!sheet && !createOpen} and extended the hand-off comments. New test suppresses the roster-load error hand-off while the create dialog holds a typed draft asserts the button is present with nothing open and absent once the dialog holds a draft — fails without the fix, passes with it.

I audited the whole category: the only other sheet-gated hand-off is the default-agent ErrorNotice at line ~1914, whose shared error state is written only by edit-sheet / mutation / avatar / default-select paths — never the create dialog (which owns its own internal error state) — so that hand-off has no create draft to destroy and needs no createOpen guard.

The FINDING (leave-guard slot collision) remains as previously scoped: it is a pre-existing property of the shared NewCrewmateDialog (also used by MembersPage, which is not inside a SidePanelLayout), Opus itself marks it "not merge-gating," and the correct fix edits the shared dialog with a present-or-fallback registration and re-tests both callers — a separate, non-blocking change.

Also re-attached the three screenshots (a prior gh pr edit --body-file had wiped them to [image removed], which is why UX/Design/GPT blind reads blocked); the body now carries user-attachments/assets URLs and this push re-triggers the reviewers against it.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/capabilities-simple-create-bot branch from 9ae1c81 to a0020eb Compare September 30, 2026 00:00
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 30, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/capabilities-simple-create-bot branch from a0020eb to 70816df Compare September 30, 2026 00:18
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Addressed the GPT 5.6 BLOCK on docs/feature-map/README.md:141 (adjudicated UPHOLD under the feature-map-correctness blocking anchor). The rewritten line claimed a new crew "starts with none and the server shows the name until one is set" — true only for an identifier-shaped name. Corrected to distinguish both paths: an identifier-shaped typed name starts with no display name (server shows name), while a free-form typed name is stored AS the display name (members.py: label = display_name or name, matching NewCrewmateDialog's own comment). Docs-only, one line, amended into the single commit (head 70816df9a).

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 30, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 1, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/capabilities-simple-create-bot branch from 8548bb5 to 50a3f03 Compare October 1, 2026 05:21
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

fixed — span=7272e91e5c0c — refreshRosterReaders omitted ['kirocrewConfig'] on the failure-reconcile path.

Legitimate and in-scope: the create's write (POST /api/agents) lands in both the registry and the config, and the crew manager's list is config-derived; the success path already invalidates both keys, but the reconcile path (dropped response / gateway restart mid-POST, or 409 agent_exists) invalidated only the two roster keys, leaving the config view stale until a manual reload. Fixed by adding queryClient.invalidateQueries({ queryKey: ['kirocrewConfig'] }) to refreshRosterReaders, so the reconcile refreshes the identical pair the success path does. Revert-proven regression test added to KiroCrewAgentsPage.createRosterRefresh.test.tsx (asserts a fresh config read on the reconcile path; fails without the fix). Head 50a3f03.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 1, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

@iamwhatever — thanks for the precise review. I took path (b) (state the retirement + fix the body + pin a test). Here's how each ask is addressed on the current head 50a3f033c:

1. State the #1684 retirement with the RFC ruling that allows it — done.
## Not a goal now says the "must pick a template before you can submit" guard is retired by ruling, citing the accepted rfc-crewmates-launch.md: Built from is "the default agent or a custom agent" — a default, not a required pick — so a create that never touches it is built from the default kirocrew agent.

2. Fix the wrong Not a goal / Compatible: lines — done.
The "does not change any create … template behaviour" claim and the old Compatible: line are corrected. ## Not a goal now explicitly carves out the one create-flow rule that changes, and ## Backwards compatibility states it as a named exception: "create is made less strict, not more … the old #1684 template-required refusal is retired."

3. Add a test pinning whichever behaviour ships — done.
website/src/pages/members/MembersPage.test.tsx — "a create that never touches 'Built from' defaults to the built-in agent, with no template-required refusal (RFC-ruled retirement of #1684)": it submits without touching the field, asserts createKirocrewAgent fires with kiro_agent: 'kirocrew', and asserts no refusal hint. The comment notes "If someone restores the old guard, this fails on the missing request." The three old create-only tests (templateRequired, privateForks, templateEditLaterNote) are deleted with the plumbing they covered.

4. "Worth naming: display name / private-memory note / edit-later note gone from this door" — the ## What changed section names the removed create-only plumbing and the docs/feature-map/README.md correction (the dialog carries no Display name field); the deleted templateEditLaterNote / privateForks test files are listed under ## Tests.

The code change itself is unchanged in intent — this was a description + test-pin follow-up. Ready for re-review when you have a moment.

bolichen97
bolichen97 previously approved these changes Oct 1, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) October 1, 2026 22:06
cruisercohen
cruisercohen previously approved these changes Oct 1, 2026
gjjnn added 2 commits October 1, 2026 15:23
Clicking "Add crew member" on the Agent Capabilities Crews tab now opens
the same NewCrewmateDialog the Crewmates page uses, not the full editor
sheet. The editor sheet becomes edit-only: its create branch and all
create-only plumbing (CreatePayload, the create mutation/submit, the
create form JSX, TemplateField, BindingFields) are removed.

Config mode: after a create the user stays on the capabilities roster,
which refetches in place — no navigation, no greeting seed. That
behaviour stays owned by the caller's onCreated; the Crewmates page
still navigates and seeds. The call-time import cycle between the two
pages is safe (bindings referenced only inside component bodies).
Inside the crew manager's SidePanelLayout the New crewmate dialog only
published its leave stake to the app shell's single slot, which the
layout's own registration displaced, and it filled no pane guard slot.
A capability-tab switch (and the browser Back the layout forwards)
unmounted the page and discarded the typed draft with no confirm.

Register the same leave predicate through useSidePanelLeaveGuard: it
fills the pane slot the layout consults and rides the layout's forward
to the app shell. Outside a layout (the Crewmates page) the hook's
context is null and it is a no-op, so the dialog's direct app-shell
registration stays its only guard there. Revert-proven regression test
mounts the real dialog in a SidePanelLayout.
@dodgeblaster
dodgeblaster dismissed stale reviews from cruisercohen and bolichen97 via 4c66b4d October 1, 2026 22:27
@dodgeblaster
dodgeblaster force-pushed the feat/capabilities-simple-create-bot branch from 50a3f03 to 4c66b4d Compare October 1, 2026 22:27
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Oct 1, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Re-reviewed at 4c66b4d: my change request is addressed by stating the #1684 retirement. The body's Not a goal and Backwards compatibility now name the exception, and NewCrewmateDialog.builtFromDefault.test.tsx:62-75 plus MembersPage.test.tsx:4408-4434 pin that an untouched create posts kiro_agent 'kirocrew' with no refusal. The ruling cited is rfc-crewmates-launch.md:123-124 ('Built from (the default agent or a custom agent)'), which reads as allowing a default rather than explicitly retiring #1684, so I am leaving the approval to a maintainer to acknowledge that reading. Nits: the Tests section omits the two new tests, and What changed still reads as history ('Review follow-ups...', 'now also...').

@bolichen97
bolichen97 merged commit c78b138 into main Oct 2, 2026
97 checks passed
@bolichen97
bolichen97 deleted the feat/capabilities-simple-create-bot branch October 2, 2026 05:51
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants