Repository navigation
feat(crews): open the simple create dialog from the crew manager - #15052
Conversation
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm a maintainer intends rfc-crewmates-launch's "Built from is a default" ruling to retire the #1684 guard on the capabilities door too. Suggestions
[DESIGN-REVIEWED] 4c66b4d Description read[DESCRIPTION-READ] c0b62a785186ea7d79580e20b106f04d5ea3f365f04930805270436e9b952cc9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The retired #1684 must-pick-a-template guard rests on reading the Crewmates-page RFC as covering the crew manager's create door — the RFC text never names that door. Not justified as shipped
What this change shipsInventory (10 items) — 9 justifiedIntent: make "add a crew member" from the capabilities manager open the same short create dialog the Crewmates page uses — an ADDITION (flow convergence), net-negative.
More below the cap: six orphaned i18n keys deleted from 14 catalogs; three create-only test files deleted (the [FIRST-PRINCIPLES-REVIEWED] 4c66b4d Description read[DESCRIPTION-READ] 4f125621896184a2d7eacda11c8678e2a33ad02680914c588379305f3692db2c That sha256 names the PR description this verdict read. Recompute it with |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Verify the single-confirm leave guard by hand: type a draft in the Crews-tab dialog, switch tabs — exactly one confirm, draft kept on Cancel. [UX-REVIEWED] 4c66b4d Description read[DESCRIPTION-READ] 73d75186bdf66b697ab1d58f4624da9222702aee369eac7a05590c3b4bcb9caa That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
3bf39ea to
9bbd2d1
Compare
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
9bbd2d1 to
278b701
Compare
|
Follow-up on the Opus 5 Review (head Fixed the two findings that are real and in this diff, with a revert-proven regression test:
Respectfully rebutting the other two:
|
278b701 to
98a1aa5
Compare
Addressed the two BLOCKING review findings on head
|
98a1aa5 to
9ae1c81
Compare
|
Follow-up on Opus 5 Review (head Fixed the one new BLOCKING finding, with a revert-proven regression test:
I audited the whole category: the only other The FINDING (leave-guard slot collision) remains as previously scoped: it is a pre-existing property of the shared Also re-attached the three screenshots (a prior |
9ae1c81 to
a0020eb
Compare
a0020eb to
70816df
Compare
|
Addressed the GPT 5.6 BLOCK on |
8548bb5 to
50a3f03
Compare
|
fixed — span=7272e91e5c0c —
|
|
@iamwhatever — thanks for the precise review. I took path (b) (state the retirement + fix the body + pin a test). Here's how each ask is addressed on the current head 1. State the #1684 retirement with the RFC ruling that allows it — done. 2. Fix the wrong 3. Add a test pinning whichever behaviour ships — done. 4. "Worth naming: display name / private-memory note / edit-later note gone from this door" — the The code change itself is unchanged in intent — this was a description + test-pin follow-up. Ready for re-review when you have a moment. |
Clicking "Add crew member" on the Agent Capabilities Crews tab now opens the same NewCrewmateDialog the Crewmates page uses, not the full editor sheet. The editor sheet becomes edit-only: its create branch and all create-only plumbing (CreatePayload, the create mutation/submit, the create form JSX, TemplateField, BindingFields) are removed. Config mode: after a create the user stays on the capabilities roster, which refetches in place — no navigation, no greeting seed. That behaviour stays owned by the caller's onCreated; the Crewmates page still navigates and seeds. The call-time import cycle between the two pages is safe (bindings referenced only inside component bodies).
Inside the crew manager's SidePanelLayout the New crewmate dialog only published its leave stake to the app shell's single slot, which the layout's own registration displaced, and it filled no pane guard slot. A capability-tab switch (and the browser Back the layout forwards) unmounted the page and discarded the typed draft with no confirm. Register the same leave predicate through useSidePanelLeaveGuard: it fills the pane slot the layout consults and rides the layout's forward to the app shell. Outside a layout (the Crewmates page) the hook's context is null and it is a no-op, so the dialog's direct app-shell registration stays its only guard there. Revert-proven regression test mounts the real dialog in a SidePanelLayout.
4c66b4d
50a3f03 to
4c66b4d
Compare
|
Re-reviewed at 4c66b4d: my change request is addressed by stating the #1684 retirement. The body's Not a goal and Backwards compatibility now name the exception, and NewCrewmateDialog.builtFromDefault.test.tsx:62-75 plus MembersPage.test.tsx:4408-4434 pin that an untouched create posts kiro_agent 'kirocrew' with no refusal. The ruling cited is rfc-crewmates-launch.md:123-124 ('Built from (the default agent or a custom agent)'), which reads as allowing a default rather than explicitly retiring #1684, so I am leaving the approval to a maintainer to acknowledge that reading. Nits: the Tests section omits the two new tests, and What changed still reads as history ('Review follow-ups...', 'now also...'). |
Problem / Motivation
Goal: Clicking "Add crew member" on the Agent Capabilities → Crews manager opens the same short create dialog the Crewmates page uses, instead of the full editor sheet.
Adding a crew member from the capabilities manager dropped the user into the heavy editor sheet in create mode — the same surface used for deep editing — asking for every field up front before a member existed. The Crewmates page already had a much lighter path (name, template, one optional line, an Advanced fold), so the same product had two very different "add a crew member" experiences depending on where you started.
Why it matters
New members are created far more often than they are deeply configured, and the full editor sheet made the common case the slowest one. Converging both entry points on the one short dialog means "add a crew member" feels the same everywhere and stays a few fields, not a form.
Not a goal
MembersPage) — its add trigger already opened the short dialog and is untouched.NewCrewmateDialogretires the old Discover project-level Kiro agents (.kiro/agents/) everywhere, not just in Slack #1684 "must pick a template before you can submit" guard, because the acceptedrfc-crewmates-launch.mdrules the New crewmate dialog's Built from field is "the default agent or a custom agent" — a default, not a required pick. So a crew created without touching Built from is built from the defaultkirocrewagent, exactly as the Crewmates page already behaved; a new test pins this.What changed (motivation → approach → change)
The capabilities manager's "Add crew member" button opened the editor sheet in create mode, so the manager carried a full second create implementation — form state, template-required validation, private-fork wiring, an edit-later note — none of which the lighter
NewCrewmateDialogneeded. That dialog already existed and was already the Crewmates page's create path, exportingCreatedCrewmateand taking{ open, onClose, onCreated, existingNames }.The approach is to reuse it rather than reconcile two creators: point the manager's add button at
NewCrewmateDialog, keep the user on the capabilities roster after a create (no navigation, no greeting seed), and make the editor sheet edit-only. All the create-only plumbing the sheet carried is removed, which is why the diff is net-negative.Concretely,
website/src/pages/KiroCrewAgentsPage.tsxnow opens the shared dialog for create and readsagentCatalog/api.membersfor its inputs; the three create-only test files (privateForks,templateEditLaterNote,templateRequired) are deleted with the plumbing they covered;CrewRoster/CrewEditorSelect/WorkspaceModaltests and thecapabilities.spec.tsPlaywright flow are updated to the new open-the-dialog behaviour; anddocs/system-specs/modules/crew-mode.mdis updated to describe the single create path.Removing the create-only plumbing orphaned six i18n keys under
pages.kiroCrewAgentsPage.*(the create form's validation errors, section headers, and edit-later note); those keys are deleted from all 14 locale catalogs underwebsite/src/i18n/locales/so the dead-key ratchet returns to baseline. Review follow-ups: the resize guard onKiroCrewAgentsPage.tsxnow also pins the pane while the create dialog is open (a regression test covers it); the roster-load and editor-options error notices now suppress the "Ask the agent" hand-off while the create dialog is open, so a hand-off click cannot unmount the dialog and discard a typed draft (revert-proven regression test); the create dialog's draft is now guarded on a side-panel tab switch —website/src/components/SidePanelLayout.tsx'suseSidePanelLeaveGuardgained an opt-inalsoGuardAppShellso the dialog registers its unsaved-draft guard through a single channel instead of two (the doublewindow.confirmis gone), and the four other hook callers are untouched;NewCrewmateDialog.refreshRosterReadersnow invalidates both themembers-rosterkey and the host page's['kirocrew-agents']key (exact) so a dropped/failed create no longer leaves a stale roster; the duplicate-name check reads display names;docs/feature-map/README.mdis corrected to say the create dialog carries no Display name field; and the stale#1684comment onkiroAgentis rewritten to describe its edit-path role now that the acceptedrfc-crewmates-launch.mdunifies both create doors onNewCrewmateDialog.Backwards compatibility
Compatible with one named exception: no field, key, or type is renamed, removed, or made stricter — but create is made less strict, not more. The old #1684 template-required refusal is retired per
rfc-crewmates-launch.md(see Not a goal above): a create that never touches Built from now succeeds against the defaultkirocrewagent instead of being blocked until a template is picked. Everything else is which dialog a button opens, and the removed code was create-only paths internal to one page.Tests
website/src/test/CrewRoster.test.tsx,CrewEditorSelect.test.tsx,WorkspaceModal.test.tsx— updated to assert the add button opensNewCrewmateDialogand the editor sheet is edit-only.KiroCrewAgentsPage.privateForks.test.tsx,.templateEditLaterNote.test.tsx,.templateRequired.test.tsx— they locked in create-only editor-sheet behaviour that no longer exists.website/playwright/capabilities.spec.ts— the create flow now drives the short dialog.website/src/test/KiroCrewAgentsPage.createRosterRefresh.test.tsx(new) — pins the dual-key roster invalidation so a dropped create re-syncs the capabilities roster.website/src/test/NewCrewmateDialog.sidePanelLeaveGuard.test.tsx(new) — pins the single-channel leave guard (one confirm, not two) when the dialog opens inside the Crews-tab side panel.Manual verification
Built the worktree SPA and served it via a provisioned pod; confirmed the served bundle carried the new-dialog markers, then walked the flow: Agent Capabilities → Crews → "Add crew member" opens the short
NewCrewmateDialog; creating stays on the roster; an existing member still opens the editor sheet (edit-only). The three stills below were captured against that running build.Screenshots / video
Agent Capabilities → Crews roster with the New crewmate entry point (create button and dashed tile):

The short "New crewmate" dialog it now opens (name, template, one optional line, collapsed Advanced fold):
The same dialog with Advanced expanded (Workspace / Model / Triggers):
Related Issues
N/A
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)