Repository navigation
feat(sidebar): show full session titles while the list is scrolled - #15224
Conversation
|
Intent: Let a user read long session titles by scrolling the sessions list: the card widens over the chat pane while it is scrolled and settles back when the pointer leaves, without changing the stored sidebar width or reflowing the chat. |
|
Note on pre-push review: the model-pinned local reviewers (GPT and Opus lanes) and the cold-reader check could not start on the author's host (every subagent failed with |
b996429 to
37995b0
Compare
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check the [DESIGN-REVIEWED] f49fd49 Description read[DESCRIPTION-READ] 1b5b2ab1db869af18d295a84d23979eb146f327cfc79d2cf1a3bad651b21d2fe That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS In Watch
Suggestions
[UX-REVIEWED] f49fd49 Description read[DESCRIPTION-READ] 4bf9141217099f5c7b40abf349e5ebac10e23f468af90a8d8cd8c8b7d32f050e That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The new Not justified as shipped
What this change shipsInventory (6 items) — 5 justifiedIntent: let a desktop user read long session titles in full while scrolling the list, without widening the sidebar. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] f49fd49 Description read[DESCRIPTION-READ] a5551dd410c496e550950f580577fbb27c987f5fcdc838175cc37ec7d6d5fdc1 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings that block the merge. FINDING — website/src/pages/chat-sidebar/scrollPeek.ts:989 — when a running session's title is clipped, the chip still lands 13px left of the row's own text, so it does not sit exactly over the title as [OPUS-REVIEWED] f49fd49 |
37995b0 to
a871102
Compare
|
|
|
|
|
|
|
|
|
|
chore (non-blocking): rebased on main as e4e9b84, no behaviour change. The three reds on be687ac came from outside this diff. Frontend Tests shard 1 failed in focusRingContrast.test.ts on AskAnswersCard.tsx:41 and in ChatPage.dirStaging.test.tsx; main fixed both in #18580 and #17929, and Frontend Coverage Merge failed only because shard 1 did. SAST (Semgrep) never scanned: Docker Hub refused the semgrep/semgrep:1.78 pull with toomanyrequests. The rebase had no conflicts, the PR diff is still 31 files, +5858/-5, and tsc, the feature-map gate and the two failing test files (73 tests) pass locally. |
|
|
|
|
|
|
chore (non-blocking): rebased on main as 7a7bd5b, no behaviour change. The only conflict was the hook list in website/src/test/ChatSidebar.ownerComposition.test.ts, where main added useCrewEnable; the resolution keeps main's lines and re-adds this PR's useSidebarScrollPeek. The PR diff is still 31 files, +5858/-5, and tsc plus the two affected test files (8 tests) pass locally. This push also reruns Frontend Tests (4), Frontend Coverage Merge and Coverage Gate, which failed on e4e9b84 in ChatInput.lexicalKeys.test.tsx the same way main's own CI failed on aee520e. |
|
|
|
|
|
|
|
chore (non-blocking): rebased on main as 298c635, no behaviour change. The only conflict was the sidebar root div in website/src/pages/ChatSidebar.tsx, where main (#18443) added role="region" and the sessions.list guide location. The resolution keeps main's div line and re-adds this PR's ScrollPeekLayer under it. The PR diff is still 31 files, +5858/-5, and tsc plus the 3 affected test files (29 tests) pass locally. |
|
issue (blocking): fixed in 1b459fa. Build Wheel and both Build Desktop jobs failed on 298c635 in gen-ui-index --check: "src/kiro_crew/docs/ui-index.generated.json is stale". main added that index in #18443, and it lists every setting, so this PR's new chat.show-full-titles-while-scrolling setting and its 12 locale labels were missing from it. The amend adds the output of |
|
issue (blocking): fixed in 684476d. The index check still failed on 1b459fa in Build Wheel, both Build Desktop jobs, Frontend Lint & Type Check and E2E. CI checks the merge with main, and main had gained 9 commits since the base, including b16b26b in the sidebar. The index's input_digest covers those source files, so the merge result was stale even though the branch alone passed. 684476d is the same change rebased onto main 6166905 with the index regenerated there, and only input_digest moved. gen-ui-index --check and tsc pass locally. The PR diff is still 32 files, +5873/-7. |
|
note (non-blocking): two reds on 684476d come from main, not from this diff. Frontend Tests (3) fails GuideLayer.test.tsx "pressing the highlighted control on the last step finishes the guide, as Done does". The same test fails in main's own CI run on 6166905 (run 38033018042) and in at least three other open PRs. Frontend Coverage Merge is red only because shard 3 is. E2E (stub ACP backend, offline) fails in check-i18n-render.mjs --build at the vs-base step: "[plugin kirocrew-ui-auto-stamp] src/pages/settings/ChatPanel.tsx changed after the auto stamp manifest was written". The base tree is built against a symlink to this checkout's website/node_modules (check-i18n-render.mjs:729), and vite.config.ts reads the stamp manifest from ./node_modules/.cache/kc-ui-auto/sites.json. So the base build reads the manifest the HEAD build wrote, and any PR that edits a stamped file (ChatPanel.tsx here, where this PR adds its setting) fails the base build. Both came in with #18443. The E2E suites themselves passed. |
|
chore (non-blocking): rebased on main d32c084 as 81c3477, no behaviour change. The only conflict was the generated src/kiro_crew/docs/ui-index.generated.json. The resolution takes main's copy and reruns |
|
chore (non-blocking): rebased on main 63c155a as bb07e16, no behaviour change. The base now includes #18793, which fixes the E2E i18n render base-build stamp manifest failure. Over the two rebases since 81c3477 the conflicts were the feature-map Sessions row and the ChatSidebar.ownerComposition.test.ts hook list, where main's lines were kept and this PR's scrollPeek entry and useSidebarScrollPeek re-added, and the generated ui-index, which was taken from main and regenerated with npm run gen:ui. The PR diff is still 32 files, +5873/-7. gen-ui-index --check, tsc and the 2 affected test files (8 tests) pass locally. |
|
chore (non-blocking): rebased on main 65df088 as 6e14cf9, no conflicts and no behaviour change. Backend Tests shard 2 failed on bb07e16 on Linux and Windows in test_wait_discipline_ratchet only: test_surface_deny_notice_sites.py and test_webhook_permission_requests.py gained wait_for(10s) sites in #19259, past the baseline. This PR touches no file under test/, and main fixed the baseline in #19495, which this base includes. E2E (stub ACP backend, offline) on bb07e16 ran 314 Playwright tests with 0 unexpected, and failed only because the suite took 1016s against the 1020s bound in test_playwright_e2e.py:447; this push re-runs it. The PR diff is still 32 files, +5873/-7, and gen-ui-index --check and tsc pass locally. |
|
chore (non-blocking): rebased on main as 296b986, no behaviour change. main de2d143 conflicted in three places, each next to a line this PR adds: the feature-map Sessions row, the sidebar module table in docs/system-specs/modules/history.md (main added models.ts) and the hook list in ChatSidebar.ownerComposition.test.ts (main added useSidebarModels). The resolution keeps main's lines and re-adds this PR's entries. The PR diff is still 32 files, +5873/-7. gen-ui-index --check, tsc and the 2 affected test files (8 tests) pass locally. The push also re-runs E2E (stub ACP backend, offline), which stopped at the 1020s Playwright bound on a1c8e49 with 326 passed and 0 flaky. A local run of 71 tests on both sides gave a median time ratio of 1.006 against main, and fork PRs run that job on ubuntu-latest in 975 to 1098s against 655 to 829s for same-repo PRs. |
|
chore (non-blocking): rebased on main as f49fd49, no behaviour change. After readiness passed on 296b986, main 1f6f5af conflicted only in the generated src/kiro_crew/docs/ui-index.generated.json. The resolution takes main's copy and regenerates it with npm run gen:ui. The PR diff is still 32 files, +5873/-7, and gen-ui-index --check and tsc pass locally. The commit still merges cleanly onto main 9b1fc3c. |
iamwhatever
left a comment
There was a problem hiding this comment.
This adds an opt-in setting, off by default and desktop only, that draws clipped session titles in full in a click-through layer while the sessions list is scrolled. Row width, the stored sidebar width and the fixed row height are not touched. Our earlier note asked for the body to describe the real lifecycle, and it now does (the 4s ceiling, a press or non-scroll key anywhere ends it, window blur, the hovered, sticky-header and occluded rows are skipped, and the z-[65] tradeoff is named). I read scrollPeek.ts, ScrollPeekLayer.tsx and the ChatSidebar, ChatPage and settings hunks, and tried to make it get in the way. The layer is pointer-events: none and aria-hidden. Every listener is passive or only calls stop(), never preventDefault, so no wheel, key or click is swallowed. Escape or any non-scroll key, any press, and blur all end it. The portal sits outside the lane, so its own render cannot feed the MutationObserver into a measure loop (samePeek also guards that). Titles render as text, not HTML. Every effect removes its listeners on cleanup. What is left is cosmetic and was answered as deferred: the chip offset by the live dot, the duplicate scrollPeek/fillsHost prop, and a pointer already inside the sidebar when the listener binds, which only shortens the peek to 0.7s. The committed evidence is about 1.2 MB, as the fork rules allow. Checks are green and the base is main. — crew-pr-reviewer (deep re-check)
Problem / Motivation
Goal: While the sessions list is scrolled, long session titles can be read in full without resizing the sidebar.
Session titles are one line and truncate. At the default 260px width most titles are cut off, and the only way to read them is to hover each row for its tooltip or drag the sidebar wider and back again.
Why it matters
Scanning the list is how people find a session. A list of titles that all end in an ellipsis after four words is hard to scan, and a permanently wider sidebar costs chat width all the time.
Not a goal
What changed (motivation → approach → change)
When you scroll the sessions list (wheel, touch, or arrow / Page / Home / End keys), every title in view that its row cuts off by 16px or more is drawn in full in a floating layer laid exactly over the row. The rows never change: the card keeps the user's stored width, nothing scrolls sideways, and the
session-row-fixed-heightrule inwebsite/AUTOSDE.yamlholds as written. The layer is click-through, so a click on a shown title selects the row under it. No title is drawn for the row under the pointer (its hover actions stay visible), for a title behind a stuck folder header, or for a title whose start (inside the sidebar) another element covers. That check samples only the title's start, so an element over just the part drawn past the sidebar's edge is not detected; the 4s ceiling bounds it. While it is up, every lane scroll and every change to the sidebar's rows (a mount, a rename, a re-sort slide) re-measures, so it follows the virtualized rows. It ends at once on a press or a non-scrolling key anywhere on the page, or when the window loses focus. Otherwise it stays while the pointer is over the sidebar, up to 4s after the last scroll input, and hides 150ms after the pointer leaves or 0.7s after the last touch or key input. The layer is portaled above the dashboard shell atz-[65], so a popover or banner that opens on its own while a peek is up can sit under the titles for up to those 4s. It is off by default and desktop-only (the reason is stated at each place that switches it off on a phone): Settings → Chat → Sessions → Show Full Titles While Scrolling turns it on.website/src/pages/chat-sidebar/scrollPeek.tsuseSidebarScrollPeek: listens for wheel, touchmove and scrolling keys in the lane (ignoring zoom wheels, horizontal wheels, caret keys in a text field and a lane that cannot scroll), measures the clipped titles fully in view below the search dock on the next frame, follows lane scrolls, and runs the hide timers.useFullTitlesOnScrollSettingreads the setting.website/src/pages/chat-sidebar/ScrollPeekLayer.tsxdocument.body,position: fixed,pointer-events: none,aria-hidden; each title starts on the row's own title and is capped at the window edge.website/src/pages/ChatSidebar.tsx,website/src/pages/ChatPage.tsxscrollPeekprop that the desktop drawer passes; the card's width is untouched.website/src/pages/chat/ChatSettings.tsx,website/src/pages/settings/ChatPanel.tsxfullTitlesOnScrollchat setting (default off) and its toggle; every catalog underwebsite/src/i18n/locales/carries its two strings, and the settings registry (settingsRegistry.gen.ts,src/kiro_crew/docs/settings-registry.generated.json) is regenerated so search and deep links find it.docs/feature-map/README.md,docs/system-specs/modules/history.mdBackwards compatibility
Compatible:
scrollPeekis a new optional prop and the setting defaults off, so every sidebar renders exactly as before until a user turns it on.Tests
website/src/pages/chat-sidebar/scrollPeek.test.tsx(21 tests):measureClippedTitlespicks only titles clipped past the threshold and fully in view below the dock, capped at the window edge.website/src/test/ChatSidebar.scrollPeek.test.tsxrenders the real sidebar, scrolls a lane of clipped titles, and asserts the layer is up while the card stays at 260px and no row gets a width.website/src/test/ChatSidebar.ownerComposition.test.tspins the two new owner hooks in the facade's call order.The 512 related frontend test files pass locally.
Manual verification
Built the dashboard from this branch and served it from an isolated dev gateway with 32 long-titled sessions, driven by a Playwright script at 1440×900 with the setting turned on. While scrolling with the pointer over the list, 13 titles were shown in full and the sidebar stayed at 260px; 1.5s after the pointer moved to the chat pane the layer was gone and the sidebar was still 260px.
Screenshots / video
At rest, titles truncated:
While scrolling, clipped titles are shown in full over their rows; the sidebar keeps its width:
The setting, under Settings → Chat → Sessions (shown on; it defaults off):
After the pointer leaves, the layer is gone
Scroll, read, move away:
Related Issues
no linked issue: requested directly by the author; no tracked issue exists.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)