Skip to content

fix(sidebar): harden the scroll peek - #20109

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/scroll-peek-hardening
Oct 20, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/scroll-peek-hardening

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The sidebar scroll peek shows full titles without covering the hovered row's actions or the composer, and lasts as long as the pointer stays on the sidebar.

Follow-up to #15224, which added full session titles over the sidebar while the list scrolls. Its review deferred six findings to this PR. The hovered row got a chip over its hover toolbar, chips ran over the composer, the chips carried a border, shadow and bold weight, the setting description was two clauses, a scrollPeek prop duplicated an existing check, and a pointer already resting on the sidebar did not count as present.

Why it matters

A chip over the hover toolbar hides the row's actions while the pointer is on them. A chip over the composer covers text the user is typing. Without the presence fix, a user who scrolls without first moving the pointer sees the peek vanish 0.7 s after the wheel.

Not a goal

Changing when the peek starts or the 0.7 s and idle-ceiling timings. Mobile, where the peek stays off.

What changed (motivation → approach → change)

  • scrollPeek.ts. measureClippedTitles skips any row that matches :hover, so the row whose toolbar shows gets no chip even when a wheel scroll moved it under the pointer without a pointerover. It reads every [data-scroll-peek-stop] rect, and a stop to the right of a row that overlaps it vertically caps that chip's width at the stop's left edge. A chip left less than PEEK_MIN_OVERFLOW wider than the row's title is dropped. A new markPointer helper sets the pointer position and presence on every wheel and pointermove over the sidebar.
  • ChatPage.tsx. The composer dock root carries data-scroll-peek-stop. The scrollPeek={!isMobile} prop is gone.
  • ChatSidebar.tsx. The scrollPeek prop is removed. The peek is enabled when fullTitlesOnScroll && !fillsHost && !boardLaneActive.
  • ScrollPeekLayer.tsx. Chips use the row title class on bg-bg-elevated with no border, shadow, semibold weight or 1 px offsets.
  • The full_titles_on_scroll_description string is one sentence in all 12 hand-written locales, and the pseudolocale and settings registry are regenerated.
  • temp-screenshots/sidebar-scroll-peek/ is deleted from the tree. website/scripts/capture-sidebar-scroll-peek.mjs recreates every still.

Backwards compatibility

The scrollPeek prop had two callers, both updated here. The setting key and default are unchanged.

Tests

  • scrollPeek.test.tsx adds four cases. A wheel with no prior pointerenter keeps the peek up past the collapse delay and ends on leave. A row matching :hover gets no chip. A stop element caps a chip at its left edge and drops a chip it would leave too narrow. The layer is removed on the render the peek ends. The layer test also checks the chip has no border, shadow or semibold class.
  • ChatSidebar.scrollPeek.test.tsx renders without the removed prop and adds a case where fillsHost keeps the layer from appearing.
  • npx tsc -p tsconfig.app.json passes. I18N_BASE_REF=origin/main npm run i18n:check passes. npm run gen:ui passes after npm run gen:settings. Vitest over src/pages/chat-sidebar, src/pages/settings, the two scroll peek files and ChatSidebar.ownerComposition ran 712 tests, all passing.

Manual verification

Ran node scripts/capture-sidebar-scroll-peek.mjs --video against a built website/dist at 1280 by 800, dark theme, 14 sessions with long titles. The script asserts the hovered row has no chip, chips beside the composer end at or before its left edge, and the layer is gone after the pointer leaves.

Screenshots / video

Every evidence file for this PR is listed here and none is committed.

  1. before.png, the list at rest with the pointer on one row and its hover toolbar showing.
    before
  2. scrolling.png, mid-scroll. 11 chips show full titles, the hovered row has none, and the two lowest chips end 4 px short of the composer. The greeting behind the chips was mid-change when the still was taken.
    scrolling
  3. after-leave.png, the pointer off the sidebar and the layer gone.
    after-leave
  4. settings-toggle.png, the setting's info tooltip with the one-sentence description.
    settings-toggle
  5. demo.webm, the same sequence recorded.
    https://github.com/user-attachments/assets/dc1319a8-3299-4ff3-ab4a-5f2db561f7e0

Related Issues

Follow-up to #15224.

Deferred UX review items, one issue each:

Pattern harvest

Not generalizable: the chip-over-composer defect came from a floating layer that measured only the sidebar, and the data-scroll-peek-stop attribute now names the surfaces it must not cover. No other layer draws across the sidebar edge.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@Pearcekieser
Pearcekieser requested review from a team and KiroCrewCaptain as code owners October 14, 2026 04:32
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 14, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/scroll-peek-hardening branch from 06dced8 to e77da1a Compare October 14, 2026 04:43
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): rebased on main as e77da1a, no behaviour change. main 70d2fa6 conflicted in one line of website/src/pages/ChatPage.tsx, the composer dock div: #19864 added the selection-inert attribute and this PR adds data-scroll-peek-stop there. The resolution keeps both attributes. tsc and the 2 scroll peek test files (27 tests) pass locally. The body also gains the Goal line that Fork PR Description asked for.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of 667047ffd17d251d9e054f0cd44b5bd213ceaea2 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Peek chips render in regular weight while the row titles are semibold, so every title visibly thins when scrolling starts. Without a border, the chips also merge into the chat behind them.

Watch

  • Weight jump on every scroll. In ScrollPeekLayer.tsx the chip class is ${ROW_TITLE_CLS} text-text bg-bg-elevated …. ROW_TITLE_CLS is only text-[13px] leading-[20px]. The row itself adds font-semibold (SessionRow.tsx:1561). So the chips don't use "the row's own type", as the PR comment says they do. You can see it in scrolling.png: the chips are light, while the hovered row ("Model switch in p…") and every title in before.png and after-leave.png are semibold. The whole list changes weight each time a scroll starts and ends, which happens every session on the daily surface. Fix: replace font-semibold in the chip class. Then change the test from "no font-semibold" to "matches the row's weight".
  • Chips merge with the hero. With no border or shadow, a 20 px chip edge disappears against the chat. In scrolling.png, "Subagent resumability across gateway restarts and upgrades" sits on top of "Good afternoon". The heading's glyphs stick out above and below the chip and read as garbled text ("ɑood afternoon"). Chips also cut through the suggestion cards ("rize this week's"). The chip fill alone isn't enough contrast to separate the chips from what's underneath. Fix: use a subtle 1 px border-border without the shadow, or a fill that contrasts more with bg.

[UX-REVIEWED] 667047f

Description read

[DESCRIPTION-READ] e6e354294ddaa0ce99b24d332907aa256bf588d5903aaf313160cbb1877f1346

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 667047ffd17d251d9e054f0cd44b5bd213ceaea2 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 667047f

Description read

[DESCRIPTION-READ] 6b879d6588107cefe2361a82988459f8b68b5a4e8d336e3cf0a089ab2035bb78

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 667047ffd17d251d9e054f0cd44b5bd213ceaea2 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that fillsHost stays true on every phone-width render, now that the peek no longer checks !isMobile itself.

What this change ships

Inventory (7 items) — 7 justified

Intent: when the sidebar scroll peek shows full titles, it should not cover the hovered row's actions or the composer, and it should stay up while the pointer is on the sidebar. This is a FIX.

  1. The row whose hover toolbar is showing gets no full-title chip while scrolling — justified
  2. Chips stop at the composer dock's left edge, and a chip left too narrow to show more than the row is dropped — justified
  3. A wheel or mouse move over the sidebar counts as the pointer being there, so the peek no longer vanishes 0.7 s after scrolling — justified
  4. Chips lose their border, shadow and bold weight and use the row's own title style — justified
  5. The setting description is shortened to one sentence in all 12 locales, with the settings registry and pseudolocale regenerated — justified
  6. The scrollPeek prop is removed and the peek is turned off by fillsHost (both callers set it for mobile and the sessions embed) — justified
  7. The committed temp-screenshots/ stills are deleted, and a capture script recreates them — justified

[FIRST-PRINCIPLES-REVIEWED] 667047f

Description read

[DESCRIPTION-READ] c20f16e46afcb37d2d8ea379fe2dcb5076ccb3ea989e26dba2594600b364d450

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 667047ffd17d251d9e054f0cd44b5bd213ceaea2 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 667047f

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 667047ffd17d251d9e054f0cd44b5bd213ceaea2 via the fork AI-review pipeline; updated in place on each push.

Review details

FINDING: a wheel latched to the sidebar can mark the pointer as inside after it has left, so the full-title chips stay over the chat.

FINDING — website/src/pages/chat-sidebar/scrollPeek.ts:261 — if (e instanceof WheelEvent) markPointer(e.clientX, e.clientY) treats every wheel event that reaches the lane as proof the pointer is inside. Browsers latch the wheel and momentum events of one gesture to the element where the gesture started. So when the cursor leaves the sidebar mid-gesture, those events still reach the lane, and markPointer sets pointerInsideRef back to true and calls clearCollapse(). That cancels the scheduleStop(PEEK_LEAVE_DELAY_MS) that onLeave set, so the chips stay up until the PEEK_IDLE_MAX_MS ceiling instead of the leave delay. → Fix: in onScrollIntent, only call markPointer when (e.clientX, e.clientY) falls inside root.getBoundingClientRect(). Otherwise just update pointRef as the code did before.

[OPUS-REVIEWED] 667047f

@Pearcekieser
Pearcekieser force-pushed the fix/scroll-peek-hardening branch from e77da1a to f781bf9 Compare October 14, 2026 05:17
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

issue (blocking): Frontend Tests (2) failed on e77da1a in src/test/ChatPage.overlaySelection.test.tsx, added on main by #19864. The test reads ChatPage.tsx as text and expects the selection-inert spread right after data-testid="composer-dock-root"; the rebase had put data-scroll-peek-stop between them. f781bf9 moves data-scroll-peek-stop after the spread, so the rendered attributes are the same. That test, the scroll peek tests and the other ChatPage suites (93 files, 1072 tests) pass locally. This push also re-runs the four lanes that hit the installation API rate limit between 04:49Z and 04:55Z: Publish readiness signal, Fork PR Description, Sensitive Change Review and Dependency License Gate.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/scroll-peek-hardening branch from f781bf9 to 7c44fb2 Compare October 14, 2026 08:12
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): pushed 7c44fb2 to re-run CI, no code change. Its tree is identical to f781bf9; only the commit date moved. On f781bf9, E2E (stub ACP backend, offline) ran all 323 Playwright tests with 0 unexpected and 0 flaky, then stopped at the 1020 s suite bound after 16.9 minutes. Every other check on that head passed.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): Frontend Tests (2) failed on 7c44fb2 with 5 failures in src/test/ChatEmbed.optimisticSend.test.tsx, which this PR does not touch. The same 5 tests fail locally on plain main 30bb0b3, so they come from main after f0016d7 (#19881), not from this branch. Frontend Coverage Merge failed because that shard did. The same shard passed on f781bf9, which has an identical tree, before main moved. I will re-run once main is green.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 14, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/scroll-peek-hardening branch from 7c44fb2 to dfa8720 Compare October 14, 2026 10:42
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): rebased on main 641b42a as dfa8720, no behaviour change. The rebase was clean and picks up #20212, which fixes the 5 ChatEmbed.optimisticSend failures that turned Frontend Tests (2) red on 7c44fb2. That file, ChatPage.overlaySelection and the 2 scroll peek files (43 tests) pass locally, and tsc passes. E2E (stub ACP backend, offline) has stopped at the 1020 s bound on both earlier heads with every test passing; this push runs it again.

@Pearcekieser
Pearcekieser force-pushed the fix/scroll-peek-hardening branch from dfa8720 to a138682 Compare October 14, 2026 11:02
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

issue (blocking): the 120 ms fade rode along, so I removed it in a138682. First Principles Review was right that none of the six deferred findings or the Goal asks for a fade. ScrollPeekLayer is now a plain portaled div: the framer-motion import, FADE_S, AnimatePresence and the separate reduced-motion render path are gone. The reduced-motion test is replaced by one that checks the layer is removed on the render the peek ends. The PR body no longer mentions the fade. scrollPeek and ChatPage.overlaySelection (3 files, 31 tests), tsc and eslint pass locally.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): answers to the 2 First Principles CONCERNS items on a138682. These are advisory, so I am not pushing for them.

Item 4, chip weight. The deferred #15224 UX finding "Every row becomes a floating card" is the source, and its disposition says the follow-up drops the border, shadow and semibold weight: #15224 (comment). The lighter weight is deliberate. A bold chip over a bold title reads as a second card, which was the finding. The code comment's phrase "the row's own type" means ROW_TITLE_CLS, the size and line height, not the weight. A maintainer can restore font-semibold in one class if they prefer it.

Item 5, setting description. There is no linked report of anyone misreading the two-clause wording. I shortened it because the peek no longer hides shortly after scrolling stops, so that clause was no longer true once item 3 ships. The new sentence describes only what the setting does. If a maintainer wants the old wording, it is a revert of 13 locale strings.

@github-actions github-actions Bot added the readiness: passed Eligible automated validation passed for the current revision label Oct 18, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: rebut
The regular weight is deliberate. The deferred #15224 UX finding "Every row becomes a floating card" asked for the border, shadow and semibold weight to go, and its disposition is #15224 (comment). A semibold chip drawn over a semibold title read as a second card. The chip keeps ROW_TITLE_CLS, so size and line height match the row; only the weight differs. First Principles raised the same point on a138682 and the answer is in #20109 (comment). Restoring font-semibold is a one-class change if a maintainer prefers it.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: accept-and-defer
The chip is opaque, using bg-bg-elevated, so where it runs past the sidebar it covers the chat text under it rather than mixing with it. That is why the greeting in attachment-02 loses its first letters. The chip exists only while the list is scrolling and is removed on the render the peek ends, so the covered text is back as soon as scrolling stops. Dropping the border and shadow came from the same deferred #15224 finding as the weight. Readiness has passed on this head, so I am not pushing for an advisory item. If maintainers want the chip edge back over chat content, a hairline border on the overflow side can go in a follow-up PR.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: accept-and-defer
The suggested wording "While you scroll the session list, cut-off titles show in full" reads more easily. Changing it touches the English string plus 12 translated locale strings and the generated settings registry, and readiness has passed on this head, so I will make it in a follow-up PR after this one merges rather than reset CI now.

mbriones98
mbriones98 previously approved these changes Oct 18, 2026

@mbriones98 mbriones98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks green and PR Readiness passed at 60b671c; non-feature change.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes at 60b671c for tracking only; the code looks sound.

Blockers:

  1. Two UX findings are marked accept-and-defer with no linked issue: the description rewording (span=0ac617ef3b8e, #20109 (comment), which promises a follow-up PR) and the hairline edge for chips over chat text (span=1bebb6919fd6, #20109 (comment)). Please either fix them here or open one issue per item and link both in the PR description.
  2. The Design Review PASS punchline on this head asks to confirm the composer dock is the only right-hand surface the chips can reach (#20109 (comment)). It has no target=design disposition yet; a one-line answer is enough.

Why the code is otherwise safe: the !fillsHost gate matches the old scrollPeek opt-in at both production call sites (

<ChatSidebar
slots={filteredSlots}
activeSlot={activeSlot}
unreadSlots={surfaceUnreadSlots}
history={history}
historyHasMore={historyHasMore}
defaultAgent={defaultAgent}
installedAgents={installedAgents}
rowAgents={sidebarAgents}
rowChoices={sidebarChoices}
mode={mode}
onWidthChange={setSidebarWidth}
onDragChange={setSidebarDragging}
fillsHost={isMobile}
collapsible={!isMobile}
staticRows={isMobile}
), the :hover skip, peek-stop width cap and wheel-as-presence changes each have a targeted test, the chip-weight rebuttal is reasoned, and every check on this head is green.

— crew-pr-reviewer (r111)

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

outcome: confirmed
The composer dock is the only surface marked data-scroll-peek-stop, and it is the only persistent right-hand surface that sits in a row's band and takes typing. Other surfaces are handled without the marker. measureClippedTitles skips a title whose start another element covers, which catches a docked panel over the sidebar's rows. Any press, a non-scrolling key or window blur ends the peek at once, so nothing the user opens can sit beneath it. A banner or pill that mounts on its own is bounded by PEEK_IDLE_MAX_MS, 4 s after the last scroll input. A future right-hand overlay that holds input should add data-scroll-peek-stop, as the scrollPeek.ts header comment says.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

@iamwhatever note (non-blocking): both blockers from the r111 review are answered, with no code change.

The two deferred UX items now each have an issue linked in the PR description under Related Issues. Pearcekieser#42 covers the setting-description rewording (span 0ac617ef3b8e) and Pearcekieser#43 covers the edge for chips over chat text (span 1bebb6919fd6). They are on the fork because the upstream issue hook only accepts an issue opened together with its PR; the rewording PR will open its upstream issue when it is published after this merges.

The Design PASS punchline has a target=design disposition at #20109 (comment). The composer dock is the only data-scroll-peek-stop surface, and the other cases are covered by the covered-start check, the end-on-press rule and the 4 s PEEK_IDLE_MAX_MS ceiling.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 19, 2026
…he composer, plainer chips

- Remove the scrollPeek prop; the peek is off when the sidebar fills its host.
- Count a wheel or pointermove over the sidebar as pointer presence.
- Skip the row whose hover toolbar shows.
- Cap chips at the left edge of any data-scroll-peek-stop surface (the composer dock).
- Drop chip border, shadow and bold weight; fade the layer 120 ms, none under reduced motion.
- Shorten the setting description to one sentence in every locale.
- Add a capture script for the stills and drop the committed evidence files; they live on the PR.
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): rebased 667047f onto main de80cdc, no behaviour change. The conflict came from #20330, which moved ScrollPeekLayer.tsx from createPortal(document.body) to the shared OverlayPortal. I kept main's OverlayPortal wrapper and this PR's plain chips with no border, shadow or semibold weight. tsc, eslint on the file and 223 vitest tests across 6 files covering the sidebar, scroll peek and overlay selection pass locally.

@Pearcekieser
Pearcekieser force-pushed the fix/scroll-peek-hardening branch from 60b671c to 667047f Compare October 20, 2026 04:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 20, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 667047f. This replaces our r111 change request.

Both r111 blockers are answered. The two deferred UX items each have a linked issue whose body covers them (Pearcekieser#42 and #43), and the Design check has a target=design disposition. The current UX round repeats the chip-weight and chip-edge classes that are already dispositioned. The rebase onto #20330 changes no behavior.

The peek is now gated by !fillsHost. Both production mounts set it for the sessions embed and for phones (ChatSidebar.tsx L564-L576), so phone widths stay off as before. CI is green and no sensitive files are touched.

The two follow-up issues live on your fork. Please open matching issues here once the hook allows it, so maintainers can track them.

— crew-pr-reviewer (r115)

@iamwhatever
iamwhatever merged commit f65c6e9 into kirodotdev:main Oct 20, 2026
100 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 20, 2026
iamwhatever pushed a commit to Pearcekieser/KiroCrew that referenced this pull request Oct 26, 2026
The description now reads 'While you scroll the session list, cut-off
titles show in full'. The UX review on kirodotdev#20109 found 'titles the sidebar
cuts off show in full' hard to parse on a first read. The translated
strings already say the same thing in their own word order, so only the
English source, the pseudo-locale and the generated settings registry
change.
iamwhatever pushed a commit that referenced this pull request Oct 26, 2026
…22547)

The description now reads 'While you scroll the session list, cut-off
titles show in full'. The UX review on #20109 found 'titles the sidebar
cuts off show in full' hard to parse on a first read. The translated
strings already say the same thing in their own word order, so only the
English source, the pseudo-locale and the generated settings registry
change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants