Skip to content

refactor(website): compose ChatPage from pages/chat/page owners - #15526

Merged
bolichen97 merged 1 commit into
mainfrom
refactor/f08-chat-page-orchestration
Oct 1, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
refactor/f08-chat-page-orchestration

Conversation

@bolichen97

@bolichen97 bolichen97 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The chat page keeps working exactly as it does today while its 9,500-line component is split into focused owners that a contributor can read, test and change one responsibility at a time.

website/src/pages/ChatPage.tsx held every chat-page responsibility inline: composer drafts and @-mention chips, launch and prefill intake, window and Electron event bridges, steer / queue / stop, turn recovery, transcript rows and jumps, the composer chips, the pane notices and the phone top bar. At 9,810 lines it was the frontend's highest-churn file; a change to one of those concerns meant reading and re-testing all of them, and 50+ open PRs touch it.

Why it matters

Every chat fix lands in this one file, so its size is paid on every change: review diffs are hard to read, conflicts between unrelated PRs are routine, and a behaviour can only be tested through a full page render. Owners with one job each give the next change a small, testable surface without changing anything a user sees.

Not a goal

  • No behaviour, copy, layout, DOM hook, storage key, event name or query key changes.
  • No change to the shared owners the page consumes (Redux store/chat/**, hooks/virtualizer/**, hooks/websocket/**, components/chat-input/**, the sidebar, the API client).
  • No new lazy boundary or load-order change, even where it would shrink the App chunk.
  • Code that source-pin tests hold in ChatPage.tsx (the send path, the switchSlot sites, renderers and renderMessage, paging and pins, the model picker, drawers and layout) stays there.

What changed (motivation → approach → change)

Users see no change. Each chat-page concern now lives in its own small module, so a fix to one can be read, tested and reviewed without the other 9,000 lines.

What ChatPage.tsx 9,732 → 6,518 lines; 19 owners under pages/chat/page/
How verbatim span moves; ChatPage calls each owner where its inline code ran
Guarantees same exports and props; effect-bearing hook sequence identical to main's ChatPage (machine-checked)

ChatPage stays the page's one public surface: the default export, its props (mode, embedded, embedMode, popout, noUrlSync), shouldAutoFillOlder and the PREFILL_STORAGE_KEY re-export. It composes its three existing controllers and the new owners, which own composer drafts, staging and @-mentions (composerDrafts.ts, composerStaging.ts, composerFileMentions.ts), text arriving from outside a keystroke (launchIntake.ts), window and Electron events (eventBridges.ts), a busy turn (busyTurnControls.ts), recovery (turnRecovery.ts), transcript rows and jumps (transcriptRows.ts, transcriptJumps.ts), the composer chips, rosters, session controls, automation, follow-up chips and welcome screen, and the dock, pane notices and phone top bar. The owner map is in learn-cron-dashboard.md § Frontend.

React runs effects in declaration order and several page effects are ordered against each other, so every moved block is copied verbatim and called at the position it held; the only hand edits are dependency arrays gaining stable refs and setters, and comments that named ChatPage line numbers. Upstream #14773 (chip undo, persisted aliases), #14756 (prompt history), #15493 (the chip's default marker), #14220 (the phone menu's new-session item), #11744 (run-in-terminal tab reuse) and #15359 (Autopilot removal: the follow-up chips drop plan dispatch) are ported into their owners.

The owning specs, the feature map, two RFC line cites (rfc-transcript-section-markers.md, rfc-resumable-subagent-sessions.md) and one note in dashboard-iframe-hosts.md now name the owners. The App chunk grows about 14 KB, entirely owner option, return and prop names that cannot be mangled: the chunk count stays 822 and no lazy chunk moves into or out of App. This PR does not edit the bundle budget: App measures 2,040,489 B, inside the 2094 KB ceiling main set in #15514.

Comments in files outside this change's claim still name ChatPage for code that now lives in an owner. They are left for a docs-sync follow-up:

Comment Now in
utils/chatFileTokenDrafts.ts:3, components/FollowUpCard.tsx:154 composerDrafts.ts
utils/fileTokens.ts:883 composerFileMentions.ts
components/ChatPane.tsx:1908 / :1955 composerDock.tsx / composerChips.ts
hooks/virtualizer/ScrollAnchorCache.ts:32 / :62, test/ScrollAnchorCache.test.ts:98, hooks/virtualizer/useVirtualChat.ts:69 / :205, chat-core/transcript/useStableMessageKey.ts:5, store/chat/transcript.ts:23 transcriptRows.ts
apps/command-bar/CommandBarOverlay.test.tsx:836, utils/errorReport.ts:390 launchIntake.ts (useErrorHandoffIntake)
components/WidgetFrame.tsx:280 launchIntake.ts (useAutoSendIntake)

Backwards compatibility

Compatible: the facade keeps every export, prop and default its five importers use (App.tsx, PopoutFrame.tsx, app-sdk/ChatPanel.tsx, apps/papyrus/CoAuthorPanel.tsx, components/ArtifactChatPanel.tsx); no wire, storage, event or query-key shape changes.

Tests

  • ChatPage.pageOwners.test.ts pins the facade exports (PREFILL_STORAGE_KEY is navIntent's binding), that no owner imports the facade or calls switchSlot, that only ChatPage imports the owners, and the owner call order with the inline signed-token effect's place in it (usePendingInputIntake must read ?prefill= before that effect strips the query). The order and import pins were checked red by mutation.
  • useChatPageEventBridges, useChatPageTranscriptJumps, useChatPageTurnRecovery, useChatPageComposerChips, ChatPage.mobileTopBarActions and ChatPage.paneNoticeDismissals cover owner paths no page suite drove (Web Preview dedupe, prefill-terminal refusals and deadline, cold file-tab reads, search re-click, error-row fixes, pin-write failure, the phone bar's menu actions, every notice's dismiss). Every owner is ≥84% line-covered by owned tests.
  • The owned source-pin tests (ChatPageDrafts, dockClearance, reachability, newSessionModel, sessionChipOffline, mcpOAuth, idlePrefetchAuth) read the moved text from its new owner at the same strength.
  • Unchanged and green: every owned ChatPage / useChatPage / SideSlashCommand suite and the read-only oracles, including switchSlotCallsiteClassification, chatSlice.ownership, the ChatPage source-text pins and the behavioural renders (116+ files).

Manual verification

N/A — unit coverage sufficient: the change is a structural move with no rendered delta, and every user path it touches is driven by the existing ChatPage render suites plus the new owner tests.

Screenshots / video

Why no screenshot: structural move only; every DOM node, class, testid and string renders identically, pinned by the unchanged ChatPage render and source-pin suites.

Related Issues

no linked issue: campaign scope F08 (chat page orchestration refactor).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@bolichen97
bolichen97 requested a review from a team September 30, 2026 18:19
@bolichen97
bolichen97 requested a review from a team as a code owner September 30, 2026 18:19
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

The order pin reads the new source only; its claimed equality with main's inline effect order rests on the author's out-of-diff machine check — verify once against base.

What this change ships

Inventory (9 items) — 9 justified

Intent: split the 9,700-line chat page into per-concern modules with zero behavior change — a structural refactor (an ADDITION of internal structure, no new capability, no FIX).

  1. 19 internal owner modules under pages/chat/page/ take the composer, intake, bridge, transcript, notice and phone-bar code — justified
  2. ChatPage keeps every export, prop, default and the send path; importers unchanged (5 counted) — justified
  3. New pin test holds the owner call order, the facade exports and the one-importer boundary — justified
  4. New owner suites cover paths no page suite drove; existing source pins broadened to scan owners too (strengthened, none deleted) — justified
  5. Specs, feature map and two RFC line cites now name the owners (AGENTS.md same-commit doc rule) — justified
  6. App chunk grows ~14 KB, inside the recorded budget; chunk count unchanged — justified
  7. The millisecond-unique notification ts helper becomes a shared module for its three callers (verbatim move) — justified
  8. Hand edits limited to the declared classes: dep arrays gaining stable setters, line-number comments reworded (spot-checked, matches) — justified
  9. Stale ChatPage-naming comments in 12 outside files declared and deferred — justified

Checks run: storage keys, testids and event listeners deleted from ChatPage reappear 1:1 in owners; no test file deleted; RFC edits are line-cite syncs, no status change; no default, label or capability moves, so lens 9 does not apply.

[FIRST-PRINCIPLES-REVIEWED] f5dc59d

Description read

[DESCRIPTION-READ] e3ea05f6156acff7feb6117023a5323e26630b40dd18b384c5022d2f1587a4bc

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

[UX-REVIEWED] f5dc59d

Description read

[DESCRIPTION-READ] a15530506832622645e2aaccb368f1221b9e61b25771e654ec55b99a2695cd6e

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the dependency-array hand edits add only identity-stable refs and setters — the one edit class the machine-checked hook-sequence guarantee doesn't cover.

[DESIGN-REVIEWED] f5dc59d

Description read

[DESCRIPTION-READ] aa96ff4035f14d4f19d83fd3a46469412644ec1c9da3eb144361dcc6c8c7d69e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f5dc59d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ human override accepted

Reviewed f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe — this comment is updated in place on each push.

Human judgment by @bolichen97 overrides the Opus 5 finding for f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe; the recorded reason is authoritative for this commit.

[OPUS-OVERRIDE] f5dc59d

Verdict recorded from an authorized human decision for commit f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe: <one-sentence reason>

@bolichen97
bolichen97 force-pushed the refactor/f08-chat-page-orchestration branch from e63f7c1 to 7c8b26a Compare September 30, 2026 19:50
@bolichen97

Copy link
Copy Markdown
Contributor Author

Pushed 7c8b26aa1: rebased onto main 3ecea02fe, which now includes #15514's re-measured App ceiling, plus one test fix.

  • Automated Rule Check (red on e63f7c1d5): a new test reset the DOM with document.body.innerHTML = '', which the frontend-security rule blocks. It now uses document.body.replaceChildren(). I ran the rule step's own script locally: it exits 0 on 7c8b26aa1.
  • Bundle Size Gate: App is 2,055,899 B, inside the 2094 KB ceiling from fix(ci): re-measure the stale App-chunk bundle ceiling that fails main #15514. check-bundle-size.mjs is untouched.
  • First Principles headline (verify the dependency-array hunks): every added dependency is a ref, a state setter, or a callback that keeps a stable identity. Before this PR, the ones not declared locally came from the page's scope, so they never appeared in a dependency list. A read-only review compared each owner with the base ChatPage span it came from. It found no dependency that re-fires an effect or changes a callback's identity. The effect-bearing hook sequence (242 hooks) is identical to main's ChatPage.
  • Design headline (fix(ci): re-measure the stale App-chunk bundle ceiling that fails main #15514 first): fix(ci): re-measure the stale App-chunk bundle ceiling that fails main #15514 is merged, and this head is rebased onto it.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rerunning one job once (flake): Backend Tests (Windows) (8), job 110069288876 on 7c8b26aa1.

The single failure is test/test_members_dm_thread.py::TestResumeGuards::test_concurrent_member_resume_does_not_duplicate_history: AssertionError: history duplicated: 2 copies. The rest of the shard passed (16,599 tests). Evidence that it is unrelated:

  • This PR changes only website/** and docs/**. It touches no backend code.
  • The same shard passed on the previous head e63f7c1d5 (job 110033327979). The only backend file that differs between the two bases is test/test_acp_runtime.py, which is unrelated to this test.
  • The same test id passes 5/5 locally (Linux, Python 3.12).

This is the one exact-job rerun; nothing else is being rerun.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Sep 30, 2026
@bolichen97
bolichen97 force-pushed the refactor/f08-chat-page-orchestration branch from 7c8b26a to 635bea8 Compare October 1, 2026 00:40
@bolichen97

Copy link
Copy Markdown
Contributor Author

Pushed 635bea8bd: rebased onto main 1e3885a5f. The PR had gone DIRTY on #15493, so its ChatPage hunks were carried over unchanged to where that code now lives:

  • The chip-marker block (useSettingsDefaultModel / modelChipMarker) goes in useComposerChips (pages/chat/page/composerChips.ts), at the same point in the hook order.
  • The model-default-error notice goes in pages/chat/page/ChatPaneNotices.tsx, which receives chipDefault as a prop.
  • The composer's modelIsInheritedDefault / modelIsAutoChosen props stay in the page's JSX.

The effect-bearing hook sequence still matches main's ChatPage. #15493's own tests run unmodified and pass, and the Bundle Size Gate passes (App 2,057,313 B).

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision labels Oct 1, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

CI status on 635bea8bd: two failures, neither caused by this PR.

  • Resolve desktop matrix (job 110163829091), infrastructure: re-run once. The dorny/paths-filter step stopped with API rate limit exceeded for installation (request 427D:22CE85:1CD0435:5E97F61:6ABDAC4B, 00:41:47Z). That happened before the job produced any verdict. I re-ran the job once at 01:03Z, after the installation window reset.
  • Backend Tests (Windows) (2) (job 110164370897), already failing on main: not re-run. The two failures are test/test_native_skill_projection.py::test_leftover_alias_lock_files_are_swept_only_when_provably_residue and ::test_a_lock_file_a_launcher_still_holds_is_never_swept.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 1, 2026
@bolichen97
bolichen97 force-pushed the refactor/f08-chat-page-orchestration branch from 635bea8 to 0ccb93f Compare October 1, 2026 02:41
@bolichen97

Copy link
Copy Markdown
Contributor Author

Infra rerun (SD21-3) on 0ccb93fc3. Two checks failed on the CI app's installation API rate limit before either produced a verdict:

  • Resolve desktop matrix (run 36807013746, job 110193509320): dorny/paths-filter returned API rate limit exceeded for installation, request C7D5:22C40C:25EED56:7D58897:6ABDC898, 02:42:32Z.
  • Publish readiness signal (run 36807010301, job 110193498894): the readiness read hit the same limit (request 1387:196116:70D571:7DDB83:6ABDC86D, 02:41:50Z; core 0/15000 remaining). The job published [read-failed] instead of a verdict.

The installation window reset at 02:42:34Z. Both runs were re-run once with --failed at 03:08Z.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 1, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=be4895e46523 Commit the hook-sequence checker used for the "242 hooks, machine-checked" claim

rebutted (disproportionate here): the checker is a one-off comparison script, not a product or CI surface; committing it would add new tooling outside this PR's scope (it would live under scripts/, which this refactor does not touch).
The order guarantee that ships, and runs in CI on every later change, is website/src/test/ChatPage.pageOwners.test.ts: it pins the page's owner-hook call sequence plus the inline signed-token effect's place in it, and goes red on a reorder (mutation-checked).
The one-off comparison was re-run at this head against main: the effect-bearing hook sequence and the hook multiset are identical. The count is 243 on the current base, not the 242 in the description, because main's #15493 added one hook to ChatPage.
A later extraction wave can re-run the same comparison from the campaign's notes, or propose a committed checker in its own PR.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 1, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at f5dc59d8e2356433ffe2d2a7b29ebbe2b3088dfe: approve

I found nothing blocking. I checked the behaviour-preservation claim against the merge base fecca3ea5 independently, without relying on the author's checker or the bot verdicts.

Verified against source

  • Hook order. I flattened base ChatPage and new ChatPage with every pages/chat/page/* owner hook inlined. Both have 458 hook calls with an identical multiset, including 71 useEffect/useLayoutEffect. All 144 effects and custom hooks (useComposerDraftSelector, useAnchoredTriggerRect, useVirtualChat, the controllers, and so on) map one-to-one to base and run in the same relative order. That includes the order-sensitive chain: the draft commit, then slot restore, then the three staged-persist effects, then composerSlotRef advancing last (composerDrafts.ts:388-427). Only plain useState/useRef/useCallback declarations moved. The staging state block now comes before the draft lifecycle. That has no behavioural effect, and tsc -b rules out any use-before-declaration.
  • Child components. ChatPaneNotices, MobileTopBar and the dock JSX contain no hooks. Moving them into child components did not move any effects into child-first order.
  • No duplicated state. No useState or useRef name is declared twice across ChatPage and the owners. The hook multiset matches base, so no owner adds state.
  • Dependency-array hand edits (the design lane's headline). I diffed every changed dependency array against its base array. Each added entry is a useRef, a useState setter, dispatch, queryClient, or a useCallback with stable deps. Examples are setInput = composerDraft.set from a useState(() => …)[0] store, the drafts/fileDrafts/pasteDrafts/pickedFileTokens refs, and currentSlotTokens/recordSlotToken/mergeSlotTokens, which depend only on refs. location.key became the locationKey value, which is the same value. Two module functions are injected: activateHandoffSlot and createFailReason. The useMemo deps in ChatPage gained only setAutomationOpen (a state setter). The empty-deps unmount cleanup (composerDrafts.ts:349) gained only refs, so it cannot fire early.
  • Dropped code. Every non-comment base line missing from the new tree is an import, a dependency array, a reworded comment, or an inline JSX handler that was hoisted to a named function with a verbatim body: stopTurn, keepQuestionAnswer, answerQuestionCard, removeFileChip, removeDirChip, selectPickedFile, applyAutomationChange and toggleFollowUpOption. The error hand-off's switchSlot(...).unwrap() became the injected activateHandoffSlot (ChatPage.tsx:359) with the same arguments.
  • Opus override. I checked git range-diff from 1425295366 (the head Opus published "No findings" on) to this head. It contains only the #15359 Autopilot port (plan dispatch, usePlanActionMutation and comment pruning) plus the rebase. The override reasoning holds.
  • CI and tests. cd website && npx tsc -b is clean. All 84 ChatPage*/useChatPage* vitest files pass (928 tests). At this SHA, 86 check runs succeeded and 8 were skipped.

Mutation checks (all restored)

  • I moved the composerSlotRef advance ahead of the persist effects. ChatPageDrafts.test.tsx failed: "declares all three composer-persist effects before advancing composerSlotRef".
  • I swapped the useErrorHandoffIntake and usePendingInputIntake calls. ChatPage.pageOwners.test.ts failed: "are called by the page in the order their inline code ran".
  • I dropped the in-memory dedupe on the Web Preview marker (eventBridges.ts:103). useChatPageEventBridges.test.tsx failed: "dedupes on the in-memory key when the persisted write is lost".

Follow-ups (non-blocking)

  1. The squash commit message is wrong in a way that lands on main. The auto-merge commit_message says "ChatPage.tsx had grown to 9,468 lines". At this base it is 9,732, which is also what the PR body's own table says. It also says "the only hand edits are dependency arrays … and comment re-pointers", but the edits also hoist the inline handlers listed above, inject activateHandoffSlot, and move uniqueNotificationTs into notificationTs.ts. Please correct the count and widen that sentence. It also names only #14773 and #14756 of the six upstream ports the body lists. Separately, the PR body cites 9,500 and 9,810 in its prose.
  2. The order pin covers the owner call sequence and one inline anchor. It does not cover effect order inside owners, or owners against the other inline page effects. Those currently hold only through the uncommitted one-off checker. A committed version of that comparison would keep the guarantee after this PR.
  3. The deferred stale ChatPage comment pointers listed in the body still need the docs-sync follow-up.

@bolichen97
bolichen97 merged commit 95cc812 into main Oct 1, 2026
97 of 99 checks passed
@bolichen97
bolichen97 deleted the refactor/f08-chat-page-orchestration branch October 1, 2026 15:20
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 1, 2026
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 6, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 7, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
omerrubi-amzn added a commit to omerrubi-amzn/KiroCrew that referenced this pull request Oct 7, 2026
A palette command fired from a non-chat page seeds pendingInput and
navigates to /chat, which mounts fresh. On the old base the slot's
draft-restore then overwrote the composer with the empty persisted
draft (the probe fails there); the ChatPage split (kirodotdev#15526) fixed it as
a side effect. Pin the observable behavior -- the composer holds the
seed -- so it stays fixed. Replaces this PR's earlier keyed-prefill
write, which is no longer needed and could resurrect a stale seed over
an edited draft on the warm path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants