Skip to content

fix(chat): keep the pinned prompt card above the composer dock - #15828

Merged
iamwhatever merged 1 commit into
mainfrom
fix/pinned-prompt-expand-overlap
Oct 1, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/pinned-prompt-expand-overlap

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The pinned copy of your last prompt never covers the chat input box.

The chat pins the most recent user prompt under the session title while it scrolls away. Two things grow that card: the progressive fold holds it at the prompt bubble's remaining height while the row leaves, and the chevron (or a resting pointer) expands it. Nothing capped either, so on a short pane a long prompt's card ran straight down over the composer and the Dynamic Dashboard bar. Reported in Slack with a screenshot of a 30-item numbered prompt painted over the input box; the reporter traced it to the hover-expand feature.

Why it matters

Anyone who pastes a long prompt in a window that is not very tall loses the input box until they scroll far enough for the card to shrink again. The expand feature exists to let you re-read your prompt; instead it takes the composer away.

Not a goal

What changed (motivation → approach → change)

Where What
usePinnedPrompt.ts measures the transcript floor — the scroller's bottom minus its padding-bottom — and derives maxH for the card; clamps the fold's live height to it; also observes the scroller's size so a resize re-derives it, and keys that observer on the pinned index too, so a hand-off between prompts without a ts re-attaches it
utils/pinnedPrompt.ts computePinnedCardMaxH(foldY, floorY); maxH carried on PinnedPromptState
PinnedPrompt.tsx maxH lands as max-height on the bubble and the bubble clips (overflow-hidden), so nothing inside can paint past the ceiling; the body is a shrinkable flex column (min-h-0, flex-col, items-stretch) and the expanded image strip scrolls like the text, so the cap scrolls the content instead of cutting it; the morph parks the box at flex-start for its 150ms so the expand animation reveals the text as before
ChatPage.tsx, ChatPane.tsx one line each: pass maxH through
website/src/index.css .pinned-scroll-more: the mask-image fade (a functional gradient, not a fill)
website/docs/page-layout.md names the floor as the card's ceiling

Symptom: the card paints over the composer. Cause: the card is an overlay beside the scroller that paints above the dock, and its height came from the prompt (fold) or the viewport (40vh), never from where the transcript ends. Fix: cap it at the transcript floor. The scroller's padding-bottom is already each host's statement of where readable rows stop (the main chat pads by the dock height plus a clearance, the side pane by 12px), so the hook reads the floor off the scroller rather than taking a prop, and the two cannot be set apart. A host that moves its floor only has to keep its padding honest.

Backwards compatibility

Compatible: no API or data change. maxH is an optional prop; the card is unbounded as before when a host has measured no floor.

Tests

  • pinnedPrompt.test.ts: computePinnedCardMaxH is the card-top-to-floor distance, caps the fold, never goes negative.
  • usePinnedPrompt.test.tsx: new block pins the ceiling — reported as maxH, clamps liveH, subtracts the scroller's padding-bottom, leaves a fitting fold alone, moves on a scroller resize for the same pinned message, and re-attaches the observers across a hand-off between prompts that carry no ts. Two existing fold tests get a taller fixture scroller so they keep testing the fold; the ResizeObserver test now expects the scroller to be observed too.
  • PinnedPrompt.ceiling.test.tsx (new): maxH lands as max-height, the box clips, the box and body carry the shrinkable-column classes in both states, the expanded image strip and the all-images-gone glyph live inside the paragraph, the bottom fade class follows the scroll position (on with more below, off at the end and when the text fits, never while collapsed), and the morph's flex-start is set in flight and cleared on transitionend.

Related set: 10 pinned-prompt vitest files (incl. kiroLightShellHooks, whose literal for the card's class string follows the new items-stretch overflow-hidden box), 188 tests pass; tsc -p tsconfig.app.json clean.

Manual verification

Scripted Playwright (Chromium launched without --hide-scrollbars, so scrollbars render as a user sees them) against two isolated pods built from this worktree and from origin/main at d8fa6a527e, same imported session (a 30-item prompt, two replies), 1400×560 and 1400×420 viewports, default and translucent-panels (glass) looks. Measured the card's bottom against [data-testid="composer-dock-root"]:

  • origin/main, mid-fold: card 91..1465px, dock top 426 → 1039px of overlap (the Slack screenshot).
  • this branch, mid-fold: card 91..410, dock top 426 → 0px, 16px clearance (DOCK_CLEARANCE_PX).
  • 1400×420 expanded: origin/main card bottom 283 vs dock top 286; this branch 270 — the floor is the binding cap there, not 40vh.
  • Expand, peek and collapse still animate; the card's text scrolls inside the capped box, with the scrollbar and the bottom fade showing there is more.
  • A six-image prompt expanded at 1400×420: the thumbnails lead the text inside the one scroll region and scroll away with it (shot below); with the strip beside the paragraph the strip had shrunk to 16px.

Screenshots / video

Mid-fold, dark: before (origin/main) left, after right.

Mid-fold: before the card buries the composer; after it stops 16px above the dock

Same with translucent panels on (cropped to the card and the composer, where the glass treatment is):

Mid-fold with translucent panels on, cropped to the card and composer so the glass treatment shows: before and after

1400×420, card expanded with the chevron:

Expanded card on a short pane: before 283px vs dock 286 with no scroll cue; after capped at the floor 270 with scrollbar and bottom fade

1400×420, a six-image prompt expanded: thumbnails and text in one scroll region under the ceiling.

Six-image prompt expanded on a short pane

Recording — scroll until the prompt pins (the fold), then expand and collapse; first on origin/main, then on this branch's final build, scrollbars rendered:

pinned-prompt-before-after-final.webm

recorded from c4a72c2 (the final build; and d8fa6a5 for the baseline half) · kirodotdev/KiroCrew worktrees via kirocrew pod up · mode: default, mc-liquid-glass=on for the glass frames · real gateway serving the built SPA with a session imported through /api/chat/slots/import, no fixtures or stubs

Related Issues

no linked issue: reported in Slack (#kirocrew, thread 1790835724.150339); no GitHub issue was filed.

Pattern harvest

Not generalizable: one overlay with one host-owned floor; the fix is a single geometric ceiling, not a recurring code shape.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested a review from a team October 1, 2026 11:05
@bolichen97
bolichen97 requested a review from a team as a code owner October 1, 2026 11:05
@bolichen97
bolichen97 requested a review from CrysisDeu October 1, 2026 11:05
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of c4a72c2f7fbc51e6905a04478b21c2432e7aa1da — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] c4a72c2

Description read

[DESCRIPTION-READ] bea7bef7ca3180d74e6446e14d9e50c9dbd99ec9cee33d1384e4cbea2c8b4c22

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of c4a72c2f7fbc51e6905a04478b21c2432e7aa1da — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the side-pane host: the manual overlap measurements cover only the main chat's dock; ChatPane's 12px padding-bottom floor was never measured against its in-flow composer.

Not justified as shipped

  • Item 3 — rides along: the bottom-edge fade (.pinned-scroll-more, moreBelow state) is not the fix; its harm is named and caused by the cap itself ("a cut line … read as a rendering defect"), so it carries no premise risk.

What this change ships

Inventory (9 items) — 8 justified

Intent: a FIX — the pinned prompt card must never cover the chat input box on a short pane; provenance is a Slack report plus the PR's own measured reproduction on base (1039px overlap).

  1. The pinned card stops at the transcript floor instead of covering the composer — justified
  2. The fold's live height is clamped to that same floor — justified
  3. Capped expanded text fades its bottom edge while more is below — rides along: an affordance the cap newly needs, declared and tested
  4. The expanded image strip now scrolls with the text instead of staying put — justified
  5. The ceiling re-derives on a pane resize with no scroll — justified
  6. Observers re-attach across hand-offs between timestamp-less prompts — justified
  7. The box clips anything that refuses to shrink at the ceiling — justified
  8. The expand animation holds the body at natural height for its 150ms — justified
  9. page-layout.md names the floor as the card's ceiling — justified

Checks run: computePinnedCardMaxH has exactly 1 non-test consumer (usePinnedPrompt.ts); the maxH state field has 2 (ChatPage.tsx, ChatPane.tsx); the deleted strip-placement comment ("stay put while long text scrolls") is reversed with declared, measured evidence (strip at 16px under the ceiling); the one sibling overlay named (Refresh suggestions) is deferred to #15741 in ## Not a goal.

[FIRST-PRINCIPLES-REVIEWED] c4a72c2

Description read

[DESCRIPTION-READ] 33aba6e7f2eee842b800d34278b0d561e5536686e033a4cd4f81f600068daa39

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of c4a72c2f7fbc51e6905a04478b21c2432e7aa1da and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c4a72c2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c4a72c2f7fbc51e6905a04478b21c2432e7aa1da: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of c4a72c2f7fbc51e6905a04478b21c2432e7aa1da — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Verify by playing the supplied recording that expand/collapse stays one continuous motion under the new ceiling — this lane confirmed the mechanism in the diff but cannot play video.

[UX-REVIEWED] c4a72c2

Description read

[DESCRIPTION-READ] f9a980905618f6540b2a82c255da9ff30d3e2fc6059ff66a58a547099a07147b

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@bolichen97
bolichen97 force-pushed the fix/pinned-prompt-expand-overlap branch from af1888e to c51c399 Compare October 1, 2026 11:31
@bolichen97

bolichen97 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=f6a223509ed6 — usePinnedPrompt.ts observer effect keyed on pinned?.ts alone — fixed in c51c399

Outcome: fixed. The ResizeObserver effect now depends on pinned?.idx as well as pinned?.ts.
Rationale: on a transcript whose messages carry no ts (an import, a legacy log) a hand-off from one prompt to the next changed nothing the effect was keyed on, so the observer stayed on the previous card and the new one was never watched. usePinnedPrompt.test.tsx now pins the hand-off between two ts-less prompts; it fails on the previous head and passes on c51c399.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed c4a72c2f7fbc51e6905a04478b21c2432e7aa1da — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c4a72c2

Verdict parsed from the review's SHA-scoped output markers for commit c4a72c2f7fbc51e6905a04478b21c2432e7aa1da.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c4a72c2f7fbc51e6905a04478b21c2432e7aa1da: <one-sentence reason>

@bolichen97
bolichen97 force-pushed the fix/pinned-prompt-expand-overlap branch from c51c399 to 78b08ce Compare October 1, 2026 12:16
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=95fca68df04c — capped expanded card reads as a rendering bug, not a scroll region — fixed in 78b08ce

Outcome: fixed. The expanded paragraph now carries pinned-scroll-more while content continues below its visible edge: a bottom-edge mask-image fade (a functional gradient per the theming contract's "Fills are flat", not a fill), set from the paragraph's scroll position and cleared at the end and when the text fits. The new stills were captured with scrollbars rendered (Chromium without --hide-scrollbars), so the scroll affordance a user sees is in the evidence too.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=ab99ab8cbf4e — two sibling scroll areas; prefer one scroll container — fixed in 78b08ce

Outcome: fixed, taken as written. The expanded image strip moved inside the paragraph, so the card has one scroll region: the thumbnails lead the text and scroll away with it. Measured on a pod at 1400×420 with a six-image prompt, the strip beside the paragraph had shrunk to 16px (flex shares the loss by base size); inside it stays at its 168px natural height. The evidence gap closes with the new six-image screenshot attached to the description.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=b0e1e8cd26f6 — item 7 rides along: observer re-keying for ts-less hand-offs — in scope, kept

Outcome: kept, in scope. The PR adds the scroller to the observed set and reads the card's ceiling off it; an observer effect that never re-attaches after a hand-off between ts-less prompts leaves THIS PR's ceiling stale on exactly the pane shrink the PR exists to handle. It was raised as a finding on this PR's diff by the GPT lane; a defect in code this PR changes is in scope per the template. Declared in the Tests section with its own test, and named in What changed under usePinnedPrompt.ts.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 1, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=04f49baadb1d — item 4 rides along: the bottom-edge fade (.pinned-scroll-more) — in scope, kept

Outcome: kept, in scope. The ceiling is what cuts the paragraph at the floor; the cut line is a consequence THIS PR introduces, and the UX lane judged it as reading like a rendering defect (its Watch item on the previous head, span 95fca68df04c). The fade is the smallest fix that lane named, keyed on the scroll position so it never dims a prompt that fits or a reader at the end. Without it the PR trades one visible defect (card over the composer) for another (a card that looks clipped); with it the capped state reads as the scroll region it is. Named in What changed (PinnedPrompt.tsx, index.css), covered by PinnedPrompt.ceiling.test.tsx.

The pinned-prompt card is an overlay beside the transcript scroller and paints
above the composer dock, and nothing bounded its height: the progressive fold
held a tall prompt's card at the bubble's remaining height and the expansion
grew it to 40vh plus an image strip. On a short pane both ran past the
scroller's bottom and over the input box and the Dynamic Dashboard bar.

The ceiling is the transcript floor: the scroller's bottom less its own
padding-bottom, which is each host's statement of where readable rows stop.
usePinnedPrompt measures it off the scroller, clamps the fold's live height
to it and hands it to the card as maxH; PinnedPrompt sets it as max-height on
the bubble and lays the body out as a shrinkable flex column so the cap
scrolls the prompt instead of clipping it. The morph parks the box at
flex-start for its duration so the expand animation reveals the text as
before.
@bolichen97
bolichen97 force-pushed the fix/pinned-prompt-expand-overlap branch from 78b08ce to c4a72c2 Compare October 1, 2026 12:50
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 1, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • span=38b27a33e5e6 — item 3 rides along: the bottom-edge fade (.pinned-scroll-more) — in scope, kept

Outcome: kept, in scope. The ceiling this PR adds is what cuts the paragraph at the floor, so the cut line is a harm this PR introduces; the UX lane read it as a rendering defect (its Watch on head c51c399, span 95fca68df04c) and named the fade as the smallest fix. It is keyed on the scroll position, so a prompt that fits and a reader at the end never see it. Named in What changed (PinnedPrompt.tsx, index.css), covered by PinnedPrompt.ceiling.test.tsx, and shown in the attached stills and recording.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 1, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at c4a72c2f7fbc51e6905a04478b21c2432e7aa1da — approve

I checked the fix against the source, and the tests fail when the fix is taken out.

Verified in source

  • Ceiling: usePinnedPrompt.ts computes floor = scroller.getBoundingClientRect().bottom − computed padding-bottom. computePinnedCardMaxH (utils/pinnedPrompt.ts) returns max(0, floor − foldY − ROW_PAD_Y). That matches the card's top, which sits ROW_PAD_Y below the fold. The fold's liveH is clamped with Math.min(maxH, …), and PinnedPrompt.tsx sets maxHeight plus overflow-hidden on the bubble.
  • Re-derive: the ResizeObserver now watches the scroller as well as the card. The effect is keyed on pinned?.idx, which fixes hand-offs between prompts that have no ts. nextPinnedPromptState carries maxH on the same-message path and includes it in the identity short-circuit.
  • Morph: alignItems: flex-start is set during the morph. It is cleared on transitionend, on an interrupted morph and on fold takeover, so it never outlives either writer.
  • Hosts: on ChatPage, the scroller pads by dockH + DOCK_CLEARANCE_PX, so the floor sits 16px above the dock. On ChatPane (the first-principles lane's Watch), the scroller pads 12px and the <Composer> is in normal flow below the scroller. The floor is therefore above the composer there too. Disposition: checked, and it doesn't block.
  • The commit message and description match the code. I found no false statement that would land in main.
  • tsc -p tsconfig.app.json and eslint on the touched files are clean. The 4 pinned-prompt test files pass: 110/110. CI is green at head; each cancelled run is a superseded duplicate of a check that succeeded.

Mutation checks (each one reverted afterwards)

Fix removed Tests that failed
the Math.min(maxH, …) fold clamp clamps the fold to the ceiling…, takes the host's bottom padding off the floor…, moves the ceiling with the scroller on the same message…
the pinned?.idx effect dependency re-attaches the observers across a hand-off between prompts that carry no \ts``
observer.observe(scrollerRef.current) re-attaches the observers… and re-derives the flag when the card itself resizes…
paddingBottom → 0 takes the host's bottom padding off the floor — the dock the main chat pads for
the bubble's maxHeight style sets the ceiling as the box's max-height, caps the fold too…

Bot findings: GPT, Opus, Design and First-Principles report nothing that blocks. The earlier GPT/UX findings (the observer keying, the scroll cue, the two scroll regions) are fixed at this head, and I confirmed each fix in source. The UX Watch asks for one continuous motion; in source, flex-start during the morph keeps the body at its natural height. I did not play the recording.

Overlap with sibling PRs

  • #15820: merges cleanly (git merge-tree) and works with this change. When the status stack is occupied, #15820 gives the scroller marginBottom: dockH and paddingBottom: 16. That moves the scroller's bottom edge, the floor follows it, and the new scroller observer picks up the resize. Follow-up for whichever PR lands second: the page-layout.md paragraph added here says "the main chat pads by the dock's height plus a clearance", which only covers #15820's composer-only state.
  • #15526: merges cleanly. maxH={pinned.maxH} survives in the merged ChatPage.tsx.

Follow-ups (non-blocking)

  • When maxH evaluates to 0 (fold at or below the floor), the bubble collapses to a sliver showing only its ring and shadow, instead of being hidden. It is an edge case and not reachable in normal layouts.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. The ceiling is the scroller bottom minus padding-bottom, landed as maxHeight on the clipping box, and the fold is clamped with min(maxH, ...); the resize observer is keyed on idx/ts/scrollerRef and disconnected on cleanup; the flex-start swap is cleared on transitionend and fold interruption; the 40vh paragraph cap still wins when smaller. CSS and layout only.

Non-blocking: computePinnedCardMaxH floors at 0 but not at the resting height, so on a pane where maxH is below the natural collapsed height the collapsed-height observer reports the clamped box (feeding pinCollapsedHRef and the hand-off line), min-h-0 lets a one-line prompt read as clamped and show a false chevron, and at maxH=0 the card vanishes and bannerH=0 turns the push off. max(maxH, restingH) or skipping the report while maxH binds would close it; no test covers that case. The second pinnedPrompt.test.ts case recomputes min itself.

@iamwhatever
iamwhatever merged commit 5534a7a into main Oct 1, 2026
142 of 152 checks passed
@iamwhatever
iamwhatever deleted the fix/pinned-prompt-expand-overlap branch October 1, 2026 15:46
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 1, 2026
CrysisDeu added a commit that referenced this pull request Oct 3, 2026
…chain)

Reverts, newest first:
- 5534a7a fix(chat): keep the pinned prompt card above the composer dock (#15828)
- 1a3732a fix(chat): keep message actions visible under a pinned long prompt (#13630)
- c250d3e fix(chat): hand the pinned prompt over at the pin line, not past it (#11462)

the moment its top crosses the fold line, the card stands in for it, and
the card shrinks line by line as the reader scrolls. #13630 re-based the
fold on the bubble and re-showed the action strip beneath the card; #15828
capped the card at the transcript floor so it stops at the composer dock.

For a prompt taller than the viewport the three together make the prompt
unreadable: the row is hidden as soon as its top passes the fold, the card
shows only the first `maxH` pixels, and scrolling down only makes the card
shorter -- the lines below the cap can never be reached (before #15828
they sat under the composer instead). The maintainer's call is that the
whole fold / stand-in / hand-off geometry is over-engineering: the banner
exists to keep one line of the latest prompt at the top as a click target
to jump back, not to be a seamless continuation of the bubble. Roll back to
the pre-#11462 behaviour -- the row stays visible and scrolls normally, the
card appears once the row's bottom edge has passed the band.

Conflict resolution, no behaviour beyond the revert:
- `components/markdown/sanitize.ts`: the `data-message-*` attribute
  reservation #13630 added to MarkdownRenderer had moved here in #14580;
  removed here instead.
- `pages/chat/PinnedPrompt.tsx`: #13318's `max-w-full` (Content Width
  setting) is kept; #12891's line-height fix lived inside the wheel
  forwarder #11462 added and goes with it.
- `.github/coverage-baselines/frontend.txt`: current baseline kept.
- `test/MarkdownRenderer.surface.test.tsx`, `test/MarkdownRenderer.domGolden.test.tsx`:
  two later tests encoded the `data-message-*` reservation as a dropped
  attribute; the reserved inputs are removed so the snapshots stay as is.

Refs #16340
CrysisDeu added a commit that referenced this pull request Oct 3, 2026
…chain)

Reverts, newest first:
- 5534a7a fix(chat): keep the pinned prompt card above the composer dock (#15828)
- 1a3732a fix(chat): keep message actions visible under a pinned long prompt (#13630)
- c250d3e fix(chat): hand the pinned prompt over at the pin line, not past it (#11462)

the moment its top crosses the fold line, the card stands in for it, and
the card shrinks line by line as the reader scrolls. #13630 re-based the
fold on the bubble and re-showed the action strip beneath the card; #15828
capped the card at the transcript floor so it stops at the composer dock.

For a prompt taller than the viewport the three together make the prompt
unreadable: the row is hidden as soon as its top passes the fold, the card
shows only the first `maxH` pixels, and scrolling down only makes the card
shorter -- the lines below the cap can never be reached (before #15828
they sat under the composer instead). The maintainer's call is that the
whole fold / stand-in / hand-off geometry is over-engineering: the banner
exists to keep one line of the latest prompt at the top as a click target
to jump back, not to be a seamless continuation of the bubble. Roll back to
the pre-#11462 behaviour -- the row stays visible and scrolls normally, the
card appears once the row's bottom edge has passed the band.

Conflict resolution, no behaviour beyond the revert:
- `components/markdown/sanitize.ts`: the `data-message-*` attribute
  reservation #13630 added to MarkdownRenderer had moved here in #14580;
  removed here instead.
- `pages/chat/PinnedPrompt.tsx`: #13318's `max-w-full` (Content Width
  setting) is kept; #12891's line-height fix lived inside the wheel
  forwarder #11462 added and goes with it.
- `.github/coverage-baselines/frontend.txt`: current baseline kept.
- `test/MarkdownRenderer.surface.test.tsx`, `test/MarkdownRenderer.domGolden.test.tsx`:
  two later tests encoded the `data-message-*` reservation as a dropped
  attribute; the reserved inputs are removed so the snapshots stay as is.

Refs #16340
CrysisDeu added a commit that referenced this pull request Oct 3, 2026
…chain)

Reverts, newest first:
- 5534a7a fix(chat): keep the pinned prompt card above the composer dock (#15828)
- 1a3732a fix(chat): keep message actions visible under a pinned long prompt (#13630)
- c250d3e fix(chat): hand the pinned prompt over at the pin line, not past it (#11462)
- 65e23bb fix(chat): keep a long prompt readable instead of pinning it (#16321),
  merged while this revert was in review: its guard is written against the
  fold geometry (`bubbleBottom`, `foldY`, `restingH`) and is subsumed by the
  bottom-edge hand-off this revert restores.

the moment its top crosses the fold line, the card stands in for it, and
the card shrinks line by line as the reader scrolls. #13630 re-based the
fold on the bubble and re-showed the action strip beneath the card; #15828
capped the card at the transcript floor so it stops at the composer dock.

For a prompt taller than the viewport the three together make the prompt
unreadable: the row is hidden as soon as its top passes the fold, the card
shows only the first `maxH` pixels, and scrolling down only makes the card
shorter -- the lines below the cap can never be reached (before #15828
they sat under the composer instead). The maintainer's call is that the
whole fold / stand-in / hand-off geometry is over-engineering: the banner
exists to keep one line of the latest prompt at the top as a click target
to jump back, not to be a seamless continuation of the bubble. Roll back to
the pre-#11462 behaviour -- the row stays visible and scrolls normally, the
card appears once the row's bottom edge has passed the band.

Conflict resolution, no behaviour beyond the revert:
- `components/markdown/sanitize.ts`: the `data-message-*` attribute
  reservation #13630 added to MarkdownRenderer had moved here in #14580;
  removed here instead.
- `pages/chat/PinnedPrompt.tsx`: #13318's `max-w-full` (Content Width
  setting) is kept; #12891's line-height fix lived inside the wheel
  forwarder #11462 added and goes with it.
- `.github/coverage-baselines/frontend.txt`: current baseline kept.
- `test/MarkdownRenderer.surface.test.tsx`, `test/MarkdownRenderer.domGolden.test.tsx`:
  two later tests encoded the `data-message-*` reservation as a dropped
  attribute; the reserved inputs are removed so the snapshots stay as is.

Refs #16340
CrysisDeu added a commit that referenced this pull request Oct 3, 2026
…chain)

Reverts, newest first:
- 5534a7a fix(chat): keep the pinned prompt card above the composer dock (#15828)
- 1a3732a fix(chat): keep message actions visible under a pinned long prompt (#13630)
- c250d3e fix(chat): hand the pinned prompt over at the pin line, not past it (#11462)
- 65e23bb fix(chat): keep a long prompt readable instead of pinning it (#16321),
  merged while this revert was in review: its guard is written against the
  fold geometry (`bubbleBottom`, `foldY`, `restingH`) and is subsumed by the
  bottom-edge hand-off this revert restores.

the moment its top crosses the fold line, the card stands in for it, and
the card shrinks line by line as the reader scrolls. #13630 re-based the
fold on the bubble and re-showed the action strip beneath the card; #15828
capped the card at the transcript floor so it stops at the composer dock.

For a prompt taller than the viewport the three together make the prompt
unreadable: the row is hidden as soon as its top passes the fold, the card
shows only the first `maxH` pixels, and scrolling down only makes the card
shorter -- the lines below the cap can never be reached (before #15828
they sat under the composer instead). The maintainer's call is that the
whole fold / stand-in / hand-off geometry is over-engineering: the banner
exists to keep one line of the latest prompt at the top as a click target
to jump back, not to be a seamless continuation of the bubble. Roll back to
the pre-#11462 behaviour -- the row stays visible and scrolls normally, the
card appears once the row's bottom edge has passed the band.

Conflict resolution, no behaviour beyond the revert:
- `components/markdown/sanitize.ts`: the `data-message-*` attribute
  reservation #13630 added to MarkdownRenderer had moved here in #14580;
  removed here instead.
- `pages/chat/PinnedPrompt.tsx`: #13318's `max-w-full` (Content Width
  setting) is kept; #12891's line-height fix lived inside the wheel
  forwarder #11462 added and goes with it.
- `.github/coverage-baselines/frontend.txt`: current baseline kept.
- `test/MarkdownRenderer.surface.test.tsx`, `test/MarkdownRenderer.domGolden.test.tsx`:
  two later tests encoded the `data-message-*` reservation as a dropped
  attribute; the reserved inputs are removed so the snapshots stay as is.
- `test/PinnedPrompt.images.test.tsx` (new): the fold's tests carried this
  file's coverage; without them it reads 78.4%. The thumbnail / failed-image
  fallback and the jump click were untested pre-#11462 and are covered here.

Refs #16340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants