Repository navigation
feat(notifications): step through the feed with the Up and Down keys - #16243
Conversation
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the four committed screenshots under [DESIGN-REVIEWED] c21c098 Description read[DESCRIPTION-READ] 359caadfc45f881d22f16f245af7ddf2e7bed14cdd51ac1980a06b35bed63fc3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has tried the Up/Down stepping. The four stills show it working on both surfaces, but this fork lane has no blind read, which caps the verdict at CONCERNS. Watch
[UX-REVIEWED] c21c098 Description read[DESCRIPTION-READ] ee7c158bed3907f5fb4da489ac3874ba0fbf9e8ebf196a96827f9ecdc6fe53c4 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Each Down press calls What this change shipsInventory (4 items) — 4 justifiedIntent: let a user read through notifications one after another with Up/Down instead of clicking or tabbing through every row. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] c21c098 Description read[DESCRIPTION-READ] 6073b9286c4a08ae79f7801a8863498a6a854736a51fad15691852a01a37c0fa That sha256 names the PR description this verdict read. Recompute it with |
|
|
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
5f50df8 to
ba18bef
Compare
|
Fixed in ba18bef.
|
|
|
Read-only review: the guard covers inner controls, modifiers and both list ends, and the tests are solid. Holding for a maintainer to accept select-on-step: stepping acks each note it lands on, unlike the sidebar's focus-only navigation. Also worth a look: in the bell sheet, clicking a collapsed stack's head expands it but Down opens it, and the disposition misdescribes the guard. |
|
@iamwhatever Corrected the Opus disposition above: the guard compares the event target with the row's own |
Up and Down on a row's open control now select the row above or below it and move focus with the selection, so holding the key reads down the feed while the detail panel follows. The feed is shared, so this covers both the inbox page's Activity feed and the bell's notification sheet. Rows are stepped in the order rendered: a collapsed stack is one stop. Keys from a control inside a row (Approve, Dismiss, a code block), modified arrows and the two ends of the list are left to the browser.
ba18bef to
c21c098
Compare
Problem / Motivation
Goal: Let a user read through their notifications with the Up and Down keys.
In the inbox page's Activity feed and in the bell's notification sheet, moving from one notification to the next takes a click on each row, or Tab through every control of every row. Up and Down do not move between notifications.
Why it matters
Reading a batch of notifications (a night's cron results, a run's subagent reports) is a one-after-another task. By mouse it means aiming at each row in turn. By keyboard it costs at least two Tab stops per row.
Not a goal
What changed (motivation → approach → change)
Both surfaces render the same feed component,
notifications/NotificationFeed.tsx, so oneonKeyDownon its list covers the inbox page and the bell sheet. It opens the neighbouring row through the sameonSelecta click calls, so both hosts mark it read as they do for a click. Focus moves with the selection, so the next press steps on from the new row and the browser scrolls it into view.The step follows the rows as drawn: a collapsed stack is one stop, its newest note. The list
divis not itself a control, so itsjsx-a11y/no-static-element-interactionswarning is suppressed on that one line with the reason, as the lint step inci.ymlasks.Backwards compatibility
Compatible: the feed had no Up or Down handler, and every other key, click and prop behaves as before.
Removes nothing: the diff adds one key handler, its test and the evidence frames.
Tests
website/src/test/NotificationFeed.arrowKeys.test.tsx:Seven mutations of the handler each turn at least one of these red: dropping the modifier guard, the inner-control guard, the
preventDefaultor the focus move, stepping through every note instead of the rows as drawn, wrapping at the ends, and stepping from the selection instead of the focused row.Manual verification
Scripted Playwright in Chromium, against a Vite dev server that mounts the real
NotificationsPageand the real bell sheet over seeded notifications. On both surfaces, a click on a row and then Down moved the selection, the detail view and focus to the next row. In a window short enough for the list to scroll, stepping to the last row brought it into view, and stepping back up returned the list to the top. No console errors.Screenshots / video
Inbox page, Activity feed: after a click on "Nightly digest ready", then after Down. The next row is open and holds focus.
Bell sheet: after a click on "Task run completed", then after Down.
Related Issues
no linked issue: no open issue asks for this; it comes from reading the inbox day to day.
Checklist