Skip to content

feat(notifications): list Up/Down in help; a step acts like a click - #16779

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
unstablebrainiac:feat/notification-keys-followups
Oct 4, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
unstablebrainiac:feat/notification-keys-followups

Conversation

@unstablebrainiac

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the notification feed's Up/Down keys findable in the shortcuts help, and make a step onto a row do what a click on that row does.

#16243 added Up/Down to the notification feed. Two gaps were left for a follow-up. The shortcuts help and Settings → Shortcuts do not list the keys. And in the bell sheet, a click on a collapsed stack of grouped notes expands it, while Down onto the same stack opens its newest note.

Why it matters

A key nobody can find goes unused, and the shortcuts help is where a user goes to find one. A row that does one thing on a click and another on Down makes the keyboard path hard to predict, right where repeated alerts pile up into a stack.

Not a goal

  • No change to what a click does on either surface. The bell sheet still expands a collapsed stack on a click; the inbox page still opens its newest note, with its "N more" pill to expand it.
  • No new key, and no change to when the keys act: only from a row's own open control.
  • The new rows are reference rows. Like "Edit last message" and "Stop speaking", they cannot be rebound.

What changed (motivation → approach → change)

The feed's existing Up/Down keys now appear in the shortcuts help. In the bell sheet, a step onto a collapsed stack now expands it, the way a click does.

Where Before After
Shortcuts help and Settings → Shortcuts, under Actions no row for the feed's keys "Previous notification ↑" and "Next notification ↓"
Bell sheet: Down onto a collapsed stack opens the stack's newest note expands the stack; the next Down opens the first note under its head
Inbox page: Down onto a collapsed stack opens its newest note unchanged

A step in notifications/NotificationFeed.tsx now presses the next row's open control instead of selecting its note. That control already does each surface's click, so a step and a click cannot drift apart. It is also why the two surfaces still differ: their clicks differ.

The two rows are code entries in lib/shortcutRegistry.ts, listed for the reference while the feed handles the keys itself. hooks/useKeyboardShortcuts.ts maps them to two new label keys, added to en.manual.json and to all 11 translations, and en-XA.json is regenerated.

Backwards compatibility

Compatible: no prop, API or stored value changes. One shipped behaviour changes on purpose: in the bell sheet, Down onto a collapsed stack expands it instead of opening its newest note.

Removes nothing: the diff adds two reference rows and their labels, and changes how a step activates the next row.

Tests

website/src/test/NotificationFeed.arrowKeys.test.tsx:

  • Bell sheet: Down onto a collapsed stack expands it and opens nothing; the next Down opens the first note under the head.
  • Inbox page: Down onto a collapsed stack opens its newest note, as a click there does.
  • The shortcuts reference lists "Previous notification ↑" and "Next notification ↓" under Actions.

website/src/test/shortcutRegistry.test.ts: the chord check pins its bare-key entries exactly. Bare Escape and the two feed arrows must each be code-dispatched with exactly that key, and every other entry still needs a modifier.

Each of these goes red when its part is reverted or broken: selecting the note instead of pressing its control, dropping the registry entries with or without their labels, unpinning a bare-key entry, giving a new entry a modifier or a registry dispatch, and emptying the Escape default.

Manual verification

Scripted Playwright in Chromium, against a Vite dev server that mounts the real bell sheet over seeded notifications (three of them grouped into one stack) and the real shortcuts help. In the bell sheet, a click on the newest card and then Down expanded the stack, with focus on its head and the open note unchanged. A second Down opened the first note under the head. In the help, a search for "notification" showed both new rows under Actions. No console errors.

Screenshots / video

Bell sheet: after a click on "Task run completed", the stack under it is collapsed (count 3). After Down, the stack is expanded and its head has focus; the open note is unchanged.

Bell sheet after a click on Task run completed: the CI stack below is collapsed

Bell sheet after Down: the CI stack is expanded and its head has focus

Shortcuts help, searched for "notification":

Shortcuts help listing Previous notification and Next notification under Actions

Related Issues

Closes #16777

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable): not applicable, no doc lists the feed's keys or its stack behaviour
  • No secrets, credentials, or internal references in the diff

The shortcuts help and Settings > Shortcuts now list Previous notification
(Up) and Next notification (Down) under Actions, as reference-only entries
like Edit last message and Stop speaking.

A step now presses the neighbouring row's open control instead of
selecting its note, so it does what a click on that row does. In the bell
sheet that means a collapsed stack expands, and the next Down moves into
the notes under it. The inbox page is unchanged.

Closes kirodotdev#16777
@unstablebrainiac
unstablebrainiac requested a review from a team October 4, 2026 14:33
@unstablebrainiac
unstablebrainiac requested a review from a team as a code owner October 4, 2026 14:33
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Oct 4, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — 🟡 CONCERNS

Premise-level review of fd22e2bfa1f0f7c4b5ac93f4c73b5640218204c6 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

Item 2 is justified only by click/step symmetry. The description never names a harm that Down opening a stack's newest note causes on its own.

Not justified as shipped

  • Item 2 — inherited: "a step onto a row do what a click on that row does" is the symmetry form. The stated harm, "makes the keyboard path hard to predict", only exists in comparison with the click. With the stack collapsed, its hidden notes can still be reached through the inner "N more" control (NotificationFeed.tsx:500), so the old behaviour did not lock anyone out.
    Clears when: Notification feed keys: list Up/Down in shortcuts help, and expand a collapsed stack like a click #16777 or the description names a user who Down-stepped onto a stack and lost or misread notes because it opened the newest one.

What this change ships

Inventory (4 items) — 3 justified

Intent: let keyboard users find the feed's Up/Down keys in the shortcuts help, and make a step onto a row behave like a click on it. ADDITION (the help rows) plus a behaviour FIX.

  1. Shortcuts help and Settings → Shortcuts list "Previous notification ↑" and "Next notification ↓" under Actions — justified
  2. Bell sheet: Down onto a collapsed stack now expands it instead of opening its newest note — inherited (symmetry with click)
  3. The registry test's bare-key exception grows from Escape alone to an exact list of three pinned chords — justified
  4. Three screenshots committed under temp-screenshots/ — justified

[FIRST-PRINCIPLES-REVIEWED] fd22e2b

Description read

[DESCRIPTION-READ] e58ab5d89881c4d4b3c6a057a8edf97b0f489c34967d0c5129e38b9f4e7f1f34

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of fd22e2bfa1f0f7c4b5ac93f4c73b5640218204c6 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the new ArrowUp/ArrowDown reference rows do not trip any Settings → Shortcuts conflict check against the code-dispatched entries.

[DESIGN-REVIEWED] fd22e2b

Description read

[DESCRIPTION-READ] 44e426ebd6dc038647f6da1496b3797a6e50217a927c56a06f53d2c175ce464c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of fd22e2bfa1f0f7c4b5ac93f4c73b5640218204c6 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

"Previous notification ↑" reads like a global key, but it only works while a notification row has focus. A user who presses ↓ anywhere else gets nothing.

Watch

  • The new help rows don't say where the keys work. The registry adds 'notification-prev' with bare ArrowUp under Actions, and its label is just "Previous notification" (attachment-01). Nearby rows like "Notifications panel" (Alt+N) work from anywhere, so a reader assumes ↑/↓ does too. They press it in chat or on the dashboard, and either nothing happens or the page scrolls. The key then looks broken. Severity: low frequency × moderate friction × persistent (the row is always shown that way). Smallest fix: put the scope in the label, e.g. "Previous notification (in the feed)".
  • The new row sits right next to "Edit last message" (⌘↑). Both are in Actions, and the two keycaps differ only by the modifier. A user scanning the list could mix them up. Severity: low. This is covered by the scoping fix above.
  • The two surfaces still behave differently on purpose. In the bell sheet, Down onto a collapsed stack expands it (attachment-02 → attachment-03, focus ring on the stack head, "Show less" appears). On the inbox page, Down opens the newest note. Someone who uses both surfaces learns two different results from the same key. The PR states this as out of scope, so this is a note, not a request.

No blind reader has seen these screenshots; that is a limit of this review lane, not a gap in the PR.

[UX-REVIEWED] fd22e2b

Description read

[DESCRIPTION-READ] 7a761f71853409950e0703c3a6901daf86993460c15fd717898b974a31bf02a9

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed fd22e2bfa1f0f7c4b5ac93f4c73b5640218204c6 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] fd22e2b

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed fd22e2bfa1f0f7c4b5ac93f4c73b5640218204c6 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] fd22e2b

@unstablebrainiac

Copy link
Copy Markdown
Contributor Author
  • Item 2: a step onto a collapsed stack expands it (rebutted)

The old step had a harm of its own, not only a mismatch with the click. In the bell sheet, Down onto a collapsed stack opened its newest note, and the next Down jumped past the whole stack. A user reading the sheet with Down never reached the stack's other notes unless they noticed the count badge and pressed Enter.
With this change Down unfolds the stack and the next Down opens the first note under its head, so one pass of Down reaches every note in it. The head opens on Enter, as it does on a second click.
The inbox page never skipped notes this way: its stack row opens the newest note, its "N more" pill unfolds the rest, and its step is unchanged.

@unstablebrainiac

Copy link
Copy Markdown
Contributor Author
  • The new help rows don't say where the keys work (rebutted)

The Actions group already lists keys that act in one place only without naming it: "Edit last message" (⌘↑) and "Optimize prompt" act only in the composer. The new rows follow that convention, and "notification" in each label names what they move through.
A scope suffix on just these two rows would make them the only rows in the group that carry one, and it changes two strings in all 12 catalogs. A scope note for every contextual row is a change to the whole reference, outside this PR.

@unstablebrainiac

Copy link
Copy Markdown
Contributor Author
  • The new row sits right next to "Edit last message" (⌘↑) (rebutted)

The rows are not adjacent: "Open agent monitor (subagents)" and "Stop speaking" sit between "Edit last message" and "Previous notification" in the Actions group. The chords also differ on sight (⌘ + ↑ against a lone ↑), and the labels name different things, a message and a notification.

@unstablebrainiac

Copy link
Copy Markdown
Contributor Author
  • The two surfaces still behave differently on purpose (rebutted)

Deliberate, and confirmed on #16777: a step does what a click on the row it lands on does, and the two surfaces' clicks already differ on a collapsed stack. The bell sheet unfolds it on a click; the inbox page opens its newest note and unfolds it from the "N more" pill. A step that agreed across surfaces would disagree with the click on one of them.

@unstablebrainiac

Copy link
Copy Markdown
Contributor Author

Design Review asked whether the new ↑/↓ rows can trip a Settings → Shortcuts conflict check. They cannot. Neither Settings recorder (the panel toggles and Search Everywhere) reads the shortcut registry; each keeps its own bindings. The only chord-collision checks, matchShortcutEvent and the registry test, consider registry-dispatched entries only, and the two new rows are code entries.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 4, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: follow-up to merged #16243. Up/Down on a row's open control now clicks the neighbouring row's open control and moves focus to it, so a step does exactly what a click on that row does (in the bell sheet a collapsed stack expands instead of opening its newest note, the mismatch flagged on #16243). The shortcut registry and help list the two keys, all 13 locales plus en-XA carry the new labels, and the stacked-feed test pins the expand-on-step behaviour. CI green.

@iamwhatever
iamwhatever enabled auto-merge (squash) October 4, 2026 22:36
@iamwhatever
iamwhatever merged commit fd705fb into kirodotdev:main Oct 4, 2026
100 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification feed keys: list Up/Down in shortcuts help, and expand a collapsed stack like a click

2 participants