Repository navigation
feat(notifications): list Up/Down in help; a step acts like a click - #16779
iamwhatever merged 1 commit into
Conversation
The shortcuts help and Settings > Shortcuts now list Previous notification (Up) and Next notification (Down) under Actions, as reference-only entries like Edit last message and Stop speaking. A step now presses the neighbouring row's open control instead of selecting its note, so it does what a click on that row does. In the bell sheet that means a collapsed stack expands, and the next Down moves into the notes under it. The inbox page is unchanged. Closes kirodotdev#16777
First Principles Review (Opus 5.5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Item 2 is justified only by click/step symmetry. The description never names a harm that Down opening a stack's newest note causes on its own. Not justified as shipped
What this change shipsInventory (4 items) — 3 justifiedIntent: let keyboard users find the feed's Up/Down keys in the shortcuts help, and make a step onto a row behave like a click on it. ADDITION (the help rows) plus a behaviour FIX.
[FIRST-PRINCIPLES-REVIEWED] fd22e2b Description read[DESCRIPTION-READ] e58ab5d89881c4d4b3c6a057a8edf97b0f489c34967d0c5129e38b9f4e7f1f34 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the new [DESIGN-REVIEWED] fd22e2b Description read[DESCRIPTION-READ] 44e426ebd6dc038647f6da1496b3797a6e50217a927c56a06f53d2c175ce464c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS "Previous notification ↑" reads like a global key, but it only works while a notification row has focus. A user who presses ↓ anywhere else gets nothing. Watch
No blind reader has seen these screenshots; that is a limit of this review lane, not a gap in the PR. [UX-REVIEWED] fd22e2b Description read[DESCRIPTION-READ] 7a761f71853409950e0703c3a6901daf86993460c15fd717898b974a31bf02a9 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
|
|
|
|
Design Review asked whether the new ↑/↓ rows can trip a Settings → Shortcuts conflict check. They cannot. Neither Settings recorder (the panel toggles and Search Everywhere) reads the shortcut registry; each keeps its own bindings. The only chord-collision checks, |
iamwhatever
left a comment
There was a problem hiding this comment.
Reviewed: follow-up to merged #16243. Up/Down on a row's open control now clicks the neighbouring row's open control and moves focus to it, so a step does exactly what a click on that row does (in the bell sheet a collapsed stack expands instead of opening its newest note, the mismatch flagged on #16243). The shortcut registry and help list the two keys, all 13 locales plus en-XA carry the new labels, and the stacked-feed test pins the expand-on-step behaviour. CI green.
Problem / Motivation
Goal: Make the notification feed's Up/Down keys findable in the shortcuts help, and make a step onto a row do what a click on that row does.
#16243 added Up/Down to the notification feed. Two gaps were left for a follow-up. The shortcuts help and Settings → Shortcuts do not list the keys. And in the bell sheet, a click on a collapsed stack of grouped notes expands it, while Down onto the same stack opens its newest note.
Why it matters
A key nobody can find goes unused, and the shortcuts help is where a user goes to find one. A row that does one thing on a click and another on Down makes the keyboard path hard to predict, right where repeated alerts pile up into a stack.
Not a goal
What changed (motivation → approach → change)
The feed's existing Up/Down keys now appear in the shortcuts help. In the bell sheet, a step onto a collapsed stack now expands it, the way a click does.
A step in
notifications/NotificationFeed.tsxnow presses the next row's open control instead of selecting its note. That control already does each surface's click, so a step and a click cannot drift apart. It is also why the two surfaces still differ: their clicks differ.The two rows are
codeentries inlib/shortcutRegistry.ts, listed for the reference while the feed handles the keys itself.hooks/useKeyboardShortcuts.tsmaps them to two new label keys, added toen.manual.jsonand to all 11 translations, anden-XA.jsonis regenerated.Backwards compatibility
Compatible: no prop, API or stored value changes. One shipped behaviour changes on purpose: in the bell sheet, Down onto a collapsed stack expands it instead of opening its newest note.
Removes nothing: the diff adds two reference rows and their labels, and changes how a step activates the next row.
Tests
website/src/test/NotificationFeed.arrowKeys.test.tsx:website/src/test/shortcutRegistry.test.ts: the chord check pins its bare-key entries exactly. Bare Escape and the two feed arrows must each be code-dispatched with exactly that key, and every other entry still needs a modifier.Each of these goes red when its part is reverted or broken: selecting the note instead of pressing its control, dropping the registry entries with or without their labels, unpinning a bare-key entry, giving a new entry a modifier or a registry dispatch, and emptying the Escape default.
Manual verification
Scripted Playwright in Chromium, against a Vite dev server that mounts the real bell sheet over seeded notifications (three of them grouped into one stack) and the real shortcuts help. In the bell sheet, a click on the newest card and then Down expanded the stack, with focus on its head and the open note unchanged. A second Down opened the first note under the head. In the help, a search for "notification" showed both new rows under Actions. No console errors.
Screenshots / video
Bell sheet: after a click on "Task run completed", the stack under it is collapsed (count 3). After Down, the stack is expanded and its head has focus; the open note is unchanged.
Shortcuts help, searched for "notification":
Related Issues
Closes #16777
Checklist