Repository navigation
fix(members): Steer / Queue / Jev auto in the crewmate chat - #16684
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a message queued in a member DM is actually sent once the crewmate's turn ends. The screenshots show the queued row but never show it being delivered. [DESIGN-REVIEWED] adc9a39 Description read[DESCRIPTION-READ] 66706a0ab2465e3c93ec8bbf8fb4166878bfd8b5110b4050db296b12bb6f738a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS After this PR nothing passes Inventory (7 items) — 6 justifiedIntent: when a crewmate is busy, the Crew page chat lets you choose Steer, Queue or Jev auto, as the main chat does. This is a FIX (#16689), and the description openly reverses the earlier "a DM has no queue concept" pin.
[FIRST-PRINCIPLES-REVIEWED] adc9a39 Description read[DESCRIPTION-READ] 5f1d64d3da2faa5af842edd7866b302c4880f302a05002ffaf5425f9f310611a That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ human override accepted@iamwhatever overrode this lane for |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsAdvisory only. Nothing blocks the merge. FINDING — website/src/pages/members/MembersPage.tsx:4045 — removing [OPUS-REVIEWED] adc9a39 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
03f0fb1 to
7906221
Compare
|
|
|
|
|
|
7906221 to
e2431ae
Compare
|
|
|
|
|
|
/ai-review override ux dc04b4a: agent: The flagged labels (busy Send icon, "Auto (Jev)", queue strip bolt) are the shared BusySendControls/QueueStack UI the main chat already ships unchanged. This PR only stops the Crew page hiding it, as #16689 asks; relabelling shared UI is outside its goal. Rebuttals posted per span. |
Human judgment recorded@iamwhatever marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
…d choice The Members (Crew) page pinned its ChatPane to busyMode steer-only, so a send while the crewmate was working always interrupted the running turn: one plain send button, no Queue, no Jev auto. Drop the pin so the DM uses the same split busy-send control as the main chat.
dc04b4a to
adc9a39
Compare
|
/ai-review override ux adc9a39: agent: The flagged labels (busy Send icon, "Auto (Jev)", queue strip bolt) are the shared BusySendControls/QueueStack UI the main chat already ships unchanged. This PR only stops the Crew page hiding it, as #16689 asks; relabelling shared UI is outside its goal. Rebuttals posted per span. |
Human judgment recorded@iamwhatever marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
buluoray
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Reviewed at adc9a39.
The Members page no longer passes busyMode="steer-only" to its DM ChatPane, so the crewmate chat falls back to the default 'split'. That default is the main chat's Steer / Queue split, with Auto (Jev) offered under the main chat's own gate. The messaging spec and the tests are updated to match. The behaviour change is correct, and the queue path already worked for member slots: ChatPane.tsx:1788 already rendered server-parked queue cards there. The doc comments that still describe the old Members-page behaviour are listed below as follow-ups.
What I verified
website/src/pages/members/MembersPage.tsx:4041-4045: thebusyModeprop is removed, andChatPane.tsx:128defaults it to'split'.- Auto (Jev) is gated exactly as in the main chat.
ChatPane.tsx:2002passesjevAutoAvailable={jevAutoConsented && running}, andbusySend.tsx:61falls anautomode back tosteerwhen that is false. Main chat uses the same gate (ChatPage.tsx:6235). This is fail-closed: with no consent, or no running turn, no Auto option appears. hideSteerBadge(ChatPane.tsx:1500) is now false on the Members page, so steer badges show there. The PR body states this as intended.membersFloorSeed.ts:35: I confirmed the PR's claim that thebusyModekey had no reader. The onlybusyModeconsumers on base are ChatInput, ChatPane, and busySend; nothing incomponents/crew/reads the key. Removing it does not change behaviour. Re-adding it leaveseditModel.test.tsgreen, which is expected for a key nothing reads.docs/system-specs/modules/messaging.md:1816no longer says the member DM is steer-only.- Tests I ran:
MembersPage.test.tsx,editModel.test.ts, andChatPane.steerOnly.test.tsxall passed (218 tests). - Mutation: re-adding
busyMode="steer-only"in MembersPage failsopens the pinned DM thread on click…, which checksdata-busy-mode="split". - Title check: "Steer / Queue / Jev auto in the crewmate chat" matches the diff. The pane gains the split button (Steer/Queue) and the Auto (Jev) option. Auto appears only when Jev auto is consented and a turn is running, not always, and the body says so.
- The overridden ux AI-review findings are about icons and labels in the shared
BusySendControls/QueueStack, which this PR does not touch. I agree with the override. - CI at the head SHA: 90 success, 8 skipped, 0 failure. No reviews have been posted yet.
Non-blocking follow-ups
-
Several doc comments and docs still say the member DM is steer-only:
website/src/components/ChatPane.tsx:191-195: "A host that presents a conversation with ONE named peer (the Members page's DM thread) passes'steer-only'".website/src/components/chat-input/props.ts:57-63: "A conversation with ONE named peer (a member DM thread) uses it".docs/system-specs/modules/crew-mode.md:1524: "the steer-only user row".
These should say that no shipped host passes
steer-onlytoday, asmessaging.mdnow does. -
website/scripts/capture-members-steer-only.mjs:75now asserts the OLD Members-page state. Its "AFTER" check expectssteerOnly === 1 && split === 0, so a re-run against this head will fail.website/capture/members-page.tsx:87still "Documents the steer-only composer". These are manual capture tools, not CI. -
PR body wording: the table says the queue list went from "hidden" to "shown". On main, server-parked queue cards were already shown on the Members page (
ChatPane.tsx:1788-1793). What changed is that the user can now ask for a queue. -
Title wording: there is no verb. Something like "fix(members): offer Steer / Queue / Jev auto in the crewmate chat" would read better.
bolichen97
left a comment
There was a problem hiding this comment.
Approving: the Crew page chat now gets the same Steer / Queue / Jev auto split as the main chat. The default busy mode is still steer, so a plain Enter while the crewmate works does what it did before; the change only adds choices.
Non-blocking: the busyMode docstring at website/src/components/ChatPane.tsx:192 still says the Members page passes 'steer-only'. Please update it in a follow-up.
AI-assisted review, posted at maintainer request.
Problem / Motivation
Goal: When a crewmate is busy, the Crew page chat lets you pick Steer, Queue or Jev auto, like the main chat.
On the Crew (Members) page, the chat box had only one send button. If the crewmate was working, every send cut into its running turn. You could not queue a message for later. Jev auto was never offered.
Why it matters
Users talk to crewmates on the Crew page all day. Without Queue, a quick follow-up always breaks into the crewmate's work. Without Jev auto, the gateway cannot pick for you. The main chat already has all three, so the Crew page felt broken.
Not a goal
steer-onlymode stays in the code. Only the Crew page stops asking for it.What changed (motivation → approach → change)
A user reported the missing choice in #16689. The earlier pin said a DM has no queue step; the user wants one, so that call is reversed.
The Members page told its chat pane
busyMode="steer-only". That one setting hid the split button and the steer badge. The page now uses the default split mode, so a message that steered shows the same badge as in the main chat. The Crew layout seed (membersFloorSeed) drops its unreadbusyModekey. The messaging spec no longer says the member DM is steer-only.Backwards compatibility
Compatible: the pane already supports split mode. Nothing that works today is refused.
Removes nothing: the Crew page gains Queue and Jev auto; Steer still works the same. The seed's
busyModekey had no reader.Tests
MembersPage.test.tsx: the page now asks forsplit, notsteer-only.editModel.test.ts: the layout seed round-trip keeps the chat cell's config.ChatPane.steerOnly.test.tsxis untouched. It still pins thesteer-onlymode itself.Manual verification
Ran the Members capture page in Chromium with a busy crewmate. Before: one Send button. After: the split button and its caret menu.
Screenshots / video
Before (main), crewmate busy, text typed:
After, same state:
After, caret menu open:
After, Jev auto consented and a turn running: the caret menu offers Auto (Jev):
After, a queued message: the queue list shows above the composer and can be cancelled:
After, a message that steered: the row carries the steer badge:
Related Issues
Fixes #16689
Pattern harvest
Not generalizable: one host prop chose a narrower mode on purpose; the product call changed, not a bug class.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)