Skip to content

fix(members): Steer / Queue / Jev auto in the crewmate chat - #16684

Merged
bolichen97 merged 1 commit into
mainfrom
fix/members-dm-split-send
Oct 5, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/members-dm-split-send

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When a crewmate is busy, the Crew page chat lets you pick Steer, Queue or Jev auto, like the main chat.

On the Crew (Members) page, the chat box had only one send button. If the crewmate was working, every send cut into its running turn. You could not queue a message for later. Jev auto was never offered.

Why it matters

Users talk to crewmates on the Crew page all day. Without Queue, a quick follow-up always breaks into the crewmate's work. Without Jev auto, the gateway cannot pick for you. The main chat already has all three, so the Crew page felt broken.

Not a goal

  • No change to how Steer, Queue or Jev auto work. This uses the main chat's control as it is.
  • No change to the main chat or split view.
  • The steer-only mode stays in the code. Only the Crew page stops asking for it.

What changed (motivation → approach → change)

Before After
Crewmate busy one Send (steers) Steer / Queue split
Jev auto never when on and a turn runs
Queue list hidden shown
Steer badge on a sent row hidden shown

A user reported the missing choice in #16689. The earlier pin said a DM has no queue step; the user wants one, so that call is reversed.

The Members page told its chat pane busyMode="steer-only". That one setting hid the split button and the steer badge. The page now uses the default split mode, so a message that steered shows the same badge as in the main chat. The Crew layout seed (membersFloorSeed) drops its unread busyMode key. The messaging spec no longer says the member DM is steer-only.

Backwards compatibility

Compatible: the pane already supports split mode. Nothing that works today is refused.

Removes nothing: the Crew page gains Queue and Jev auto; Steer still works the same. The seed's busyMode key had no reader.

Tests

  • MembersPage.test.tsx: the page now asks for split, not steer-only.
  • editModel.test.ts: the layout seed round-trip keeps the chat cell's config.
  • ChatPane.steerOnly.test.tsx is untouched. It still pins the steer-only mode itself.

Manual verification

Ran the Members capture page in Chromium with a busy crewmate. Before: one Send button. After: the split button and its caret menu.

Screenshots / video

Before (main), crewmate busy, text typed:

before

After, same state:

after

After, caret menu open:

after menu

After, Jev auto consented and a turn running: the caret menu offers Auto (Jev):

after menu with Jev auto

After, a queued message: the queue list shows above the composer and can be cancelled:

after queued message

After, a message that steered: the row carries the steer badge:

after steer badge

Related Issues

Fixes #16689

Pattern harvest

Not generalizable: one host prop chose a narrower mode on purpose; the product call changed, not a bug class.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested a review from a team October 4, 2026 06:23
@iamwhatever
iamwhatever requested a review from a team as a code owner October 4, 2026 06:23
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of adc9a399214bf84d03c718ad0fc3e04140a20994 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that a message queued in a member DM is actually sent once the crewmate's turn ends. The screenshots show the queued row but never show it being delivered.

[DESIGN-REVIEWED] adc9a39

Description read

[DESCRIPTION-READ] 66706a0ab2465e3c93ec8bbf8fb4166878bfd8b5110b4050db296b12bb6f738a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of adc9a399214bf84d03c718ad0fc3e04140a20994 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

After this PR nothing passes busyMode="steer-only". capture-members-steer-only.mjs frame 01 still checks for a plain Send button. Decide whether to delete it.

Inventory (7 items) — 6 justified

Intent: when a crewmate is busy, the Crew page chat lets you choose Steer, Queue or Jev auto, as the main chat does. This is a FIX (#16689), and the description openly reverses the earlier "a DM has no queue concept" pin.

  1. A busy crewmate's composer shows the Steer / Queue split button instead of a single Send — justified
  2. Auto (Jev) is offered on the Crew page when consented and a turn runs — justified
  3. The queue list now shows above the Crew page composer — justified
  4. A message that steered shows the steer badge in the Crew chat — justified
  5. The Crew layout seed drops its busyMode key. Grep found 0 readers of the cell config busyMode — justified
  6. A slot that picked Queue or Auto in the main chat now keeps that mode on the Crew page. Before, steer-only ignored the saved choice — undeclared
  7. The messaging spec no longer calls the member DM steer-only — justified

[FIRST-PRINCIPLES-REVIEWED] adc9a39

Description read

[DESCRIPTION-READ] 5f1d64d3da2faa5af842edd7866b302c4880f302a05002ffaf5425f9f310611a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ human override accepted

@iamwhatever overrode this lane for adc9a399214bf84d03c718ad0fc3e04140a20994 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed adc9a399214bf84d03c718ad0fc3e04140a20994 — this comment is updated in place on each push.

Review details

Advisory only. Nothing blocks the merge.

FINDING — website/src/pages/members/MembersPage.tsx:4045 — removing busyMode="steer-only" makes hideSteerBadge false. createTranscriptRenderers emits its session-aware user entry only when o.hideSteerBadge is set, so the Members DM now falls back to the SDK user row. That row calls renderUserContent({ content: c, meta: mt, onFileOpen: ctx.onFileOpen }) without passing onSessionOpen, sessions or activeSession. As a result, a /chat?sid=… link, slot key or short session name that the user types into a crewmate DM no longer opens that session in the app. This contradicts crew-mode.md:1524 ("the steer-only user row (through renderUserContent)"). → Fix: in transcriptRenderers.tsx, emit the dashboard user entry whenever o.onSessionOpen && o.sessions are supplied, and pass hideSteerBadge only for steer-only. This needs an edit to a file the PR did not touch. Also update crew-mode.md:1524 and the busyMode docstring at ChatPane.tsx:191, which still name the Members DM as the steer-only host.

[OPUS-REVIEWED] adc9a39

Verdict parsed from the review's SHA-scoped output markers for commit adc9a399214bf84d03c718ad0fc3e04140a20994.

False positive or not applicable? A repository writer can comment:
/ai-review override fable adc9a399214bf84d03c718ad0fc3e04140a20994: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of adc9a399214bf84d03c718ad0fc3e04140a20994 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] adc9a39

False positive or not applicable? A repository writer can comment:
/ai-review override gpt adc9a399214bf84d03c718ad0fc3e04140a20994: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 4, 2026
@iamwhatever
iamwhatever force-pushed the fix/members-dm-split-send branch from 03f0fb1 to 7906221 Compare October 4, 2026 06:32
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Item 1 — inherited premise span=2d279f8df3c7 — fixed in 7906221

The user report is now an issue, #16689, and the body links it with Fixes #16689.
The user asked for Queue and Jev auto in the crewmate chat, so the old no-queue premise is reversed by that report, not by symmetry.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Item 3 — seed busyMode key has no reader span=888650e64053 — fixed in 7906221

membersFloorSeed.ts no longer sets busyMode; editModel.test.ts now checks the chat cell config survives via agentLocked.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 4, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Item 4 — undeclared steer badge span=319daba9c31a — fixed in 7906221

The body now declares it: the What changed table has a Steer badge row, hidden before, shown after.
Showing the badge is intended: a steered send should look the same as in the main chat.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 4, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Item 5 — steer-only mode has no shipped host span=e15ffa8ed0ef — rebutted

Deleting the mode touches about 10 files (busySend.tsx, props.ts, ChatPane.tsx, UserMessage.tsx, transcriptRenderers.tsx, QueueStack.tsx and 4 test files).
That is a cleanup well beyond this one-prop fix; Not a goal names it. Keeping a tested, unused mode ships no defect.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • A recorded decision is reversed on symmetry alone span=876ab0d3b60e — fixed in 7906221

The reversal now rests on a user report filed as #16689 and linked with Fixes #16689, which is this item's Clears-when condition.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The busy Send button gives no hint of what it will do span=741c69cb6867 — rebutted

The button is BusySendControls from busySend.tsx, the same control and icons the main chat and split view already ship.
This PR only lets the Crew page use it; changing its icon or label would change every chat surface and is out of this goal.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Queue and Send look alike span=baaf0322508a — rebutted

The Queue icon comes from the shared BusySendControls menu that the main chat already ships unchanged.
Redesigning that shared icon is outside this one-prop fix and would touch every chat surface.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 4, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Item 7 — steer-only variant has no shipped host span=2a334a92723d — rebutted

Deleting the variant touches about 10 files (busySend.tsx, props.ts, ChatPane.tsx, ChatInput.tsx, UserMessage.tsx, transcriptRenderers.tsx, QueueStack.tsx and 4 test files).
This PR is a one-prop fix; that cleanup is listed under Not a goal. A tested, unused variant ships no defect.

@iamwhatever
iamwhatever force-pushed the fix/members-dm-split-send branch from 7906221 to e2431ae Compare October 4, 2026 07:37
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 4, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The main Steer button is hard to read before the menu is opened span=60289952e795 — rebutted

The button is BusySendControls from busySend.tsx, the same control the main chat and split view already ship unchanged.
This PR only lets the Crew page use it; relabelling the shared control would change every chat surface and is outside this goal.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The Queue icon looks like the old send arrow span=b0fe31855d41 — rebutted

The Queue icon is part of the shared BusySendControls menu the main chat already ships.
Redesigning that shared icon is outside this one-prop fix and would touch every chat surface.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The lightning bolt on the queue strip is a guess span=8879e3d75829 — rebutted

QueueStack is not changed by this PR; its send-now button is the main chat's.
The control is the shared BusySendControls / QueueStack UI that the main chat and split view already ship unchanged.
This PR only stops the Crew page from hiding it; relabelling shared UI would change every chat surface and is outside its goal.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • A queued message seems to vanish span=94b54bc4cb59 — rebutted

A queued message is delivered as a normal user row when the turn ends, the same flow the main chat uses.
The control is the shared BusySendControls / QueueStack UI that the main chat and split view already ship unchanged.
This PR only stops the Crew page from hiding it; relabelling shared UI would change every chat surface and is outside its goal.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The primary send action is a bare icon span=bf28cfcf06f3 — rebutted

The busy split button face is identical to the main chat's; this PR changes no icon or label.
The control is the shared BusySendControls / QueueStack UI that the main chat and split view already ship unchanged.
This PR only stops the Crew page from hiding it; relabelling shared UI would change every chat surface and is outside its goal.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override ux dc04b4a: agent: The flagged labels (busy Send icon, "Auto (Jev)", queue strip bolt) are the shared BusySendControls/QueueStack UI the main chat already ships unchanged. This PR only stops the Crew page hiding it, as #16689 asks; relabelling shared UI is outside its goal. Rebuttals posted per span.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the ux AI finding as false positive, not applicable, or explicitly accepted for dc04b4a9244398bcffe0c82bb76b8acc5a7fd57d.

agent: The flagged labels (busy Send icon, "Auto (Jev)", queue strip bolt) are the shared BusySendControls/QueueStack UI the main chat already ships unchanged. This PR only stops the Crew page hiding it, as #16689 asks; relabelling shared UI is outside its goal. Rebuttals posted per span.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 5, 2026
…d choice

The Members (Crew) page pinned its ChatPane to busyMode steer-only, so a send while the crewmate was working always interrupted the running turn: one plain send button, no Queue, no Jev auto. Drop the pin so the DM uses the same split busy-send control as the main chat.
@iamwhatever
iamwhatever force-pushed the fix/members-dm-split-send branch from dc04b4a to adc9a39 Compare October 5, 2026 15:45
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved since this head went green (087f6c9 -> a97659d); picks up #16785, which fixes the Windows test_registry_store_art_prewarm.py failure. CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 5, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 5, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override ux adc9a39: agent: The flagged labels (busy Send icon, "Auto (Jev)", queue strip bolt) are the shared BusySendControls/QueueStack UI the main chat already ships unchanged. This PR only stops the Crew page hiding it, as #16689 asks; relabelling shared UI is outside its goal. Rebuttals posted per span.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the ux AI finding as false positive, not applicable, or explicitly accepted for adc9a399214bf84d03c718ad0fc3e04140a20994.

agent: The flagged labels (busy Send icon, "Auto (Jev)", queue strip bolt) are the shared BusySendControls/QueueStack UI the main chat already ships unchanged. This PR only stops the Crew page hiding it, as #16689 asks; relabelling shared UI is outside its goal. Rebuttals posted per span.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Oct 5, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Reviewed at adc9a39.

The Members page no longer passes busyMode="steer-only" to its DM ChatPane, so the crewmate chat falls back to the default 'split'. That default is the main chat's Steer / Queue split, with Auto (Jev) offered under the main chat's own gate. The messaging spec and the tests are updated to match. The behaviour change is correct, and the queue path already worked for member slots: ChatPane.tsx:1788 already rendered server-parked queue cards there. The doc comments that still describe the old Members-page behaviour are listed below as follow-ups.

What I verified

  • website/src/pages/members/MembersPage.tsx:4041-4045: the busyMode prop is removed, and ChatPane.tsx:128 defaults it to 'split'.
  • Auto (Jev) is gated exactly as in the main chat. ChatPane.tsx:2002 passes jevAutoAvailable={jevAutoConsented && running}, and busySend.tsx:61 falls an auto mode back to steer when that is false. Main chat uses the same gate (ChatPage.tsx:6235). This is fail-closed: with no consent, or no running turn, no Auto option appears.
  • hideSteerBadge (ChatPane.tsx:1500) is now false on the Members page, so steer badges show there. The PR body states this as intended.
  • membersFloorSeed.ts:35: I confirmed the PR's claim that the busyMode key had no reader. The only busyMode consumers on base are ChatInput, ChatPane, and busySend; nothing in components/crew/ reads the key. Removing it does not change behaviour. Re-adding it leaves editModel.test.ts green, which is expected for a key nothing reads.
  • docs/system-specs/modules/messaging.md:1816 no longer says the member DM is steer-only.
  • Tests I ran: MembersPage.test.tsx, editModel.test.ts, and ChatPane.steerOnly.test.tsx all passed (218 tests).
  • Mutation: re-adding busyMode="steer-only" in MembersPage fails opens the pinned DM thread on click…, which checks data-busy-mode="split".
  • Title check: "Steer / Queue / Jev auto in the crewmate chat" matches the diff. The pane gains the split button (Steer/Queue) and the Auto (Jev) option. Auto appears only when Jev auto is consented and a turn is running, not always, and the body says so.
  • The overridden ux AI-review findings are about icons and labels in the shared BusySendControls / QueueStack, which this PR does not touch. I agree with the override.
  • CI at the head SHA: 90 success, 8 skipped, 0 failure. No reviews have been posted yet.

Non-blocking follow-ups

  • Several doc comments and docs still say the member DM is steer-only:

    • website/src/components/ChatPane.tsx:191-195: "A host that presents a conversation with ONE named peer (the Members page's DM thread) passes 'steer-only'".
    • website/src/components/chat-input/props.ts:57-63: "A conversation with ONE named peer (a member DM thread) uses it".
    • docs/system-specs/modules/crew-mode.md:1524: "the steer-only user row".

    These should say that no shipped host passes steer-only today, as messaging.md now does.

  • website/scripts/capture-members-steer-only.mjs:75 now asserts the OLD Members-page state. Its "AFTER" check expects steerOnly === 1 && split === 0, so a re-run against this head will fail. website/capture/members-page.tsx:87 still "Documents the steer-only composer". These are manual capture tools, not CI.

  • PR body wording: the table says the queue list went from "hidden" to "shown". On main, server-parked queue cards were already shown on the Members page (ChatPane.tsx:1788-1793). What changed is that the user can now ask for a queue.

  • Title wording: there is no verb. Something like "fix(members): offer Steer / Queue / Jev auto in the crewmate chat" would read better.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving: the Crew page chat now gets the same Steer / Queue / Jev auto split as the main chat. The default busy mode is still steer, so a plain Enter while the crewmate works does what it did before; the change only adds choices.

Non-blocking: the busyMode docstring at website/src/components/ChatPane.tsx:192 still says the Members page passes 'steer-only'. Please update it in a follow-up.

AI-assisted review, posted at maintainer request.

@bolichen97
bolichen97 enabled auto-merge (squash) October 5, 2026 22:05
@bolichen97
bolichen97 merged commit 68d920b into main Oct 5, 2026
98 of 99 checks passed
@bolichen97
bolichen97 deleted the fix/members-dm-split-send branch October 5, 2026 22:05
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crew page chat has no Queue or Jev auto while a crewmate is busy

3 participants