Skip to content

docs(prepare-pr): bring SKILL.md back under its byte ceiling - #16719

Closed
bolichen97 wants to merge 1 commit into
mainfrom
docs/prepare-pr-skill-under-ceiling
Closed

bolichen97 wants to merge 1 commit into
mainfrom
docs/prepare-pr-skill-under-ceiling

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: prepare-pr/SKILL.md is back under its 68000-byte ceiling on main.

test_slim_skills_do_not_regrow_duplicate_guidance_or_wire_model_ids[prepare-pr-68000] fails on main (68077 bytes, 77 over) since #16196. Every open PR inherits the red through its merge ref, in Backend Tests (3.12) shard 3 and Backend Tests (Windows) shard 3.

Why it matters

A red test on main reds every PR, so no author can tell their own failures from this one.

Not a goal

What changed (motivation → approach → change)

77 bytes over → shorten prose that restates itself, leave every pinned phrase alone → src/kiro_crew/builtin_skills/kirocrew-dev/prepare-pr/SKILL.md goes from 68077 to 67984 bytes (−93): the "This file carries only…" paragraph, the accepted-and-deferred row (same facts, fewer words), and one clause in the single_commit note. One trim I tried (runtime/provider-reported) is pinned by test_model_selection_is_discovered_and_service_evidence_is_not_invented, so it stays.

Backwards compatibility

No behaviour change; documentation only.

Reader: test/test_review_repair_routing_skill.py:test_slim_skills_do_not_regrow_duplicate_guidance_or_wire_model_ids -- entry: release -- reads the file size; now 67984 ≤ 68000
Reader: test/test_prepare_pr_status.py -- entry: release -- unaffected, passes

Tests

pytest test/test_review_repair_routing_skill.py test/test_prepare_pr_status.py: 229 passed. On main the first file fails with assert 68077 <= 68000.

Manual verification

Byte count of the file before and after (68077 → 67984), no CRLF introduced.

Related Issues

Closes #16718

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@bolichen97
bolichen97 requested a review from a team as a code owner October 4, 2026 07:41
@bolichen97
bolichen97 requested a review from kyleseaman October 4, 2026 07:41
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 00ab9b57a774221e0b2f9e509a55f98d91a39eee — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 00ab9b5

Description read

[DESCRIPTION-READ] 48498c81a68413faf32281ee7b378fd2be0df67585fcc75c0ef2ac766987dc73

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 00ab9b57a774221e0b2f9e509a55f98d91a39eee — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

The trimmed intro drops "not on every load". Check that the loop's lazy-load guidance for references/rationale.md still reads the same.

What this change ships

Inventory (3 items) — 3 justified

Intent: get main green again by bringing prepare-pr/SKILL.md back under its 68000-byte ceiling, which test_review_repair_routing_skill.py:116 enforces. FIX.

  1. The intro paragraph that points to references/rationale.md is shorter. — justified
  2. The accepted-and-deferred disposition row has the same requirements in fewer words. — justified
  3. The single_commit note says "use" where it said "go through". — justified

[FIRST-PRINCIPLES-REVIEWED] 00ab9b5

Description read

[DESCRIPTION-READ] 2d59841e749a6a836e4150e5c2c0e8a3081e211fe5c0185d0cd9a414dd0f32fe

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 00ab9b57a774221e0b2f9e509a55f98d91a39eee — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 00ab9b5

Verdict parsed from the review's SHA-scoped output markers for commit 00ab9b57a774221e0b2f9e509a55f98d91a39eee.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 00ab9b57a774221e0b2f9e509a55f98d91a39eee: <one-sentence reason>

@bolichen97

Copy link
Copy Markdown
Contributor Author

Closing: #16717 merged and already brings SKILL.md back under its ceiling (main is now 67995 bytes), so this is no longer needed.

@bolichen97 bolichen97 closed this Oct 4, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Superseded by #16717, which merged the same byte-ceiling fix.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 00ab9b57a774221e0b2f9e509a55f98d91a39eee and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 00ab9b5

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 00ab9b57a774221e0b2f9e509a55f98d91a39eee: <one-sentence reason>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: prepare-pr SKILL.md is 77 bytes over its size ceiling on main

1 participant