Repository navigation
Conversation
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS The "No Kiro Crew tools" warning sits on the agent chip, but the steps to fix it live in the Context-window popover, a different control. A user who sees the warning has no visible way to learn what to do. BlockersThe fix is hidden away from the warning
Severity: rare state × the task fails with no recovery path × happens every time the state occurs. Fix: show the state's guidance where the warning is. Put the Notes
[UX-REVIEWED] 6435bfb Description read[DESCRIPTION-READ] f6cf3dcb92b260c618e470269acc819c9071bac947000003230708fa9dee300f That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the new slot fields only add display data, nothing is removed, and three committed screenshots cover the new composer surface. Notes
[DESIGN-REVIEWED] 6435bfb Description read[DESCRIPTION-READ] e4f7036ddd7151e81981cb27630d70b485acd8e13ca9ed0b1612c584a96940a4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. One rider goes past the display-only Goal: the warm-pool crew rebind changes which crew a restarted session is governed and spawned as. Notes
What this change shipsInventory (10 items) — 7 justifiedIntent: let a person see which harness, model, effort and crew a live session actually runs, and whether it has Kiro Crew's tools. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 6435bfb Description read[DESCRIPTION-READ] ca5819d1808e4dd9afd01b3a0d80a0e4c70b26a907ba21fd06a2c1e33b8b5003 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — 🔴 changes requested (blocking)Reviewed Blocks: the session facts this PR adds stay on the slot after their session is gone, and the composer now ranks them above what the user just picked. After an unclaimed resume prefetch expires, picking a different model or effort keeps showing the dead session's model, effort, harness and agent. BLOCKING — src/kiro_crew/dashboard/state_parts/slot_session.py:722 Trigger: opening a past chat runs Outcome: the model chip names, and the picker highlights, the dead session's model instead of the new pick. Before this change the pin won and Anchor: defect Fix: stamp the facts with the provider's |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
48d9db0 to
b83ed1e
Compare
|
Rebased onto Three files conflicted, all mechanically: #17245 replaced
Range-diff: commit 2 is identical; commit 1 differs only in those three files. Please pull with |
b83ed1e to
449e500
Compare
0cfc46b to
251c7aa
Compare
251c7aa to
33dc399
Compare
|
Rebased onto main @ f454c08 (old head main moved the chat turn into owner modules since the last port, so these hunks were re-applied where the code now lives: the footer model and the end-of-turn fact sync to Main's The HOLD items and the two blocking findings on |
|
self-added: yes
|
|
self-added: yes
|
|
Design (HOLD): the description claimed a 64 KB |
|
First Principles item 10: description claims the diff does not ship. Fixed in the description: the 64 KB |
|
First Principles item 7 / item 8: the footer re-pointing is oversized for a composer-only Goal. Resolved by amending the Goal, on the author's decision: "...; each reply's footer names the model that turn actually ran." The footers are where a person reads what a finished turn ran, and naming the selection there hides the same substitution the chip now shows. The mechanism stays: |
|
UX: "No tools" overstates the problem. Fixed in 7b92a35: the agent chip says No Kiro Crew tools, the same scope as the popover row, in every catalog. The harness's own tools are not covered by the warning, and it no longer reads as if they were. |
|
UX: the not-sent warning gives no next step. Fixed in 7b92a35: "Kiro Crew tools were not sent to this session. Add @kirocrew-core to this agent's tools under Customize → Custom agents, then start a new session." With |
|
UX suggestion: "Sent, not confirmed". Adopted in 7b92a35 for every catalog. It names what is known (the tools were sent) and what is not (no confirmation), drops "harness", and fits one line of the 208px popover. |
|
UX: no blind read. Not something this PR can supply: the fork UX lane has no blind-read pass by design, and only |
|
UX evidence gap: the |
|
UX note: the |
|
UX note: the selection shows only in the model chip's hover title. Kept as is. The chip names what ran, which is this PR's point; the selection is one tap away, since the model picker the chip opens highlights it, on a phone too. A second marker would compete with the reported id for the chip's width on a phone. |
|
Design note: on kiro-cli, |
|
Design note: the SPA keeps its own copies of the gateway's server and harness sets. Kept, with a smaller copy: the SPA now mirrors one server name ( |
|
First Principles note: a warm-pool claim's crew rebind also sets the governed agent on restart. Declared in the description; no code change. The rebind is in |
The composer named a session's model and effort from config until its
first turn, and after it from the model the session selected. A harness
can run a model other than the one it accepted, the effort level an
adapter accepted was never read back, and no surface named a session's
ACP backend. A session could therefore run another model, effort or
backend, or run without the gateway's tools, under labels that said
otherwise.
Each session now reports its own facts, recorded on the slot when eager
spawn registers it, when a turn starts on a new or reloaded session,
when a turn ends, and after a live model or effort change:
- turn_model: the model the prompt response's model_usage says served
the turn (claude-agent-acp, codex-acp), redacted before its cap and
cleared when a turn starts or the model switches
- served_effort: the effort option's value in the set_config_option
response (kept only within 64 KB and when it is an effort name), the
effort suffix of codex's current model id when it advertises no
effort option, or, on kiro-cli, which reports none, the level Crew
last pushed live with /effort (a fallback swap carries one without
storing it), else the level written to its settings overlay
- served_backend and served_agent: the provider's backend, in the
config spelling the SPA reads ("kiro" for kiro-cli), and the crew it
runs as
The model chip leads with the harness logo and shows the reported
model, with the selection in its title when the two differ. The effort
label shows the reported level. The agent chip names the crew the
session runs as and warns "No Kiro Crew tools" when kirocrew-core was
not sent or failed to start; a spec may leave out kirocrew-cron on
purpose, so that server alone decides. The not-sent warning says where
to add the server. The context popover lists the harness, the full
served id and the tool state, kept inside the viewport on a phone.
Until a session reports, the chips keep the configured prediction.
The turn and Slack cron footers name the reported model
(read_reported_turn_model); the usage record keeps the resolved id, so
a harness spelling a model its own way does not split that model's
usage history in two.
|
Rebased the author's latest head Conflict resolution only, no new behaviour:
Locally: the 10 touched Python test files (531 tests), |
…tions path applied_effort finds the effort config option by its id instead of gating on ACP_BACKENDS_EFFORT_VIA_CONFIG_OPTION (test_backend_cards_advertised). The helper takes a provider, not self, and the frozen AcpProvider inventory lists applied_effort, session_agent and turn_model. Main already stores the configOptions a set_config_option response carries, so bounded_config_options only added a 64 KB cutoff (First Principles item 10). It is removed with its doc bullet. applied_effort still reports only an effort name, which the rewritten session-facts test pins for a 70 KB level. gatewayToolsState no longer reads kirocrew-core listed in no_tools as 'connected': it returns 'no_tools', which the agent chip warns on and the context popover explains with a warn-status notice (GPT 6.1 Review F2). The notice ends with the next step: turn that server off, then start a new session. A warm-pool claim now rebinds the provider's own crew next to client.rekey, so session_agent reports the claiming crew instead of the pool's agent spec, as a cold start does (Opus 5.5 Review). Co-authored-by: Ashish Patil <7754022+ash663@users.noreply.github.com>
|
Fixed the two CI reds on
Also passing locally: |
|
@ash663 status check from the stale-PR sweep. This branch now conflicts with main in 17 files. One overlap needs your call: main shipped #33404 on 11-09, which marks the composer model chip with the session's harness through a |
|
@iamwhatever Thanks for the status check, and for the two rebases you did for us. Before we put in another round, could you tell us if you'd like this PR? If yes, we're glad to rebase it. We'll drop our harness mark and use #33404's
After 40 days it still has no human review. We'd love to find a way that works better for outside contributors, and costs less on both sides. If you'd like it, these would help a lot:
If it's not something you want, no problem at all. Just let us know and close it. That's better for everyone than a sixth rebase. |
Code change approver recommendation: Request changesWhy: the decider found 3 problems and estimates an 88% chance that this change introduces a defect, at or above the 80% level where it asks for changes. The PR makes the composer show the backend, model, effort and crew a session actually runs. On this head it breaks existing backend tests that I traced to the change itself. The new Problems found:
An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
Problem / Motivation
Goal: The chat composer names the backend, model, reasoning effort and crew a live session actually runs, and says when the session runs without Kiro Crew's own tools; each reply's footer names the model that turn actually ran.
The composer's chips are predictions: config before a session's first turn, then the model the session selected rather than the one that ran. The effort label is the level Crew asked for, never read back, and nothing names the session's ACP backend. On main:
claude-fable-5. After its turn the chip readauto · Max.global.anthropic.claude-opus-5-5[1m]at the adapter's default effort, without the session's MCP servers. Its chip readauto · Default · High, with no sign that the tools were missing.Why it matters
Model and effort are picked for cost and quality. A label naming something other than what ran hides a pick, pin or effort override that did not take. A session without Kiro Crew's tools fails every task that needs them, and nothing on screen says why.
Not a goal
auto.What changed (motivation → approach → change)
The composer names what each live session reports running: its harness, model, effort and crew. The chips named config or the selection because the slot kept only
served_model, the id a session selected, so each session now records what it reports, beside that field. The slot records it when eager spawn registers the session, when a turn starts on a new or reloaded session, when a turn ends, and after a live model or effort change. Teardown forgets it withserved_model, and like that field it is display-only.turn_model_meta.quota.model_usagerow with the most tokens (parse_prompt_turn_model), redacted whole, then capped at 200 characters; claude-agent-acp and codex-acp report it, kiro-cli does notserved_effortcurrentValuein theconfigOptionsthe session already caches; codex's[effort]model-id suffix when it advertises no effort option; on kiro-cli, which reports no level, Crew's own record: the level last pushed live with/effort(a fallback swap carries one without storing it), else the overlay's. Kept only when it is an effort nameserved_backend,served_agentkirofor kiro-cli), and the crew it runs asThe model chip leads with the harness logo, drawn by the
HarnessLogoSettings → Agent Harness uses, and shows the reported model, with the selection in its title when they differ. The effort label shows the reported level. Until a session reports, the chips keep today's prediction.Whether Crew's tools reached a session is read off its existing
mcp_report(gatewayToolsState).kirocrew-corealone decides, because a spec may leave outkirocrew-cronon purpose, as the conductors do. When it was not sent, failed to start or gave the session no tools, the agent chip says No Kiro Crew tools, and the context popover says what happened and what to do next:@kirocrew-coreto the agent's tools under Customize → Custom agents, then start a new sessionAvailable,Sent, not confirmedorNot reported yetOn a phone the shelf wraps around the warning, and the popover stays 8px inside the viewport.
The turn, abnormal-turn and Slack cron footers name the model the harness reported (
read_reported_turn_model). The usage record keeps the resolved id (read_turn_model), so one model's usage history does not split across two spellings.The sidebar's crew marker prefers
served_agent. A warm-pool claim sets the pooled provider's own crew to the claiming crew, soserved_agentnames that crew, and a restart of the session is governed as that crew too, as a cold start is.model-selection.md,providers.md,acp-client.mdandturn-stats-footer.mdsay where each fact comes from.Where it lives: the turn's model is parsed in
acp/_dispatch.pyand kept byacp/client_usage.pyandacp/session_handle_turn.py; the provider's readers are inproviders/acp.py,providers/base.pyandproviders/acp_model_effort.py, whose live effort recordproviders/acp_lifecycle.pyresets on a restart; the slot fields and where they are recorded are instate_parts/slot_session.py,chat_turn/model_fallback.py,chat_turn/turn_stats.pyandchat_turn/eager_spawn.py; the footers' reader is inhandlers/usage.py, whichgateway_runtime/cron_turn.pycalls for the cron footer; a warm-pool claim reports the claiming crew insession_allocation_parts/get_or_create.py. In the SPA,lib/mcpSessionReport.ts,lib/model.tsandtypes/index.chat.tsderive the state;chat-input/ContextShelf.tsx,components/HarnessMark.tsx,page/ComposerDockView.tsx,chat-sidebar/SessionRow.tsxandutils/agentLabel.tsrender it;locales/en.manual.jsonand every other catalog carry the labels.Backwards compatibility
Compatible: the four slot fields are additive and every existing field keeps its value; the SPA falls back to the configured prediction while a field is absent or
null.Removes nothing: no key, record, validator or path is removed or tightened.
Tests
Each of these fails on the parent commit unless it says otherwise.
test/test_session_facts.py(new): the turn-model parser, its redaction before the cap and its reset; claude, kiro and codex effort; a reported level that is no effort name, a 70 KB one included; no effort channel; crew vs spec agent; record and forget.test_kiro_effort_carried_to_a_fallback_model_is_the_level_it_runs_at: a kiro-cliset_modelto a fallback with no stored level reports the level it pushed live, and the next switch carries none. It fails without the live record ('' == 'high').test_the_footer_names_the_reported_model_and_the_usage_row_the_selected_oneruns one_run_chatturn whose harness reports a model the session did not select: the usage row keeps the selected id and the footer names the reported one.test_the_spa_reads_tools_off_the_same_servers_and_harnessesparses the SPA's mirrored names and fails when either side moves alone.website/src/test/mcpSessionReport.test.tsx:gatewayToolsStateper harness, including a roster withoutkirocrew-cron, which readssenton claude andconnectedon kiro-cli.website/src/test/ChatInput.sessionFacts.test.tsx: the logo on every shelf width, the popover inside a 390px viewport with the full served id, the shelf wrapping around the warning, and each state's text and role (statusfor a warning,alertfor a failed start).test_acp_runtime_session_handle.py,test_chat_slot_reasoning_effort.py,test_eager_spawn.py,test_session_pool.py(a warm-pool claim reports the claiming crew),test_chat_slot_facade_contract.py,test_acp_bindings.py,model.chipMarker.test.ts,useChatPageComposerChips.test.tsx,ChatSidebar.effectiveAgent.test.tsx.On this head: the touched backend modules, the composition and bindings contracts and every effort suite (2,387 tests) pass, and so do the touched vitest files and every i18n suite (59 files, 1,144 tests).
tsc, eslint, black, isort, flake8, mypy,i18n:check,lint:i18n, semgrep on the diff and the flake-pattern ratchet are clean.test_session_facts.pypasses 20 runs at-n0, 10 at-n 4beside two sibling files, and the touched backend files' 518 tests in a shuffled order (seed 589).Gate proof: tree ce4564f8deb6; ran 24; skipped none
Manual verification
The built SPA, served without a gateway, every API call answered in the browser with the slots stubbed per state. At 390x844 the shelf does not overflow, and the context popover spans x=104 to x=312 in each warning state. At 1440x900 every popover is inside the viewport too. The measured texts match the table above.
The hover titles, which the browser draws and a screenshot cannot show:
Agent: default · This session has no Kiro Crew toolsModel: global.anthropic.claude-opus-5-5[1m] · Selected: fable · Reasoning effort: Default · Agent harness: Claude CodeTurn took 7.9s ($0.2311 API cost) · model: global.anthropic.claude-opus-5-5[1m]Screenshots / video
Tools not sent, on a phone (a Claude Code session): the shelf with the warning, then the context chip tapped; then a kiro-cli session whose
kirocrew-coregave it no tools:kiro-cli at 1440x900, the context popover per state: available, not reported yet, failed to start, and gave no tools:
What a session reports: a Claude Code session whose harness reported another model than its selection, with the chip's title printed in the white box and the context popover open; that reply's footer; a sidebar row whose session runs as another crew; and the model chip per harness:
Related Issues
The first live run of this change surfaced two defects it reports but does not fix; both are fixed on main: #16782 (a second Claude session in one project was refused the shared settings seed, so its MCP servers were withheld) and #16783 (an effort keyed under the configured model spelling was missed under the advertised one).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)