Repository navigation
docs(rfc): creating a crewmate counts as chatting with it - #17844
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check before merge that #17808 stamps [DESIGN-REVIEWED] ecdec47 Description read[DESCRIPTION-READ] d8b07ccc8be051fa24dfe93faa8cc50a6ef1f17fe300c933a85071fd201e77fc That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Amends rfc-crewmates-chatted-list.md (#17816): the user's own create (POST /api/agents, owner-only, not cron-attested) stamps the new crew so it is listed at once and sorts first; crews added by the agent sync, an app or background work are not stamped. Names #17835, whose shared hide rule the switcher runs. Implementation: #17808.
ba9bd45 to
ecdec47
Compare
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
|
RFC, merge |
Problem / Motivation
Goal: Record the product owner's follow-up decision that creating a crewmate counts as chatting with it, so a new crewmate is listed at once and sorts first.
rfc-crewmates-chatted-list.md(#17816, merged) lists only the crewmates the user sent a message. The product owner then ruled that creating a crewmate is also an interaction. #17808 implements that rule. The First Principles lane reads the decision from the base branch.Why it matters
Without this text on main, #17808's create rule has no recorded decision, and a crewmate the user just made would not show in the list until they message it.
Not a goal
What changed (motivation → approach → change)
docs/request-for-change/rfc-crewmates-chatted-list.md: the summary, the decision table and the decision text say that the user's ownPOST /api/agentsstamps the new crew. That route is owner-only, so an app token never reaches it, and an attested cron does not count. A crew added by the agent sync, an app or background work is not stamped. One rejected alternative is added: keeping "created on the dashboard" as its own rule. The text also names fix(members): one roster reading, and no New team door for now #17835, whose shared hide rule the header switcher runs.docs/request-for-change/README.md: the index row says "sent a message or created".Backwards compatibility
Removes nothing: documentation only; no code, config or data path changes.
Tests
N/A — documentation only.
scripts/docs-lint.shpasses.Manual verification
N/A — documentation only.
Related Issues
Amends #17816. Records the decision for #17808, which builds on #17835.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)