Skip to content

docs(rfc): creating a crewmate counts as chatting with it - #17844

Merged
iamwhatever merged 1 commit into
mainfrom
docs/rfc-crewmates-chatted-list-create
Oct 8, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
docs/rfc-crewmates-chatted-list-create

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the product owner's follow-up decision that creating a crewmate counts as chatting with it, so a new crewmate is listed at once and sorts first.

rfc-crewmates-chatted-list.md (#17816, merged) lists only the crewmates the user sent a message. The product owner then ruled that creating a crewmate is also an interaction. #17808 implements that rule. The First Principles lane reads the decision from the base branch.

Why it matters

Without this text on main, #17808's create rule has no recorded decision, and a crewmate the user just made would not show in the list until they message it.

Not a goal

What changed (motivation → approach → change)

  • docs/request-for-change/rfc-crewmates-chatted-list.md: the summary, the decision table and the decision text say that the user's own POST /api/agents stamps the new crew. That route is owner-only, so an app token never reaches it, and an attested cron does not count. A crew added by the agent sync, an app or background work is not stamped. One rejected alternative is added: keeping "created on the dashboard" as its own rule. The text also names fix(members): one roster reading, and no New team door for now #17835, whose shared hide rule the header switcher runs.
  • docs/request-for-change/README.md: the index row says "sent a message or created".

Backwards compatibility

Removes nothing: documentation only; no code, config or data path changes.

Tests

N/A — documentation only. scripts/docs-lint.sh passes.

Manual verification

N/A — documentation only.

Related Issues

Amends #17816. Records the decision for #17808, which builds on #17835.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested a review from a team as a code owner October 7, 2026 20:38
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ecdec479684aa47d233cc57311125046f61e28de — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check before merge that #17808 stamps last_chat_ts only inside api_kirocrew_agents_create, after _require_owner, never in the agent-sync or app write paths.

[DESIGN-REVIEWED] ecdec47

Description read

[DESCRIPTION-READ] d8b07ccc8be051fa24dfe93faa8cc50a6ef1f17fe300c933a85071fd201e77fc

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ecdec479684aa47d233cc57311125046f61e28de and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ecdec47

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ecdec479684aa47d233cc57311125046f61e28de: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ecdec479684aa47d233cc57311125046f61e28de — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ecdec47

Verdict parsed from the review's SHA-scoped output markers for commit ecdec479684aa47d233cc57311125046f61e28de.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ecdec479684aa47d233cc57311125046f61e28de: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 7, 2026
Amends rfc-crewmates-chatted-list.md (#17816): the user's own create
(POST /api/agents, owner-only, not cron-attested) stamps the new crew so
it is listed at once and sorts first; crews added by the agent sync, an
app or background work are not stamped. Names #17835, whose shared hide
rule the switcher runs. Implementation: #17808.
@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmates-chatted-list-create branch from ba9bd45 to ecdec47 Compare October 8, 2026 07:03
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ecdec479684aa47d233cc57311125046f61e28de touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision ecdec479684aa47d233cc57311125046f61e28de ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 8, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

RFC, merge

@iamwhatever
iamwhatever merged commit 1c5a71d into main Oct 8, 2026
97 of 98 checks passed
@iamwhatever
iamwhatever deleted the docs/rfc-crewmates-chatted-list-create branch October 8, 2026 07:13
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant