Repository navigation
fix(members): list only crewmates the user chatted with, reopen the last one - #17808
Conversation
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS
Not justified as shipped
What this change shipsInventory (9 items) — 6 justifiedIntent: let the user find the crewmates they actually talk to, and reopen the last one after a restart. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 9e5767d Description read[DESCRIPTION-READ] 7086b4c3400fc0d324802e9af80af3a55ae031470bf6d6086da63b2136400d9d That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check a host upgraded from main whose user only chatted in normal chat. The seed reads DM threads only, so their switcher may start empty, default crew included. [DESIGN-REVIEWED] 9e5767d Description read[DESCRIPTION-READ] 127b6bf49f0bcd8fa841cad5a84771408a7a62e5612f8ad07c96a8b40ea79b36 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The shortened switcher hides 10 of 12 crewmates without saying why, so a first-time reader couldn't tell what "2" counts or what "Show the full roster" adds. Watch
Suggestions
[UX-REVIEWED] 9e5767d Description read[DESCRIPTION-READ] 8c4c35fe938e7e675cafb03100f14abc0352380a9bc65ea5175f86bd58fd81c9 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsFINDING -- src/kiro_crew/dashboard/handlers/members.py:922 -- The documented human-only seed uses False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
b63043c to
629963f
Compare
629963f to
006a311
Compare
…ast one The folded crewmate switcher was handed every roster row (orderedMembers), and the roster's own listing rule counted any DM message, a dashboard create or the default crew. Record when the PERSON sends a crew a message (POST /api/chat, no app token / cron / relay) in crew_recency.json, ship it as last_chat_ts, list and order by it, and reopen the last-chatted crewmate. A one-time seed reads typed rows from existing DM threads.
006a311 to
9e5767d
Compare
|
…refix The one-time crew_recency seed decided a DM row was typed by the user from content not opening with '[', which counted heartbeat prompts and skipped human messages like '[1, 2, 3]'. Require meta[HUMAN_TURN_META_KEY], the allowlist the human send paths set. Follow-up to #17808.
…refix The one-time crew_recency seed decided a DM row was typed by the user from content not opening with '[', which counted heartbeat prompts and skipped human messages like '[1, 2, 3]'. Require meta[HUMAN_TURN_META_KEY], the allowlist the human send paths set. Follow-up to #17808.
Open the built-in `default` row on the Crewmates page, leave, come back: the page reopened a different crewmate. `activate()` never wrote `default` to the last-member memory, the restore effect never read it, and `resolveDefaultMember` skipped it twice, so once `default` was the row the user actually worked in, the page could never land on it. `default` is now remembered like any other row, with the open's time beside it (`mc-members-last-member-ts`). It is never ranked by `last_chat_ts` (#17808): the default crew's stamp also moves for every plain chat that picked no crew, so it would win nearly always and bury the crewmate the user talked to. Instead a remembered `default` opens when its open is newer than the last chat with any crewmate (`rememberedDefaultPick`); older, the last-chatted crewmate still wins. A roster holding only `default` still shows the hero, and the most-recently-used fallback still never picks `default`. Supersedes #16311, whose roster-click-only gate (`rowPickRef`) predates the server-side last-chatted rule. Closes #17210 Co-authored-by: Helena Stafford <helenars@amazon.com>
…refix (#17953) The one-time crew_recency seed decided a DM row was typed by the user from content not opening with '[', which counted heartbeat prompts and skipped human messages like '[1, 2, 3]'. Require meta[HUMAN_TURN_META_KEY], the allowlist the human send paths set. Follow-up to #17808. Co-authored-by: Joe Guo <zejiangg@amazon.com>
Amends rfc-crewmates-chatted-list.md (#17816): the user's own create (POST /api/agents, owner-only, not cron-attested) stamps the new crew so it is listed at once and sorts first; crews added by the agent sync, an app or background work are not stamped. Names #17835, whose shared hide rule the switcher runs. Implementation: #17808.
Amends rfc-crewmates-chatted-list.md (#17816): the user's own create (POST /api/agents, owner-only, not cron-attested) stamps the new crew so it is listed at once and sorts first; crews added by the agent sync, an app or background work are not stamped. Names #17835, whose shared hide rule the switcher runs. Implementation: #17808. Co-authored-by: Joe Guo <zejiangg@amazon.com>
Open the built-in `default` row on the Crewmates page, leave, come back: the page reopened a different crewmate. `activate()` never wrote `default` to the last-member memory, the restore effect never read it, and `resolveDefaultMember` skipped it twice, so once `default` was the row the user actually worked in, the page could never land on it. `default` is now remembered like any other row, with the roster's chat mark beside it (`mc-members-last-member-chat-mark`: the greatest crewmate `last_chat_ts` at that open). It is never ranked by its own `last_chat_ts` (#17808): the default crew's stamp also moves for every plain chat that picked no crew, so it would win nearly always and bury the crewmate the user talked to. Instead a remembered `default` opens while no crewmate's `last_chat_ts` has moved past the mark (`rememberedDefaultPick`); once one has, that crewmate wins. Both sides are the server's clock, so a remote dashboard compares the same. The mark is the user's own open; a restore re-reads it but never re-writes it. A roster holding only `default` still shows the hero, and the most-recently-used fallback still never picks `default`. Supersedes #16311, whose roster-click-only gate (`rowPickRef`) predates the server-side last-chatted rule. Closes #17210 Co-authored-by: Helena Stafford <helenars@amazon.com>
Open the built-in `default` row on the Crewmates page, leave, come back: the page reopened a different crewmate. `activate()` never wrote `default` to the last-member memory, the restore effect never read it, and `resolveDefaultMember` skipped it twice, so once `default` was the row the user actually worked in, the page could never land on it. `default` is now remembered like any other row, with the roster's chat mark beside it (`mc-members-last-member-chat-mark`: the greatest crewmate `last_chat_ts` at that open). It is never ranked by its own `last_chat_ts` (#17808): the default crew's stamp also moves for every plain chat that picked no crew, so it would win nearly always and bury the crewmate the user talked to. Instead a remembered `default` opens while no crewmate's `last_chat_ts` has moved past the mark (`rememberedDefaultPick`); once one has, that crewmate wins. Both sides are the server's clock, so a remote dashboard compares the same. The mark is the user's own open; a restore re-reads it but never re-writes it. A roster holding only `default` still shows the hero, and the most-recently-used fallback still never picks `default`. Supersedes #16311, whose roster-click-only gate (`rowPickRef`) predates the server-side last-chatted rule. Closes #17210 Co-authored-by: Helena Stafford <helenars@amazon.com>
…17972) Open the built-in `default` row on the Crewmates page, leave, come back: the page reopened a different crewmate. `activate()` never wrote `default` to the last-member memory, the restore effect never read it, and `resolveDefaultMember` skipped it twice, so once `default` was the row the user actually worked in, the page could never land on it. `default` is now remembered like any other row, with the roster's chat mark beside it (`mc-members-last-member-chat-mark`: the greatest crewmate `last_chat_ts` at that open). It is never ranked by its own `last_chat_ts` (#17808): the default crew's stamp also moves for every plain chat that picked no crew, so it would win nearly always and bury the crewmate the user talked to. Instead a remembered `default` opens while no crewmate's `last_chat_ts` has moved past the mark (`rememberedDefaultPick`); once one has, that crewmate wins. Both sides are the server's clock, so a remote dashboard compares the same. The mark is the user's own open; a restore re-reads it but never re-writes it. A roster holding only `default` still shows the hero, and the most-recently-used fallback still never picks `default`. Supersedes #16311, whose roster-click-only gate (`rowPickRef`) predates the server-side last-chatted rule. Closes #17210 Co-authored-by: Helena Stafford <helenars@amazon.com>
…ult crewmate A session is started from a template, a folder and a memory store; a crewmate is a durable identity with its own three, talked to in its DM thread. Four seams read "no crewmate picked" as "the default crewmate": the agent-less create stamped the `default` alias, the resolver answered an empty or template name with the `default` row's workspace and model pin, and the recency record credited every plain chat to the `default` crewmate -- which is why #17972 needed a client-side chat mark to keep `default` from winning the Crewmates page. A template session is now first-class in `resolve_agent_bindings`: an alias hit is the crewmate; anything else binds the named materialized template, else `default_template(config)` (`agent.default_agent`, then `kirocrew`), to `default_workspace` and Global Memory V1 with no crewmate pin, `resolved_alias` empty and `selection_kind="template"`. The default template always resolves; the "first available alias" fallback is gone. An agent-less create and an empty `/agent` switch stamp the default template in the template namespace, and a template session with no name of its own records its template as the selection. `agent or config.default_agent` fallbacks in session selection, private-store pinning and model fallback read the name alone. What counts as a chat WITH a crewmate is one rule, `crew_recency.crewmate_for_user_chat`: its DM thread, or a plain session that explicitly picked it (#17808) -- except the `default` alias outside its DM, which pre-change agent-less creates stamped on every plain slot. `""` is refused and the roster no longer folds it into the `default` row. The Members page drops the #17972 chat mark: `default` is remembered and last-chatted like any row, the most-recently-used fallback still skips it (listed by name, not by use), and a default-only roster still lands on the hero. The doctor's Model section reads the default template, not the `default` crewmate's binding. A config whose `default` crewmate binds another template than `agent.default_agent` changes: new plain sessions run `agent.default_agent`; existing sessions keep their recorded execution. Specs updated in `crew-mode.md` and `config.md`. Closes #18328
…ult crewmate A session is started from a template, a folder and a memory store; a crewmate is a durable identity with its own three, talked to in its DM thread. Four seams read "no crewmate picked" as "the default crewmate": the agent-less create stamped the `default` alias, the resolver answered an empty or template name with the `default` row's workspace and model pin, and the recency record credited every plain chat to the `default` crewmate -- which is why #17972 needed a client-side chat mark to keep `default` from winning the Crewmates page. A template session is now first-class in `resolve_agent_bindings`: an alias hit is the crewmate; anything else binds the named materialized template, else `default_template(config)` (`agent.default_agent`, then `kirocrew`), to `default_workspace` and Global Memory V1 with no crewmate pin, `resolved_alias` empty and `selection_kind="template"`. The default template always resolves; the "first available alias" fallback is gone. An agent-less create and an empty `/agent` switch stamp the default template in the template namespace, and a template session with no name of its own records its template as the selection. `agent or config.default_agent` fallbacks in session selection, private-store pinning and model fallback read the name alone. What counts as a chat WITH a crewmate is one rule, `crew_recency.crewmate_for_user_chat`: its DM thread, or a plain session that explicitly picked it (#17808) -- except the `default` alias outside its DM, which pre-change agent-less creates stamped on every plain slot. `""` is refused and the roster no longer folds it into the `default` row. The Members page drops the #17972 chat mark: `default` is remembered and last-chatted like any row, the most-recently-used fallback still skips it (listed by name, not by use), and a default-only roster still lands on the hero. The doctor's Model section reads the default template, not the `default` crewmate's binding. A config whose `default` crewmate binds another template than `agent.default_agent` changes: new plain sessions run `agent.default_agent`; existing sessions keep their recorded execution. Specs updated in `crew-mode.md` and `config.md`. Closes #18328
…ult crewmate A session is started from a template, a folder and a memory store; a crewmate is a durable identity with its own three, talked to in its DM thread. Four seams read "no crewmate picked" as "the default crewmate": the agent-less create stamped the `default` alias, the resolver answered an empty or template name with the `default` row's workspace and model pin, and the recency record credited every plain chat to the `default` crewmate -- which is why #17972 needed a client-side chat mark to keep `default` from winning the Crewmates page. A template session is now first-class in `resolve_agent_bindings`: an alias hit is the crewmate; anything else binds the named materialized template, else `default_template(config)` (`agent.default_agent`, then `kirocrew`), to `default_workspace` and Global Memory V1 with no crewmate pin, `resolved_alias` empty and `selection_kind="template"`. The default template always resolves; the "first available alias" fallback is gone. An agent-less create and an empty `/agent` switch stamp the default template in the template namespace, and a template session with no name of its own records its template as the selection. `agent or config.default_agent` fallbacks in session selection, private-store pinning and model fallback read the name alone. What counts as a chat WITH a crewmate is one rule, `crew_recency.crewmate_for_user_chat`: its DM thread, or a plain session that explicitly picked it (#17808) -- except the `default` alias outside its DM, which pre-change agent-less creates stamped on every plain slot. `""` is refused and the roster no longer folds it into the `default` row. The Members page drops the #17972 chat mark: `default` is remembered and last-chatted like any row, the most-recently-used fallback still skips it (listed by name, not by use), and a default-only roster still lands on the hero. The doctor's Model section reads the default template, not the `default` crewmate's binding. A config whose `default` crewmate binds another template than `agent.default_agent` changes: new plain sessions run `agent.default_agent`; existing sessions keep their recorded execution. Specs updated in `crew-mode.md` and `config.md`. Closes #18328
…ult crewmate A session is started from a template, a folder and a memory store; a crewmate is a durable identity with its own three, talked to in its DM thread. Four seams read "no crewmate picked" as "the default crewmate": the agent-less create stamped the `default` alias, the resolver answered an empty or template name with the `default` row's workspace and model pin, and the recency record credited every plain chat to the `default` crewmate -- which is why #17972 needed a client-side chat mark to keep `default` from winning the Crewmates page. A template session is now first-class in `resolve_agent_bindings`: an alias hit is the crewmate; anything else binds the named materialized template, else `default_template(config)` (`agent.default_agent`, then `kirocrew`), to `default_workspace` and Global Memory V1 with no crewmate pin, `resolved_alias` empty and `selection_kind="template"`. The default template always resolves; the "first available alias" fallback is gone. An agent-less create and an empty `/agent` switch stamp the default template in the template namespace, and a template session with no name of its own records its template as the selection. `agent or config.default_agent` fallbacks in session selection, private-store pinning and model fallback read the name alone. What counts as a chat WITH a crewmate is one rule, `crew_recency.crewmate_for_user_chat`: its DM thread, or a plain session that explicitly picked it (#17808) -- except the `default` alias outside its DM, which pre-change agent-less creates stamped on every plain slot. `""` is refused and the roster no longer folds it into the `default` row. The Members page drops the #17972 chat mark: `default` is remembered and last-chatted like any row, the most-recently-used fallback still skips it (listed by name, not by use), and a default-only roster still lands on the hero. The doctor's Model section reads the default template, not the `default` crewmate's binding. A config whose `default` crewmate binds another template than `agent.default_agent` changes: new plain sessions run `agent.default_agent`; existing sessions keep their recorded execution. Specs updated in `crew-mode.md` and `config.md`. Closes #18328
Leaving the Crewmates page and coming back landed on the crewmate the user last CHATTED with, not the one they had open. A row that was only clicked never moves `last_chat_ts`, so ranking the server's last-chatted crewmate above the browser memory (the order #17808 chose for the restart case) reopened a different thread on every ordinary return. The landing now reads the browser memory first (`rememberedMember`: any row still on the roster, `default` included, never a default-only roster), then falls back to the last-chatted crewmate, then to the most recently used one. localStorage survives a gateway restart, so the restart case lands on the same row the user had open; a new browser or a cleared storage still gets the server's record. The `mc-members-last-member-chat-mark` key, `chatMarkOf`, `rememberedDefaultPick` and the restore-only `stamp` branch of `activate` existed only to rank a remembered `default` against the last chat; with the memory first they have no job and are removed. `resolveDefaultMember` loses its `remembered` parameter for the same reason: every production caller passed `null`. Spec (`crew-mode.md`) and the decision record (`rfc-crewmates-chatted-list.md`, new §3.1) are amended in the same change. §3.1 also records the product owner's answer to a generalized chat-mark tie-break: a crewmate's conversation is its Crewmates thread, there is no other place to chat with one, so the memory alone is the rule. Closes #19341
Leaving the Crewmates page and coming back landed on the crewmate the user last CHATTED with, not the one they had open. A row that was only clicked never moves `last_chat_ts`, so ranking the server's last-chatted crewmate above the browser memory (the order #17808 chose for the restart case) reopened a different thread on every ordinary return. The landing now reads the browser memory first (`rememberedMember`: any row still on the roster, `default` included, never a default-only roster), then falls back to the last-chatted crewmate, then to the most recently used one. localStorage survives a gateway restart, so the restart case lands on the same row the user had open; a new browser or a cleared storage still gets the server's record. The `mc-members-last-member-chat-mark` key, `chatMarkOf`, `rememberedDefaultPick` and the restore-only `stamp` branch of `activate` existed only to rank a remembered `default` against the last chat; with the memory first they have no job and are removed. `resolveDefaultMember` loses its `remembered` parameter for the same reason: every production caller passed `null`. Spec (`crew-mode.md`) and the decision record (`rfc-crewmates-chatted-list.md`, new §3.1) are amended in the same change. §3.1 also records the product owner's answer to a generalized chat-mark tie-break: a crewmate's conversation is its Crewmates thread, there is no other place to chat with one, so the memory alone is the rule. Closes #19341
…ne (#19346) Leaving the Crewmates page and coming back landed on the crewmate the user last CHATTED with, not the one they had open. A row that was only clicked never moves `last_chat_ts`, so ranking the server's last-chatted crewmate above the browser memory (the order #17808 chose for the restart case) reopened a different thread on every ordinary return. The landing now reads the browser memory first (`rememberedMember`: any row still on the roster, `default` included, never a default-only roster), then falls back to the last-chatted crewmate, then to the most recently used one. localStorage survives a gateway restart, so the restart case lands on the same row the user had open; a new browser or a cleared storage still gets the server's record. The `mc-members-last-member-chat-mark` key, `chatMarkOf`, `rememberedDefaultPick` and the restore-only `stamp` branch of `activate` existed only to rank a remembered `default` against the last chat; with the memory first they have no job and are removed. `resolveDefaultMember` loses its `remembered` parameter for the same reason: every production caller passed `null`. Spec (`crew-mode.md`) and the decision record (`rfc-crewmates-chatted-list.md`, new §3.1) are amended in the same change. §3.1 also records the product owner's answer to a generalized chat-mark tie-break: a crewmate's conversation is its Crewmates thread, there is no other place to chat with one, so the memory alone is the rule. Closes #19341
Problem / Motivation
Goal: The Crewmates page lists only the crewmates the user actually chatted with, newest first, and reopens the last one after a gateway restart.
The crewmate switcher in the Crewmates header lists every roster row: package-installed crews, app-driven crews, crews that only ran crons, wakes or sub-agents. On a busy host that is dozens of rows. Coming back to
/membersafter a restart opens whichever row the old fallback picks, not the crewmate the user last talked to.Why it matters
The switcher is the only crewmate list on the desktop DM view. When most of its rows are crews the user never talked to, the few they did use are hard to find. Reopening the wrong crewmate after a restart puts the user in a thread they did not come back for.
Not a goal
What changed (motivation → approach → change)
Symptom → cause → change:
orderedMembers(every row)CrewmateSwitcheruntouched)listedByDefault)last_chat_ts > 0), or starred itsortRoster)last_active_ts(moves on background turns too)last_chat_tsresolveDefaultMember, URL sync effect)last_active_tslast_chat_tsfirst, then browser memory, thenlast_active_tsThe signal: nothing on main records "a person typed this". DM messages, crew-log recency and the dashboard-created flag also move for crons, wakes, patrols, workers and apps. New
src/kiro_crew/crew_recency.pykeeps{crew name: epoch}increw_recency.jsonunder the data home.POST /api/chat(dashboard/chat_handlers.py) writes to it only when the caller is the dashboard user: no app token, no cron attestation. Writes happen off the event loop, at most one per 30 s per crew. A chat with no crew picked is recorded under"", and the default crew owns it.GET /api/members(dashboard/handlers/members.py) ships the value aslast_chat_ts, typed inwebsite/src/api/client/agents.ts. On first read, a one-time seed reads each DM thread's newest typed user row. Gateway-injected rows open with[and are skipped.The record is written when the send reaches the handler. So a send whose turn later fails still counts as the user chatting with that crew. Every writer refuses to replace a file it cannot read, and a seed that could not read a thread is retried on a later read. On an accepted send,
sendTurn(website/src/chat-core/transport/sendTurn.ts) stamps the same value on the roster row bound to that slot and marks the roster stale (noteUserChatinwebsite/src/api/membersQuery.ts). A crewmate the user just messaged therefore stays listed after they switch away.docs/system-specs/modules/crew-mode.mdstates the new rules. Creating a crewmate counts too:POST /api/agents(dashboard/agent_admin/crew_records.py, owner-only, so never an app token) stamps the new crew unless an attested cron made it, so it is listed at once and sorts first. The decision record is #17816 (rfc-crewmates-chatted-list.md, amendingrfc-crewmates-launch.mdscreen 02) and #17844 (creation counts).A row with no
last_chat_ts(an older gateway) keeps the old rule, so a mixed-version deploy does not blank the list.Backwards compatibility
Compatible:
last_chat_tsis a new optional field; every existing field is still shipped, and a row without it is listed by the old rule.The diff hides rows the old rule listed (a tighter listing rule):
Reader: website/src/pages/members/MembersPage.tsx:shownMembers -- crew page -- header count and filter tallies read the same rule, so a count never includes a hidden row (MembersPage.filters.test.tsx)
Reader: website/src/pages/members/MembersPage.tsx:listedMembers -- crew page -- auto-open candidates; the last-chatted crewmate leads, and a hidden one is still opened by URL or search (
lists only crewmates the user chatted withtest)Reader: website/src/pages/members/MembersPage.tsx:sortedMembers -- crew page -- roster column; hidden rows are reachable through the search box (rosterFilter.test.ts
rosterShows)Reader: website/src/pages/members/CrewmateSwitcher.tsx:population -- crew page -- after #17835 the chip runs
rosterPopulation/rosterShows, the same rule as the column; its search reaches every row (#17835's CrewmateSwitcher.test.tsx)Tests
test/test_crew_recency.py: store round trip, write granularity, no backwards move, junk values, unreadable file is never reseeded, seed runs once and a live record wins.api_chatrecords the slot's crew for the dashboard user and""for a no-crew chat. It records nothing for an app token or a cron (mutation: forcing the guard toTrueturns both red). Roster shipslast_chat_tsand folds""into the default crew. The seed counts a typed row and skips a peer[sent by session …]row and assistant speech.rosterFilter.test.ts: listing and Recent order bylast_chat_ts; starred still listed; old-gateway fallback unchanged.MembersPage.test.tsx:lastChattedMemberoutranks memory and background recency; page opens the last-chatted crewmate and the roster lists only chatted rows, newest first; search reaches a hidden one.test/test_crew_recency.py: creating a crewmate lists it and puts it first; a crew a background writer added stays hidden; a cron-attested create records nothing.membersQuery.test.ts:noteUserChatstamps the row bound to the slot and marks the roster stale; a normal-chat slot only marks it stale.test/test_crew_recency.pyalso pins that no writer replaces an unreadable file, and that a seed hitting a busy transcript is retried, not marked done.Manual verification
Isolated
./dev-backend.shhome (throwawayKIROCREW_HOME) with 12 crews: 8 package rows,radar(dashboard-made, never chatted),default, plusscribe(chatted most recently) andoncallincrew_recency.json. Fresh browser context on/memberseach time:app-botscribescribeandoncallfirstscribescribe,oncallscribeThat throwaway home set
agent.sandbox_allow_unsandboxed_execso the page would render on a host with no sandbox. No agent turn ran in it.Screenshots / video
Before (main): the switcher lists every crew and the page opened
app-bot.After, on top of #17835: only the crewmates the user chatted with, newest first; the page opened
scribe.This PR alone, full pages, after-restart
This PR alone, before #17835: last-chatted first, but every crew still listed.
Related Issues
Designed to land with or after #17835 (one roster reading for the chip and the column), and either order rebases cleanly. This branch is based on main alone and does not contain #17835's commits. Cherry-picking it onto #17835's head
300e746ce5applies with no conflict, andsrc/pages/members/plusmembersQuery.test.tspass there (497 tests).N/A — requested directly by the user (Crew page polish, item A).
Pattern harvest
Not generalizable: the defect was a missing source (nothing recorded a person's send), not a reusable code shape.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)