Skip to content

fix(members): name the folded crewmate switcher as the roster - #18219

Merged
buluoray merged 1 commit into
mainfrom
fix/crewmates-roster-visible-18123
Oct 9, 2026
Merged

buluoray merged 1 commit into
mainfrom
fix/crewmates-roster-visible-18123

Conversation

@buluoray

@buluoray buluoray commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A first-time visitor who opens Crewmates and lands in a reopened conversation can see where the crew list is.

On desktop, a bare /members reopens the crewmate you last chatted with, and the roster folds into the header switcher chip. That chip showed only stacked faces, a number and a chevron, with no visible words. The nightly GUI user test read the page as "Crewmates skipped the member list and dropped me straight into nova-sky's existing chat" (5 sightings).

Why it matters

Every first look at the Crewmates page on desktop goes through this. A user who has chatted with a crewmate once cannot tell how to reach the others, because the only way back to the roster is a chip that does not say what it is.

Not a goal

What changed (motivation → approach → change)

  • Symptom: the folded roster did not read as the roster.
  • Cause: CrewmateSwitcher's closed chip carried its name only in aria-label/title. Sighted users saw faces + a count with no text.
  • Change: the chip now shows the page's own name, "Crewmates", as visible text between the faces and the count. This reuses the existing pages.membersPage.title key, so no new strings or locale edits. Following WCAG 2.5.3 (label in name), the accessible name now starts with that visible word ("Crewmates", or "Crewmates, Needs your approval or answer"). The action "Switch crewmate" moves to the tooltip. The tooltip now always shows only that action. The needs-you signal stays in the visible warn dot on the faces and in the accessible name, but it is no longer repeated in the tooltip.
  • The count is now drawn in the muted text colour, so the visible word "Crewmates" leads and the number reads as secondary.
  • docs/system-specs/modules/crew-mode.md (switcher section) updated to match.

Backwards compatibility

Compatible: same chip, same test ids, same popover and switching path. Only the visible text and the accessible name change.

Removes nothing: the change adds a visible label and re-words the chip's accessible name. No path, key, record or capability is removed.

Tests

  • website/src/pages/members/CrewmateSwitcher.test.tsx: the closed-chip test now checks that the visible crewmate-switcher-label reads "Crewmates", that the accessible name is "Crewmates", and that the tooltip is "Switch crewmate". The needs-you tests now expect "Crewmates, Needs your approval or answer". Mutation check: removing the label text makes the closed-chip test fail (1 failed / 15 passed). With the change in place, 16/16 pass (npx vitest run src/pages/members/CrewmateSwitcher.test.tsx).
  • npx eslint on both changed files: clean.

Manual verification

I ran website/scripts/capture-members-remember-last.mjs (real MembersPage, gateway-free) against a local vite. Frame 01-arrival is the issue's exact state: desktop /members reopens a thread, and the chip now reads "Crewmates 4 ▾" next to the identity pill, with no overlap. I captured dark theme only. The script's later back-navigation frame (04) timed out on a click and never reached a screenshot. It does not cover this chip. I did not run macOS or Windows.

Screenshots / video

After: desktop, bare /members reopens the last thread, and the header chip names the roster.

Crewmates chip with visible label

Before: see the screenshot in #18123 (faces + count only).

Related Issues

Closes #18123

Pattern harvest

Not generalizable: one chip had dropped its visible label when the roster column folded into it. Other icon-only header controls use aria-label/title on purpose and are not a lost-label case.

Decision for the owner

Clicking Crewmates should keep reopening the last conversation, and the issue asks how a first-time user is supposed to find the other crewmates from there. This draft keeps the reopen and labels the folded roster chip "Crewmates", the smallest form of the triage's recommended option, instead of opening the roster with nothing selected, which would cost every returning user an extra click.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b1c5d3a11540c2a0956d9dfffc5fa683457384b3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the page title "Crewmates" still fits in the chip next to the identity pill in long locales. The screenshot covers English, dark theme only.

[DESIGN-REVIEWED] b1c5d3a

Description read

[DESCRIPTION-READ] c4dbeb3e1c8e93625805296416e469d00a762a97ec3ef72c777f23ec38ba14ad

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b1c5d3a11540c2a0956d9dfffc5fa683457384b3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b1c5d3a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b1c5d3a11540c2a0956d9dfffc5fa683457384b3: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of b1c5d3a11540c2a0956d9dfffc5fa683457384b3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that dropping "Needs your approval or answer" from the chip's tooltip is intended. The tooltip now always reads "Switch crewmate".

What this change ships

Inventory (4 items) — 2 justified

Intent: let a first-time visitor who lands in a reopened thread see where the crew list is. This is a FIX (#18123, 5 sightings in the nightly GUI user test).

  1. The folded switcher chip now shows "Crewmates" as visible text between the faces and the count — justified
  2. The chip's screen-reader name changed from "Switch crewmate[, Needs you…]" to "Crewmates[, Needs you…]" — justified
  3. The tooltip now always says "Switch crewmate" and no longer shows the needs-you signal — undeclared: the description mentions moving the action into the tooltip but not losing the signal from it
  4. The roster count is now in muted colour, not the full-weight text colour — undeclared: a visual change the description does not mention

[FIRST-PRINCIPLES-REVIEWED] b1c5d3a

Description read

[DESCRIPTION-READ] e9d2392d50f30cc32f5930e08287d6cda1099dd43196ac293416bb2ea73e3974

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of b1c5d3a11540c2a0956d9dfffc5fa683457384b3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The blind reader identified the "Crewmates 4" chip as the crew switcher but rated it only "a guess", and confused it with the "radar Working" pill beside it.

Watch

  • Primary chip read correctly, but only as a guess. The chip now shows the word "Crewmates" (rosterLabel), and the blind reader got it right: "a list drops down where I can switch to another helper -> a guess". Severity: every first desktop visit to /members goes through this chip. It is usable, but the reader was not sure. Smallest fix: none needed in this PR beyond the two points below.
  • The chip and the identity pill read as one job. The reader said: "'Crewmates 4' at the top left and the 'radar Working' pill … look like two places for the same thing … I can't tell which one to use to change helper." The cause is that both controls show ghost faces plus a chevron side by side. Severity: the PR's goal is for a first look to find the roster, so doubt about which control to use works against that goal on every first visit. A second screenshot of the chip's popover open, with "Show the full roster" visible, would show whether the open state settles the doubt.
  • Three faces but a count of 4. The faces are the other crewmates, while the count includes the one you are talking to. The reader noticed: "Only three faces show, though, so I'm not sure what the 4 counts". The new label sits right between the faces and the number, which invites the reader to compare them. Severity: low impact, but users see it on every visit.

Suggestions

  • In CrewmateSwitcher.tsx, either make the count match the faces shown, or put the count in the tooltip (e.g. "Switch crewmate · 4 crewmates") so faces and number don't disagree.

[UX-REVIEWED] b1c5d3a

Description read

[DESCRIPTION-READ] e0f54916688436692d951abcf783d39d7d984ac91fddb6ce67302daae786abcb

That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b1c5d3a11540c2a0956d9dfffc5fa683457384b3 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b1c5d3a

Verdict parsed from the review's SHA-scoped output markers for commit b1c5d3a11540c2a0956d9dfffc5fa683457384b3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b1c5d3a11540c2a0956d9dfffc5fa683457384b3: <one-sentence reason>

@buluoray

buluoray commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Dispositions for the advisory findings on b1c5d3a115 (none blocking: Design PASS, First Principles PASS, UX CONCERNS, GPT 6.1 and Opus 5.5 no findings).

  • First Principles: the tooltip no longer carries "Needs your approval or answer". This is intended. The tooltip names the action, "Switch crewmate". The needs-you state is still shown by the visible warn dot over the faces and is still in the accessible name ("Crewmates, Needs your approval or answer"), which the switcher tests pin. The PR description now declares this.
  • First Principles: the count is now muted. This is intended, so the new word leads and the number reads as secondary. The description now declares it.
  • Design: long locales. The label is the page's own title string, pages.membersPage.title. It already renders as the page heading in every locale, and the chip is shrink-0 inside the header's left 1fr column. I did not capture a long-locale screenshot, so this is reasoned from source, not verified.
  • UX: three faces but a count of 4. This mismatch predates this PR. The stack has shown the OTHER crewmates while the count shows the whole roster since the switcher landed in feat(members): crewmate panel ia with switcher and profile card #16317, and the existing test "stacks the OTHER crewmates' faces in roster order, and says how many there are" pins it. The change is outside this PR's goal, so I'm leaving it for the owner as a follow-up.
  • UX: the chip and the identity pill look like two controls for the same job. The chip now names itself as the crew list. Separating the two further would change the header, which goes beyond this T1 fix. Also left for the owner.

No code change for any of these, so no push. CI on this head keeps running.

@buluoray
buluoray marked this pull request as ready for review October 8, 2026 23:51
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners October 8, 2026 23:51
@buluoray
buluoray requested a review from cruisercohen October 8, 2026 23:51
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 8, 2026

@CrysisDeu CrysisDeu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at b1c5d3a. Read the full diff plus the owning spec; nothing blocking. Non-blocking notes, worth a follow-up or a quick fix before merge:

  • [MINOR] website/src/pages/members/CrewmateSwitcher.tsx:170 -- the issue's stated expectation is "a list of member cards to choose from"; the PR keeps the auto-reopen of the last thread (citing #17808 / #16317) and fixes the DISCOVERABILITY of the folded roster, not the arrival behaviour the tester stalled on. That is a defensible product call and the body declares it, but it is a symptom-level fix relative to the issue text: the GUI-user lane will open a fresh issue if the next tester still reads "/members dropped me into a chat". Owner should confirm the label alone is the intended close for #18123 rather than, e.g., opening the roster popover once on first desktop arrival.
  • [NIT] website/src/pages/members/CrewmateSwitcher.tsx:170 -- the label span has no truncate/min-w-0 and the button is shrink-0 inside a grid-cols-[1fr_minmax(0,auto)_1fr] left cell (MembersPage.tsx:3703). With 3 stacked faces + label + count + chevron, a long locale at the md breakpoint can push the chip into the centred identity pill. Real catalogs are short (max fr "Coéquipiers", 11 chars; en-XA pseudo is 26 and is the only one likely to collide), so this is a watch item, not a defect; evidence is English/dark only as the Design lane already noted.
  • [NIT] website/src/pages/members/CrewmateSwitcher.tsx:32-34 -- the re-wrapped doc comment leaves one line ("crewmate, the current one marked, and a "New crewmate" footer that opens the same create dialog the") well past the surrounding wrap width; re-flow it.

@buluoray
buluoray enabled auto-merge (squash) October 9, 2026 05:27
@buluoray
buluoray merged commit 87e0701 into main Oct 9, 2026
113 checks passed
@buluoray
buluoray deleted the fix/crewmates-roster-visible-18123 branch October 9, 2026 05:28
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ux(members): Clicking Crewmates skipped the member list and dropped me straight into nova-sky's existi…

2 participants