Skip to content

fix(members): one roster reading, and no New team door for now - #17835

Merged
CrysisDeu merged 2 commits into
mainfrom
fix/switcher-hide-rule
Oct 9, 2026
Merged

CrysisDeu merged 2 commits into
mainfrom
fix/switcher-hide-rule

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Crewmates page gives one answer to "who is on my crew?", and stops offering a team you cannot finish making.

Two things on that page disagreed with themselves. The header's crewmate chip counted every row the gateway returns, while the roster column counted only the crewmates you have actually chatted with, created or starred — so one user read 2 crewmates in the column beside a chip saying 10, and another read 6 beside a chip offering 12. The chip is also the only roster affordance on the desktop DM view, so the extra rows it offered were reachable nowhere else.

Separately, the + menu still offered New team, a door into a concept that is not ready to be offered.

Why it matters

The count is the page's one-line answer to who you work with. Two numbers on one screen make both untrustworthy, and the chip let a user switch into a sync-generated template they never created and the column refuses to list. The team door is the part of an unfinished feature a first-time user is most likely to walk into.

Not a goal

  • Removing teams. An existing team still groups the roster, opens its view, and is renamed, re-membered or deleted from that view's Edit.
  • Deleting the team create path. The dialog's create mode, its labels and api.teams.create stay; hiding the door is one revertible commit.
  • Giving the chip the column's other affordances (team headers, the star, the filters, the sort). Those stay column-only.
  • Changing what the gateway returns for /api/members.

What changed (motivation → approach → change)

The chip and the column were asking the same question through different code: the column ran the roster's hide rule, the chip ran a bespoke filter over the raw list. Now there is one reading. CrewmateSwitcher calls the column's own rosterPopulation and rosterShows, so its count, its faces and its needs-you dot read the listed crewmates, and typing in its search reaches a hidden row exactly as the column's search does. The chip's one extra search term — matching a row by the agent template it runs — moved into the shared matcher, so "what the search reaches" has one definition and the column gained that term too.

Surface Before After
Header chip count every roster row the crewmates the column lists
Chip's open list every roster row the same rows, plus any the search reaches
Roster + menu New crewmate / New team New crewmate
A team that exists grouped, opened, edited unchanged

The team door is simply not drawn; the comment where it was says what returns it. The two page tests that drove it become one that pins its absence, and create-mode coverage moves to the dialog's own test, which can still reach it. The docs that named the door — the feature map, the crew-mode spec, the learn-cron-dashboard.md spec's TeamDialog line and the shipped crew-members.md user doc — now describe what the page actually offers, and the feature map also records that the folded roster runs the column's hide rule. A new capture harness under website/scripts produces the screenshots below and asserts both readings, and the existing create-page harness now expects one door.

Backwards compatibility

Compatible: no API, config key or stored shape changes; a crewmate hidden from the chip was already hidden from the column, and /api/members returns exactly what it did.

This diff takes away one UI path (the roster + menu's New team item), so every reader of team creation:

Reader: website/src/pages/members/TeamDialog.tsx:save — crew page — create mode is untouched and still posts {name, members}; covered by TeamDialog.test.tsx (gate on a name, roster-ordered body, failure notice, draft guard)
Reader: src/kiro_crew/dashboard/handlers/teams.py:api_teams_create — crew page — route, payload and validation unchanged; no dashboard door calls it while the item is hidden
Reader: src/kiro_crew/crew_teams.py:create_team — release — the operator's own kirocrew agent create / delete path into the team document is unchanged
Reader: website/src/pages/members/TeamView.tsx:team-edit — crew page — the team view's Edit still opens the same dialog in edit mode; covered by the existing MembersPage team cases
Reader: website/scripts/capture-crewmates-page-create.mjs:assertHeldMenu — release — asserted the item stayed live under a create hold; now asserts the menu offers one door
Reader: test/gui_user/scenarios/crewmate-team-view.yaml — nightly GUI run — its only purpose was to create a team through the + menu, which no longer exists; the scenario is retired (file deleted, dropped from SHIPPED and the members group in test_scenarios_and_report.py, catalog count 41 → 40 scenarios, 9 → 8 nightly), and crewmate-create-first.yaml now describes the menu as one row
Reader: src/kiro_crew/docs/crew-members.md:"Creating and editing" / "Teams" — release — the shipped user doc said the + menu had two rows and that New team creates one; it now names the one row and says team creation is not offered for now, with Edit team as the way to change an existing team

Tests

  • CrewmateSwitcher.test.tsx — an unchatted app row is neither listed nor counted while its name is still reachable by typing; the open crewmate stays listed even when the hide rule would drop it.
  • rosterFilter.test.ts — the shared search matches a row by its agent template.
  • TeamDialog.test.tsx (new) — create mode: the checklist and the one-team rule, Create gated on a name, the roster-ordered body it posts, a failed create said inside the dialog, and the unsaved-draft guard against Escape.
  • test/gui_user/test_scenarios_and_report.py — the retired nightly team scenario is gone from the shipped set and the catalog counts.
  • MembersPage.test.tsx — the + menu offers exactly one item and never opens the dialog in create mode; the draft guard now runs through the reachable Edit door.
  • 482 tests in website/src/pages/members pass.

Manual verification

Both readings were captured against a real build of this branch with a fixture roster (six chatted crewmates across two teams, beside six package templates nobody has chatted with): before, the column said 6 crewmates and the chip said 12; after, both say 6, and typing conductor in the chip still reaches five hidden templates.

One foreign red worth naming: on this machine src/test/ArtifactDetailPage.test.tsx fails six editor cases inside the lazy PierreEditor import, and it fails identically on a clean main worktree with none of these changes, so it is local dependency state, not this diff.

Screenshots / video

The roster column and the header chip in one frame, before and after.

Before: the column says 6 crewmates, the chip says 12

After: both say 6

The hidden rows are still reachable by typing, and the + menu now has one door.

Searching "conductor" reaches the hidden templates

The roster + menu offers New crewmate alone

The same pair on a two-crewmate roster

Before, two crewmates: the chip says 10

After, two crewmates: both say 2

Related Issues

Closes #17833
Closes #17834

Pattern harvest

Rule candidate: review-prompt
Pattern: a folded or collapsed view of a list filters the list itself instead of calling the full view's own filter, so the two disagree about how many items there are.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested a review from a team as a code owner October 7, 2026 20:00
@CrysisDeu
CrysisDeu requested a review from buluoray October 7, 2026 20:00
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 7, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 7, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/switcher-hide-rule branch from 300e746 to 609664c Compare October 7, 2026 23:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 53d44d9ef241ff618f93988af78b7019c51d9800 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

The RFC (docs/request-for-change/rfc-crewmates-launch.md:352, :441) still lists New team as a launch surface. Confirm a maintainer agreed to defer team creation.

[DESIGN-REVIEWED] 53d44d9

Description read

[DESCRIPTION-READ] 70b94ff93b0ff749a8f9f36766e07cec126e2b8a3b9c1b1accae248c7b508c1f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 53d44d9ef241ff618f93988af78b7019c51d9800 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Rows that appear only when you search the chip look identical to listed crewmates, so the reader would not dare click them.

Watch

  • Rows found only by search are unmarked. The search now runs rosterShows over every row, including hidden ones, and those rows render exactly like listed crewmates. In shot-03, three results (ledger, pipeline, security) are missing from the "6 crewmates" column. The blind reader's response: "no idea what clicking does to them… no, it might add them somewhere". In shot-05 the reader also asked "switching to them, or adding them?" about the extra rows. Severity: medium. It happens every time someone searches for a template, and it makes them stop instead of acting. Smallest fix: give rows outside the population a muted tag, such as "not on your roster", or a separate group heading in the search results.
  • The search looks like it has missed a match. The PR says typing conductor "still reaches five hidden templates", but shot-03 shows four rows and no scroll cue. The reader says "crew-manager-conductor is missing… this makes me trust the search less." Severity: low to medium. It is a trust problem on the exact path this PR advertises. Smallest fix: if the list scrolls, show that it does, for example with a fade or a cut-off last row. If it doesn't scroll, fix the PR's claim.
  • The one-item menu screenshot has no context. Shot-04 is cropped to the button alone, and the reader "can't tell where in the app this button is". It is grey there and purple in the chip's footer, so the reader also could not tell they are the same action. Severity: low, because it limits the evidence rather than the shipped UI. Smallest fix: re-capture the + menu open next to the "Crewmates" header.

[UX-REVIEWED] 53d44d9

Description read

[DESCRIPTION-READ] faaa32650f405abcfff8b231b5454533cf2a6be044db08969f60da891a49365c

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@CrysisDeu overrode this lane for 53d44d9ef241ff618f93988af78b7019c51d9800 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 53d44d9ef241ff618f93988af78b7019c51d9800 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 53d44d9

Verdict parsed from the review's SHA-scoped output markers for commit 53d44d9ef241ff618f93988af78b7019c51d9800.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 53d44d9ef241ff618f93988af78b7019c51d9800: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 53d44d9ef241ff618f93988af78b7019c51d9800 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 53d44d9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 53d44d9ef241ff618f93988af78b7019c51d9800: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 7, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/switcher-hide-rule branch from 609664c to 59b1819 Compare October 8, 2026 00:20
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 8, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/switcher-hide-rule branch from 59b1819 to 4b18f54 Compare October 8, 2026 00:49
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 8, 2026
@CrysisDeu
CrysisDeu force-pushed the fix/switcher-hide-rule branch from 4b18f54 to bb76105 Compare October 8, 2026 03:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 8, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 9, 2026
The Crewmates column lists rows through `rosterPopulation` / `listedByDefault`
-- created, chatted-with, starred rows and the default crew -- while the header
chip's `CrewmateSwitcher` was handed the raw roster and listed everything, so a
user with two crewmates read "2 crewmates" beside a chip that said 10 and
offered every sync-generated template.

The switcher now runs the same two functions over the same roster: the count,
the face stack and the needs-you cue read the listed population, and a typed
search falls back to the full roster exactly as the column's search does. The
chip's agent-template search term moves into the shared `matchesSearch`, so one
definition of "what the search reaches" serves both placements.
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 2911745: same maintainer decision as on bb76105 (R8 = R7 rebased onto main a098d44; feature-map Crew Members row merged three-way with #17836) -- New team stays hidden for the current phase; decision recorded in #17834.

@CrysisDeu
CrysisDeu force-pushed the fix/switcher-hide-rule branch from b24e086 to 2911745 Compare October 9, 2026 06:29
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 29117454fee83546a52f27c4720e7deea5044e29.

same maintainer decision as on bb76105 (R8 = R7 rebased onto main a098d44; feature-map Crew Members row merged three-way with #17836) -- New team stays hidden for the current phase; decision recorded in #17834.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for 29117454fee83546a52f27c4720e7deea5044e29 manually from the Actions tab.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 9, 2026
Teams are not ready to be offered as something to create, so the roster
header's "+" no longer carries New team: its only door is New crewmate.
Everything a team already has keeps working -- the roster groups by team,
a group header opens its team view, and that view's Edit still opens the
dialog in edit mode.

The dialog's create mode, its labels and `api.teams.create` all stay, so
the door comes back by reverting this commit. The two page cases that
drove the removed item become one that pins its absence, and create-mode
coverage moves to TeamDialog's own test, which can still reach it.
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 53d44d9: same maintainer decision as on bb76105 (R9 = R8 with the feature-map Crewmate chat row restored to main's, per GPT F1) -- New team stays hidden for the current phase; decision recorded in #17834.

@CrysisDeu
CrysisDeu force-pushed the fix/switcher-hide-rule branch from 2911745 to 53d44d9 Compare October 9, 2026 06:38
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 53d44d9ef241ff618f93988af78b7019c51d9800.

same maintainer decision as on bb76105 (R9 = R8 with the feature-map Crewmate chat row restored to main's, per GPT F1) -- New team stays hidden for the current phase; decision recorded in #17834.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for 53d44d9ef241ff618f93988af78b7019c51d9800 manually from the Actions tab.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 9, 2026
@CrysisDeu
CrysisDeu merged commit e2fc9f5 into main Oct 9, 2026
102 of 103 checks passed
@CrysisDeu
CrysisDeu deleted the fix/switcher-hide-rule branch October 9, 2026 07:32
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crewmates: hide the New team door for the current phase Crewmates: the switcher chip and the roster column disagree about who is on the crew

3 participants