Skip to content

docs(rfc): list only the crewmates the user chatted with, newest first - #17816

Merged
bolichen97 merged 1 commit into
mainfrom
docs/rfc-crewmates-chatted-list
Oct 7, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/rfc-crewmates-chatted-list

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the product owner's decision that the Crewmates list shows only the crewmates the user chatted with, newest first, and reopens the last one.

#17808 changes what every user sees on the Crewmates page: which rows are listed, their order, and which crewmate opens on a bare /members. That is a product-shape change. The First Principles lane reads the decision for it from an RFC on the base branch.

Why it matters

Without the decision on main, #17808 cannot merge. The rule it replaces is written in rfc-crewmates-launch.md screen 02 and in docs/system-specs/modules/crew-mode.md.

Not a goal

What changed (motivation → approach → change)

  • New docs/request-for-change/rfc-crewmates-chatted-list.md, accepted. It amends rfc-crewmates-launch.md screen 02 with a before/after table for the listing, switcher, order and landing rules. It also gives the reasons and the rejected alternatives.
  • docs/request-for-change/README.md: one index row.

Backwards compatibility

Removes nothing: documentation only; no code, config or data path changes.

Tests

N/A — documentation only. scripts/docs-lint.sh passes.

Manual verification

N/A — documentation only.

Related Issues

Implements the decision for #17808.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Records the product owner's 2026-10-07 decision amending
rfc-crewmates-launch.md screen 02: the Crewmates list and switcher show
only crewmates the user sent a message, ordered by that, and the landing
opens the last one. Implementation: #17808.
@iamwhatever
iamwhatever requested a review from a team as a code owner October 7, 2026 18:58
@iamwhatever
iamwhatever requested a review from buluoray October 7, 2026 18:58
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6e6c5138aadfcf66f76829d478bb43c172b5e7b4 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6e6c513

Verdict parsed from the review's SHA-scoped output markers for commit 6e6c5138aadfcf66f76829d478bb43c172b5e7b4.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6e6c5138aadfcf66f76829d478bb43c172b5e7b4: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6e6c5138aadfcf66f76829d478bb43c172b5e7b4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6e6c513

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6e6c5138aadfcf66f76829d478bb43c172b5e7b4: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6e6c5138aadfcf66f76829d478bb43c172b5e7b4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that #17808 rewrites crew-mode.md §Landing rule (lines 793–832) in the same commit. That section still states the rule this RFC replaces.

Suggestions

  • Add a one-line "amended by rfc-crewmates-chatted-list.md" note to screen 02 of rfc-crewmates-launch.md. As it stands, someone reading that screen sees the old listing rule with nothing pointing to this amendment.

[DESIGN-REVIEWED] 6e6c513

Description read

[DESCRIPTION-READ] 9c2d6fb9ed80abcfe129092a7c2f635276a5d0d95c356f2e58c228299ad16931

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 7, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. CI green on this head.

@bolichen97
bolichen97 merged commit cacb1bd into main Oct 7, 2026
101 checks passed
@bolichen97
bolichen97 deleted the docs/rfc-crewmates-chatted-list branch October 7, 2026 20:00
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 7, 2026
iamwhatever pushed a commit that referenced this pull request Oct 8, 2026
Amends rfc-crewmates-chatted-list.md (#17816): the user's own create
(POST /api/agents, owner-only, not cron-attested) stamps the new crew so
it is listed at once and sorts first; crews added by the agent sync, an
app or background work are not stamped. Names #17835, whose shared hide
rule the switcher runs. Implementation: #17808.
iamwhatever added a commit that referenced this pull request Oct 8, 2026
Amends rfc-crewmates-chatted-list.md (#17816): the user's own create
(POST /api/agents, owner-only, not cron-attested) stamps the new crew so
it is listed at once and sorts first; crews added by the agent sync, an
app or background work are not stamped. Names #17835, whose shared hide
rule the switcher runs. Implementation: #17808.

Co-authored-by: Joe Guo <zejiangg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants