Repository navigation
feat: welcome users with Mate, a first crewmate they get to name - #18317
Conversation
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The Mate row appears outside the Crewmates preview. Upgraded users with the preview off will see an unexplained new crew, which contradicts the description. Watch
Suggestions
[DESIGN-REVIEWED] 46db236 Description read[DESCRIPTION-READ] e470f26b132d98dd8fe82d1d04ffd6635fbe8110a2175eaaa2df3a1838ffbd1d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing the new "first greeting could not be started" notice and its Retry button, which no screenshot shows. Evidence gaps
Watch
Suggestions
[UX-REVIEWED] 46db236 Description read[DESCRIPTION-READ] 2cd80b3d7a1bf18c71d0f44f030b6e4569d8ac69f4430ba602b167e244896a50 That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK product-shape change without accepted RFC: every install now gets a crewmate it never asked for, plus a model-written welcome that Not justified as shipped
What this change shipsInventory (10 items) — 3 justifiedIntent: give a newcomer a crewmate that talks first and gets named by them. This is an ADDITION.
Blockers
[FIRST-PRINCIPLES-REVIEWED] 46db236 Description read[DESCRIPTION-READ] 0ba610ef04ec59f87bec046707ff008b04d37fbb4f1960edc965c695d073ed10 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 is real: no production component renders
🏷️ Fenced finding(s) machine-flagged as likely edge caseThe security fence keeps these findings blocking regardless of adjudication; the only clearance path is a human override. The annotate-only pass judged the condition combination each one requires extreme, and pre-drafted the override rationale below. A repository writer must independently verify a rationale before posting it — it is machine-authored, and a wrong override on a security-class finding ships exactly the class the fence exists to stop.
False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Record the product owner's 2026-10-08 decision, taken after the team review, so the First Principles lane can read it from the base branch when #18301 and #18317 change default mounts and first-visit landing. Part 1: one read-or-offer MCP server, kirocrew-guide, mounted for the kirocrew template, its crewmates, worker and dashboard sessions. Guides highlight the real control and change cards apply only on the user's press, from a dashboard turn the user sent; trust-root areas are answered in words only. Part 2: Kiro Crew creates one ordinary crewmate, Mate, once. It opens first on the Crewmates page while never chatted with, writes its own welcome, and renames itself through rename_self. default stays the shared fallback crew. The document amends sections of rfc-crewmates-launch, rfc-crewmate-greeting and rfc-crewmates-chatted-list rather than editing those accepted documents. The index gains its row and audit note.
3637e85 to
639dc8c
Compare
Every install, fresh or upgraded, creates one ordinary crewmate once, shown as Mate while it has no display name. It is bound to the ordinary crewmate template, gets its own private memory store, and can be renamed, rebound or deleted like any other; a deleted one is never re-created, and a crewmate the user already keeps under the key mate is left as it is. The first time Mate's own thread opens empty, it speaks first with one hidden kickoff turn. Only the first-crewmate step owes that welcome, recorded in the member's directory, and the claim is an O_CREAT|O_EXCL marker so two tabs, a reload or a retry never greet twice. The welcome explains in everyday words what a crewmate is and invites the user to give Mate a name; a user who already has crewmates hears Mate introduce itself as one more teammate. A crewmate the user creates on the dashboard keeps greeting through the create flow's seeded first turn. When the user answers with a name, Mate calls the new kirocrew-guide tool rename_self. It renames only the calling crewmate, derived from the caller's own pinned thread, only from a turn sent in the dashboard, and the new label reaches the open chat and the roster through the member/config projection with no reload or confirm card. With the Crewmates preview on, a bare visit to the Crewmates page opens Mate while no message has been exchanged with it, ahead of a remembered crewmate, and that visit does not also announce Meet CrewMates; after that the page lands and announces as before. With the preview off nothing about Mate is shown: no landing and no welcome.
c3ea98a to
46db236
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Problem / Motivation
Goal: Give a new user one ready crewmate, Mate, that opens the conversation itself, explains what crewmates are and lets the user give it a name of their own, and have every crewmate the user creates greet them with its goal, so nobody starts in front of an empty chat.
Stacked on #18301 (crewmate guides and change cards); review that one first. The diff here is only the commit on top of it. With it, any crewmate can find controls and prepare changes, but an install still starts with no crewmate that talks first: the user has to know what to ask, and what a crewmate is, before anything happens. A crewmate the user creates on the dashboard already greets with its goal through the create flow's seeded first turn on main; this PR keeps that and adds none of its own.
Why it matters
The first minutes decide whether someone keeps using Kiro Crew. A crewmate that is already there, speaks first, and explains in plain words what it and other crewmates can do turns the guide and card tools from the platform PR into something a newcomer actually meets. Naming it is the first thing the user does with a crewmate, and seeing the name change at once shows that crewmates are theirs to shape.
Not a goal
defaultmember into Mate: it stays the shared fallback crew, its template and conversations untouched.What changed (motivation → approach → change)
Approach: reuse the ordinary crewmate create path, the member event log the page already folds, and the platform guide tools; add a once-only pre-create, a once-only hidden first turn for Mate, and one narrow self-rename tool.
agent_materialization/first_crewmate.py): every install, fresh or upgraded, creates one ordinary crewmate once (keymate, shown as Mate while it has no display name), bound to the ordinary crewmate template with its own private memory store. A marker records that it ran and whether it wrote the row, so deleting Mate never brings it back, and a crewmate the user already keeps under the keymateis left alone, memory binding included.dashboard/mate_welcome.py,website/src/pages/members/useFirstGreeting.ts): the first time Mate's own thread opens empty, the gateway starts one hidden kickoff turn. Only the first-crewmate step owes it; the claim is anO_CREAT|O_EXCLmarker in the member's directory, so two tabs, a reload or a retry never greet twice. The welcome explains in everyday words what a crewmate is and invites the user to give Mate a name. A user who already has other crewmates hears Mate introduce itself as one more teammate, not as their first.kirocrew-guidetoolrename_self,POST /api/guide/agent/rename,members.rename_member_display): when the user answers with a name, Mate renames itself. The member renamed is the caller's own pinned thread, never an argument; only a turn sent in the dashboard may call it, like every agent-half guide route; the name is cleaned and checked againstMEMBER_NAME_MAX_CHARS, and the default crew is refused. The rename is amember/configevent, so the open chat header and the roster show the new name at once, with no reload and no confirm card.MembersPage.tsx,rosterFilter.ts): with the preview on, a bare visit opens Mate while no message has been exchanged with it, ahead of a remembered crewmate, as an early rule of its own; after that the page lands as before. While that Mate is still owed its first visit, Meet CrewMates does not open on its own, neither at the end of the tour nor on a Crewmates page visit, so it never covers Mate's welcome; once Mate has history, or was deleted, the flow opens as on feat: let any crewmate guide users to the control on their screen #18301 (useMeetCrewmatesGate.ts, readingpendingMatefromlib/assistantMember.ts). Mate is listed from the start; every other row keeps feat: let any crewmate guide users to the control on their screen #18301's listing rule, including the rule for rows from older gateways.crewmateBubbles.ts,useCarryHeldAnswer.ts,GuideMateNote.tsx): folds the narration written before a tool call, and a guide note offered from Mate's thread names Mate while it has no display name.Moving parts the bullets above do not name:
agent.py,agent_files.py,agent_materialization/__init__.pymatekey and its default display name.src/kiro_crew/members.py,memory_stores.pyrename_member_displayand the welcome-owed marker; at startup, give the Mate row the first-crewmate step wrote, if it still points at Global memory, its own private store.mcp_guide.py,validation.py,config/defaults.jsonrename_selftool, its argument schema and its exact-name grant.src/kiro_crew/docsui-index.generated.json;agent-spec-fields.mdnames the first crewmate.store/chatSlice.ts,store/chat/runState.ts,website/src/apiapp-sdk/messageRenderers.tsx,pages/chat/*,components/AgentSelector.tsx,pages/KiroCrewAgentsPage.tsx,pages/members/CrewNotesTab.tsxwebsite/src/cards,guide/findByName.ts,uiLocations/areas/members.tshooks/useMeetCrewmatesGate.tshasNoCrewmatescounts Mate as a crewmate; both automatic triggers wait for the roster while the Crewmates preview is on and stay shut for the session if Mate is still owed its first visit.website/scriptswebsite/src/i18nBackwards compatibility
Compatible: existing installs keep their members and conversations. An upgraded install gains Mate once, as an added member created through the existing create path, with a welcome worded for a user who already has crewmates; nothing existing is renamed, rebound or reserved, and a row the user already keeps under the key
mateis left as it is.Reader: website/src/hooks/useMeetCrewmatesGate.ts:useMeetCrewmatesGate -- first run and crew page -- with the Crewmates preview on, neither the tour-end nor the page-entry auto-open fires while Mate exists with no chat history, and one held that way stays held for the session; with Mate chatted with, deleted, the roster unreadable, or the preview off, both fire exactly as on #18301 (useMeetCrewmatesGate.test "the tour ending does not open the flow while Mate exists and has never been chatted with", "the tour ending still opens the flow once Mate has history", "the tour ending still opens the flow when Mate was deleted", "a Crewmates page entry does not open the flow while Mate has never been chatted with")
Tests
test_first_crewmate_ordinary.py(created once, ordinary, deletable, never re-created),test_welcome_owed.py(only the first-crewmate step owes a welcome, on an upgrade with other crewmates too; a dashboard or CLI create owes none),test_mate_welcome.py(kickoff turn, refusals, the first-crewmate wording alone and the one-more-teammate wording beside other crewmates),test_mate_rename_self.py(renames only the caller, refuses a channel or non-dashboard turn, a non-crewmate thread and the default crew, refuses a turn the user did not send, cleans the name; the welcome asks for Mate's name in plain words and states principles rather than prohibitions),test_assistant_agent.py(a user's ownmaterow keeps its Global binding at the next start; a created Mate left on Global is moved), updatedtest_change_cards.py, guide-route and composition-contract tests.useFirstGreeting.test.tsx,ChatPane.mateChat.test.tsx,KiroCrewAgentsPage.mateDisplayName.test.tsx,useCarryHeldAnswer.test.ts,assistantMember.test.ts,rosterFilter.test.ts(Mate listed, feat: let any crewmate guide users to the control on their screen #18301's rule otherwise), Members page cases (never-chatted Mate beats a remembered crewmate, a chatted one does not, preview off lands and greets nothing, only Mate's thread asks for a welcome, Meet CrewMates not announced over Mate's landing and announced once Mate has history),useMeetCrewmatesGate.test.tsx(tour-end and page-entry both held while Mate is owed its first visit, tour-end still held after Mate's history arrives in the same session; both fire once Mate has history or is deleted; nothing held with the preview off).Manual verification
Run on a preview gateway built from an earlier head of this branch, fresh data home, Crewmates preview on, real model turns: Mate opened on the first Crewmates visit and greeted first; "Call you Pebble" renamed it in the header, composer, switcher and roster with no reload; with the preview off there was no Crewmates rail entry and no welcome. Not re-run on this head: the welcome wording for a user who already has crewmates, and Meet CrewMates staying shut over Mate's landing (both covered by the tests above). Gates on this head: black, isort, flake8, mypy,
tsc,npm run build, the i18n checks withI18N_BASE_REF=origin/main, and the related pytest and vitest sets. Not exercised: Windows and macOS hosts.Screenshots / video
All frames are real model turns on a preview gateway built from earlier heads of this branch. Since then the welcome wording changed (plain words, a variant for a user who already has crewmates), so greeting text differs from a run on this head.
/memberstyped directly shows no welcome and no Crewmates rail entryRelated Issues
Part of #18315
Stacked on #18301; together they replace #15326.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.