Repository navigation
feat: welcome users with Mate, a first crewmate they get to name - #18406
Conversation
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Crewmate IDs are now hidden in every picker, which reverses a test that said they must stay visible. That change sits outside the Goal and is bundled into the Mate PR. Watch
[DESIGN-REVIEWED] 5f1a0e4 Description read[DESCRIPTION-READ] fd1a394a8ccc89a6b823f535bf12a3ddc1f559a08389c08d28e64759cc9eec8e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@buluoray overrode this lane for |
UX Review (Opus 5.5) — ✅ human override accepted@buluoray overrode this lane for |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
ed5b74c to
6dd9d77
Compare
6dd9d77 to
ab68b31
Compare
ab68b31 to
2fdd164
Compare
|
AI-review override not recorded: keep the reason to 500 characters or fewer. |
|
/ai-review override first-principles 40c35f1: Product owner decision: crewmates are shown by display name only. The crew ID is a slug of the first name typed, so beside the name it repeats it, goes stale after a rename (Pebble shown with |
|
/ai-review override ux 40c35f1: Product owner decision to land this head without recapturing. The three missing stills (picker without the ID, Customize crew cards, picker with the preview off) are evidence gaps, not defects: the ID-less picker and header are pinned by |
Sensitive change review
|
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
GPT 6.1 on 40c35f1
|
|
/ai-review override first-principles 5232113: Product owner decision: crewmates are shown by display name only. The crew ID is a slug of the first name typed, so beside the name it repeats it, goes stale after a rename (Pebble shown with |
|
/ai-review override ux 5232113: Product owner decision to land this head without recapturing. The three missing stills (picker without the ID, Customize crew cards, picker with the preview off) are evidence gaps, not defects: the ID-less picker and header are pinned by |
Sensitive change review
|
Every install, fresh or upgraded, gains one ordinary crewmate, Mate, created once. With the Crewmates preview on, the first visit opens Mate, which speaks first: one hidden kickoff turn asks the model to explain in plain words what a crewmate is, what it can help with, and what the user would like to call it. When the user answers, Mate calls the new kirocrew-guide tool rename_self, and the header and roster show the new name at once. With the preview off, Mate is hidden from every list that names crew. kirocrew-guide is a new always-mounted platform server. This change carries its registration, the one-time grant on existing specs, and the gateway admission its tools share: only a turn the user sent from the dashboard may call it, never a channel message, schedule, subagent, app or the hidden welcome kickoff. Mate is deletable and renamable like any crewmate, never re-created after deletion, and a crewmate the user already keeps under the key mate is left alone. The decision is recorded in docs/request-for-change/rfc-crewmate-guides-and-mate.md.
|
/ai-review override first-principles 5f1a0e4: Product owner decision: crewmates are shown by display name only. The crew ID is a slug of the first name typed, so beside the name it repeats it, goes stale after a rename (Pebble shown with |
|
/ai-review override ux 5f1a0e4: Product owner decision to land this head without recapturing. The three missing stills (picker without the ID, Customize crew cards, picker with the preview off) are evidence gaps, not defects: the ID-less picker and header are pinned by |
Sensitive change review
|
|
AI-review override not recorded: |
|
/ai-review override ux 5f1a0e4: Product owner decision to land without recapturing. The missing stills (picker and Customize card without the ID, picker with the preview off) are evidence gaps, not defects: the ID-less picker and header are pinned by AgentDropdownList.test.tsx and MembersPage.test.tsx, which redden when the ID span returns, and hideMateWithoutPreview is unchanged since the last capture. The Customize fallback wording for Mate is a follow-up. |
Human judgment recorded@buluoray marked the ux AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override first-principles 5f1a0e4: Product owner decision: crewmates are shown by display name only. The crew ID is a slug of the first name typed, so beside the name it repeats it, goes stale after a rename (Pebble shown with |
Human judgment recorded@buluoray marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: Give every user one ready crewmate, Mate, that welcomes them on the Crewmates page, explains in plain words what a crewmate is, and lets them give it a name of their own.
A person who opens the Crewmates page for the first time finds no crewmate at all: nothing speaks first, and they have to know what to ask and what a crewmate is before anything happens. The decision is recorded in
docs/request-for-change/rfc-crewmate-guides-and-mate.md(accepted, merged in #18326). This is the first of three PRs that ship that RFC, in order: Mate (this one), then guided tours (#18301), then change cards.Why it matters
The first minutes decide whether someone keeps using Kiro Crew. A crewmate that is already there, speaks first and asks to be named is the first thing a newcomer does with crewmates, and seeing the name change at once shows that crewmates are theirs to shape.
Not a goal
defaultmember into Mate: it stays the shared fallback crew.What changed (motivation → approach → change)
Approach: reuse the ordinary crewmate create path and the member event log the page already folds; add a once-only create, a once-only hidden first turn, and one self-rename tool on a new platform server that the next two PRs extend.
agent_materialization/first_crewmate.py): every install, fresh or upgraded, creates one ordinary crewmate once (keymate, shown as Mate while it has no display name) on the ordinary crewmate template with its own private memory. A marker records the attempt, so a deleted Mate never comes back, and a row the user already keeps undermateis left alone. It is created the way every crewmate is (in-memory row,provision_member_memory,persist_member_config(create=True)), so it is never on Global memory; a failed creation leaves nothing and is tried again at next start.dashboard/mate_welcome.py,handlers/members.pyPOST /api/members/{slug}/greet,pages/members/useFirstGreeting.ts): the first time Mate's thread opens empty, the gateway starts one hidden kickoff turn, claimed with anO_CREAT|O_EXCLmarker so two tabs or a retry never greet twice. The kickoff states principles; the model writes the welcome: what a crewmate is, that it can help set Kiro Crew up, fix problems or show the user around, and what the user would like to call it. A user who already has crewmates hears it introduce itself as one more teammate. A greeting request that fails shows nothing: the chat works without it, and the next open asks again.kirocrew-guideserver and live rename (mcp_guide.py,dashboard/handlers/guide.py,src/kiro_crew/members.pyrename_member_display): a new always-mounted platform server, granted by exact tool name through theallowedToolsceiling (agent._GUIDE_AUTO_GRANTS), once on an existing spec (agent_materialization/guide_platform.py). Its one tool,rename_self, renames only the caller's own crewmate thread. The shared admission_resolve_agent_calleradmits only a turn the user sent from the dashboard, reading the opener provenancechat_runner.pynow records (_turn_channel_origin,_turn_user_sent); a channel message, schedule, subagent, app or the hidden kickoff gets 403. The rename is amember/configevent, so header and roster update at once.MembersPage.tsx,rosterFilter.ts,hooks/useMeetCrewmatesGate.ts): with the preview on, a never-chatted Mate opens first and Meet CrewMates stays shut over it; afterwards the page lands as on main. With the preview off, the agent pickers, Customize and a template's crew list leave Mate out (hideMateWithoutPreviewinlib/assistantMember.ts). Every place that names a crewmate (both agent pickers, Customize, the Crewmates header) shows its display name only, never its ID; the picker still matches a search on either.Smaller pieces:
memory_stores.pycreates a member'smemory/directory owner-only (0700);agent.py,agent_files.py,agent_materialization/__init__.pyandservice_agents.pymount the server and keep it off background agents;cli.py,cli_doctor.py,src/kiro_crew/doctor_checks,mcp_core.py,mcp_discovery.py,src/kiro_crew/mcp_gateway,mcp_cleanup.py,src/kiro_crew/onboarding_sources,security_posture.py,validation.pyandconfig/defaults.jsonregister it, its argument schema and its grant;dashboard/server.py,server_runtime/mcp_routes.py,dashboard/state.py,routes/agents.pyandhandlers/__init__.pywire the routes and the provenance fields;website/src/api,website/src/store,website/src/app-sdk,website/src/components(ChatPane, AgentSelector, crew editor, chat bubbles),pages/chat/*,pages/KiroCrewAgentsPage.tsx,hooks/useAgents.tsandwebsite/src/libcarry Mate's label, its narration folding and the preview gate;website/src/i18nadds two strings in 12 locales;src/kiro_crew/docsanddocs/cover MCP, MCP shareability, crew mode, memory and the feature map;test/gui_useradds a scenario.Backwards compatibility
Compatible: existing installs keep their members and conversations. An upgraded install gains Mate once as an added member; nothing existing is renamed, rebound or reserved, and the new server's routes accept nothing main accepted before.
Reader: website/src/hooks/useMeetCrewmatesGate.ts:useMeetCrewmatesGate -- first run and crew page -- with the Crewmates preview on, neither the tour-end nor the page-entry auto-open fires while Mate exists with no chat history; with Mate chatted with, deleted, the roster unreadable, or the preview off, both fire as on main (
useMeetCrewmatesGate.test.tsx)Reader: website/src/hooks/useAgents.ts:useAgents -- chat composer, Customize -- with the Crewmates preview off, the row keyed
mateis left out of the agent lists; every other row is listed as on main (useAgents.hideMate.test.tsx)Tests
test_first_crewmate_ordinary.py,test_welcome_owed.py,test_mate_welcome.py,test_mate_rename_self.py(renames only the caller, refuses a non-crewmate thread, the default crew and a turn the user did not send, cleans the name; the kickoff asks for Mate's name and states principles),test_guide_server.py(always mounted, per-tool grant, governance ceiling, one-time grant, background agents without it, first-crewmate creation, off-dashboard wording),test_guide_admission.py(real admission: channel turns, channel steers, non-user turns refused; the runner records the provenance), plus updated composition, spec-byte, MCP registry and doctor contracts.useFirstGreeting.test.tsx,ChatPane.mateChat.test.tsx,useAgents.hideMate.test.tsx,useMeetCrewmatesGate.test.tsx,assistantMember.test.ts,rosterFilter.test.ts, Members page and crew-editor cases._USER_TURN_OPERATIONSreddenstest_a_turn_the_user_did_not_send_is_refusedandtest_only_a_turn_the_user_sent_can_rename; removing the channel check reddenstest_a_channel_turn_on_the_mirrored_slot_is_refusedandtest_a_dashboard_turn_narrowed_by_a_channel_steer_is_refused.Manual verification
On a preview gateway built from this head (fresh data home, real model turns): the roster held
defaultandmate; Mate's row carried its ownmember_idand private store, andmembers/mate/was mode 0700. With the Crewmates preview off, the chat agent picker listed no Mate. After turning the preview on in Settings → Developer, opening Mate's thread showed it busy and empty while the hidden kickoff ran, then Mate greeted first ("Hi. I'm Mate. I'm your first crewmate…", three offers, ending on "What would you like to call me?"). Replying "Call you Pebble" got "I go by Pebble now." and the header and composer showed Pebble with no reload. Mate's replies draw as ordinary bubbles, the same as every crewmate's. With the preview on, the chat agent picker lists the renamed crewmate as "Pebble" (that run was on the previous head, which still drewmatebeside it; the current head draws the name alone, pinned byAgentDropdownList.test.tsxandMembersPage.test.tsx).4k tests) and vitest (about 2k tests). Not exercised: Windows and macOS hosts.Screenshots / video
One continuous run on the preview gateway above, on this head, fresh data home: Mate's thread while its first greeting runs; the welcome; after "Call you Pebble"; the chat agent picker naming it Pebble (captured on the previous head, so the grey
mateID beside it is gone on this head); Pebble's editor in Customize.Related Issues
Closes #18315
Part of the RFC in #18326; followed by #18301 (guided tours) and a change-cards PR.
Pattern harvest
Not generalizable: a feature PR.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.