Repository navigation
feat(crew): fold the crewmate header pill to its face, and draw the loop mark as a solid ring - #18549
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a crewmate's face alone is enough to tell whose DM is open on desktop. At rest the name now shows only on hover or focus. [DESIGN-REVIEWED] 0b241ef Description read[DESCRIPTION-READ] 1dd6fa55c4ed9907efd142975a54539a7522f32921fc5551946cac16271e1253 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that #18547 actually asks for the crewmate's name to be hidden at rest. Every mouse user now sees only a face until they hover. What this change shipsInventory (7 items) — 7 justifiedIntent: give the transcript back the space the crewmate header pill covers, and make a running loop easy to spot at a glance. This is an ADDITION (presentation only).
[FIRST-PRINCIPLES-REVIEWED] 0b241ef Description read[DESCRIPTION-READ] c8925c1944e9bc389bdfb018ce0bb58680aa3fdf59011ba70c55eedc3cc48a7c That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS At rest the pill no longer shows the crewmate's name, and its loop ring has no words next to it, so both identity and loop state come down to guessing from a face. Watch
[UX-REVIEWED] 0b241ef Description read[DESCRIPTION-READ] 4f4ca43a22c1f0e258099497146ff425acdc7ecaf3f11dc6b71666b13834239f That sha256 names everything this verdict read: the PR description, plus the 29 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
4c40ba3 to
bd8ec46
Compare
|
|
|
|
|
|
|
|
|
|
|
bd8ec46 to
591924d
Compare
|
|
|
|
|
|
|
|
9f1193d to
fd437e9
Compare
…oop mark as a solid ring The DM header identity pill now shows only the face (with its loop mark) and the chevron at rest. The name and activity line fold into a zero-width grid column that slides open on hover or keyboard focus (cut under reduced motion); folded they stay in the DOM, so the crewmate still names the button. A screen with no hover keeps them open. Capture harnesses that waited for the title row to be visible now wait for the pill. The loop-on mark is a solid 2px accent ring with a larger orbiting dot, and the ring now stays under prefers-reduced-motion (only the orbit swaps for a still dot). Closes #18547
fd437e9 to
0b241ef
Compare
|
|
|
|
|
|
|
|
Problem / Motivation
Goal: On a crewmate DM, the header pill takes as little room as it can, and a user can see at a glance when a crewmate's loop is on.
The floating identity pill (#18332) always showed the face, name, ID, activity line and chevron, so it covered more of the conversation than it needed to. The loop-on mark (#17910) was a faint 1px ring with a 6px dot; the user could not tell where to look to see a loop was on. Under reduced motion even the ring went away. The word "On watch" did not say what the loop does.
Why it matters
The pill floats over the transcript, so every pixel it takes hides conversation. A loop that acts on its own without a clear sign surprises the user when the crewmate speaks up unasked.
Not a goal
isLoopOn), the activity text (pillActivity.ts), or the face flight / floating Profile behaviour.title.What changed (motivation → approach → change)
0frat rest and1frongroup-hover/group-focus-visible, withoverflow-hiddenon its child. A0fr → 1frcolumn is how the width animates (transition-[grid-template-columns], 200ms,motion-reduce:transition-none); padding is fixed, so nothing else jumps. Folded, the words stay in the DOM, so the crewmate is still the button's accessible name.[@media(hover:none)]) keeps the column open at rest, since a tap opens Profile and never sets:focus-visible.CrewLoopIndicator): a solid 2px accent ring (was 1px at 40%) and an 8px orbiting dot (was 6px). The ring does not move, so it now stays under reduced motion; only the orbit swaps for the still dot. Still accent, never the working state's green. The roster row uses the same component, so it reads the same with no row change.docs/system-specs/modules/crew-mode.mdon the compact pill and the mark.website/playwright/member-memory.spec.ts: three checks that the header showed the crewmate's name as visible text now check the pill is visible and holds the name (folded text is in the DOM, not painted).scripts/lib/crew-pod-harness.mjs,capture-avatar-entry-affordance.mjs,capture-members-activity-days.mjs,record-members-activity-days.mjs) waited formember-title-rowto be visible; folded it has zero width, so they now wait formember-identity-pill.Backwards compatibility
Compatible: no API, route, key, prop or copy changes.
The diff hides the pill's words at rest. Readers of that text:
Reader: website/src/pages/members/MembersPage.tsx:member-pill-activity-sr -- crew page -- the screen-reader copy outside the button is unchanged
Reader: website/src/pages/members/MembersPage.loop.test.tsx:'the open thread header shows it too' -- crew page -- reads
textContent, which a folded column keepsReader: website/scripts/capture-members-pill-activity.mjs:readLine -- crew page -- reads
textContentanddata-activity, both unchangedReader: website/scripts/capture-members-header-identity-pill.mjs:stills -- crew page -- checks the name is in the pill's text and
member-title-rowexists; both still hold (folded content stays in the DOM)Tests
CrewLoopIndicator.test.tsx: the ring is no longermotion-reduce:hidden, never animates and isborder-2; the orbit still spins and hides under reduced motion.MembersPage.loop.test.tsx: new case "the header pill is compact at rest": the fold isgrid-cols-[0fr]with the hover, focus-visible and no-hover openers, animatesgrid-template-columnsand cuts it under reduced motion, clips withoverflow-hidden; the pill is agroup; the crewmate still names the button; the chevron sits outside the fold.member-memory.spec.tsupdated as above; not run locally (needs the gateway), CI runs it.--maxWorkers=1onCrewLoopIndicator.test.tsx,MembersPage.loop.test.tsx,MembersPage.test.tsx(221 passed);tsc -p tsconfig.app.json;eslint --max-warnings 0on touched files.Manual verification
Capture harness (
website/capture/members-page.html, the realMembersPage, gateway-free API routing; one-off script, not committed), before onorigin/main@ d4c3a73 and after on this branch. Each frame asserts its state first. Pill width at 1280px:At 320px the opened pill (196px at most, narrower than main's 210px) is asserted right of the back button. On a 360px touch viewport (
isMobile,hasTouch) the words are asserted open at rest. Reduced motion: the orbit's computeddisplayisnonein both; after, the ring still shows. Not checked against a live gateway; the change is presentation only.Screenshots / video
Fold and unfold, loop on, dark: rest → hover → rest → keyboard focus → rest.
09-fold-after.webm
Dark, loop on, at rest — before / after:
Dark, loop on, hover — before / after:
The mark up close, dark — before / after; reduced motion — before / after:
320px, keyboard focus — before / after (light); touch, at rest — before / after (dark):
Light, loop off, keyboard focus, roster row, 320px rest
Light, loop on, rest — before / after:
Light, loop on, hover — after:
Loop off, rest and hover — after (dark):
Keyboard focus, loop on — after (light):
Reduced motion header, after (light):
Roster rows — before / after (light), and after (dark):
320px at rest — before / after (light), after (dark):
Touch at rest — after (light):
Related Issues
Closes #18547
Checklist