Repository navigation
feat(dashboard): animated, actionable goal-board with PR links via a host open bridge - #18557
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check before merge: any page a crew publishes can now get a GitHub PR opened by the host when the person clicks inside its frame, not only the conductor templates. [DESIGN-REVIEWED] 3b41e76 Description read[DESCRIPTION-READ] d03b21e0f78478438046498480b41c4d7cd778ed1b9ef3debf0ed426ab38a2d3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The pop-in, bar-grow and band-glow animations rest only on matching the old drawer, and the template's own comment calls them decoration. Not justified as shipped
What this change shipsInventory (10 items) — 8 justifiedIntent: let a person watching a conductor see what is moving, answer tasks that wait on them, and open a task's PR. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 3b41e76 Description read[DESCRIPTION-READ] a460f943c40e6e514b1ffff61ea167f123801814139180e617470568823c7905 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The approval-blocked row offers "✎ Write a reply" right under copy saying a reply won't help, and the card pill says "open" while the bar says "needs you". Watch
Suggestions
[UX-REVIEWED] 3b41e76 Description read[DESCRIPTION-READ] 60ca3e38aba528d3414b10dcb6433fefe563487dd4e26bcb7862dbb7b9326e16 That sha256 names everything this verdict read: the PR description, plus the 21 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
9b789be to
03a53d9
Compare
03a53d9 to
6315f98
Compare
6315f98 to
75cda6d
Compare
75cda6d to
c2e71c0
Compare
Rebutted. The user asked for this in the dispatch for this item: per Needs-you row, one Reply button plus option buttons when the conductor supplies them, through ONE optional agentic field. The Goal section is frozen and I will not amend it on my own. The field is optional: a page with no asks write renders and works, which is why Reply exists on every row. |
Kept as is. The link needs a repo, and the user's rule for this item is never to guess or hardcode one. L's acceptance names no repo, so there is no URL to open. A grey chip that is not a button is the honest reading. A link that guesses the repo would open the wrong page. Every conductor-made pr_checks item carries acceptance.repo, so the plain chip is the rare case. |
Deferred. The board can only show what the record holds: the worker's own summary (shown under the task since the last head) and the reason (approval / needs a person). What to approve is not in the work fold. When the conductor knows, it can offer the answer as an asks option, which the goal-conductor skill now tells it how to write. Adding new fold data is outside this PR's Goal. |
Deferred to a follow-up. Each Reply button sits directly under its task's title and report, inside that row, and it fills the chat box with that task's title and id, so a press can only answer the row it is in. The hint line says the buttons only fill the chat box. Scope is frozen after three review rounds on this head series. |
Deferred to a follow-up together with the item above. The prefill already names the task and id, and scope is frozen after three rounds. |
Deferred. The board does not know which approval timed out or where to re-run it; that is the conductor's to say, as an asks option or in chat. Not in this PR's Goal. |
c2e71c0 to
18a7ff4
Compare
…host open bridge
Goal-board built-in (the Dashboard tab's conductor template): ports the old drawer's
motion (state pills, pop-in cards on first draw, live shimmer and dot, done-of-total
line with running and needs-you counts, warm needs-you band); all motion stops under
prefers-reduced-motion. Each needs-you row gets a Reply button plus one button per
option from a new optional agentic field, asks ({item_id: {options: [string]}}); every
button posts kirocrew-dashboard:act, so the host only fills the composer.
PR links. SECURITY: adds one new frame-to-host message, kirocrew-dashboard:open
{url}, handled by useFrameOpenLink in both hosts (CrewDynamicDashboard and the
CrewWebview / CrewDashboardFrame panel). The host honours it only from its own
frame's contentWindow and only for a URL matching
^https://github\.com/[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+/pull/[0-9]+/?$, and opens it with
window.open(url, '_blank', 'noopener,noreferrer'). Both sandboxes are unchanged
(allow-scripts only, no allow-popups). The goal-board PR chip uses the item's
acceptance.repo; the conductor panel takes an optional top-level repo (contract and
goal-conductor skill updated). No repo or no PR number: plain text, no button.
18a7ff4 to
3b41e76
Compare
Rebutted. This item exists because the user asked for the old drawer board's motion in the new Dashboard tab: state pills, pop-in cards, live shimmer, done meter and warm band. The Goal section is frozen and is not mine to amend. The motion carries no data on purpose, so turning it off loses nothing: one prefers-reduced-motion block stops all of it, pinned by a test. The band glow now runs three times, not forever. |
Rebutted. The user asked for both boards to open a task's PR: the goal-board in the Dashboard tab and agent_panel_templates/kirocrew-conductor.html, the right-panel board the conductor publishes, with an optional top-level repo. The panel board is not a dashboard built-in, so the 'No change to other built-in templates' line still holds. ConductorBoardPanel.repo is optional and a board without it renders as before. |
Kept. Reply still has a use on that row: asking the conductor about the approval, or telling it to skip it. The line above it now says plainly that replying does not approve, and where to approve. Hiding Reply would leave a row the reader cannot answer at all when the approval card is gone. |
Kept, by design of the page. The card pill is the ledger's recorded state, which is 'open', and the board never relabels a recorded state; the verdict-vs-state note in the template says why. The bar groups open items waiting on the reader under 'needs you' so they are not hidden as moving work, and those same cards sit in the warm Needs-you band and carry the warm tint. Follow-up candidate: a 'needs you' pill beside 'open' on those cards. |
Deferred, low severity per the lane. The chip is plain grey text, not a button, and only appears when the item's acceptance names no repo, which a conductor-made pr_checks item always names. Scope is frozen after five review rounds. |
Already in this head. src/kiro_crew/builtin_skills/goal-conductor/SKILL.md tells the conductor to write each option as a full answer that reads on its own beside the worker's report, and the evidence fixture now uses 'Ship the compact layout' / 'Ship the roomy layout'. |
CrysisDeu
left a comment
There was a problem hiding this comment.
Reviewed the diff with the security change in focus: both sandboxes stay as they are; the new kirocrew-dashboard:open bridge accepts only an exact GitHub PR URL, only from one of the host's own frames (event.source match), and only with a live user activation while that iframe is the focused element; the open is noopener,noreferrer. The template builds every node with createElement/textContent, no innerHTML. Reduced-motion block covers pseudo-elements. All checks green.
Problem / Motivation
Goal: The conductor's goal board in the Dashboard tab moves like the old drawer board did, and a person can act on it: answer a task that needs them, and open a task's pull request.
The old right-panel board (
agent_panel_templates/kirocrew-conductor.html, #17800) had motion: state pills, pop-in cards, a live shimmer, a done meter and a warm Needs-you band. The new Dashboard tab renders the built-ingoal-boardtemplate, which has none of that. Its Needs-you items cannot be answered from the page. Neither board can open a task's PR, because both frames aresandbox="allow-scripts"with noallow-popups, so a link is a dead click.Why it matters
The goal board is what a person watches while a conductor runs. A static list hides what is moving and what waits on them. Without a reply button or a PR link, the reader has to retype the task name into chat and hunt for the PR by hand.
Not a goal
allow-popupsstays withheld.workfold paths as before.goal-board.What changed (motivation → approach → change)
Motion:
goal-board/template.htmlports the old drawer's vocabulary using the theme variables the frame already injects. It adds tone-coloured state pills, cards that pop in on first draw only (a host refill does not replay them), and a shimmer plus a blinking dot on open items whose worker last reportedprogress(keyed on status, because the host masksworker_session_keybefore any field reaches a page). It also adds a done-of-total line with in-progress and needs-you counts, and a warm band listing open items whose worker reportedquestionorblocked; the band glows three times when drawn, not forever. With nothing waiting, a calm line says "Nothing needs you right now." Oneprefers-reduced-motionblock stops every animation and transition, pseudo-elements included.Acting on Needs-you: each row in the band gets a
✎ Write a replybutton that putsAbout "<title>" (<id>):in the chat box. When the conductor writes the new optional agentic fieldasks({item_id: {options: [string]}}), the row also gets one button per option. Every button posts the existingkirocrew-dashboard:act(as office and project-report do): the host only fills the composer. A row with noasksentry still gets Reply. Option buttons carry the same ✎ mark. Worker status words are translated. An approval-blocked row says to approve on the chat card, not by replying, and the state bar gives needs-you items their own warm segment instead of counting them as open. The band says the buttons only fill the chat box, and each row shows the worker's own reported summary under the task it names.src/kiro_crew/builtin_skills/goal-conductor/SKILL.mdtells the conductor how to writeaskswithdashboard_write.PR links. Security change: one new frame→host message,
kirocrew-dashboard:open {url}, behind a strict allowlist. The newuseFrameOpenLinkhook (website/src/hooks/useFrameOpenLink.ts) runs in both hosts:website/src/pages/members/CrewDynamicDashboard.tsx(Dashboard tab) andwebsite/src/pages/members/CrewWebview.tsx(the docked frame, the expanded frame, andCrewDashboardFrame). It honours a message only whenevent.sourceis one of that host's own frames'contentWindow. The URL must match exactly^https://github\.com/[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+/pull/[0-9]+/?$, so no other host, no query and no fragment get through. It also needs a live user gesture in that very frame: the host has a user activation (navigator.userActivation.isActive) and its focused element is that iframe. Activation alone is page-wide, so focus ties the gesture to the frame. Anything else is dropped silently. Both sandbox docstrings now name this one exception. It opens withwindow.open(url, '_blank', 'noopener,noreferrer'). A linked chip readsPR n on GitHub ↗(the panel:PR #n on GitHub ↗); a PR with no known repo is a plain grey chip.docs/architecture/dashboard-iframe-hosts.mdlists both crew hosts and their two messages out. On the goal board, the PR chip becomes a<button>when the item'sacceptance.repogives a valid URL. On the right-panel board, "PR #n" becomes a<button>when the data carries the new optional top-levelrepo, which is added toConductorBoardPanelinsrc/kiro_crew/conductor_board_contract.pyand to the board line insrc/kiro_crew/builtin_skills/goal-conductor/SKILL.md.src/kiro_crew/dashboard_templates/builtin/README.mdnow saysgoal-boarddeclaresasks. With no repo or no PR number, both stay plain text.Backwards compatibility
Compatible: every new field is optional (
askson the goal-board manifest,repoonConductorBoardPanel). A board without them renders as before, and both sandboxes are unchanged.Removes nothing: the templates only add elements, and the hosts only add a listener.
Tests
test/test_dashboard_template_goal-board.py(new) pins:.board *,::beforeand::after, and stops animations and transitions;kirocrew-dashboard:actandkirocrew-dashboard:open, never a send;asksentry still gets Reply;openwith the host's allowlist and never useswindow.open,hrefortarget;acceptance.repo, with a text fallback.test/test_conductor_board_contract_parity.py: the panel postsopenwith the same allowlist, builds the URL fromrepo, and falls back to text. The existing parity test also covers the newrepoleaf.website/src/hooks/useFrameOpenLink.test.ts(new): the hook rejects a non-GitHub host and a look-alike host. It rejects non-pull GitHub URLs (repo root, issue,/files, query, fragment,http:,javascript:). It rejects a message from another frame, from the window itself and with a null source, and it ignores theacttype. A valid PR URL calls the opener exactly once, and the default opener iswindow.open(url, '_blank', 'noopener,noreferrer'). A message with no user gesture opens nothing; by default an activation with the composer focused opens nothing, and an activation with the frame focused opens once. The goal-board test pins thatlivenever reads a masked key and that only the shimmer and the dot loop forever.test_dashboard_templates_builtin.pyandtest_dashboard_template_manifest.py(103 passed). Vitest ranuseFrameOpenLink,CrewDynamicDashboard,CrewDashboardFrame,CrewDashboardTab, the threeCrewWebview*tests,crewDashboardActanddashboardTemplatesI18n(all pass).tsc,eslinton the touched files,i18n:check, and black, isort and flake8 are clean.Manual verification
I rendered both templates with
scripts/render_dashboard_builtin.py'sbuild_pageand a fixture of five items (accepted, live, question with options, blocked without options, rejected without a repo), then drove them in Chromium:reducedMotion: 'reduce', the computedanimationNameisnoneon every element and pseudo-element.scrollWidthis 320 in both themes and no element overflows.{type: 'kirocrew-dashboard:act', text: 'About "K: crew list density" (it_c): '}, and an option posts the same text plusShip option B.{type: 'kirocrew-dashboard:open', url: 'https://github.com/kirodotdev/KiroCrew/pull/17797'}. The rejected item, whose acceptance has no repo, renders a plainSPAN:PR 18402.repoposts the sameopenmessage. The panel withoutreporenders 0 PR buttons.Not checked: the Electron app actually handing
window.opento the system browser. That path is the existing one other links use and is unchanged here.Screenshots / video
Goal board after, dark and light, 760px:
Needs-you band with keyboard focus on Reply. It says the buttons only fill the chat box and shows each worker's report. K has options, M has none and still gets Reply:
Before (main), 320px after, motion frames, reduced motion, right panel
Before, dark and light:
After at 320px:
Motion: a pop-in frame at 140ms, and the live card's shimmer at two instants 500ms apart:
Reduced motion (settled, with no animation running):
Right-panel board with
repo(PR chips are buttons) and without (plain text):Related Issues
Follows #17800 (the drawer board's motion) and #17507 / #16603 (the Dashboard tab templates). @chenmingwei23, please review: the template change is limited to
goal-board, plus the new hostopenbridge.Checklist