Repository navigation
Conversation
9f6144f to
00013b1
Compare
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
00013b1 to
e1c2904
Compare
Design Review (Opus 5.5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The RFC stores Watch
[DESIGN-REVIEWED] 394624e Description read[DESCRIPTION-READ] 4a1de34dd47b74f76ba0c6e851248c50ac44295bf016f5fffe84b1104c469c1f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
e1c2904 to
650d35a
Compare
650d35a to
156808e
Compare
|
Rebased onto |
156808e to
6f1e51f
Compare
eacd05d to
0f8dc87
Compare
|
Rebased onto |
0f8dc87 to
336088f
Compare
|
Rebased onto |
|
Rebased |
|
Rebased |
|
This docs-only PR revises rfc-conductor-default-patrol.md so a crew- or member-mode conductor also gets the bind-time patrol, as the gateway's own content-pinned arm with a gateway-patrol trust entry that is checked again at fire time. The patrol's wake never becomes a self-arm and cannot reset_conversation. Head 5d1beab is a rebase, and the RFC file is byte-identical to the one I reviewed before. The README row now correctly says that on main a crew/member bind commits with 200 and |
The first version of rfc-conductor-default-patrol.md listed arming on a crew- or member-mode conductor as a non-goal, because the bind route cannot prove the turn is the session's own. Two days after it landed the patrol's owner filed kirodotdev#17603 asking for the patrol on exactly those conductors, which are the normal conductor shape; on a live gateway every refusal since 2026-09-24 was a member-mode conductor's bind. This revision records the decision kirodotdev#17603 asks for and how it is kept inside the property section 5 protects. The patrol is admitted on such a slot as the gateway's own arm, never a self-arm: pinned on its fixed text and the slot's own work-ledger watch at arm time, backed by a gateway-patrol trust entry, and re-read against the stored row at fire time, so a message rewritten in the agent-writable store is refused like any other outside text. The self-arm route the issue suggested is recorded as an alternative with the reasons it was not taken. Sections 2, 3, 4, 5, 6 and 8 change; the README row is re-audited against 950be41. The implementation is kirodotdev#18592, which rebases onto this document so its First Principles lane reads the decision from the base. Refs kirodotdev#17603
|
Rebased |
|
This docs-only PR revises rfc-conductor-default-patrol.md so a crew- or member-mode conductor also gets the bind-time patrol, as the gateway's own content-pinned arm with a gateway-patrol trust entry that is checked again at fire time. Head 394624e is another rebase: the RFC file is byte-identical to 5d1beab, and the README row still correctly reports the 200 + |
|
Disposition: the new rollback finding holds. §3 currently shares the self-arm record, while main |
|
No rebase pushed: current main now carries the accepted v2 RFC (#19742) whose section 9 says member/crew slots get no outside arm, while this revision admits the gateway patrol on those slots. That is a direct design conflict, not a mechanical README merge. I aborted the local rebase and left fork head |
|
|
Thank you @rubencu for this RFC revision and for keeping it rebased so patiently. Closing as you asked in your comment:
The RFC revision on Your branch is kept, and you are welcome to reopen or open a new PR when the self-arm route is ready. Thanks again! |
Problem / Motivation
Goal: record, in the RFC that decided otherwise, the decision to arm the gateway's default patrol on a crew- or member-mode conductor, so the implementation (#18592) can be judged against a decision on the base.
docs/request-for-change/rfc-conductor-default-patrol.md(statusin-progress) lists "Arming on a crew- or member-mode conductor" as a non-goal and makes the refusal an exit criterion, because the bind route cannot prove the turn is the session's own. Two days after it landed, the patrol's owner filed #17603 asking for the patrol on exactly those conductors. Member DM threads are the normal conductor shape, so the safety net the patrol is has been inert where conductors run: on a live gateway every refusal since 2026-09-24 was a member-mode conductor's bind (3 refusals, 0 arms).The implementation is open as #18592. Its First Principles lane reads the RFC from the base branch and blocks on this exact point (product shape without a recorded decision), and its Design lane asks that the RFC be amended in a PR that lands before it with the patrol owner's sign-off. GOVERNANCE.md says the document lands first and the implementation references it. This PR is that document, proposed for the patrol's owner to accept by merging.
Why it matters
Member DM threads are the normal conductor shape. Until this decision is on the base, every member-mode conductor's workers report to a ledger nobody reads, and the fix for that cannot merge: its First Principles lane blocks on the missing decision by design.
Not a goal
What changed
docs/request-for-change/rfc-conductor-default-patrol.mdwork-ledgerwatch at arm time, a gateway-patrol trust entry beside the row's tag, the content re-read against the stored row at fire time (the loop store is agent-writable and the entry names only an id and a slot),monitor_updatetuning bounds and banner but not message or watch, and the two trust-entry kinds never vouching for each other so the patrol's wake cannotreset_conversation.implementation-prsadds 18592,tracking-issuesadds 17603, re-audited at950be41684.docs/request-for-change/README.md: the row is re-audited against950be41684(the bind-time arm from fix(work-ledger): arm a work-ledger patrol on a conductor's bind when it has none #17069 is on main; the crew/member admission is not: nois_gateway_patrol, nogateway_patrolentry kind), and the audit-history paragraph gains the matching sentence.If the owner prefers the self-arm route the issue suggested, this document and #18592 change together; the decision is theirs, and merging this records it.
Tests
scripts/docs-lint.shclean;test/test_pr_quality_gates.pypasses (76). Docs only.Related Issues
Refs #17603. Implementation: #18592.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)